Commit Graph

115 Commits

Author SHA1 Message Date
sebastian nordgren
b89a39b7f2 Fixed crash when SDockingTab::GetTabManager() dereferenced an invalid weak pointer. GetTabManager has been deprecated in favor of GetTabManagerPtr which returns a TSharedPtr.
#jira UE-140354
#preflight 61fbda35176256ec4f6ffa17
#rnx
#lockdown jeanmichel.dignard
#rb patrick.boutot

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18861915 in //UE5/Release-5.0/... via CL 18862125 via CL 18862236
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18862253 by sebastian nordgren in ue5-main branch]
2022-02-04 08:33:30 -05:00
matt kuhlenschmidt
9c6b92c014 [Backout] - CL18312422
Original CL Desc
-----------------------------------------------------------------
Prevent tab manager from summoning empty windows when no tabs can be opened

#rb lauren.barnes

#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 18313460 in //UE5/Release-5.0/... via CL 18313900
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18314217 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-11-29 14:48:54 -05:00
matt kuhlenschmidt
048278eb2d Prevent tab manager from summoning empty windows when no tabs can be opened
#rb lauren.barnes

#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 18312422 in //UE5/Release-5.0/... via CL 18312506
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18312560 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-11-29 13:08:53 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
vincent gauthier
00a271aafe Fix reference to UE4 in TabManager
#jira UE-111069

#rb trivial

#ROBOMERGE-AUTHOR: vincent.gauthier
#ROBOMERGE-SOURCE: CL 17723180 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v879-17706426)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0

[CL 17723210 by vincent gauthier in ue5-release-engine-test branch]
2021-10-05 12:21:19 -04:00
steven dao
969d9a3708 Sidebar tab pinning - pinned tabs' drawers stay open instead of automatically dismissing when they lose focus
STabManager and SDockingTabStack: store pinned state in FTab, serialize pinned state, helpers for accessing/setting pinned state

STabDrawer:
- allow bypassing animation when opening drawer (e.g. for restoring pinned drawers on startup) and provide helper to check whether drawer is in the middle of closing
- automatically activate tab when its drawer gains focus and deactivate tab when its drawer starts to close

STabSidebar:
- change blue stripe on sidebar tab button to indicate tab active state, which is more consistent with regular tabs
- open sidebar tabs on mouse press (not mouse click), which is more consistent with regular tabs
- add UI for toggling pin state to the sidebar tab button
- prevent pinned sidebar tab drawers from closing when they lose focus
- automatically summon back drawers for pinned tabs when all other drawers are closed

#jira UETOOL-3813
#rb lauren.barnes
#preflight 612ce47a79d62b00015abe3b

#ROBOMERGE-SOURCE: CL 17353020 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17353055 by steven dao in ue5-release-engine-test branch]
2021-08-30 11:31:46 -04:00
lauren barnes
5bd8c74d4e FAssetEditorModeUILayer now serves as a layer between a given asset editor and the mode toolkits, so that the mode toolkits can request UI panels and the asset editor determines where they are located in the asset editor layout. The first implementation is in the level editor, and all default mode UI has been moved to FModeToolkit.
#jira UETOOL-3555
#preflight 61143dbf9c7bb10001f080b3
#rb Matt.Kuhlenschmidt

#ROBOMERGE-SOURCE: CL 17152278 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17152291 by lauren barnes in ue5-release-engine-test branch]
2021-08-12 10:54:54 -04:00
keith yerex
9fbd2e0cb2 TabManager change to allow document tabs to insert next to a particular tab id, but be created with a different id
[REVIEW] Rex.Hill

#ROBOMERGE-SOURCE: CL 16592808 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16592830 by keith yerex in ue5-release-engine-test branch]
2021-06-08 16:27:52 -04:00
justin hare
931a22a28b Removed temporary logging used to help pinpoint occurrences of "unrecognized tab"s showing up in Blueprint Editor
#jira UE-106350
#rb none (simple removals, no changes beyond logging)
#rnx
#preflight 60a6bbc49e68c20001b27c36

[CL 16409616 by justin hare in ue5-main branch]
2021-05-20 16:36:51 -04:00
sebastian nordgren
9ea3e5850b Layouts are now also stored as JSON in the AppData/Local directory.
Added helpers to FTabManager::FLayout to work directly with JSON rather than roundtripping to strings.

#jira UETOOL-3377
#review-16183924 @lauren.barnes

[CL 16193194 by sebastian nordgren in ue5-main branch]
2021-05-04 09:54:42 -04:00
Matt Kuhlenschmidt
7b08530bff Make logging for regstering and unregistering tab spanwers verbose to cut down on log spam
[CL 16164798 by Matt Kuhlenschmidt in ue5-main branch]
2021-04-29 22:38:12 -04:00
durra mohsin
b90d90f672 Add docking/undocking listeners to enable docking support for native rendering browser windows for Bridge plugin.
#jira UE-114404
#rb matt.kuhlenschmidt
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 16133681 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v789-15992632)

[CL 16133730 by durra mohsin in ue5-main branch]
2021-04-27 18:09:34 -04:00
Matt Kuhlenschmidt
87e5451da6 Nomad tabs docked with major tabs now have a menu instead of just empty space. The menu is simplified because nomad tabs do not belong to a specific editor.
[CL 16115179 by Matt Kuhlenschmidt in ue5-main branch]
2021-04-26 12:11:27 -04:00
matt kuhlenschmidt
d43686a0bf UE5 layout changes
Content browser now hidden by default, opening tip is displayed showing you how to access it from the drawer. It can be permanently docked into the layout from there. Opening tip is never shown again
Placement browser is now closed by default
A UE4 classic layout has been added for those who want the placement browser and content browser docked by default

#jira UETOOL-2669

#ROBOMERGE-OWNER: matt.kuhlenschmidt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 15918688 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)
#ROBOMERGE-CONFLICT from-shelf

[CL 15921147 by matt kuhlenschmidt in ue5-main branch]
2021-04-05 15:03:56 -04:00
justin hare
b35f14fea1 Improved logging messages for editor application mode and tab manager tracking, in the search for the cause of temporary "unrecognized tab" instances.
#rb none
#preflight 606789ae93db5a00012c1f34

[CL 15906148 by justin hare in ue5-main branch]
2021-04-02 17:58:46 -04:00
Patrick Boutot
f429888aa9 Slate: Fix simple implicit type conversion warnings in Slate
#jira UE-88354
#rb vincent.gauthier
#preflight 60630f23b4299e0001c05524

[CL 15860052 by Patrick Boutot in ue5-main branch]
2021-03-30 08:39:30 -04:00
halfdan ingvarsson
536a9a5b38 When closing the app, only ask major tabs whether they want to block closing.
#jira UE-108632
#rb matt.kuhlenschmidt

[CL 15726746 by halfdan ingvarsson in ue5-main branch]
2021-03-17 13:10:05 -04:00
Marc Audy
8f73cd7fa9 Merge UE5/Release-Engine-Staging @ 15630841 to UE5/Main
This represents UE4/Main @ 15601601

[CL 15631170 by Marc Audy in ue5-main branch]
2021-03-05 19:27:14 -04:00
justin hare
8db4641bc7 Fixed bug where a recurring "unrecognized tab" could show up in Slate editors (typically seen in the BP editor), and also where an "unrecognized tab" could block the user from their intended functionality (e.g Find Results). Unrecognized tabs are no longer saved in the serialized layout data. Also improved log messaging to help track down what causes an unrecognized tab in the first place.
#jira UE-82665
#jira UE-106350

[CL 15534737 by justin hare in ue5-main branch]
2021-02-25 17:49:35 -04:00
matt kuhlenschmidt
6679ca5faa Fix browse to content browser sometimes not working in asset editors. In UE4, the toolbar was a tab so clicking on the browse button would force the toolbar tab to be active. Now that the toolbars are not tabs you could get into a situation where no tab is activated so if the content browser was previously activated it would never switch because it thought it was already activated.
#jira ue-108049
#rb lauren.barnes

#ROBOMERGE-SOURCE: CL 15492655 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15492666 by matt kuhlenschmidt in ue5-main branch]
2021-02-22 15:30:42 -04:00
Tim Smith
4c3942091b Fixing PVS 7.7 Issues:
warning V547: Expression 'XYZ' is always true/false.

#rb trivial
#jira UE-91644

[CL 15054368 by Tim Smith in ue5-main branch]
2021-01-12 16:15:34 -04:00
brooke hubert
6b43ed1986 Add a drop down menu to the Content shortcut in the level editor, to which plugins can add additional shortcuts.
#Jira UE-101076
#rb chris.gagnon

[CL 14728018 by brooke hubert in ue5-main branch]
2020-11-11 19:29:13 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00