- It was accumulating new indices resulting in unecessary updates.
Store PendingHeightFieldAdd/UpdateOps in TSet instead of TArray so that Contains/Remove calls are O(1).
#rb Krzysztof.Narkowicz
#preflight 627d0c089f7ad2a14be26bd9
[CL 20163847 by tiago costa in ue5-main branch]
- Replaced FRW{Structured, ByteAddress}Buffer with TRefCountPtr<FRDGPooledBuffer>
- Replaced ResizeResourceIfNeeded with Resize{Structured, ByteAddress}BufferIfNeeded.
- Replaced FScatterUploadBuffer with FRDGScatterUploadBuffer.
- Removed awkward copy of page table buffers now that scatters are on the RDG timeline.
- Reduced number of uniform buffers created by consolidating within FLumenSceneFrameTemporaries.
- Fixed up const-correctness of FLumenSceneFrameTemporaries to sanity check that resources were not being mutated later in the frame.
- Reduced explicit view creations somewhat.
- Distance fields needs an FDistanceFieldSceneFrameTemporaries to cache RDG resources, but I held off on this due to the number of files it would touch.
#rb krzyzstof.narkowicz, daniel.wright
#ROBOMERGE-AUTHOR: zach.bethel
#ROBOMERGE-SOURCE: CL 19921040 via CL 19922067 via CL 19922607
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
[CL 19925590 by zach bethel in ue5-main branch]
- Shaders sampling mesh distance fields must define OFFSET_DATA_STRUCT according to r.DFShadowOffsetDataStructure.
- Also renamed cvar r.DFShadowOffsetDataStructure to r.DistanceFields.OffsetDataStructure since it applies to all techniques sampling mesh distance fields.
#preflight 626661771a71643e8b8b07df
#rb Krzysztof.Narkowicz
#jira none
[CL 19900311 by tiago costa in ue5-main branch]
* Added "BeginRenderingViewFamilies" render interface call that accepts multiple view families. Original "BeginRenderingViewFamily" falls through to this.
* FSceneRenderer modified to include an array of view families, plus an active view family and the Views for that family.
* Swap ViewFamily to ActiveViewFamily.
* Swap Views array from TArray<FViewInfo> to TArrayView<FViewInfo>, including where the Views array is passed to functions.
* FSceneRenderer iterates over the view families, rendering each one at a time, as separate render graph executions.
* Some frame setup and cleanup logic outside the render graph runs once.
* Moved stateful FSceneRenderer members to FViewFamilyInfo, to preserve existing one-at-a-time view family rendering behavior.
* Display Cluster (Virtual Production) uses new API.
Next step will push everything into one render graph, which requires handling per-family external resources and cleaning up singletons (like FSceneTextures and FSceneTexturesConfig). Once that's done, we'll be in a position to further interleave rendering, properly handle once per frame work, and solve artifacts in various systems.
#jira none
#rnx
#rb zach.bethel
#preflight 625df821b21bb49791d377c9
[CL 19813996 by jason hoerner in ue5-main branch]
* Distance Field streaming GPU mask scope clean up, to avoid startup crash. Added single high level FRHIGPUMask::All() scope in PrepareDistanceFieldScene, to avoid the need to set the mask in multiple lower level functions, and hopefully cover future modifications to the distance field scene code. View dependent subset of the code is then masked to the view. Validation asserts added in case code gets moved around in the future.
* Fixed bug when generating SRVs for structured buffers -- wasn't pointing the SRV to the correct GPU buffer. Caused GPU hangs and all sorts of corrupted rendering.
* Fixed bug that RHICopyToResolveTarget wasn't using the correct GPU index. Main symptom was DumpGPU being non-functional on the second GPU, but could cause other artifacts as well.
#jira none
#rnx
#rb christopher.waters chris.kulla
#preflight 624716e2b6084b9832597015
[CL 19591778 by jason hoerner in ue5-main branch]
- Upload heightfield bounds tile + relative world position
- Upload heightfield tile + relative world matrices
- Positions are still converted to float when loaded in shader.
#rb none
#preflight 622118eebf662715a8c73d52
#jira none
[CL 19250645 by tiago costa in ue5-main branch]
- Was incorrectly casting rows of FMatrix to FVector4f.
- Cast matrix to FMatrix44f first.
#rb aleksander.netzel
#preflight 621c9c54037be0078c913673
#ROBOMERGE-AUTHOR: tiago.costa
#ROBOMERGE-SOURCE: CL 19171873 via CL 19171875 via CL 19171877 via CL 19172301
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)
[CL 19172357 by tiago costa in ue5-main branch]
- Upload bounds tile + relative world position
- Upload object tile + relative world matrices
- Positions are still converted to float when loaded in shader.
#rb aleksander.netzel
#preflight 6218e94fa77f4c4a4ba5be27
#jira UE-143275
[CL 19146964 by tiago costa in ue5-main branch]
- Required to support LWC.
- Modified GetDistanceFieldInstanceData to output InstanceLocalToPrimitive transforms.
- Apply Proxy->LocalToWorld in ProcessPrimitiveUpdate(...)
#preflight 62166c450f71e491cc0691c7
#rb Krzysztof.Narkowicz
[CL 19094749 by tiago costa in ue5-main branch]
Pullback on Voxel traces for Screen Probes, fixes leaking when resuming a screen trace
#rb Krzysztof.Narkowicz
#jira UE-141204
#preflight 61fb4a6ec431b6aac04e163e
#lockdown Michal.Valient
#ROBOMERGE-AUTHOR: daniel.wright
#ROBOMERGE-SOURCE: CL 18850068 in //UE5/Release-5.0/... via CL 18850157 via CL 18850823
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)
[CL 18850862 by daniel wright in ue5-main branch]
#jira UE-122078
#rb Andrew.Davidson, Colin.McGinley
#preflight standard build
#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 18817999 in //UE5/Release-5.0/... via CL 18818012 via CL 18822871
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)
[CL 18824721 by fred kimberley in ue5-main branch]
* Removed culled DF object copies during culling. Instead now only indices to culled objects are stored
* Refactored DF heightfield object loads into FHeightfieldObjectBounds and FHeightfieldObjectData
This is a step towards optimizing DF culling and reusing this code for Lumen Landscape culling
Perf Reverb on 2080:
* CullMeshSDFObjectsToFrustum 0.04ms->0.03ms (removed DF object copies)
* Other passes didn't change
#preflight 61f5a7b7694910780bd91918
#rb Tiago.Costa
#ROBOMERGE-AUTHOR: krzysztof.narkowicz
#ROBOMERGE-SOURCE: CL 18789232 in //UE5/Release-5.0/... via CL 18789258 via CL 18789368
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)
[CL 18789821 by krzysztof narkowicz in ue5-main branch]
FLinearColor has also been modified to make any double->float conversions explicit. Previously all 3D TVector versions were allowed to be implicit and thus could convert TVector<double> => FLinearColor => TVector4<float>.
Fixed up all engine and game casts. Added "//LWC_TODO: precision loss" around any explicit casts that previously were silently explicit and we may need to revisit for precision loss analysis.
#jira UE-122085
#rb Ben.Ingram, Andrew.Davidson
#preflight 61f24af473238441cb7bb0f1
#ROBOMERGE-AUTHOR: zak.middleton
#ROBOMERGE-SOURCE: CL 18751249 in //UE5/Release-5.0/... via CL 18751253 via CL 18751319
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)
[CL 18751326 by zak middleton in ue5-main branch]
Project
* Ray Lighting Mode - project wide control for ray lighting quality
Post Process Volume
* Lumen Scene Lighting Quality - drives Radiosity gather quality
* Lumen Scene Detail - drives Lumen culling aggressiveness
* Lumen Scene View Distance - controls the distance from the camera that Lumen Scene will be maintained
* Lumen Scene Lighting Update Speed - drives Radiosity gather convergence speed
* Final Gather Lighting Update Speed - drives Final Gather temporal accumulation strength
* Max Trace Distance - the distance that Lumen features will trace through the scene
* Ray Lighting Mode - local control for ray lighting quality
Primitive Component
* Emissive Light Source - provides a hint to Lumen that the mesh has an important lighting contribution and should not be culled
Replaced r.Lumen.MaxTraceDistance with r.Lumen.MaxTraceDistanceScale
Increased MAX_GLOBAL_DF_CLIPMAPS to 6
#rb Krzysztof.Narkowicz
#preflight 61ef58b8ca3de856bce72093
#ROBOMERGE-OWNER: krzysztof.narkowicz
#ROBOMERGE-AUTHOR: daniel.wright
#ROBOMERGE-SOURCE: CL 18743987 in //UE5/Release-5.0/... via CL 18744701 via CL 18745671
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)
[CL 18745941 by krzysztof narkowicz in ue5-main branch]
Bonus: Saves about 1.1 MS in the current branch.
[at]juan.canada, [at]ryan.vance, [at]patrick.kelly
#preflight 614364b9b5a4fa0001630d89
#lockdown andrew.firth
#ROBOMERGE-OWNER: jon.nabozny
#ROBOMERGE-AUTHOR: brandon.dawson
#ROBOMERGE-SOURCE: CL 17552671 via CL 17946035 via CL 18363833 via CL 18363966
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
[CL 18364062 by jon nabozny in ue5-release-engine-test branch]
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035
[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
