#jira UE-131184
#jira UE-124744
#rb jack.porter
#[fyi] will.damon carl.lloyd axel.riffard
#preflight 618e2f249e784835d570d871
#ushell-cherrypick of 18165990 by axel.riffard
[CL 18598774 by will damon in ue5-main branch]
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485
[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
I couldn't find a place where I can say is stalling. So I added a few more CYCLE_COUNTER to get more information on this hitch in a future perf pass.
[at]Sam.Zamani, [at]Rob.Cannaday
#ROBOMERGE-SOURCE: CL 11278995 via CL 11278996 via CL 11278997
#ROBOMERGE-BOT: (v0-11244347)
[CL 11278998 by federico prado in Main branch]
#rnx
#rb none
#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870549 by ryan durand in Main branch]
#jira UE-76195
[at]Sam.Zamani, [at]Chris.Varnsverry
#ROBOMERGE-SOURCE: CL 7206297 via CL 7209564
#ROBOMERGE-BOT: (v367-6836689)
[CL 7209652 by mark fitt in Main branch]
#jira UE-76195
[at]Sam.Zamani, [at]Chris.Varnsverry
#ROBOMERGE-SOURCE: CL 7205917 via CL 7209485
#ROBOMERGE-BOT: (v367-6836689)
[CL 7209577 by mark fitt in Main branch]
[at]josh.adams, [at]peter.sauerbrei, [at]michael.trepka
#ROBOMERGE-SOURCE: CL 6189966 via CL 6189971 via CL 6192418
[CL 6192513 by michael kirzinger in Main branch]
[REVIEW] [at]peter.sauerbrei, [at]josh.adams, [at]sam.zamani, [at]evan.kinney
#ROBOMERGE-SOURCE: CL 5759815 via CL 5759823 via CL 5759828 via CL 5759829 via CL 5763532
[CL 5763602 by michael kirzinger in Main branch]
#rb none
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 4247640 by Daniel.Lamb
BuildPatchTool: PackageChunks: Fixed issue with filenames not being set for chunkdbs in particular cases where the chunkdbs were small.
Change 4247246 by Leigh.Swift
BuildPatchTool: Adding support to BPT PackageChunks to filter by tagsets, and also split chunkdb output by them too.
Change 4173518 by Wes.Fudala
WebBrowser: Adding support to enable allowing net security expirations.
Change 4102451 by Leigh.Swift
BuildPatchTool: PackageChunks: Adding tool mode JSON output for listing created chunkdb files.
Change 4099951 by Leigh.Swift
BuildPatchTool: PackageChunks: Adding PrevManifestFile commandline support to BPT PackageChunks mode, allowing us to generate chunkdbs that only cover data required to perform an update.
Change 4051406 by Leigh.Swift
BuildPatchServices: Update default number of simultaneous downloads for an installer to 16 which is now well proven in the wild.
Change 4036807 by Leigh.Swift
BuildPatchServices: Added new message type for receiving updates about which files have been touched by the installation.
BuildPatchServices: Cloud enumeration is now threaded to improve speed.
Change 4036477 by Richard.Fawcett
Thirdparty: AWSSDK: Update AWS SDK to version 3.3 as speculative fix for object is used after being disposed error.
Confirmed this exception is being raised from within the AWS SDK, and _not_ in Epic code.
Advice by Amazon on AWS forums for people experiencing this exception is always to update to the latest version of the SDK in the first instance.
Change 3922493 by Justin.Sargent
Runtime: Added shortcircuit support to the ExpressionParser. More documentation to come.
AgreementExpressionEvaluator has been updated to use the shortcircuit logic so it now processes expressions lef to right as expected in all cases.
AgreementExpressionEvaluator was also updated to perform evaluation as a two pass system. The tow pass solution prevents over prompting eulas in certain scenarios where the expression would ultimately resolve true without them.
Change 3983713 by Barnabas.McManners
BuildPatchServices: Fix for verification logging error counts for unique runs. Solved the issue by using an external cache of the errors encountered each run to deduct from the total. Reporting only the delta.
Change 3966915 by Wes.Fudala
WebBrowser: CEF: Potential fix for a rare issue encountered when we attempting to release resources outside of the game thread.
Change 3955168 by Justin.Sargent
BuildPatchServices: Updated primary messaging of overall install status to now display Updating when patching an existing installation rather than Installing.
Change 3954610 by Leigh.Swift
BuildPatchServices: Fixing issue with Cloud Chunk Source which would erroneously conclude that it needed to re-download a chunk due to external system failure.
There is now an explicit concept of 'lost chunk' which is tracked and bubbled up by the system errors that cause the loss in the first place, so that each source knows exactly when it should be required to retrieve a chunk that it had already retrieved previously. Being explicit, these lost chunks can also now contribute to the total download required stat.
Also fixing some tracking that was missing to update the total download required stat if a local Install Chunk Source failed to load data from the files on disk and so these chunks needed to be additionally downloaded.
Change 3947928 by Chad.Garyet
UAT: Changing commandutils to attempt to find the Win8.1sdk signtool before the win10 one. There's currently a bug related to vs2017/server2012r2/win10sdk signtool that causes it to exit with an undefined error when signing from a service account. Using the win8.1sdk circumvents this issue.
Change 3942776 by Rob.Cannaday
Http: Fix for Mac sending up duplicate header strings
Change 3940306 by Leigh.Swift
BuildPatchServices: Refactor to isolate CoreUObject dependency and be able to compile out usage.
Change 3936655 by Justin.Sargent
Slate: Changed the invalid fontcache ensure in ShapedTextCache from always to only once to reduce ensure spamChange 3917840 by Leigh.Swift
BuildPatchTool: DiffManifests mode now also saves info for New, Removed, Changed, and Unchanged file to the output json file.
Change 3911756 by Justin.Sargent
WebBrowser: SWebBrowserView now ensures that it has a valid pointer to it's parent window in it's onpaint to avoid issues with the first frame being scaled incorrectly due to not being able to access the parent windows dpi scaling.
Change 3906670 by Justin.Sargent
Slate: Change the ShapedTextCache to hold a weakptr to the Slate FontCache instead of a reference. This will allow it to detect if the FontCache has become invalid since it was linked with the ShapedTextCache, thus making it able to avoid crashing.
Change 3889008 by Justin.Sargent
StandaloneRenderer: Made the SlateD3DRenderingPolicy more resilient to graphics device errors.
Change 3886969 by Justin.Sargent
StandaloneRenderer:Changed SlateD3DConstantBuffer to no longer check on a D3DDevice failure and instead soft fail, so the application can go through the process of attempting to re-establish the D3DDevice.
Change 3886960 by Justin.Sargent
WebBrowser: Made CEFWebBrowserWindow more resilient to issues with creating textures.
Change 3855821 by Barnabas.McManners
BuildPatchServices: Added logging of the configuration to the start of all installs.
Change 3839245 by Wes.Fudala
WebBrowser: Adding support for web browser drag regions. These are areas of a page tagged with -webkit-app-region: drag or -webkit-app-region: no-drag. The application can now pass a handler function to the browser to handle window drag events. This handler will be called if the browser detects mouse drag events inside of a tagged drag region.
Change 3835225 by Jacob.Hedges
Slate: Fix for SScrollBarTrack size issue
Change 3824320 by Wes.Fudala
WebBrowser: Fix for reported deadlock in WebBrowserSingleton. Associated with github pull request #4303.
#jira UE-53420 GitHub 4330 : Fixed deadlock in FWebBrowserSingleton
#4303
Change 3811191 by Barnabas.McManners
BuildPatchServices: Expanded MF01-X into MF01-X-X and MF02-X where X is the os error codes
Change 3807662 by Barnabas.McManners
BuildPatchServices: Broke down build verification errors into 4 new cases.
Change 3805698 by Leigh.Swift
BuildPatchServices: Speculative fixes for Unit test crashes / failures.
Change 3804175 by Wes.Fudala
ThirdParty: CEF: Adding browser locale pak files for es-MX, and es-ES as the typical mapping/fallback does not seem functional on mac browser. They are copies of es_419 and es respectively.
Change 3786628 by Leigh.Swift
WebBrowser: Exposing ability to customise tool tip widgets produced from SWebBrowserView.
Change 3775678 by Richard.Fawcett
BuildPatchServices: Allow a Prerequisite install only mode.
Change 3774365 by Justin.Sargent
BuildPatchServices: Updated Build Stat report that is logged after every installation to use FText::AsMemory instead of the UnitConversion logic, and now it outputs multiple unit types for convenience.
Change 3774361 by Justin.Sargent
Http: Remove Pragma: no-cache header from libcurl requests
Change 3774258 by Leigh.Swift
BuildPatchServices: Fix for destructive patch destroy files that contain useful data.
Change 3766156 by Barnabas.McManners
Http: Various lower changes to enable Hardware testing and to enable proxy configuration.
Change 3756723 by Leigh.Swift
BuildPatchServices: Hooking up disk chunk store operation states to the installer statistics.
BuildPatchServices: Memory chunk store statistics fix for booted chunks that have been reloaded.
Change 3756320 by Rob.Cannaday
Http: Add default headers added to every HTTP request.
Change 3741274 by Wes.Fudala
WebBrowser: Release CEF related references prior to CEF shutdown.
Change 3738003 by Leigh.Swift
BuildPatchServices: Fix-ups for install stats when failures are occurring
NumFilesOutdated now only set on first run, so it is not set to the number of files that are retried.
Total downloaded data and total download requirement stats fixed up for runtime as well as final values.
Initial chunk counters now only set for first run.
Moving the GetBytesDownloaded api from cloud source to download service so that it correctly accumulates.
InstallSource was multiply attempting, and counting, recycle failures, throwing that stat out of proportion.
Change 3729851 by Barnabas.McManners
BuildPatchServices: Changed the installer's MoveFile method to default to not retry. We currently only have uses of move file which already handle retry.
Change 3725611 by Leigh.Swift
Core: FText::AsMemory - Fix for numerical edges.
Added unit tests to check all edges up to full uint64 range.
Change 3725127 by Leigh.Swift
BuildPatchServices: ManifestDiff: Correcting string format padding for new data size output uints.
Change 3725126 by Leigh.Swift
Core: FText::AsMemory fix. Shifting (equivalent of divide 2 per shift) does not work for calculating SI units which are base 10.
Change 3721926 by Justin.Sargent
ThirdParty: LibCurl update performed by Simon Tourangeau.
We now have 100MB/sec download speed with libcurl on Win64, compared to 3MB/sec originally
Change 3700670 by Michael.Trepka
SlateReflector: Fixed mouse click highlighting in Widget Reflector's Demo Mode in high DPI
Change 3697526 by Leigh.Swift
BuildPatchServices: Exposing a suite of runtime statistics for BuildPatchInstallers.
Change 3686439 by Leigh.Swift
BuildPatchServices: Stop installers from always logging a shutdown error on destruction. This should only occur if the installer is actually running.
Change 3684747 by Leigh.Swift
BuildPatchTool: Fix file ignore list to parse using platform agnostic method.
Change 3643038 by Michael.Trepka
Core: Don't defer Cocoa calls in FMacWindow Show and Hide to make sure both actions complete before we exit these functions. This solves the problem with the blocks being called after window was destroyed.
Change 3639692 by Michael.Trepka
Fixes for a couple of issues found by address sanitizer
Change 3625568 by Leigh.Swift
BuildPatchServices: Fixing numerical limits problem with double -> uint64 in FStatsCollector::SecondsToCycles().
Change 3617948 by Leigh.Swift
BuildPatchServices: Disk space requirement can now be lower when patching if destructive patch mode is enabled. This mode will delete existing old files once they are not needed.
BuildPatchServices: Adding new installation mode setting on installer config.
BuildPatchServices: If destructive installation mode is enabled, the file constructor will delete old existing files after completing the new one.
BuildPatchServices: Adding missing file path length check for install location to cover situation where staging directory is outside the install directory.
Change 3593632 by Leigh.Swift
BuildPatchServices: Adding additional installation tracking to BuildPatchServices. See Engine/Source/Runtime/Online/BuildPatchServices/Public/Interfaces/IBuildInstaller.h
[CL 4273704 by Leigh Swift in Main branch]
