Commit Graph

23 Commits

Author SHA1 Message Date
Marc Audy
7379fa99c5 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14229157
[CL 14233282 by Marc Audy in ue5-main branch]
2020-09-01 14:07:48 -04:00
Matt Kuhlenschmidt
603a4119c5 Fix HAL/PlatformFileManager.h non-portable casing CIS issues
#rb none

[CL 13214257 by Matt Kuhlenschmidt in ue5-main branch]
2020-05-06 17:58:18 -04:00
ryan durand
0f0464a30e Updating copyright for Engine Runtime.
#rnx
#rb none


#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870549 by ryan durand in Main branch]
2019-12-26 14:45:42 -05:00
thomas ross
62b59465c4 iOS Background HTTP Fixes
- Fixing error where pausing and resuming tasks on iOS would activate too many tasks.
- Fixing potential multi-threaded crash accessing UnAssociatedTasks list
#rb Peter.Sauerbrei
#tests iOS Client


#ROBOMERGE-SOURCE: CL 10500599 via CL 10500600 via CL 10500603 via CL 10500605
#ROBOMERGE-BOT: (v606-10482310)

[CL 10500610 by thomas ross in Main branch]
2019-12-03 15:56:40 -05:00
thomas ross
bdfe4aeb92 Fixing bug in iOS Background HTTP where we could end up queueing lower priority tasks when backgrounding earlier then intended when the task count was low.
#tests iOS Client
#rb none


#ROBOMERGE-SOURCE: CL 10493435 via CL 10493436 via CL 10493437 via CL 10493438
#ROBOMERGE-BOT: (v606-10482310)

[CL 10493439 by thomas ross in Main branch]
2019-12-02 20:37:13 -05:00
thomas ross
bd0a756878 Fixing bug where iOS Background HTTP Requests are not resuming all work when going into background correctly.
#tests iOS Client


#ROBOMERGE-SOURCE: CL 10492894 via CL 10492910 via CL 10492913 via CL 10492917
#ROBOMERGE-BOT: (v606-10482310)

[CL 10492923 by thomas ross in Main branch]
2019-12-02 19:43:10 -05:00
thomas ross
7ff68c9ba5 Background HTTP Fixes:
- Fix ensure during backgrounding
- Fix potential crash when backgrounding
#rb none
#tests iOS Client


#ROBOMERGE-SOURCE: CL 10454165 via CL 10455164 via CL 10455271
#ROBOMERGE-BOT: (v595-10452236)

[CL 10455456 by thomas ross in Main branch]
2019-11-26 11:53:43 -05:00
thomas ross
b6ec1d7d18 BackgroundHttp Improvements:
- Added priority system for Background HTTP downloads.
- Fixed bug where dropping internet connection mid-download would trigger an ensure and try to re-activate all possible download tasks on iOS at once.
- Fixed issue where we were immediately calling the NSURLSession Background completion handler instead of waiting for threads to finish their work. Could lead to scenarios where we weren't finishing re-queuing failed tasks in the background if many failed.
[CODEREVIEW] [at]Justin.Marcus, [at]Daniel.Lamb
#tests iOS Client, Android Client
#rb none


#ROBOMERGE-SOURCE: CL 10149845 via CL 10150034 via CL 10150114
#ROBOMERGE-BOT: (v587-10111126)

[CL 10150178 by thomas ross in Main branch]
2019-11-13 14:31:30 -05:00
thomas ross
5ee7eccdcc Fixed issue where UnAssociatedTasks could associate with an already completed task and create a timing issue where a BackgroundHttp request would do no work as it was pending a cancel that wasn't going to happen. No longer associates with tasks that are already completed/completing
#rb none
#tests iOS Client


#ROBOMERGE-SOURCE: CL 8669433 via CL 8669434 via CL 8672590 via CL 8672608 via CL 8675994
#ROBOMERGE-BOT: (v417-8656536)

[CL 8676132 by thomas ross in Main branch]
2019-09-13 13:57:36 -04:00
ben marsh
fb4078d777 More IncludeTool fixes.
#rb none
#rnx
#jira

#ROBOMERGE-SOURCE: CL 8374228 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v406-8472469)

[CL 8497914 by ben marsh in Main branch]
2019-09-04 15:40:51 -04:00
chris varnsverry
f564a4cb73 Make MaxActiveDownloads configurable
[at]Michael.Kirzinger [at]Thomas.Ross


#ROBOMERGE-SOURCE: CL 8130597 via CL 8130603 via CL 8133879
#ROBOMERGE-BOT: (v401-8057353)

[CL 8160214 by chris varnsverry in Main branch]
2019-08-21 09:37:24 -04:00
thomas ross
c5aa3a3a4f Fix for BackgroundHttpManager resuming paused tasks when moving to background.
Fix for BackgroundHttpManager resuming paused tasks when they associate with an UnAssociatedTask.
Fix for BackgroundHttpManager resuming paused tasks when they were created in the background.
#rb none
#tests iOS Client
[REVIEW] [at]Justin.Marcus, [at]Daniel.Lamb


#ROBOMERGE-SOURCE: CL 6892268 via CL 6892271 via CL 6892273 via CL 6893375
#ROBOMERGE-BOT: (v366-6836689)

[CL 6893406 by thomas ross in Main branch]
2019-06-07 13:18:42 -04:00
thomas ross
d0e706a32d Previous fix could crash when handling unassociated tasks. Also fixed seperate potential crash with uninitialized variable for debug name.
#tests iOS Client
#rb none
[REVIEW] [at]Justin.Marcus, [at]Daniel.Lamb


#ROBOMERGE-SOURCE: CL 6837842 via CL 6837845 via CL 6837847 via CL 6837849 via CL 6840261
#ROBOMERGE-BOT: (v366-6836689)

[CL 6841316 by thomas ross in Main branch]
2019-06-04 18:27:02 -04:00
thomas ross
44cbb9d3d4 Fix so that iOS BackgroundHttp no longer auto-resumes paused tasks.
#tests iOS Client
[REVIEW] [at]Justin.Marcus,[at]Daniel.Lamb


#ROBOMERGE-SOURCE: CL 6836763 via CL 6836765 via CL 6836771 via CL 6836774 via CL 6838783
#ROBOMERGE-BOT: (v366-6836689)

[CL 6838917 by thomas ross in Main branch]
2019-06-04 15:55:50 -04:00
thomas ross
137c382560 Fixing iOS compile error by previous submit.
#tests none
#rb none


#ROBOMERGE-SOURCE: CL 5954847 via CL 5958841 via CL 5961035

[CL 5961138 by thomas ross in Main branch]
2019-04-17 20:27:28 -04:00
thomas ross
cba82160b5 iOS BackgroundHTTP Fixes:
- Fixing bug where queueing same URL with 2 different BackgroundHttpRequests on iOS could result in receiving a callback 2x for the same request.
- Crash fix for iOS when an invalid URL is present in a task when we process UnAssociatedTasks.
#rb none
#tests iOS Client


#ROBOMERGE-SOURCE: CL 5953315 via CL 5953428 via CL 5959421

[CL 5959613 by thomas ross in Main branch]
2019-04-17 20:14:46 -04:00
thomas ross
0fc1b01094 Fixing compile error on iOS with invalid Super:: call.
#rb none
#tests none


#ROBOMERGE-SOURCE: CL 5537537 via CL 5547598 via CL 5548130

[CL 5548195 by thomas ross in Main branch]
2019-03-25 19:45:08 -04:00
thomas ross
338aa44dd2 Adding timeout for BackgroundHTTP Temp files after a configurable timeout time. Default is 3 days. -1 to turn off.
#rb none
#tests Android Client


#ROBOMERGE-SOURCE: CL 5537027 via CL 5547592 via CL 5547918

[CL 5548102 by thomas ross in Main branch]
2019-03-25 19:44:02 -04:00
thomas ross
b20e390704 Background Http Improvements:
- Fixed bug where BackgroundHttp temp files were not being cleaned up by calls to the CleanUpTemporaryFiles on the  BackgroundHttpManager were not correctly cleaning temp files on iOS.
- Improved handling of BackgroundHttp downloads that were in progress at app start by improving UnAssociatedTask handling.
- Fixed bug where Apple BackgroundHttp could end up queueing duplicate download tasks for the same file in some threading cases.
- Made general logging improvements and converted some NSLogs and Warnings into ensures to better track bad behavior.
#rb none
#tests iOS Client


#ROBOMERGE-SOURCE: CL 5403159 via CL 5403165 via CL 5405452

[CL 5405495 by thomas ross in Main branch]
2019-03-14 19:06:08 -04:00
thomas ross
ebd05e2bb3 iOS Background Http Improvements:
- Improved handling of UnAssociatedTasks. Removing some bugs where they would stall and no longer update.
- Fixed bug with how many tasks we thought were active while in the foreground being inaccurate.
- Added ensures to make sure we don't violate thread safety in our callbacks.
- Minor logging changes
#rb none
#tests ios client


#ROBOMERGE-SOURCE: CL 5009707 via CL 5009709 via CL 5013145

[CL 5014433 by thomas ross in Main branch]
2019-02-15 21:06:27 -05:00
thomas ross
d9a8318dc0 Correcting Copyright notices on newly submitted files.
#jira UE-69643
#rb none
#tests none


#ROBOMERGE-SOURCE: CL 4923337 via CL 4923339 via CL 4923341 via CL 4923441 via CL 4927248

[CL 4931954 by thomas ross in Main branch]
2019-02-07 09:15:10 -05:00
thomas ross
818151c3fc Added ability to cancel/pause/resume background http requests at the request level
#rb none
#tests iOS Client, Windows Editor Client


#ROBOMERGE-SOURCE: CL 4921169 via CL 4921171 via CL 4921173 via CL 4921262 via CL 4926860

[CL 4927673 by thomas ross in Main branch]
2019-02-07 01:38:51 -05:00
thomas ross
ba30c91d75 Adding background http protype system. Enables downloading files while app is suspended on iOS. Other platforms need to be added over time if desired. For now other platforms just wrap basic HTTPRequests under the hood.
#rb none
#tests iOS / Android
[CODEREVIEW] Andrew.Grant,Daniel.Lamb,Justin.Marcus
[FYI] Pete.Sauerbrei


#ROBOMERGE-SOURCE: CL 4898958 via CL 4898963 via CL 4898965 via CL 4905881

[CL 4906509 by thomas ross in Main branch]
2019-02-05 18:09:08 -05:00