#rnx
#rb none
#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870549 by ryan durand in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 2932765 by Nick.Whiting
Merging updated license files for Oculus libraries
Change 3480552 by Dustin.Holmes
Added map and gamemode for calibration
#jira UEVR-808
Change 3502253 by Nick.Whiting
Trying to fix up p4's botch of the merge
Change 3513736 by Keli.Hlodversson
Move duplicated late update code into a common FLateUpdateManager
#jira UEVR-893
Change 3514798 by Mike.Beach
#4.17
Exposing a way for Blueprint users to remap the SteamVR controller's d-pad buttons (clashes with the Oculus mappings).
#jira UE-42634
Change 3516042 by Dustin.Holmes
Runtime handedness changes in Vive controllers are now reflected when a new device is connected. Device mappings are also reset when a device disconnects, so that if it connects again it fully reregisters instead of just assuming the role it previously had.
Change 3517781 by Keli.Hlodversson
Remove unused local variable bUseCustomPresentTexture
Change 3517951 by Mike.Beach
#4.17
Guarding against dereferencing a null pointer. Defaulting to the identity when we don't (yet) have a valid head pose to use.
#jira UE-43685
Change 3518142 by Mike.Beach
#4.17
Resolving fallout from bad merge (CL 3514868) - checking for teminating null in array (which was added to keep ARRAY_COUNT from acting on an empty array).
Change 3523183 by Ryan.Vance
#jira UE-46493, UEVR-661
Fixes GearVR only displaying a black screen on startup
Fixes GearVR rendering incorrectly with mobile multi-view w/o direct mode enabled
Adding mobile multi-view direct support to Daydream
Change 3523718 by Nick.Whiting
Adding core controller recentering delegate, and moving Google over to that system.
Change 3527263 by Dan.Oconnor
Mirror 3526925 for Nick Donaldson
Change 3533596 by Dustin.Holmes
Add garbage matte map, gamemode, and blueprints.
Change 3533598 by Dustin.Holmes
Expose the Set Tint Color and Opacity function for Widget Components as a Blueprint node.
Change 3538139 by Mike.Beach
Moving Oculus debug shader directly into Oculus plugin.
#jira UE-47134
Change 3543185 by Nick.Atamas
Address UEVR-891 : Merge in changes to Google Tango plugin.
#jira UEVR-891
Change 3543285 by Nick.Atamas
Merging using //UE4/Release-4.17/... -> //UE4/Dev-VR/... :
Fixed UEVR-852:
Adjusted Google Tango Plugins copyright to Copyright Google 2017.
Removed Apache 2.0 license.
Change 3545505 by Nick.Atamas
Fix UEVR-851 : some fix-ups to MeshReconHUD and overlay material now has a material parameter for tinting the reconstructed mesh to help debug visualization.
Change 3547549 by Jeff.Fisher
Fixing DefaultSpectatorScreenController comment.
Change 3551339 by Ryan.Vance
#jira UE-44947
Editor primitives we not being handled correctly with ISR.
Change 3554169 by Dustin.Holmes
Reconcile missed Mixed Reality blueprint
Change 3566825 by Mike.Beach
Fixing some bad merges from Main (fallout from CL 3566309)
Change 3567143 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3567572 by Mike.Beach
[WIP] Adding some MR plugin dependencies to keep CIS quiet (SteamVR is just temporary, and will be removed).
Change 3569116 by Jeff.Fisher
Mixed reality build breaks for PS4
-Module is dependent on steamvr, so don't build it for PS4.
-Removed unused class that doesn't compile with clang.
Change 3569362 by Mike.Beach
Organizing MR plugin content, to make way for new calibration modes.
Change 3572802 by Jeff.Fisher
UEVR-832 Add save/load system for calibrated camera settings
-Moved MixedRealityConfigurationSaveGame to c++.
#review-3571779
#jira UEVR-832
Change 3573864 by Mike.Beach
[WIP] Initial work on MR cam alignment controller - records point/frustum data from user input.
Change 3575900 by Jeff.Fisher
Vive spectator flat rect expanded to match other platforms.
-The vive 'full flat eye' rect was narrower than other platforms. Expanded it to be closer to the other platforms.
Change 3578684 by Mike.Beach
Static analysis fixes for CIS.
#jira UE-48204, UE-48203, UE-48206
Change 3579460 by Mike.Beach
[WIP] New calibration mode for camera alignment.
#jira UEVR-785
Change 3581232 by Mike.Beach
[WIP] Saving off alignment calibration data, and loading it on initialization. We skip alignment calibration if it has been configured.
#jira UEVR-832
Change 3588411 by Mike.Beach
[WIP] Adding calibration for compositing (chroma color, etc.).
#jira UEVR-785
Change 3588541 by Mike.Beach
[WIP] Cleaning up some display issues with the MR calibration.
#jira UEVR-785
Change 3588680 by Mike.Beach
Re-organizing the MR content, now that the alignment controller calibrates more than just alignment (renaming, etc.).
Change 3588694 by Mike.Beach
Renaming the MR calibration pawn (since it doesn't do any calibrating itself).
Change 3591518 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3591671 by Ryan.Vance
Debug stereo layer support
This adds an option to render the debug canvas to a stereo layer which greatly improves console and stat readability in an hmd.
Change 3591812 by Ryan.Vance
Don't snap motion controllers to the origin when tracking is lost.
Change 3594681 by Mike.Beach
[WIP] Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3596679 by Mike.Beach
CIS fix (likely fallout from CL 3591671) - changing the order of initialization to better match the order of declaration.
Change 3598191 by Jeff.Fisher
UEVR-807 Setup M_MRVidProcessing to use 3D garbage matte data.
-Created MixedRealityGarbageMatteCaptureComponent. An instance of this is spawned by and attached to MixedRealityCaptureComponent. Saved config data is loaded into it. It spawns a garbage matte actor. It then captures the garbage matte actor into a render target (which is set on MixedRealityCaptureComponent).
#jira UEVR-807
#review-3598179
Change 3598276 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3598332 by Mike.Beach
Guarding against a blind cast in the SteamVRChaperone component, which can be used cross platform (can't assume SteamVR).
Change 3605271 by Mike.Beach
Copying //Tasks/UE4/Dev-MixedReality to Dev-VR-Minimal (//UE4/Dev-VR-Minimal)
Change 3608490 by Jeff.Fisher
UEVR-987 Social Screen PS4 need to go to 'mirroring' for hmd setup dialog because system dialogs are not visible in separate mode.
UEVR-988 SpectatorScreen Flickering
UE-47234 Spectator screen: need frame delay before assigning dynamically created rendertarget to spectator texture
UE-47310 Spectator Screen: crash if you release a render target which is assigned as the spectator texture
-Test level content for all of these bugs.
Change 3608883 by Jeff.Fisher
UEVR-807 Setup M_MRVidProcessing to use 3D garbage matte data.
-Set material to use the garbage matte render target.
Change 3613292 by Mike.Beach
Moving header fcn decl up, under the proper interface section (for organization's sake).
Change 3616943 by Nick.Whiting
Updating SteamVR libraries to 1.0.9, so we can bring back macOS support
Change 3616970 by Nick.Whiting
Adding in steamvr visible area mesh support. Can be toggled with vr.SteamVR.UseVisibleAreaMesh
Change 3617866 by Mike.Beach
Updating the VR template to reflect Oculus HMD device naming that we've keyed off of in these Blueprints (when determining which VR system we're running on).
Change 3620108 by Mike.Beach
[WIP] Adding an intermediate calibration step to tweak the MR virtual cam's alignment.
Change 3620982 by Mike.Beach
Tying off some loose ends with the MR calibration map:
* Saving after each calibration phase
* Fixing blocked input from garbage matte creation
* Blocking input handling while exiting/previewing
* Adding minimum radius for random screen pt
Change 3621551 by Mike.Beach
[MR] Leveraging camera support in the new media framework - working for limited cameras in calibration.
Change 3621552 by Mike.Beach
[MR calibration] - fixing it so when you first switch into compoisiting calibration it updates the property readout.
Change 3621660 by Mike.Beach
[MR calibration] Cleaning up how we display text (adding a struct to wrap the coresponding properties).
Change 3623323 by Dustin.Holmes
Fix buffer overflow when using 5+ Vive generic trackers and add more Special hand designations to cover the maximum 11 trackers Vive supports
Change 3625900 by Keli.Hlodversson
Remove fixed 16:9 aspect ratio for SteamVR and Oculus splash screens.
Oculus was already fixed in CL#3413801, but regressed with plugin renaming and unificiation with GearVR in CL#3502152.
#jira UE-40220 StereoLayer splash layers are hardcoded to 8 by 4.5 meters (16:9 aspect ratio)
Change 3628409 by Mike.Beach
Speculative CIS fix.
#jira UE-49339
Change 3628440 by Nick.Whiting
Fix for SteamVR OSX build issues
Change 3628489 by Nick.Whiting
Fix for win32 build break
Change 3629045 by Mike.Beach
Shadowed variable name fix (CIS).
Change 3629202 by Arciel.Rekman
Copying //UE4/Partner-Valve@3629179 to Dev-VR (//UE4/Dev-VR)
Change 3629340 by Nick.Atamas
Unshelved and resolved changes from Oculus.
Change 3629772 by Ryan.Vance
Fixing Oculus Vulkan related compile issues. This will break Oculus Vulkan support, but the code needs to be refactored anyway.
Change 3629833 by Mike.Beach
Fixing up CIS warning introduced by Oculus 1.17 changes - "unsafe conversion" warning
#jira UE-49376
Change 3630696 by Jeff.Fisher
UE-49415 //UE4/Dev-VR: Incremental UE4Editor Win64 completed with errors - 5 Errors
Switching an include to a forward declaration
-Not sure why the previous version didn't compile on the build machine, but fewer dependencies is good.
Change 3630783 by Mike.Beach
Fixing CIS compiler failures for our vehicle templates.
#jira UE-49417
Change 3630802 by Mike.Beach
Better fix than 3630783 - updating the vehicle template's stereoscopic check (fixing the VehicleHud.cpp logic as well)
#jira UE-49417
Change 3630870 by Mike.Beach
Pragma'ing out a function pointer cast warning. Good warning, but I figure we know what we're doing here and there's no other way around it.
#jira UE-49376
Change 3630993 by Ryan.Vance
Check to ensure we have a valid third camera before trying to use it.
We could check >= 3 or if the left and right cameras are left/right stereo etc. decided to go with the simple test for now.
Change 3631322 by Jeff.Fisher
UEVR-909 PIP in Garbage Matte
-Added ExternalGarbageMatteActor to MixedRealityGarbageMatteCaptureComponent and exposed it to blueprint though MixedRealityCaptureComponent. This lets us switch from using the normal mixed reality component save/load garbage matte data and instead use an external actor, in this case the actor we use to setup the garbage matte. Then the mask is able to capture that actor live as it is edited.
-Also implemented GetViewOwner() so that we can use SetOwnerOnlySee to prevent other cameras and captures from seeing the garbage matte actor.
-Calibration level now uses the external garbage matte actor to let the garbate matte mask live update. It also does a picture-in-picture preview of the mixed reality scene. 'P' can show/hide the garbage matte actor on that PIP preview.
-Added SetUnmaskedPixelHighlightColor to MixedRealityCaptureComponent and the material. With this one can make unmasked video pixels more obvious in the output. The calibration level has this mapped to shift-P and makes pixels bright yellow to white.
-Added blueprint to calibration level to make the garbage matte actor visible in the mixed reality capture. That is bound to ctrl-g.
-GarbageMatteActors spawned by the mixed reality capture component are now attached to the vr origin. The calibration level now saves garbage matte mesh transforms relative to the vr origin.
-The garbage matte mesh is now plugin content, and is referenced in the mixedrealitycomponent default object, so it is cooked in any project that includes the plugin.
-Fog and AtmosphericFog no longer affect the garbage matte mask capture... there may be other things we need to turn off there.
#review-3618345
#jira UEVR-909
Change 3631362 by Keli.Hlodversson
#jira UE-49418 Exiting Google Instant Preview displays half of the editor viewport as black.
Note convoluted fix: passing bIsStereoScopic3D to IsActiveThisFrame. ISceneViewExtension code cannot rely on StereoRenderingDevice->IsStereoEnabled to know whether to render in stereo, as the current viewport widget may disable it. This was not a problem before the refactoring, as HMD-related viewextensions were only added to the active list after establishing that stereo indeed was enabled and allowed by the current view port widget.
Change 3631887 by Jeff.Fisher
Fixing IsActiveThisFrame build break.
Change 3632206 by Nick.Atamas
Fix for UE-49413.
Registering FOculusHMD as an extensions the same way as others: now creates an XRCamera that passes all the calls back to the HMD.
Change 3632264 by Nick.Whiting
Fix for Vive rendering getting cropped off due to invalid subrect values being submitted to the compositor.
Change 3632340 by Nick.Atamas
Merged in change from Loren; opted for our solution to ViewExtensions instead of the one in the changelist.
Original description below.
Change 3632214 by Loren.McQuade@Loren.McQuade_Dev-VR on 2017/09/07 19:51:29 *pending*
[Dev-VR] Added OculusHMD_SceneViewExtension, PlayerPosition/PlayerOrientation values, FOculusHMD::GetRelativeEyePose cross-eyed madness (CL 3631541, 3631687)
Change 3632353 by Ryan.Vance
#jira UE-49468
Don't apply xr camera rotation on the player controller when not using xr tracking.
Change 3632735 by Keli.Hlodversson
Better fix for #jira UE-49413.
Revert oculus xr camera code and use that one can have more than one view extension registered instead.
Use GetPriority to have the OculusHMD view extension code execute after the default xr camera.
The xr camera subclass did not forward the calls to ISceneViewExtension to the parent, breaking various functionality such as late update.
Fixes a crash when entering VR pie twice, back to back.
Change 3632752 by Keli.Hlodversson
Applying change 3632592 by Loren.McQuade@Loren.McQuade_Dev-VR_Branch on 2017/09/08 02:08:22
[Dev-VR] Push //UE4/Partner-Oculus@3632591 #rb merge
//UE4/Partner-Oculus to //UE4/Dev-VR/...
Reverted OculusHMD_XRCamera changes, as that clas has been removed in the interim.
Change 3633211 by Mike.Beach
Backing out Oculus MotionController hiding that accidently got submitted - we decided not to adopt this change originally.
Change 3633315 by Jeff.Fisher
merge from main with dev-platform problem children
-expecting SDRBackBuffer stuff to be wrong.
Change 3634006 by Mike.Beach
Resurecting Oculus clip plane settings which got dropped in the IXR refactor.
#jira UE-49520
Change 3634639 by Keli.Hlodversson
Avoid include cycle
https://ec-01.epicgames.net/commander/link/jobStepDetails/jobSteps/68863219?stepName=UE4Editor%20Static%20Analysis%20Win64%20%28IncludeTool%29&jobId=7995809&jobName=UE4%20Dev-VR%20-%20CL%203632752%20-%20Nightly%20Build&tabGroup=diagnosticHeader&firstPage=1
Change 3634641 by Jeff.Fisher
UE-49535 Lighting is blown out when playing in VR Preview on Vive
-Need pixel format to be PF_B8G8R8A8 for vr, now the plugins all build their render target and use that format.
#review-3634623
Change 3634682 by Jeff.Fisher
IHeadMountedDisplay forward declarations needed.
Change 3634690 by Ryan.Vance
We can't override the screen percentage when rendering for stereo
#jira UE-49287
Change 3635970 by Keli.Hlodversson
#jira UE-49563 Crash while opening QA-Game Referencing SharedPointer.h
Verify that StereoRendering is valid before calling IsStereoEnabled()
Change 3635979 by Mike.Beach
CIS static analysis fix - checking a ptr for null before we use it.
#jira UE-49531
Change 3636059 by Mike.Beach
Fixing XR system name aliasing for the -hmd command.
[CL 3638830 by Ryan Vance in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb Merge
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3094167 on 2016/08/18 by Jeff.Fisher
UEVR-97 Morpheus HMD tracking needs to wait until HMD is fully tracked.
-Morpheus CALIBRATING/NOT_TRACKED tracking state hmd orientation update disabled and delegates added to present instructions to the user. This behavior is controlled by morpheus ini setting bDisableHMDOrientationUntilHMDHasBeenTracked, but defaulted to true to avoid subtly bad user experiences.
#review-3094106 @chad.taylor
#jira UEVR-97
Change 3104799 on 2016/08/29 by Jeff.Fisher
UEVR-178 Morpheus HMD Black crescents
-Switched reprojection frame time for 60/120 mode from 120hz to 60hz so we much better predict where the hmd will be pointing when the frame we are about to render is actually displayed, and are run off the edge of it less often and less severely. This makes the black crescent artifacts only just visible during very fast head turning. The kWrapModeMirror change, which will be submitted separately, makes the left and right crescents invisible to me.
-Renamed the functions for setting the prediction info in the PS4Tracker.
-Added render frame parameters to sony reprojection functions, these can help with debugging reprojection.
-Added commented out sce call to get the reprojection debug data. Not allowed to submit an executable that calls it, but its nice to at least know where one can put it. May improve this later.
-Wrapped PS4Tracker->Synchronize call in a check that the tracker handle is valid, because I managed to get it called when it wasn't (probably during hmd power off testing, but I don't remember now). It should be fine to not do it if the tracker is not functioning.
#review-3104780 chad.taylor
#jira UEVR-178
Change 3108423 on 2016/08/31 by Jeff.Fisher
Morpheus Config Improvements.
-UEVR-138 Morpheus HMD reprojection wrap mode config setting
-Can now switch between wrap mode Mirror and ClampToBorder. Mirror is the default.
-Made bDisableHMDOrientationUntilHMDHasBeenTracked editable in UE4Editor project settings.
-Using generic project setting for bStartInVR, removed the morpheus specific one.
#jira UEVR-138
#review-3106999 @nick.whiting
Change 3111231 on 2016/09/01 by Jeff.Fisher
Fixed bStartInVR ini setting.
-Initial implementation worked via a generic EnableStereo call, which worked, but happened after the hmd setup dialog, which is not what I wanted.
-Also fixed a tracking frame mismatch assert that hit when I powered the hmd off once, causing it to lose tracking. Its ok that it doesn't update in that circumstance.
#review-3111211 @ryan.vance
Change 3115196 on 2016/09/06 by Keli.Hlodversson
#jira UEVR-128
Map move controller Select button to Invalid, as it is always handled by the system
Change 3116425 on 2016/09/07 by Chad.Taylor
PSVR: stereo layers implementation
Change 3116593 on 2016/09/07 by Jeff.Fisher
UEVR-126 Morpheus HMD connect dialog cancel reactions
-VR only apps can't allow the player to cancel out of the hmd setup dialog, so lets just pop the dialog up again (sony were ok with a licencee doing this) if an ini setting says to do that.
-VR/2D apps might want to switch to 2d if the player cancels out of the hmd setup dialog, so there is an ini setting for that.
-A delegate only implementation is also provided for apps that want to do something else. This leaves the game rendering in VR mode, and fires the delegate.
-Refactored to better separate successful HMD acquisition from stereo rendering. This was necessary to support the delegate only option on startup. If you start in vr mode with your hmd off and cancel the dialog stereo rendering now starts with default values for the hmd hardware stats (as read from my pvt) instead of crashing trying to use uninitialized data. When an hmd is connected its values will be read.
-Refactored to ensure reprojection starts immediately when we call StartReprojection.
#jira UEVR-126
#review-3116221
Change 3116754 on 2016/09/07 by Keli.Hlodversson
bPixelDensityAdaptive is a bool and not a float property
Change 3117692 on 2016/09/08 by Jeff.Fisher
UEVR-135 Morpheus HMD recent feature error reporting
UEVR-173 2DVR flexibility (UTexture)
-Error log for sceHmdReprojectionSetOutputMinColor failure.
-Made the parameter for 2dVR a UTexture* instead of a UTexture2D*, so it can be a rendertarget, etc.
-Added error logs for missing texture, invalid texture, wrong texture format to 2DVR.
#jira UEVR-135
#jira UEVR-173
#review-3116955 @keli.hloedversson
Change 3117990 on 2016/09/08 by Jeff.Fisher
UEVR-127 Morpheus HMD removal reaction
-Added VRHeadsetPutOnHead and VRHeadsetRemovedFromHead delegates, and implemented them for Morpheus.
#jira UEVR-127
#review-3117968 @keli.hlodversson
Change 3120198 on 2016/09/09 by Jeff.Fisher
MorpheusReprojector frame complete wait error log
-Now log a warning if the sceKernalWaitEqueue returns an error. It not a problem if this happens rarely, but something is very broken if it starts happening continuously.
Change 3121754 on 2016/09/12 by Keli.Hlodversson
#jira UE-21878 - Also emit VR initialization analytics events in the editor.
Change 3122311 on 2016/09/12 by Nick.Whiting
Merging fix for Adreno devices rendering black from 4.13.1
Change 3123057 on 2016/09/13 by Keli.Hlodversson
#jira UE-30097 Use the current value of r.ScreenPercentage on Occulus Rift if it's explicitly set.
* If the SetBy part of the flags for the console var is SetBy_Constructor, then ignore the value.
* If it's SetBy_Scalability, then ignore it if it equals 100
* Else, call SetScreenPercentage using the current value
The obsolete HMD SCREENPERCENTAGE console command is still available and will override the setting until r.ScreenPercentage is modified the next time.
Change 3123200 on 2016/09/13 by Chad.Taylor
PS4 Stereo Layer double buffering. Since the overlays are reprojected at 120hz but rendered at 60hz we need to render to a separate buffer than the one being used by reprojection.
Change 3125845 on 2016/09/14 by Keli.Hlodversson
#jira UE-33996 Add hmd=<name> command line option to allow overriding which HMD module is used.
Renamed GetModulePriorityKeyName to simply GetModuleKeyName, as this name is now also used to match against the command line options.
Change 3127293 on 2016/09/15 by Jeff.Fisher
UEVR-225 Morpheus HMD top and bottom black crescents
-The hidden and visible area meshes for morpheus were too restrictive. Nudged them out a bit, no black crescents at the top and bottom of the screen. We are rendering a few more pixels now though.
#review-3127145 @ryan.vance
#jira UEVR-225
Change 3130635 on 2016/09/19 by Jeff.Fisher
UEVR-226 Morpheus HMD mirrored fill wrong on outer edges
-The setting was never being used, leaving the wrap mode at 0 aka kWrapModeWrap.
-Refactored how the setting is applied so it works, and is less convoluted.
#jira UEVR-226
#review-3129403
Change 3131615 on 2016/09/19 by Keli.Hlodversson
#jira UE-29341. Update Chaperone bounds when SteamVR tells us they have changed
Change 3136527 on 2016/09/22 by Keli.Hlodversson
Don't depend on the current state of the VR subsystem when exiting PIE mode to decide whether the main window should be restored. Instead always restore it if it was minimized at the start.
Change 3136652 on 2016/09/22 by Keli.Hlodversson
Allow shutting down Steam VR subsystem without shutting down the Steam VR plugin completely in response to quitting from the SteamVR overlay. Enabling stereo rendering again will reinitialize SteamVR. This is useful when using PIE in VR mode as it allows entereing it again without restarting the editor. Also fixes crashes by first disabinge stereo rendering a short while before shutting down the VR subsystem.
#jira UE-35940
Change 3138901 on 2016/09/23 by Ryan.Vance
Merging 3138521 using OdinToDevVR to bring over temporary forward lighting ISR changes for 4.14
Change 3141614 on 2016/09/27 by Keli.Hlodversson
Implement GetNumOfTrackingSensors and GetTrackingSensorProperties on SteamVR.
#jira UE-32994
Change 3141948 on 2016/09/27 by Jeff.Fisher
UEVR-242 Is AddControllerYawInput not allowed when morpheus is enabled?
-Indeed it did not work. Looks like morpheus would not accumulate the yaw, so it would be reset every frame. I made the implementation of ApplyHmdRotation very similar to the one used for occulus (also similar to other platforms) to fix this.
#jira UEVR-242
#review-3141933 keli.hlodversson
Change 3143484 on 2016/09/28 by Nick.Whiting
Integrating Oculus 1.8 SDK support, includes support for cylinder and cubemap stereo layers
Change 3143517 on 2016/09/28 by Chad.Taylor
Merging PS4Tracker fixes from Release-4.13 into Dev-VR
Change 3143805 on 2016/09/28 by Keli.Hlodversson
#jira UE-36478 Workaround to make world to meters scale apply correctly to Occulus controllers while running in PIE
Change 3143943 on 2016/09/28 by Nick.Whiting
Merging latest drop from OSVR
Change 3144221 on 2016/09/28 by Keli.Hlodversson
Implement GetTrackingSensorProperties on PS4
#jira UE-32994
Change 3144352 on 2016/09/28 by Ryan.Vance
Initial implementation of mobile multi-view.
This is non-functioning and requires a lot more work, but enough of the framework exists to make the 4.14 branch for an experimental release.
Change 3144585 on 2016/09/29 by Jeff.Fisher
UEVR-14 PSVR Support for 90Hz to 90Hz, and 120Hz to 120Hz
-Enum setting added for the three frame sequences.
-90Hz mode is trying to run camera updates at 90hz, but they can only run at 60 so every third one fails. This works, but its dubious.
-Feature marked as experimental for now because of that 90hz tracking issue, and the lack of testing.
-Defaulting to 60/120.
#jira UEVR-14
#review-3143486 chad.taylor nick.whiting
Change 3145263 on 2016/09/29 by Nick.Whiting
Fix for constructor initialization order in StereoLayerComponent, which threw a warning on Clang
Change 3145536 on 2016/09/29 by Nick.Whiting
Fixes for project files to prevent mystery pop up from CAPI
Change 3145663 on 2016/09/29 by Keli.Hlodversson
PSVR: Make sure the camera orientation returned from GetTrackingSensorProperties points in the right direction.
Change 3145670 on 2016/09/29 by Keli.Hlodversson
For some reason the orientation of the Oculus tracking sensor is reported as pointing backwards. This flips it around to face front
Change 3145687 on 2016/09/29 by Chad.Taylor
VR splash screen support
[CL 3146243 by Nick Whiting in Main branch]
#lockdown Nick.Penwarden
Change 3110660 on 2016/9/1 by Andrew.Grant
Moved performance/quality warnings out of DrawStatsHUD into new function and now display them in everything other than shipping builds (unless disabled, or screenshot/movie dumping is in progress.
HLOD warning is updated every 20 secs to deal with streaing levels.
Moved debug warnings into a separate Draw function (still disabled in test, but would like to make this an option in Orion soon).
#rb Michael.Noland
#tests verified we see our unbuilt HLOD warning in v31 :(
Change 3106649 on 2016/08/30 by Cody.Haskell
#Orion
- Input Axis Work
#rb DanH
#tests PIE
Change 3106299 on 2016/08/30 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 31.2 @ CL 3105865
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3105969 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3106213 on 2016/08/30 by Ben.Marsh
BuildGraph: Include UAT, UBT, and UHT binaries in precompiled binaries zip file.
#rb none
#tests preflight
Change 3105994 on 2016/08/30 by Martin.Wilson
Stop recompression happening when additive frame index is changed "interactively" (recompression will occur at end of interactive input)
#jira UE-35289
#rb Thomas.Sarkanen
#tests Tested UI in editor
Change 3105331 on 2016/08/29 by Uriel.Doyon
Allowed texture to ignore streaming MipBias with UTexture2D::bIgnoreStreamingMipBias
Used this new flag when assigning texture to UImage::SetBrushFromTexture to prevent having low quality UI in low texture budget.
#rb marcus.wassmer
#tests launched editor and played game
#jira OR-25814
Change 3105143 on 2016/08/29 by Josh.Markiewicz
#UE4 - added assert when histogram input parameters don't match
#rb none
#tests launched/ran/won game golden path
#codereview dmitry.rekman, michael.noland, bart.bressler
Change 3104976 on 2016/08/29 by Jon.Lietz
pickup refector
- fixed a big that would allow mixed replication to call a gameplay cue's added twice.
- All pickups now use the pick up manager, consolidated all pick up code into the manager.
- added to the XP set so we can define the CXP bounty for targets.
#RB Dave.Ratti
#tests Bot match, test maps, spawning coins and pickups.
Change 3103480 on 2016/08/26 by Josh.Markiewicz
#UE4 - added GetSessionIdStr to FOnlineSessionSearchResult and FOnlineSession
#rb none
#tests golden path matchmaking
#codereview paul.moore, eric.newman
Change 3103410 on 2016/08/26 by Max.Chen
Movie Capture: Fix commandline burnin option.
#rb none
#tests Render movie with commandline -UseBurnIn=yes option.
Change 3102134 on 2016/08/25 by Brian.Karis
Fix for HDR output exposure. Added 1000nit output option.
#rb marcus
#tests agora
Change 3101276 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_31 - Merging CL 3100347 (head revision of 2 files :o )
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3101273 in //Orion/Release-31/... via CL 3101274
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3101267 on 2016/08/25 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_DUI - Integrating Media changes from 4.13 (head revision)
#RB:none
#Tests:none
/Engine/Plugins/Media
/Engine/Source/Runtime/Media
/Engine/Source/Runtime/MediaAssets
[CodeReviewed] matt.schembari, max.preussner
#R@BOMERGE-SOURCE: CL 3099267 in //Orion/Dev-UI/... via CL 3101266
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100378 on 2016/08/24 by John.Pollard
Fix a crash that can occur when scrubbing in replays
#codereview David.Ratti
#tests Replays
#rb DavidR
This is the output:
[2016.08.24-21.35.05:973][603]LogAbilitySystem:Warning: OnRep_ReplicatedAnimMontage: PlayMontageSimulated failed. Name: AbilitySystemComponent0, AnimMontage: LevelStart_Montage
Change 3100375 on 2016/08/24 by Laurent.Delayen
Added AimOffsetLookAt node. AimOffset node that drives its inputs automatically from a Target Location (and a Source Socket).
#rb none
#codereview lina.halper
#tests Tacticia's RMB Targeting
Change 3100278 on 2016/08/24 by Laurent.Delayen
Fix for fast path struct copy being broken for FVectors.
#rb lina.halper
#codereview thomas.sarkanen
#tests Chains' hook, Tacticia's LaserBeam and OrientationWarping
Change 3100161 on 2016/08/24 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix issue with refresh viewer command failing due to backend congestion
#rb RyanG
#tests Replays
Change 3100114 on 2016/08/24 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3098849
#RB:none
#Tests:none
#CodeReview: kerrington.smith, matt.schembari
#R@BOMERGE-SOURCE: CL 3100078 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3100015 on 2016/08/24 by Michael.Noland
Don't allow the consideration of nodes that won't be processed to affect the live aspect of the active sound containing a cross fade node
#jira UE-34998
#rb Aaron.McLeran
[re-implementing CL# 3098559 originaly by Marc.Audy in Release 4.13]
#tests Compiled and ran a golden path match with headphones on
Change 3100012 on 2016/08/24 by Michael.Noland
UE-34951 - Zero-volume vorbis decoded sounds are too expensive
-Adding an audio settings parameter to disable zero-volume playback globally
-Adding a new bool on sound waves to allow opt-in to virtualize when at zero-volume
#rb marc.audy
[re-implementing CL# 3094893 from Dev-Framework, originally by Aaron McLeran]
#tests Compiled and ran a golden path match with headphones on
Change 3099889 on 2016/08/24 by Max.Chen
Sequencer: Added command line option to enable burnin
#rb none
#tests Render movie from command line wtih -UseBurnIn=yes
Change 3099801 on 2016/08/24 by Lina.Halper
Removed unnecessary comment
#rb: none
#code review: Benn.Gallagher
#tests: compile
Change 3099787 on 2016/08/24 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#http
- fix for cancelled requests that have not been started never triggering a completion delegate
- fixes soft lock when handling disconnects during login
OR-26945 The client stays on the "downloading profile" screen when rejoining after disconnecting
#rb josh.markiewicz, alex.fennell
#tests none
#R@BOMERGE-SOURCE: CL 3099782 in //Orion/Release-30.2/... via CL 3099784 via CL 3099785
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3099252 on 2016/08/24 by Lina.Halper
Fixed menu text
#rb: none
#code review: Thomas.Sarkanen
#tests: open editor and create child montage and replaced the animation
Change 3099251 on 2016/08/24 by Lina.Halper
Deterministic cooking of skeleton
- abandon all guid from GuidMap. GuidMap is still important since we have to generate UID from it, but GuidMap only contains name once cooked
#jira: UE-34834
#rb: Martin.Wilson
#tests: cooking orion and make sure it works
Change 3098504 on 2016/08/23 by Bart.Bressler
Add server time between sending packets monitoring histogram
#rb dmitry.rekman
#tests ran server locally and made sure analytics events were sent
Change 3098494 on 2016/08/23 by Michael.Noland
Engine: Added UWorld::SetTimeUntilNextGarbageCollection to change the GC timer for use when doing automated performance capture measurements
- Note: Things that force a GC will still force a GC after using this method (and they will also reset the timer)
- Fixed a bug where UWorld::ForceGarbageCollection might not force a GC immediately if run on a server with no clients connected
#tests Tested by calling while stat dumphitches was active and confirmed that the interval changed
#codereview ben.salem, gil.gribb
#rb none
Change 3098491 on 2016/08/23 by Mieszko.Zielinski
Expanded BTDecorator_IsAtLocation with an option to use AIDataProvider #UE4
#rb Lukasz.Furman
#test golden path
Change 3098070 on 2016/08/23 by Lina.Halper
Fix crash with UI update reconstructing
- will have to come up with a better solution than this.
#rb: Martin.Wilson
#tests: child anim montage
Change 3097914 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
Merging CL #3097879
from //WEX/Main/Engine/Source/Runtime/Online/NotForLicensees/OnlineSubsystemMcp/...
to //Orion/Main/Engine/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/...
#Analytics #OSS: Adjusted cohort selection algorithm and test cases
[CodeReviewed]: Philip.Buuck
#TESTS: unit tests
#RB: none
#R@BOMERGE-SOURCE: CL 3097911 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097745 on 2016/08/23 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Megre 30.2/31 @ CL 3096895
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3097716 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3097722 on 2016/08/23 by Chris.Bunner
Update texture expression properties before triggering parent material recompile.
#rb John.Billon
#tests Editor replace references, Golden path
#jira OR-27531
Change 3097694 on 2016/08/23 by Lina.Halper
#Child Anim Montage
- Duplicate from parent of the information it cares to get
- Currently it is selective on copying what data
- Modified GetAllAnimationSequencesReferred to get a partial data
- Added ParentAsset/AssetMappingTable in AnimationAsset
- Sequence Browser opening would also add to history
- AnimNotify - CanBeplaced virtual function lets you filter which asset it's placed on
#code review: Benn.Gallagher, Thomas.Sarkanen, David.Ratti
#rb:Martin.Wilson
#tests: creating child montage, editing, lots of UI functionality, notifies placement
Change 3097513 on 2016/08/23 by Thomas.Sarkanen
Non-POD structs can now be copied using the fast path
We now always use CPP struct ops to perform copies when dealing with struct properties.
#jira UE-34571 - Support struct member access on AnimBP fast path
#rb Laurent.Delayen
#tests OrionEntry with Tacticia, confirming orientation warping works correctly and fast path is enabled. Agora_P with Tacticia & bots, played two games.
Change 3096729 on 2016/08/22 by Mieszko.Zielinski
Fixes to EQS scoring function preview #UE4
#rb Lukasz.Furman
#test golden path
Change 3096596 on 2016/08/22 by Jason.Bestimt
#ORION_DG - Fixes from 4.13 to video playback (CL# 3075761 & 3083970)
#RB:none
#Tests:none
#CodeReview: matt.schembari, max.preussner
#R@BOMERGE: MAIN
Change 3096550 on 2016/08/22 by Jurre.deBaare
Fix for HLOD dirty clusters PIE warning message
#tests Simulated Origin with built HLOD clusters, and with one dirty cluster
#rb none
Change 3096532 on 2016/08/22 by Mieszko.Zielinski
Modified GameplayTask_WaitDelay to allow specifying task's priority #UE4
As part of the change introduced UGameplayTask::NewTaskUninitialized that's basically a redirect of NewObject, but clearly indicates that a task needs to be manually initialized
#codereview Lukasz.Furman
#rb none
#test golden path
Change 3096455 on 2016/08/22 by Jason.Bestimt
#R@BOMERGE-AUTHOR: keli.hlodversson
#CEF: Copy upgraded CEF binaries from //Portal/Main to fix crash issues with Sofort purchases
#RB David.Nikdel
#TESTS none
#R@BOMERGE-SOURCE: CL 3096452 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3096316 on 2016/08/22 by Sammy.James
Resave to fix log warnings.
BPC changes to ensure type saves.
#rb #tests editor
Change 3096040 on 2016/08/22 by bruce.nesbit
Revised fix for landscape crash
#rb GarethM
#tests Game
#codereview Bart.Bressler
Change 3096015 on 2016/08/22 by bruce.nesbit
Fixed a crash in ALandscapeProxy::PostLoad when running an editor build with -server
#rb none
#tests game
#codereview Bart.Bressler
Change 3095578 on 2016/08/19 by Mieszko.Zielinski
Made NavigationSystem call TickAsyncBuild on all navigation data instances is there was an ongoing navigation build in progress in the editor #UE4
This was causing Orion's flow field to not build if auto navmesh update was disabled in the editor
#rb none
#test golden path
#codereview Lukasz.Furman
Change 3095397 on 2016/08/19 by Lina.Halper
Fix issue with crash when deleting all segment
#rb: Laurent.Delayen
#tests: delete segment and make sure it doesn't crash
#jira: UE-34830
Change 3095060 on 2016/08/19 by Bart.Bressler
Don't load ULandscapeComponent objects on dedicated servers to save memory.
#tests cooked server data and played a Solo vs. AI game
#rb gareth.martin
#codereview james.golding
Change 3095037 on 2016/08/19 by Lina.Halper
Potential fix with montage trigger ensure on marker sync group
#jira: OR-27685
#rb: Benn.Gallagher
#code review: Martin.Wilson
#tests: attack primhelilx with knock up
Change 3094962 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merging #OSS - Added FUserOnlineAccountMcp::SelectCohort
#RB: None
#TESTS: test suite in source
[CodeReviewed]: Philip.Buuck
#R@BOMERGE-SOURCE: CL 3094961 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094950 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#Merge #UE4 - Made FMD5 const-correct
#RB: none
#TEST: none
#R@BOMERGE-SOURCE: CL 3094949 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3094619 on 2016/08/19 by Lina.Halper
#DUPEFIX - ANIM: SmartNAME: the cooking doesn't guarantee the package is saved in the order, so we'll still have to regenerate list without GUID.
- assumed the name is all set by now
#rb: Benn.Gallagher
#jira : UE-34886
#tests: cooking infiltrator that showed same issue and run game.
Change 3094532 on 2016/08/19 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3094498
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3094528 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3093260 on 2016/08/18 by Josh.Markiewicz
#UE4 - changed how party reset occurs to skip relying on AGameState which could very rarely be null (during server travel)
- removed unnecessary cast
#rb bart.bressler
#codereview bart.bressler, rob.cannaday
#tests launched game, some basic party testing
Change 3093224 on 2016/08/18 by Josh.Markiewicz
#UE4 - added a chatroom class that does some basic chat room join/create/leave functionality to share between games
#rb paul.moore
#codereview anthony.carter
#tests solo vs ai chat with 2 players, coop vs ai chat with 2 players, one leaving and rejoining
Change 3092597 on 2016/08/17 by Daniel.Lamb
Added Ben Crocker to the rebuild lighting emails.
#rb Trivial
#Test none
Change 3092063 on 2016/08/17 by andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb #tests none
Change 3091081 on 2016/08/16 by Jurre.deBaare
Fixing non-Editor build errors
#fix Wrapped parts in WITH_EDITOR and added IsBuilt to check if the LODActor has a valid static mesh (thus is not dirty)
#tests Build Editor + Game
#rb none
Change 3091009 on 2016/08/16 by Mieszko.Zielinski
Added a way to configure a map to not spawn AISystem instance at all #UE4
#rb none
#test golden path
Change 3090932 on 2016/08/16 by Michael.Noland
Vixen: Added indication to the analytics and FPS charts
#rb marcus.wassmer
#tests Compiled for the platform
Change 3090844 on 2016/08/16 by Laurent.Delayen
Replicated CL 3090734 from Fortnite.
---
Fix AbilitySystemComponent not ticking while playing a montage, and ticking when we're not playing a montage
Here's the issue in the version of the code prior to this checkin:
- UpdateShouldTick calls GetShouldTick, which checks the value of RepAnimMontageInfo.IsStopped
- When we call UpdateShouldTick within AnimMontage_UpdateReplicatedData, we haven't set RepAnimMontageInfo.IsStopped yet to the correct value
- So when we aren't playing any montages but are starting a new one, we were saying we shouldn't tick
- It also means if we were playing a montage, and then stop, we'll start ticking
- Ticking calls AnimMontage_UpdateReplicatedData, which should be called while we're playing
#codereview john.abercrombie
#rb none
#tests golden path
Change 3090832 on 2016/08/16 by Michael.Noland
Windows: Fixed a whitespace issue
#rb none
#tests Compiled for windows
Change 3090688 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Merging using ROBO://Orion/Release-Candidate->//Orion/Main
#rb none
#tests built
#R@BOMERGE-SOURCE: CL 3090687 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3090547 on 2016/08/16 by Jurre.deBaare
Need a warning message similar to lighting unbuilt when HLOD cluster is not built
#fix Added HLOD clusters need to be rebuilt message similar to the lighting one during PIE and game-time, and cleaned/changed "'DisableAllScreenMessages' to suppress" behaviour
#jira UE-34335
#rb none
#codereview Michael.Noland
#tests pie Agora with and without dirty HLOD clusters
Change 3090285 on 2016/08/16 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3090267
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3090282 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3089413 on 2016/08/15 by paul.mader
Agora 2.0 assets
Change 3089266 on 2016/08/15 by Max.Chen
Sequencer: Add Convert to Possessable
Copy from Dev-Sequencer
#jira UE-32139
#rb none
#tests Convert steel to possessable in Gameplay_PS4 map.
Change 3089136 on 2016/08/15 by Mieszko.Zielinski
Fixed AISense_Sight's time slicing unintentionally skipping queue aging if given time limit is reached #UE4
#rb Lukasz.Furman
#codereview Dan.Youhon
#test golden path
Change 3089118 on 2016/08/15 by Mieszko.Zielinski
Fixed a rare crash in UBlackboardData::GetKeyType resulting from a key selector referencing a type that has been removed from the project's source code #UE4
#rb none
#test golden path
Change 3088976 on 2016/08/15 by Andrew.Grant
Fixed issue with PS4 toolchain ignoring ModuleRules.CodeOptimization.Never / ModuleRules.CodeOptimization.Always when determining optimization level of modules.
Fixed issue with VC toolchain ignoring ModuleRules.CodeOptimization.Never setting.
Removed superflous /Os from VC debugg settings
#rb none
#tests verified module built with 'Never' on PS4/Win is built without optimizations.
#codereview Marcus.Wassmer, Ben.Marsh
Change 3088830 on 2016/08/15 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3088807
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3088829 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3088597 on 2016/08/14 by Jason.Bestimt
#ORION_DG - Trying to resolve R@BOMERGE collision (DUI to MAIN -> DG)
#RB:none
#Tests:none
#CodeReview: andrew.grant, david.ratti, matt.schembari
Change 3087827 on 2016/08/12 by Bart.Bressler
Updates to skeletal mesh memory saving on dedicated server
#rb lina.halper
#tests Cooked server data, played a game for a while in Solo vs. AI
Change 3087351 on 2016/08/12 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
#jira OR-27406
#rb RyanG
#tests Replays
Change 3087118 on 2016/08/12 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3086747
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3087117 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3086176 on 2016/08/11 by Marcus.Wassmer
Fix PS4 ShaderPipelines not matching pixel/vertex shader properly.
#rb Rolando.Caloca
#tests Broken PS4 content before/after
Change 3085992 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Unclog R@BOMERGE
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085987 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3085911 on 2016/08/11 by Laurent.Delayen
Added FBoneContainer::BoneIsChildOf for FCompactPoseBoneIndex
#rb none
#tests Orientation Warping
Change 3085614 on 2016/08/11 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3085547
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3085598 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3084507 on 2016/08/10 by Marcus.Wassmer
Duplicate 3070376 and 3078879 to fix corrupted decals on Vixen.
#rb none
#tests paragon ps4/vixen
#codereview Olaf.Piesche
Change 3084136 on 2016/08/10 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3083799
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3083814 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083424 on 2016/08/09 by Max.Chen
Sequence Recorder: Fix crash when actor class to record is null.
#tests Use sequence recorder to record a skeletal mesh actor
#rb none
Change 3083134 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
#online,store,ps4
- creating one offer entry per entitlement
#rb david.nikdel, ian.fox
#tests MTX purhcase on PS4
#lockdown: andrew.grant
#R@BOMERGE-SOURCE: CL 3083127 in //Orion/Release-30.1/... via CL 3083128 via CL 3083131
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3083069 on 2016/08/09 by Marcus.Wassmer
Vixen scalability changes
#rb Michael.Noland
#tests vixen/ps4
#codereview jordan.walker
Change 3083063 on 2016/08/09 by Marcus.Wassmer
Most games will probably run out of memory if setup to do auto-4k.
Make this a setting that's off by default.
#rb Michael.Noland
#codereview Luke.Thatcher, Lee.Clark
#tests vixen on 4k.
Change 3082778 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for Vixen GPU page faults and rendertarget errors (3066087)
#rb none
#tests Agora on vixen.
Change 3082772 on 2016/08/09 by Marcus.Wassmer
Duplicate fix for detail mode reregistration (3065543)
#rb none
#tests Toggled detail mode, observe proper items spawning
Change 3082765 on 2016/08/09 by Marcus.Wassmer
Don't crash when trying to use windowed vsync on vixen
#rb Michael.Noland
#test ran paragon on vixen
#codereview Luke.Thatcher,Lee.Clark
Change 3082764 on 2016/08/09 by Marcus.Wassmer
fix HLOD distance scale not working properly when components are re-registered.
#rb michael.noland
#codereview jurre.debarre
#tests setting multiple times, setting on boot via deviceprofile
Change 3082429 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: sam.zamani
Merging //Orion/Release-30.1 to Main (//Orion/Main)
Change: 3082419
#online,store,PS4
OR-25384 [PS4] "There is no content. It might not be for sale yet, or might no longer be for sale" at main menu and at post match screen
- added config option for toggling store on PS4
[OnlineSubsystemPS4]
bStoreEnabled=true
- can also override via title specific json values in <titleid>\title.json
allow_mtx=true
[CodeReviewed]: andrew.grant, phillip.buck, ian.fox
#lockdown: andrew.grant
#rb none
#tests ps4 run with titleid=CUSA3609_00 (which has mtx disabled for PS4 since that title has no store support)
#R@BOMERGE-SOURCE: CL 3082428 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3082194 on 2016/08/09 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3082105
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3082192 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080984 on 2016/08/08 by Lina.Halper
Issue with not being able to set static animation data via BP
- artists were using SetAnimation/PlayAnimation, but they are not safe to be used in construction script, so made sure the other serializable properties are exposed via BP
- also since they want it to work in level viewport, I have to tick/refresh whenever it's getting called.
#rb: Martin.Wilson
#tests: Sword Beauty map
Change 3080665 on 2016/08/08 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3080081
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3080543 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3080565 on 2016/08/08 by Laurent.Delayen
Fix for curve values during URO interpolation.
Fixes flashing of materials and Twinblast's ult weapon.
https://jira.ol.epicgames.net/browse/OR-27107https://jira.ol.epicgames.net/browse/OR-24358
#rb lina.halper, martin.wilson
#tests Twinblast's ult and Coil's primary.
Change 3079832 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: marcus.wassmer
Fix for PS4 crash reports not attaching the minidump when trying to force full crash dumps via commandline
#rb none
[CodeReviewed] Chris.Wood
#tests checked crashcontext on PC/PS4
#lockdown Andrew.Grant
#R@BOMERGE-SOURCE: CL 3078933 in //Orion/Release-30/... via CL 3078934 via CL 3078935 via CL 3079831
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3079045 on 2016/08/05 by Lina.Halper
Adding more log to figure out why ActivePlayers.Count becomes inconsistent.
#rb: Martin.Wilson
#tests: PIE with bots
Change 3078944 on 2016/08/05 by Rolando.Caloca
O - Update blacklisted driver
#jira OR-27051
#rb Marcus.Wassmer
#tests Run with AMD card
Change 3078735 on 2016/08/05 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3078670
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3078734 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3078122 on 2016/08/04 by Dmitry.Rekman
Linux: treat abort() / SIGABRT as crash.
- Rationale: certain code not under our control (most notably, stack smashing protector) may call abort(), which would previously terminate the engine without any chance to even enter the crash handler.
- Rewrote RequestExit() because it used abort() itself.
- Also removed -fstack-protector. The logic behind this is: stack protector calls abort() on detecting a smash (which is suspected to contribute to missing reports), but does it at an inappropriate place, that causes stack unwinding to crash later. As bad as it sounds, it may be better to allow stack to be corrupted and crash later - hopefully outside of libc code - to some other reason.
#rb Mark.Satterthwaite
#codereview Mark.Satterthwaite, Michael.Noland, Andrew.Grant
#review-3078104 @Mark.Satterthwaite, @Michael.Noland, @Andrew.Grant
#tests Ran Linux server, crashed using different methods.
Change 3077887 on 2016/08/04 by Dmitry.Rekman
Initialize StackCount to 0 (kills valgrind warning).
#rb David.Ratti
#codereview David.Ratti
#tests Ran Linux server.
Change 3077257 on 2016/08/04 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3077193
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3077256 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3077242 on 2016/08/04 by Dmitry.Rekman
Linux: stop heartbeat thread before handling the crash.
#rb Robert.Manuszewski
#codereview Robert.Manuszewski, Andrew.Grant
#tests Compiled and ran Linux server, crashed it.
Change 3076676 on 2016/08/03 by Dmitry.Rekman
Linux: print details about memory access (read or write).
- Also print all the 16 digits of the pointer.
- Read/write detection only implemented for x86_64.
#rb Andrew.Grant
#codereview Andrew.Grant
#tests Compiled (natively) and ran Linux server.
Change 3076675 on 2016/08/03 by Dmitry.Rekman
Print a bit more info about the array in assert.
#rb Andrew.Grant
#codereview Andrew.Grant
#test Compiled and ran Linux server.
Change 3076010 on 2016/08/03 by Laurent.Delayen
Moved OrionAnimNode_LegIK from Paragon to Engine.
#codereview lina.halper
#rb none
#tests Grim.exe + Iggy & Scorch
Change 3075512 on 2016/08/03 by Matt.Kuhlenschmidt
Reimplemented 3070766 for Orion:
Make sure richtooltips are not generated for hidden enum items so that there is not a mismatch between rich tooltips and enum items (causing a crash)
#rb none
#tests none
Change 3075446 on 2016/08/03 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3075422
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3075445 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3075394 on 2016/08/03 by HaarmPieter.Duiker
Adding a shadows max and highlights min parameters to allow the user to control when the 'shadows' controls fall off and when the 'highlights' controls ramp in.
#rb marcus.wassmer
#tests post process color correction
Change 3074314 on 2016/08/02 by Dmitry.Rekman
Linux: change optimization from -O2 to -O1 (temporarily?).
- The purpose is to make callstacks easier to follow and possibly catch stack smashing (if it happens) earlier.
- Also adds a line to UBT output during compilation to draw attention.
#rb Michael.Noland
#codereview Michael.Noland, Andrew.Grant, Bart.Bressler
#tests Compiled and ran Linux server.
Change 3073553 on 2016/08/02 by jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3073360
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3073481 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
#R@BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Characters/Heroes/BP_Hero.uasset - can't integrate exclusive file already opened
#CodeReview: jason.bestimt
Change 3073505 on 2016/08/02 by Daniel.Lamb
Added cook modification delegate stats to cooker stats.
#rb Wes.Hunt
#test cook paragon.
Change 3072440 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Adding #if !(UE_BUILD_SHIPPING || UE_BUILD_TEST) around the use of the debug only variable ForceFeedbackEffectHistoryEntries.
#rb none
#tests SHIPPING
Change 3072259 on 2016/08/01 by Aaron.Eady
PlayerController Force Feedback (Debug only);
Added more information to the things displayed on the screen for force feedback when we do ShowDebug ForceFeedback.
#rb Michael.Noland
#tests PIE
Change 3071908 on 2016/08/01 by John.Pollard
Fix null reference crash
#rb DavidR
#tests Live game + replays
Change 3071876 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Assertion failed: WriterState.Changed.Num() == 0 occurs when a Pitcher Husk hits the Player
#rb none
#tests FN + Paragon live game + replays
#codereview Andrew.Grant
Change 3071875 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Finalize replay version system
* No longer use changelist to filter replays (so we will only filter by engine/game version now, which need to be hand cranked to invalidate old versions)
* Submit actual changelist when uploading (rather than locking to previous versions). We can do this now since we don't filter by changelist anymore.
* Removed unnecessary 'bShowAllVersions' property from replay browser code, using cvar instead (orion.ShowAllReplayVersions)
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071874 on 2016/08/01 by John.Pollard
Merging using Dev-Networking_->_Dev-General_(Orion)
Fix gameplay tags to work better with backwards compatibility in replays
* We use the net field export group system in the package map to export tag names as a packed index
* This will allow us to see the names of tags that no longer exists on the remote side
#rb RyanG
#tests Live game + replays
#codereview Andrew.Grant
Change 3071776 on 2016/08/01 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30.2 @ CL 3071738
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3071775 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3071258 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Removed voice operation set since it was causing crashes when stopping voices. Still a good idea, but need to make sure the async OnBufferEnd and stopping an FSoundSource can work together.
- Added a proxy object that wraps the FAsyncTask used for async decoding. Calling IsDone() and EnsureCompletion() can't happen at the same time from different threads now.
#rb none
#tests ran paragon soaking for a long time with constant AI combat and observed no crashes or audio issues.
Change 3071099 on 2016/07/30 by Aaron.McLeran
OR-26580 CRASH: FXAudio2SoundSource::GetChannelVolumes - Silent Crash during gameplay
- Temporary revert of a portion of CL 3067560 which exacerbates an issue with the async decoding tasks and calling IsDone and EnsureComplete on different threads.
#rb none
#tests ran paragon with change and noticed no change in audio quality
Change 3070916 on 2016/07/29 by Andrew.Grant
Missed file!
#rb #tests na
Change 3070915 on 2016/07/29 by Andrew.Grant
Merging //UE4/Main @ 3070724 through //UE4/Orion-Staging
#rb none
#tests Engine QA, Orion QA smoke
Change 3070576 on 2016/07/29 by Uriel.Doyon
Fixed initialization of the defrag pool size. Now controlled by r.PS4DefragPoolSize.
#review-3070386 @marcus.wassmer
#jira OR-25941
#rb marcus.wassmer
#tests Run Game on PS4, and in editor
Change 3070086 on 2016/07/29 by Martin.Wilson
Fixed ensure triggering during sequencer playback due to double update.
#jira UE-33938
#rb Thomas.Sarkanen
#tests opened affected asset and verified problem no longer occured
Change 3070016 on 2016/07/29 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 30 @ CL 3069935
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3069976 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3069435 on 2016/07/28 by Ian.Fox
#Orion, #Mcp - Check if Price Engine is configured before attempting query
#rb Sam.Zamani
#tests none
#codereview Sam.Zamani
Change 3069381 on 2016/07/28 by Michael.Noland
Animation: Demoted a check() in anim sync group code to an ensure() to unblock others
#rb nick.penwarden
#tests Loaded Paragon cine asset that was crashing
#codereview lina.halper, martin.wilson
Change 3069203 on 2016/07/28 by Dmitry.Rekman
Headless client: do not draw windows.
- Disables a bunch of code, including reaching into font cache to estimate width.
- Should be probably disabled on a higher level, but cutting out the whole Slate application is infeasible (according to BradA/BenM, due to some logic requiring widgets).
#rb Nick.Atamas
#review-3068983 @Nick.Atamas, @Michael.Noland, @Brad.Angelcyk, @Ben.Salem
#codereview Nick.Atamas, Michael.Noland, Brad.Angelcyk, Ben.Salem
#tests Compiled and ran Orion Linux client.
Change 3069181 on 2016/07/28 by Lina.Halper
Fix struct redirector for Orion anim node moving to engine
#rb: Maciej.Mroz
#code review:Laurent.Delayen
#tests: editor loading the anim BP that caused the name conversion
Change 3069092 on 2016/07/28 by Aaron.McLeran
OR-26161 Client hitches indefinitely when using Stat soundcues / soundwaves
- Not all active sounds have sound classes, was causing a crash
#codereview marc.audy
#rb zabir.hoque
#tests Run game with stat soundcues and not crash
Change 3068969 on 2016/07/28 by David.Ratti
Move test for invalid gameplaycue instance up, since calling IsPendingKill() on garbage can cause crash too.
#rb none
#tests compile
Change 3068902 on 2016/07/28 by David.Ratti
Code for tracking down UGameplayCueManager::GetInstancedCueActor crash.
#rb none
#tests compile
Change 3068831 on 2016/07/28 by Aaron.McLeran
OR-26417 Reverb is too loud in-game in Dev-General
- Initializing prev reverb to 0s so that the first default reverb gets set when no audio volume is set.
#rb Jeff.Campeau
#tests run a map with no reverb audio volume and reverb is not super wet
Change 3068529 on 2016/07/28 by Jason.Bestimt
#R@BOMERGE-AUTHOR: david.nikdel
#OSS #PurchaseMcp: Use GameService->CreateOnlineHttpRequest instead of McpSubsystem->CreateRequest to query receipts (uses subsystem config)
#RB: none
#TESTS: none
#R@BOMERGE-SOURCE: CL 3068465 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3068399 on 2016/07/28 by Andrew.Rodham
Sequencer: Changed animation tracks to allow more animation types (such as anim montages)
- APIs now accept UAnimSequenceBases rather than UAnimSequences to afford more flexibility
#jira OR-25769
#tests Tested all combinations of animation with sequencer (montage+sequence on asset/BP driven animation components) and matinee. Tested running a game and playing back the announce trailer. Rendered out some movies to ensure that trails work correctly.
#rb Benn.Gallagher
Change 3068138 on 2016/07/28 by Marcus.Wassmer
Disable mallocleak testing by default
#rb none
#test none
Change 3068121 on 2016/07/28 by Marcus.Wassmer
Make sure we always do fast stack captures when USE_FAST_STACKTRACE is enabled.
Fixes game becoming unresponsive on Windows after 'mallocleak' dumps data. Any other tool that uses stacktraces could become 700 - 1000x slower after any stack symbolication also.
#rb Robert.Manuszewski
#tests stack tracing / symbolication with mallocleak on windows.
Change 3068119 on 2016/07/28 by Marcus.Wassmer
Fix MallocLeakProxy deadlock
#rb Robert.Manuszewski
#tests mallocleak start/stop/dump on windows
Change 3067752 on 2016/07/27 by Michael.Noland
Engine: Refactored FPS chart creation to make it modular so many performance data consumers can be active at once, allowing greater flexibility and decoupling game analytics from FPS chart exec commands
- IPerformanceDataConsumer is an interface for all consumers of per-frame performance tracking data, and instances can be registered/unregisted with the engine using AddPerformanceDataConsumer/RemovePerformanceDataConsumer
- The implementation of the 'standard' frame time and hitch histogram tracking is FPerformanceTrackingChart, while the per-frame logging .csv is split into a separate FFineGrainedPerformanceTracker class.
- The calculation of frame time breakdowns and hitch detection now occur as long as at least one IPerformanceDataConsumer is registered
- Internally the code has been cleaned up a bit to use FHistogram for data storage instead of custom binning code
Upgrade Notes:
- DumpFPSChartAnalytics has been removed, games that used it should switch to creating their own instance of FPerformanceTrackingChart and call DumpChartToAnalyticsParams on it directly
- In general games should have no reason to programmatically call GEngine->StartFPSChart anymore, instead creating their own instance (this prevents conflicts when using the engine console commands)
- HTML output for stopfpschart is now generated to a single file rather than two duplicate files (using both map name and capture time as part of the file name)
- Removed PauseFPSChart, IsFPSChartActive, and GetFPSChartBoundByFrameCounts to reflect that the GEngine instances aren't meant for external use (Start/Stop are left public for automated testing that wants to use them to do logging, but may also be moved private in the future)
Paragon:
- Updated to use a separate FPerformanceTrackingChart for gameplay versus in-game menus and removed the duplicated code and GameThreadHitchChart event
- Removed partial USE_SERVER_PERF_COUNTERS code in ChartCreation.cpp, splitting it out into a separate observer, which currently lives in Paragon but will be moved to shared code in a separate checkin. The code was only useful in the first place along with other Paragon-side code that was consuming it.
#rb dmitry.rekman
#codereview bob.tellez, peter.knepley, andrew.grant, john.mauney
#review-3067607 @Dmitry.Rekman, @Bob.Tellez
#tests Tested manual startfpschart/stopfpschart as well as Paragon match analytics via golden path solo vs AI
Change 3067654 on 2016/07/27 by Michael.Noland
FString - Fix divide overload path concatenation for empty paths since there are several places in the engine that expect using that doing { path / "" } will append a / onto path.
#rb steve.robb
#jira UE-31959
[duplicating CL# 3039827]
#tests Tried moving a folder in the editor
Change 3067644 on 2016/07/27 by Aaron.McLeran
OR-24537 Looping audio sometimes persists in Agora
Adding stopping sounds if audio component is destroyed while playing a looping sound
#rb jeff.campeau
#tests audio component stops looping sound if audio component is destroyed prematurely
Change 3067560 on 2016/07/27 by Aaron.McLeran
OR-26322 Client Hang in FXAudio2EffectsManager::SetReverbEffectParameters
- Only applying reverb parameters if they've changed from previous reverb params to avoid unnecessarily spamming the XAudio2 API call
- using xaudio2 operation sets to ensure that voice and effect params are executing in sequence
- only calling destroy voice after all voice and effect changes have been committed to avoid destroy voice interfering with those commands
- Don't call EnsureCompletion on pending async tasks on teardown
#rb Jeff.Campeau
#tests play paragon with change, notice no changes to audio behavior, no crashes. Created testmap with several reverb zones and demonstrated reverb effect transitions
Change 3067420 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge 29.2/30 @ CL 3067312
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3067400 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067316 on 2016/07/27 by jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3065602
#RB:none
#Tests:none
[CodeReviewed]: matt.schembari
#R@BOMERGE-SOURCE: CL 3067079 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3067025 on 2016/07/27 by Michael.Noland
Core: Corrected the initial value of FLightweightTimeGuard::FrameTimeThresholdMS to be in MS rather than seconds and did a few coding standards fixes
#rb none
#tests Compiled
Change 3067020 on 2016/07/27 by Michael.Noland
Core: Various improvements to FHistogram and split it out into separate files
- Added the ability to use a separate thresholding key than the actual measurement value being recorded (e.g., when accumulating frame time spent in a chart keyed on framerate)
- Added O(1) getters for total sample counts and sum of all measurements
- Removed encapsulation-breaking SetBinCountByIndex / SetBinSumByIndex
- Added support for specifying explicit histogram bucket thresholds
#rb dmitry.rekman
#tests Tested with another pending changelist that moves FPS charts to use FHistogram for the underlying storage
Change 3066681 on 2016/07/27 by Frank.Gigliotti
Camera anim field of view fix;
* The FOV is now reset on the PlayerCameraManager camera actor when it's initialized. This fixes cases of stale FOV values after playing camera anims that don't end with the FOV at it's base value.
* Base FOV can now be edited in the CameraAnim properties. This allows you to specify what the FOV keys are relative to. Previously it was always using a base FOV of 90 degrees.
#RB None
#CodeReview Jeff.Farris
#Tests Multiple camera animations in PIE
Change 3066508 on 2016/07/27 by Lina.Halper
Smartname guid will be discarded during cooking, and once it's cooked, it's trusted to have correct name.
#code review:Martin.Wilson, Benn.Gallagher
#rb: Martin.Wilson
#tests: cooked test map, run test map, PIE, saving content, loading standalone game
Change 3066246 on 2016/07/27 by Jason.Bestimt
#R@BOMERGE-AUTHOR: andrew.grant
Fix for non-unity error
#rb none
#tests compiled
#R@BOMERGE-SOURCE: CL 3066245 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3066167 on 2016/07/27 by Benn.Gallagher
Fixed clothing corruption seen on Twinblast after mesh updates. We were copying a u32 index buffer into a multisize container but CopyIndexBuffer doesn't change the data size when copying - only when rebuilding.
#rb Ori.Cohen
#tests Editor, PIE, Applying clothing to characters.
Change 3065868 on 2016/07/27 by Michael.Noland
Blueprints: Fixing non-editor build (missing WITH_EDITOR)
#rb none
#tests Compiled PS4
Change 3065749 on 2016/07/26 by Michael.Noland
Blueprints: Prevent a crash on load in RemoveNodeAndPromoteChildren when removing a corrupted SCS node if it has no parent link (the children are moved to the root node instead)
#codereview mike.beach, marc.audy
#tests Loaded and recovered a corrupted Blueprint on Cameron's machine
#rb Phillip.Kavan
Change 3065706 on 2016/07/26 by Josh.Markiewicz
#UE4 - changed default values for bLogoutOnSessionTimeout for reservation beacons
- fixed non shipping cmd line override to be correct
#rb none
#codereview andrew.grant, paul.moore
#tests none
Change 3065359 on 2016/07/26 by Rob.Cannaday
Limit external id querying to 100 ids per call. The backend currently enforces this and is returning an error when we exceed this limit.
Break up calls in batches of 100 ids.
#jira OR-20674
#rb ian.fox
#tests login to front end with PC, PS4. forced tests to simulate > 100 requests.
Change 3065197 on 2016/07/26 by Bart.Bressler
Change how PS4 sessions work:
- We now will only try to join somebody's PS4 session only if we accepted an invite from the PS4 system software. This means that an MCP party can have members in different PS4 sessions.
- Refactored a lot of the delegates in UOrionParty to lambdas to try to make it more readable
- Added comments, other misc. code cleanup.
#rb josh.markiewicz, sam.zamani, rob.cannaday
#tests created cross play parties with multiple pc + ps4 players
#jira OR-20332
Change 3065158 on 2016/07/26 by Lina.Halper
Fix the guid keep generated by adding to the database.
- This caused worse problem with non-deterministic cooking - This doesn't fix UE-33454 for 100%, but this was the main reason why this was so visible
#rb: Martin.Wilson
#jira: UE-33772, UE-33454
#tests: cooked AI_Test map, editor rename curves
Change 3064735 on 2016/07/26 by Dmitry.Rekman
Linux: added WebRTC libs.
- Compiled against glibc 2.12 / CentOS 6.x environment (see howto in a separate doc).
#rb none
#tests Tested OrionClient in Dev-General, and UE4Editor in Dev-Platform.
(Edigrating 3063715 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064727 on 2016/07/26 by Dmitry.Rekman
Fix crash on cooker exit (UE-33583).
- Global/static tickable objects could outlive the collection and trigger asserts when removing themselves from it.
#rb none
#tests Compiled and ran Linux server and Linux client.
(Edigrating 3058779 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064725 on 2016/07/26 by Dmitry.Rekman
Linux: use libc++ instead of libstdc++.
- Needed to solve problems with third-party C++ libraries (e.g. WebRTC).
- Bundled libc++ 3.8.1 (TPS cleared).
- Turned off ICU compilation (needs recompile against libc++).
- Some libraries (e.g. FBX sdk) still need libstdc++, so in practice it is going to be a mix.
#rb none
#tests Built and ran a number of Linux targets.
(Edigrating 3057152 from //UE4/Dev-Platform/... to //Orion/Dev-General/...)
Change 3064572 on 2016/07/26 by Jason.Bestimt
#R@BOMERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 29.2 @ CL 3064545
#RB:none
#Tests:none
#R@BOMERGE-SOURCE: CL 3064569 in //Orion/Main/...
#R@BOMERGE-BOT: ORION (Main -> Dev-General)
Change 3064523 on 2016/07/26 by Jon.Lietz
Fixing it so gameplay effects with execution none will no longer keep the BP in a dirty state. Only call EmptyArray() on CalculationModifiersArrayPropHandle if it has any elements.
#RB none
#tests BP compiles and stays not dirty
#codereview dave.ratti@epicgames.com
[CL 3111280 by Andrew Grant in Main branch]
#lockdown Nick.Penwarden
#rb
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3063901 on 2016/07/25 by Chad.Taylor
PSTracker initializing variable to null
Change 3089846 on 2016/08/15 by Jeff.Fisher
UEVR-77 UE4 : Motion Controller Components completely freak out when game is paused
-Attachments were spiraling off to nowhere because the late update continues to run, applying the difference between the controller position and the component's position to the primitive each frame, but the component was not ticking, so its position remained constant and the primitive was never updated by the component directly.
-Because we want the controller to work even when the game is paused the solution is to make it tick even when paused: PrimaryComponentTick.bTickEvenWhenPaused = true.
#review-3089837 @chad.taylor
#jira UEVR-77
Change 3093132 on 2016/08/18 by Sam.Zamani
Updating OnlineSubsystemOculus to latest revision
Change 3093629 on 2016/08/18 by Jeff.Fisher
Copying using Dev-VR_to_Release-4.13
3074289 UEVR-13 PSVR: TCR Requirement
Reprojection problem after Sony PlaystationVR Morpheus HMD reconnect fixed.
Change 3093655 on 2016/08/18 by Jeff.Fisher
Copying using Dev-VR_to_Release-4.13
3081616 UEVR-13 PSVR: TCR Requirements
-2dvr support "stereo on" and "stereo off" now switch ps4 from 2d to vr mode.
Change 3093684 on 2016/08/18 by Sam.Zamani
enable oculus OSS for QAGame
Change 3094165 on 2016/08/18 by Jeff.Fisher
UEVR-134 Morpheus HMD sceCommonDialogInitialize should not assert if already initialized
-A couple other systems can also try to initialize this, and its ok as long as it gets called at least once. So we can just ignore the already initialized error code.
#jira UEVR-134
Change 3094167 on 2016/08/18 by Jeff.Fisher
UEVR-97 Morpheus HMD tracking needs to wait until HMD is fully tracked.
-Morpheus CALIBRATING/NOT_TRACKED tracking state hmd orientation update disabled and delegates added to present instructions to the user. This behavior is controlled by morpheus ini setting bDisableHMDOrientationUntilHMDHasBeenTracked, but defaulted to true to avoid subtly bad user experiences.
#review-3094106 @chad.taylor
#jira UEVR-97
Change 3100356 on 2016/08/24 by Chad.Taylor
PSVR Frame Stutter Fix: PS4Tracker camera processing modified to occur only after vblank to prevent it's GPU 'work from colliding with our game's own GPU workload
Change 3104464 on 2016/08/29 by Jeff.Fisher
UEVR-171 sceKernelWaitEqueue timeout in MorpheusHMD.cpp
-One licensee found this to be hanging, and the timeout to fix it, another similar call to it has a timeout. Sony documentation says that these events can be lost, but that the game should except and exit... not sure what's up, but timing out here seems fine.
#review-3104452 @chad.taylor
#jira UEVR-171
Change 3104799 on 2016/08/29 by Jeff.Fisher
UEVR-178 Morpheus HMD Black crescents
-Switched reprojection frame time for 60/120 mode from 120hz to 60hz so we much better predict where the hmd will be pointing when the frame we are about to render is actually displayed, and are run off the edge of it less often and less severely. This makes the black crescent artifacts only just visible during very fast head turning. The kWrapModeMirror change, which will be submitted separately, makes the left and right crescents invisible to me.
-Renamed the functions for setting the prediction info in the PS4Tracker.
-Added render frame parameters to sony reprojection functions, these can help with debugging reprojection.
-Added commented out sce call to get the reprojection debug data. Not allowed to submit an executable that calls it, but its nice to at least know where one can put it. May improve this later.
-Wrapped PS4Tracker->Synchronize call in a check that the tracker handle is valid, because I managed to get it called when it wasn't (probably during hmd power off testing, but I don't remember now). It should be fine to not do it if the tracker is not functioning.
#review-3104780 chad.taylor
#jira UEVR-178
Change 3106922 on 2016/08/30 by Nick.Whiting
Integrating fix for negative indexed buffer in haptic effects
Change 3108309 on 2016/08/31 by Nick.Whiting
Updating positional tracking information for HMD when the device is not tracked. The Sony SDK has been updated to return positions that represent the IPD as soon as there is a valid orientation post-calibration (including, surprisingly, in the NOT_STARTED state). This allows us to start off with a valid stereo rendering offset.
Enabled PSVR by default when running on PS4, for ease of development.
#review jeff.fisher
Change 3108423 on 2016/08/31 by Jeff.Fisher
Morpheus Config Improvements.
-UEVR-138 Morpheus HMD reprojection wrap mode config setting
-Can now switch between wrap mode Mirror and ClampToBorder. Mirror is the default.
-Made bDisableHMDOrientationUntilHMDHasBeenTracked editable in UE4Editor project settings.
-Using generic project setting for bStartInVR, removed the morpheus specific one.
#jira UEVR-138
#review-3106999 @nick.whiting
[CL 3110878 by Nick Whiting in Main branch]
#lockdown nick.penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2897367 on 2016/03/07 by Chad.Taylor@Chad.Taylor_Z3299_Tango
PS4Tracker Submit call now assigning the appropriate memory type read mode
Change 2920696 on 2016/03/23 by Nick.Whiting@nick.whiting_T7326_DevVRStream
Fixed analytics event for VRPIE to have a description
#jira UE-28562
Change 2925395 on 2016/03/28 by Chad.Taylor@Chad.Taylor_Z3299_Tango
Aspect ratio and buffer clearing fixed up to properly handle non-standard viewport configurations.
#jira UE-28816
Change 2932703 on 2016/04/04 by Nick.Whiting@nick.whiting_T7326_DevVRStream
Merging CL 2922134, fix for culling because of stale view matrices
Change 2932761 on 2016/04/04 by Nick.Whiting@nick.whiting_T7326_DevVRStream
Oculus 1.3 Engine support, merged from 4.11 stream
Change 2932762 on 2016/04/04 by Nick.Whiting@nick.whiting_T7326_DevVRStream
Removing redundant libraries for Oculus LibOVRMobile
Change 2932765 on 2016/04/04 by Nick.Whiting@nick.whiting_T7326_DevVRStream
Merging updated license files for Oculus libraries
Change 2938342 on 2016/04/08 by Ryan.Vance@ryan.vance_devvr
Fixing bloom offset in stereo.
Change 2938427 on 2016/04/08 by Ryan.Vance@ryan.vance_devvr
Adding PSVR support for changing the screen percentage dynamically. Previously it could only be changed with ini settings and a relaunch.
Reworked mutex use in reprojection thread. Some things weren't locked that should have been and removed a redundant mutex.
Change 2938736 on 2016/04/08 by Ryan.Vance@ryan.vance_devvr
#jira UE-26722
Updating ISR related code for debug view to fix tesselation.
Change 2939709 on 2016/04/11 by Chad.Taylor@Chad.Taylor_Z3299_Tango
Explicit order prioritization for ISceneViewExtensions for proper sampling order
Change 2939717 on 2016/04/11 by Chad.Taylor@Chad.Taylor_Z3299_Tango
Initial stereo layer implementation sans editor wireframe visualization
Change 2939816 on 2016/04/11 by Chad.Taylor@Chad.Taylor_Z3299_Tango
Stereo layer compionent visualizer
[CL 2940449 by Nick Whiting in Main branch]
ryan durand
Ben Marsh
Ryan Vance
Nick Whiting
Andrew Grant