Commit Graph

252 Commits

Author SHA1 Message Date
ionut matasaru
f24c462eeb [Insights] Added more LLM_SCOPEs ("Trace/CpuProfiler" and "Trace/Stats").
#rb Johan.Berg
#preflight 62876a371e478b95c7fc6d08

[CL 20292637 by ionut matasaru in ue5-main branch]
2022-05-20 07:12:25 -04:00
ionut matasaru
7a9c217ab6 Improved scoped cpu timers for FEngineLoop (add cpu timers for FEngineLoop::Tick, HeartBeat, TickHotfixables and TickRenderingTickables). Also added a scoped cpu timer for FStats::AdvanceFrame.
#rb Johan.Berg
#preflight 62874a80c057ee6e23f18437

[CL 20292398 by ionut matasaru in ue5-main branch]
2022-05-20 06:11:55 -04:00
ionut matasaru
17bfdee3de [Insights] Fixed StatsTrace incorrectly tracing disabled stats (i.e. when the stat name is set to "None").
#rb Johan.Berg
#preflight 6285208f571eb4bfb6f161cc

[CL 20277511 by ionut matasaru in ue5-main branch]
2022-05-19 05:02:06 -04:00
Andriy Tylychko
4b8cf5b49d fixed a crash on local static stats task destruction that was caused by the allocator used for them was already destroyed
#preflight 625fff3de30cb43e8cb55778

[CL 19828478 by Andriy Tylychko in ue5-main branch]
2022-04-20 08:58:26 -04:00
Steve Robb
51802de52f UE_ prefix added to math macros, with switches for turning on deprecation and removal for the old macros.
Fixes for all the macro use in Core.

#rb robert.manuszewski
#jira UE-140139
#preflight 623c54628900c14eecdea9c6

[CL 19493359 by Steve Robb in ue5-main branch]
2022-03-24 07:49:46 -04:00
ionut matasaru
c971027564 Fixed TraceStats crashing when the stat name is a wide char FName.
#jira UE-145293
#rb Catalin.Dragoiu
#preflight 622f3641344901ad191c3a08

[CL 19372250 by ionut matasaru in ue5-main branch]
2022-03-14 09:55:16 -04:00
Sebastian Thomeczek
8691e4a479 Stats Trace: Add stat group tracking
#rb Ionut.Matasaru
#jira none
#preflight
#preflight 620683bab84973a2bb8cfb43

[CL 18952844 by Sebastian Thomeczek in ue5-main branch]
2022-02-11 10:57:43 -05:00
jason nadro
d6dd20c881 stat DumpFrame incorrectly reports as cycles instead of ms.
- This was a bug introduced in 16927028.
- Add missing `else if` statement.

#rb Dave.Jones2
#jira UE-142184
#preflight 62056c620c64e1822f435743

#ROBOMERGE-AUTHOR: jason.nadro
#ROBOMERGE-SOURCE: CL 18941651 in //UE5/Release-5.0/... via CL 18941862 via CL 18941996
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18942015 by jason nadro in ue5-main branch]
2022-02-10 15:27:35 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
andriy tylychko
6bf3101dcd deprecated FTicker and family and replaced by thread-safe FTSTicker
#jira UE-120090
#rb francis.hurteau


#ROBOMERGE-SOURCE: CL 17176325 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17176374 by andriy tylychko in ue5-release-engine-test branch]
2021-08-16 11:09:22 -04:00
martin ridgers
a0fd56f78d Convert Stats and Csv tracing to use array/string type trace event fields instead of attachments
#rb cm
#rnx

#ROBOMERGE-SOURCE: CL 17048347 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v850-17047176)

[CL 17048351 by martin ridgers in ue5-release-engine-test branch]
2021-08-04 08:03:55 -04:00
jason nadro
d2fe3d0c52 Fix build warning.
#rb Dave.Jones2

#ROBOMERGE-SOURCE: CL 16929525 via CL 16929532
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16929542 by jason nadro in ue5-release-engine-test branch]
2021-07-22 15:26:04 -04:00
jason nadro
bc82444ea1 Respect memory flag on stats so we can pretty print that stat as memory (in MBs).
- This makes the output of memreport much easier to read:

812.081MB  -  StaticMesh Total Memory - STAT_StaticMeshTotalMemory2 - STATGROUP_MemoryStaticMesh - STATCAT_Advanced

#rb Dave.Jones2

#ROBOMERGE-SOURCE: CL 16926919 via CL 16927028
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16927051 by jason nadro in ue5-release-engine-test branch]
2021-07-22 13:22:59 -04:00
andriy tylychko
e38e3d02a9 conditional compilation for "StatsThread as a pipe" with an ability to turn back to "StatsThread as a named thread"
#jira UE-117540

#ROBOMERGE-SOURCE: CL 16686290 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16686297 by andriy tylychko in ue5-release-engine-test branch]
2021-06-16 07:11:54 -04:00
Marc Audy
3cfedaade8 Fix PVS warning V502 when comparing against NAME_None in a trinary
[CL 16137741 by Marc Audy in ue5-main branch]
2021-04-28 01:58:36 -04:00
Jamie Dale
4afb7ce6bb Made EName an enum class to prevent implicit conversion to int
The following code would call the int overload rather than the name overload when passed an EName constant, which could easily lead to confusion and bugs:
    using FMyId = uint8;
    void DoThing(FName);
    void DoThing(FMyId);
    DoThing(NAME_Actor);

The change to use enum class requires that any code that actually deals with EName as an int (mostly internal name code and serialisation) be updated to explicitly cast, but prevents the implicit conversion that causes the issue above.

In order to preserve the NAME_X aliases that the old-style enum added to the global scope, new aliases have been added that point to the EName scoped versions. Unfortunately these can cause shadowing warnings if NAME_X is defined in the local scope, as the old-style enum used to allow that without shadowing, however there is no way to prevent this so we'll just need to fix any warnings that occur.

#rb Johan.Torp
#preflight 6087e06349a9840001414708

[CL 16126708 by Jamie Dale in ue5-main branch]
2021-04-27 10:11:18 -04:00
Luke Thatcher
c25f24b42b Fix compiler warning in StatsMallocProfilerProxy.cpp when building debug with Clang.
#rb trivial
#jira none

[CL 16056029 by Luke Thatcher in ue5-main branch]
2021-04-19 18:22:19 -04:00
Andriy Tylychko
d73a076897 added FTask alias for TTask<void>, for convenience as it's expected to be the majority of cases
[CL 16049773 by Andriy Tylychko in ue5-main branch]
2021-04-19 08:40:23 -04:00
Johan Torp
83e9856501 Reduce Stats allocations during early editor startup
#rb devin.doucette

[CL 15987404 by Johan Torp in ue5-main branch]
2021-04-13 05:45:27 -04:00
mark lintott
69f62bf934 #jira UE-111719
#rb andrew.ladenberger, ionut.matasaru
Replaced references to ue4stats with uestats.
Fixed frontend profiler to load uestats
#preflight 60630fd74862cc0001ef53c6

#ROBOMERGE-SOURCE: CL 15861539 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15861543 by mark lintott in ue5-main branch]
2021-03-30 09:48:17 -04:00
Andriy Tylychko
327a94d1a4 StatsThread replaced by a Pipe:
* the thread was removed and its surrounding was cleaned up a bit
* ENamedThreads::StatsThread (and relatives) deprecated
* support for single-threaded execution looks a bit messy because it still have to be based on the old TaskGraph API until we convert the game thread to the new API (which will be one of the very last things)
* despite the direct usage of ENamedThreads::StatsThread from an external code is highly unlikely, to preserve backward compatiblity internally TaskGraph redirects all remaining stats tasks to StatsPipe

#rb martin.ridgers

[CL 15794122 by Andriy Tylychko in ue5-main branch]
2021-03-24 04:47:07 -04:00
jeff newquist
34f6ef6d1c Stats system is still using 32-bit cycle counts, so don't use Cycles64() which may have a different resolution. Fix issue with hitch detection resulting from use of 64-bit count.
#jira UE-107359, UE-94786
#rb Yuriy.Odonnell
#rnx

#ROBOMERGE-SOURCE: CL 15643029 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v779-15635321)

[CL 15643057 by jeff newquist in ue5-main branch]
2021-03-08 13:39:18 -04:00
ionut matasaru
f1d532b209 [Insights] Fixed usage of UE::Trace namespace when (EXPERIMENTAL_)STATSTRACE_ENABLED is 1.
#rb none

[CL 14813185 by ionut matasaru in ue5-main branch]
2020-11-25 12:45:19 -04:00
Martin Ridgers
559f49880e Fixed StatsTrace compile errors.
#rb jb
#rnx

[CL 14733569 by Martin Ridgers in ue5-main branch]
2020-11-12 09:53:37 -04:00