Commit Graph

606 Commits

Author SHA1 Message Date
Devin Doucette
4b99be9d9e Avoid calling GLog->TearDown() from RequestExit as it may deadlock
#preflight 627ec8eebb2c29688c468c8f
#rb Tim.Smith
#rnx

[CL 20224709 by Devin Doucette in ue5-main branch]
2022-05-16 11:06:18 -04:00
Devin Doucette
c8db2d77fe Logging: Added a workaround to log callstacks for failed assertions
#preflight 626ac3c5b17dd9121b406186
#rb Josh.Adams

[CL 19966435 by Devin Doucette in ue5-main branch]
2022-04-28 14:52:11 -04:00
Devin Doucette
292008ea35 Logging: Replaced GLog->PanicFlush() with GLog->Panic()
Panic allows only one thread to become the panic thread. In panic mode, logs are only sent to panic-safe output devices. Each call to Panic flushes buffered logs to panic-safe output devices, and flushes panic-safe output devices.

#jira UE-147152
#preflight 62424814292f228e09d8a612
#rb Zousar.Shaker
#fyi Brandon.Schaefer

[CL 19545093 by Devin Doucette in ue5-main branch]
2022-03-29 13:31:48 -04:00
chris constantinescu
7c6ec4c494 Revert basedir path changes for Mac in 19498448
#jira UE-147176
#rnx
#preflight N/A

[CL 19543301 by chris constantinescu in ue5-main branch]
2022-03-29 11:50:06 -04:00
chris constantinescu
ae281656f2 Tests converted from 18848115 made to work multi-platform.
Not all were converted because they were designed for packaged applications whereas low level tests are designed to run as "native" non-packaged applications.
- reporting support for non-desktop platforms, for the moment Catch2 report type "console" is used that is sent to a .out file
- most number of tests possible running multi platform, slower tests excluded on incremental builds
- slow tests are moved to run on the monolithic build
- Catch2 report failure event listener such that Horde detects them as build errors. Must add new Horde matcher for Catch2 failures

#rb Mark.Lintott
#preflight 623c8de389625f0612dabd64

[CL 19498448 by chris constantinescu in ue5-main branch]
2022-03-24 13:28:25 -04:00
Devin Doucette
c8d64e3c97 Logging: Added and migrated to GLog->PanicFlush() for crash handling
#preflight 623a433a10251d53d5796835
#rb Zousar.Shaker

[CL 19478551 by Devin Doucette in ue5-main branch]
2022-03-23 09:39:18 -04:00
jack porter
0340e664c9 Fix for iPhone device names with apostrophes appearing as ???? on Mac
#jira UE-112753
#rb Will.Damon
#preflight None

#ROBOMERGE-AUTHOR: jack.porter
#ROBOMERGE-SOURCE: CL 19153534 in //UE5/Release-5.0/... via CL 19159210
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19161398 by jack porter in ue5-main branch]
2022-02-25 19:44:03 -05:00
michael sartain
a5e79b5414 Fix Mac compilation error with _NSGetArgc & _NSGetArgv
#jira none
[FYI] Will.Damon
#preflight trivial

#ROBOMERGE-AUTHOR: michael.sartain
#ROBOMERGE-SOURCE: CL 18817804 in //UE5/Release-5.0/... via CL 18817810 via CL 18822866
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824700 by michael sartain in ue5-main branch]
2022-02-02 07:58:33 -05:00
michael sartain
6f95a3686b Use _NSGetArgc / _NSGetArgv in FMacPlatformMemory::BaseAllocator
These functions don't allocate memory like "NSArray *Args = [[NSProcessInfo processInfo] arguments];" does.

This fixes initialization crash in UnrealLightmass:

  * Embree has a global ctor embree::registerRegressionTest which adds to a std::vector which does an operator new.
  * That called FMemory::Malloc and FMacPlatformMemory::BaseAllocator for the first time.
  * BaseAllocator does an allocation here:
     - NSArray *Args = [[NSProcessInfo processInfo] arguments];
  * And now we're in a spot where CFAllocatorAllocate calls malloc_zone_malloc to alloc some memory where:
     - __CFAllocatorCustomMalloc --> CFAllocatorAllocate --> malloc_zone_malloc --> __CFAllocatorCustomMalloc --> rinse, lather, repeat...

And we're in recursive death.

[REVIEW] [at]Will.Damon
[FYI] Juan.Canada
#jira UE-126266
#preflight trivial

#ROBOMERGE-AUTHOR: michael.sartain
#ROBOMERGE-SOURCE: CL 18813604 in //UE5/Release-5.0/... via CL 18813614 via CL 18822764
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824297 by michael sartain in ue5-main branch]
2022-02-02 07:35:43 -05:00
jonathan adamczewski
2c4f852baa UnrealBuildTool: Remove references to UE4, changes affecting Mac platforms.
#jira UE-111420
#rb will.damon
#rb dave.hunter
#preflight none

#ROBOMERGE-AUTHOR: jonathan.adamczewski
#ROBOMERGE-SOURCE: CL 18566526 in //UE5/Release-5.0/... via CL 18566532
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18566536 by jonathan adamczewski in ue5-release-engine-test branch]
2022-01-10 18:03:06 -05:00
jack porter
e7b6f0102c Add flag to FPlatformProcess::CreatePipe to indicate the pipe will be used for stdin redirection rather than stdout redirection.
Windows needs to set permissions accordingly.
#rb Brandon.Schaefer
[FYI] Josh.Adams
#preflight 61d79ed84c252480ca31e640

#ROBOMERGE-AUTHOR: jack.porter
#ROBOMERGE-SOURCE: CL 18539045 in //UE5/Release-5.0/... via CL 18539064
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18539081 by jack porter in ue5-release-engine-test branch]
2022-01-06 21:19:58 -05:00
ionut matasaru
aa98be8f78 Fixed usage of TCHAR_TO_UTF8 when running CrashReportClient on Mac.
#rb Johan.Berg, Brandon.Schaefer
#preflight 61b738edfc570891337cedb3

#ROBOMERGE-AUTHOR: ionut.matasaru
#ROBOMERGE-SOURCE: CL 18453436 in //UE5/Release-5.0/... via CL 18453437
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18453442 by ionut matasaru in ue5-release-engine-test branch]
2021-12-14 06:50:16 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
69fe095547 Merge from Release-Engine-Staging @ 17636544 to Release-Engine-Test
This represents UE4/Main @17638339 and Dev-PerfTest @17636504

[CL 17638842 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-27 19:54:25 -04:00
richard wallis
3cec9abbfc Update Xcode project XCBuildConfiguration to handle unique build environments. Also implement platform process GetModulesDirectory() on macOS which allows re-launching of the correct app to also work.
#jira UE-80706
[at]will.damon,  [at]ben.marsh,  [at]dave.hunter
#rb will.damon,  ben.marsh

#ROBOMERGE-SOURCE: CL 17332770 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17332818 by richard wallis in ue5-release-engine-test branch]
2021-08-27 06:31:40 -04:00
geordiemhall
1c5bfd52de Implement OutStdErr in FUnixPlatformProcess::ExecProcess
Add stderr parameter to CreateProc
Add exec-process test to TestPAL

PR #6919: Add a new FPlatformProcess::CreateProc() overload to allow separating stderr and stdout (Contributed by geordiemhall)

#rb Brandon.Schaefer, James.Singer, Robert.Seiver, Will.Damon
#jira UE-91758, UE-92964

#ROBOMERGE-SOURCE: CL 17290306 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17290325 by geordiemhall in ue5-release-engine-test branch]
2021-08-24 14:16:10 -04:00
richard wallis
ed0e0f99b8 Remove rd_route library from Unreal Engine. Tested remote [http] URL for video playback in the engine and shutdown to confirm original reason for adding rd_route is now fixed.
#jira UE-121889
[at]will.damon
#rb will.damon,  dave.hunter

#ROBOMERGE-SOURCE: CL 17282698 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17282704 by richard wallis in ue5-release-engine-test branch]
2021-08-24 04:37:16 -04:00
johan torp
d6867ae8da Mark all FPlatformProcess::SleepInfinite implementations as [[noreturn]]
#rb steve.robb

#ROBOMERGE-SOURCE: CL 17211654 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17211664 by johan torp in ue5-release-engine-test branch]
2021-08-18 02:46:55 -04:00
aurel cordonnier
dc4bf61540 Merge from Release-Engine-Staging @ 17030559 to Release-Engine-Test
This represents UE4/Main @ 17030256 and Dev-PerfTest @ 17030553

[CL 17031509 by aurel cordonnier in ue5-release-engine-test branch]
2021-08-03 11:56:47 -04:00
danny couture
80a0593017 Exclude mimalloc.c from static analysis
Fix typo where double slash were used

#rnx
#rb trivial
#preflight 60d1fe1fbe81e80001837c38

#ROBOMERGE-SOURCE: CL 16744965 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16744987 by danny couture in ue5-release-engine-test branch]
2021-06-22 12:49:10 -04:00
aurel cordonnier
02c0f425e8 Copy up from Release-Engine-Staging @ 16738359
This represents UE4/Main @ 16738161 and Dev-PerfTest @ 16737719

[CL 16738582 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-22 00:27:54 -04:00
danny couture
f358a5d8a4 Include mimalloc compilation as part of the core module instead of relying on prebuilt binaries
- This will make maintenance for multiple platforms a lot easier (i.e. just preflight)
  - Will be easy to get callstack and debug since it will be compiled on the machine it is debugged on
  - Easier to try out modifications on mimalloc itself
  - Fix mimalloc compilation under Clang 10
  - Fix mimalloc inconsistent usage of MI_ENCODE_FREELIST define
  - Fix mimalloc inconsistent usage of _WIN32 define
  - Implement MacOS and Unix -mimalloc command-line switch

- Some MacOS changes were contributed by Will.Damon

#rb Brandon.Schaefer, Will.Damon
#preflight 60b4ea613c6c4e000158233e
#rnx

[CL 16512512 by danny couture in ue5-main branch]
2021-06-01 05:35:42 -04:00
Steve Robb
0c3302d7cf Some explicit casts to UTF8CHAR, for upcoming changes to that type.
#rb none
#jira none

[CL 16487296 by Steve Robb in ue5-main branch]
2021-05-27 12:45:14 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00
dave hunter
b2c7ef5a31 Remove UE4 references
This removes a variety of low-risk UE4 references.

#jira UE-112113
#rb will.damon

[CL 16023965 by dave hunter in ue5-main branch]
2021-04-15 14:09:49 -04:00