Commit Graph

49 Commits

Author SHA1 Message Date
seth weedin
a3a299e5eb Add data to spat params to allow using the AttenuationDistance (which may differ from distance to listener)
- Work done specifically for SourceEffectSimpleDelay to use it for "DelaySpeedBasedOnDistance" calculations

Impact: Prevents pitch warble when moving the camera around quickly for projects that use an attenuation override

#rb Aaron.McLeran, Ryan.Mangin

#ROBOMERGE-AUTHOR: seth.weedin
#ROBOMERGE-SOURCE: CL 20130485 via CL 20130494 via CL 20130515 via CL 20130536
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20132808 by seth weedin in ue5-main branch]
2022-05-10 21:06:28 -04:00
miles flanagan
8c332293cc adding IWaveformTransformation interface to AudioExtentions, and adding WaveformTransformations module to WaveformEditor.
#rb phil.popp, igor.dallavanzi
#jira UE-150314, 150315
#preflight 62683b59430b9997ebe7f00d

[CL 19926462 by miles flanagan in ue5-main branch]
2022-04-26 15:15:19 -04:00
rob gay
9ed959dac8 Downgrade seek ensure to log
- Add more logging around failures in ADPCM decode
- Remove superfluous logs
#rb jimmy.smith
#rnx
#jira UE-145250
#preflight 6230cac1cf609c54b1e5ae8e
#p4v-cherrypick 19390151

[CL 19394411 by rob gay in ue5-main branch]
2022-03-15 16:40:51 -04:00
rob gay
1f287a42ac Parameter Update Perf Regression Fix-ups
- Use cached transmissable inputs when initializing/sanitizing parameters
- Update internal API to promote batching & keeping AudioParameters sorted/using faster merge logic where possible
- Swap CitySample vehicle controller to use batched parameter update call
- Clarify When RuntimeData is cached for safety (in InitResources or InitParameters, whichever comes first)
- Alleviate extreme confusion around AudioParameter setters requiring type by adding static conversion functions
#rb helen.yang
#rnx
#jira UE-145211
#preflight 6229424e6e026fc824b24861

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19328764 in //UE5/Release-5.0/... via CL 19329587
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19348372 by rob gay in ue5-main branch]
2022-03-10 22:07:08 -05:00
rob gay
9b977d30c6 - Fix upcast copy causing parameters to not be cached properly on proxy by removing unnecessary virtual function
- Fix return value improperly assigning value in MixModulatorNode, causing it always to be 0 or 1 based on if the modulator was registered (as return is if the value was found and assigned, and its a boolean cast when the modulator is found)
- Remove unused parameter proxy ModHandle member
- Don't re-register if parameter already registered
- Remove duplicate validation call
#rb helen.yang
#rnx
#jira UE-144721
#preflight 6221645ca00412627d1bfde2

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19259386 in //UE5/Release-5.0/... via CL 19260159
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263839 by rob gay in ue5-main branch]
2022-03-04 04:11:49 -05:00
rob gay
41a2a172dc Fix missing ability to order graph members
- Remove base template for node customizations now that it isn't required to be a template to enable intra-engine versioning (allows moving implementation of category customization to .cpp)
- Move redundant "Literal" property to parent UMetasoundEditorGraphMember
#rb helen.yang
#jira UE-121749
#rnx
#preflight 621d2e869a5676d19a3d50e9

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19181623 in //UE5/Release-5.0/... via CL 19183646
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19206681 by rob gay in ue5-main branch]
2022-03-01 16:31:55 -05:00
jimmy smith
929ebcd8d7 Fix spamming of Triggers by adding new Track type
#jira UE-138615
#rb rob.gay Ludovic.Chabant
#preflight 6216753437178b0175b2317f


#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 19095469 via CL 19096552 via CL 19097708 via CL 19098551 via CL 19105431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147043 by jimmy smith in ue5-main branch]
2022-02-25 09:59:46 -05:00
aaron mcleran
e79529af7a Fixing one-shot interface issues
#rb Rob.Gay
#jira UE-139680
#preflight 620d3d228a1ea1600981931f


#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 19093707 via CL 19095893 via CL 19096208 via CL 19097039 via CL 19105391
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19146717 by aaron mcleran in ue5-main branch]
2022-02-25 09:45:49 -05:00
rob gay
522b5ad474 Split Modulation Registration into actual registration/Modulation proxy generation vs Settings construction to support AudioDevice-less DATAProxy generation
- Made modulator settings objects stateless & removed AudioDevice dependency in mod settings constructors.
- Required moving ModulationParameters to thread-safe registered singleton registry in AudioExtensions and out of plugin
- Rename IAudioModulation/FAudioModulation to IAudioModulationManager/FAudioModulationManager for clarity
#rb phil.popp
#jira UE-138516
#rnx
#preflight 61ddc6b9f33c075417271dc2

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18574824 in //UE5/Release-5.0/... via CL 18574848
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18574874 by rob gay in ue5-release-engine-test branch]
2022-01-11 13:52:09 -05:00
rob gay
33c92448da Migrate behavior for SetTriggerParameter back to just executing on command (and not caching in InstanceParameters). Rename to "ExecuteTriggerParameter" & add tooltip explaining the difference and when to use "SetBooleanParameter" for triggers instead
#rb anna.lantz
#jira UE-137582
#rnx
#preflight 61d37e416c000c869bff2489

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18504624 in //UE5/Release-5.0/... via CL 18504636
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18504639 by rob gay in ue5-release-engine-test branch]
2022-01-03 18:32:36 -05:00
aaron mcleran
fccc58820c Adding SourceSettings support for SourceDataOverride audio extension.
#rb Maxwell.Hayes
#jira UE-132713
#preflight 61b7e82f1a4451f7ba2237f3

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18450873 in //UE5/Release-5.0/... via CL 18450882
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18450885 by aaron mcleran in ue5-release-engine-test branch]
2021-12-13 20:05:51 -05:00
rob gay
3bdc09e2a5 Backout out backed out changelist 18369256 (includes AudioComponent redirect fix)
-----------------------------------------------------------------
MetaSounds Interfaces Checkpoint 2:
- Version up source archetypes to become two interfaces: channel interfaces (mono/stereo) & base source namespace
- Clean-up Interface panel to support namespacing better
- Fix bugs with assuming interfaces are always and the only base namespace members
- Allow namespacing for any arbitrary interface member
- Add lock icon to clarify what interface members cannot be modified individually (i.e. cannot add, remove, or rename them as they are interface members)
- Organize members alphabetically
#jira UE-135000
#rnx
#rb phil.popp
#preflight 61a7d1079c77d610079303ec
#p4v-cherrypick 18344347

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18413245 via CL 18413381 via CL 18413401 via CL 18434953 via CL 18437303
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18437360 by rob gay in ue5-release-engine-test branch]
2021-12-10 20:37:31 -05:00
aurel cordonnier
3e68a3edef [Backout] - CL18345215
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
MetaSounds Interfaces Checkpoint 2:
- Version up source archetypes to become two interfaces: channel interfaces (mono/stereo) & base source namespace
- Clean-up Interface panel to support namespacing better
- Fix bugs with assuming interfaces are always and the only base namespace members
- Allow namespacing for any arbitrary interface member
- Add lock icon to clarify what interface members cannot be modified individually (i.e. cannot add, remove, or rename them as they are interface members)
- Organize members alphabetically
#jira UE-135000
#rnx
#rb phil.popp
#preflight 61a7d1079c77d610079303ec
#p4v-cherrypick 18344347

#ROBOMERGE-AUTHOR: aurel.cordonnier
#ROBOMERGE-SOURCE: CL 18369256 via CL 18369273 via CL 18369290 via CL 18434224 via CL 18435611
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18436532 by aurel cordonnier in ue5-release-engine-test branch]
2021-12-10 19:13:22 -05:00
rob gay
d2e6910760 MetaSounds Interfaces Checkpoint 2:
- Version up source archetypes to become two interfaces: channel interfaces (mono/stereo) & base source namespace
- Clean-up Interface panel to support namespacing better
- Fix bugs with assuming interfaces are always and the only base namespace members
- Allow namespacing for any arbitrary interface member
- Add lock icon to clarify what interface members cannot be modified individually (i.e. cannot add, remove, or rename them as they are interface members)
- Organize members alphabetically
#jira UE-135000
#rnx
#rb phil.popp
#preflight 61a7d1079c77d610079303ec

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18344347 in //UE5/Release-5.0/... via CL 18344412
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18344446 by rob gay in ue5-release-engine-test branch]
2021-12-01 15:59:03 -05:00
rob gay
9f190c654d Guard against potential race condition that can cause crash in debug builds on start-up when registering MetaSound Interfaces. General clean-up therein
#rb unblocking
#jira none
[FYI] phil.popp
#rnx

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18265488 in //UE5/Release-5.0/... via CL 18265509
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18265518 by rob gay in ue5-release-engine-test branch]
2021-11-22 19:46:23 -05:00
rob gay
ff8b5954ac MetaSounds Interface Checkpoint
- Archetype to Interface rename & support for multiple interface versions stored on MetaSoundBase
- Added ability to register interfaces
- Added spatialization/attenuation interfaces
- Added UX to add/remove Interfaces
- Fix ensure when deleting UMetaSound asset
#rb phil.popp
#jira UE-135000
#jira UE-120656
#rnx
#preflight 619bd9e33a7219926732337c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18262648 in //UE5/Release-5.0/... via CL 18262703
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18262725 by rob gay in ue5-release-engine-test branch]
2021-11-22 15:55:50 -05:00
jimmy smith
aa8c65bb29 Support for Metasounds in Sequencer via transmission interface.
#rb rob.gay max.chen
#preflight 6196e5d68703d6d083d597fd

#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 18247091 in //UE5/Release-5.0/... via CL 18247116
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18247123 by jimmy smith in ue5-release-engine-test branch]
2021-11-18 19:26:47 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
rob gay
446f417744 Move (invalid) IsValid checks to IsNone FName checks & make display names for parameter types consistent for BP readibility
#rb trivial
#jira none

#ROBOMERGE-SOURCE: CL 17393501 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17393642 by rob gay in ue5-release-engine-test branch]
2021-09-01 18:27:05 -04:00
rob gay
408e1d89f7 Missing header
#rb trivial
#jira none

#ROBOMERGE-SOURCE: CL 17356327 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17356345 by rob gay in ue5-release-engine-test branch]
2021-08-30 14:56:48 -04:00
rob gay
1328563c0e - Add ability to send MetaSound object parameter types that are not SoundWaves
- Cache Audio Parameters on AudioComponent properly so they can be modified prior to playback.
- Migrate AudioComponentParameterization to SoundGeneratorParameterInterface
- AudioComponent now inherits from SoundGeneratorParameterInterface
- Unify code path with default transmitter implemented in SoundBase for legacy SoundCue parameter system

Other Minor updates:
- Rename to "Audio Instance" to "Audio Parameter" for clarity

#rb phil.popp
#jira UE-123951
#jira UE-123979
#preflight 612d0053423a8f00012ba195

#ROBOMERGE-SOURCE: CL 17355572 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17355596 by rob gay in ue5-release-engine-test branch]
2021-08-30 14:08:45 -04:00
Rob Gay
7a7793e767 Deprecate more AlignedFloatBuffer callsites and use FAlignedFloatBuffer
#rb trivial
#rnx
#preflight 60918ea390631e0001d41516

[CL 16198391 by Rob Gay in ue5-main branch]
2021-05-04 16:05:46 -04:00
rob gay
a5adaf2847 - Fix triggered inputs firing on initialization in subsequent SoundGenerator instances
- Caused by leak in Transmission System's Global DataChannels, wherein AudioComponents were not removing instance data, which caused new sounds played from that Component taking on last value set from prior instance.
    - Remove custom input preview Sender logic in MetasoundEditor to avoid managing multiple senders (can just use the one housed on the preview AudioComponent).
#lockdown nick.whiting
#jira UE-111897
#rb phil.popp
#preflight 606bea71d5cb3c000197c7ac

#ROBOMERGE-SOURCE: CL 15927511 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15927516 by rob gay in ue5-main branch]
2021-04-06 01:41:29 -04:00