#rnx
#rb none
#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870549 by ryan durand in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
Change 3196499 on 2016/11/14 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.3 @ CL 3196473
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3196498 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3195674 on 2016/11/11 by Laurent.Delayen
Fix for twinblast ult mesh not disappearing at lower lods. (curves not getting properly update with URO)
Fixes https://jira.it.epicgames.net/browse/OR-31509
#rb lina.halper
#tests twinblast ult multiPIE
Change 3195245 on 2016/11/11 by Dan.Hertzka
Card crafting progress
- Device responds to UI actions appropriately and infinitely
- Backing out of device screen goes to card details first (i.e. doesn't take you all the way out of the screen)
- CraftingDevice and CraftingDeviceNode now have a few natively-controlled timelines for reversible states
- Non-reversible timelines all now play from start (so they work more than once)
Engine-side:
- Added an overload to UTimelineComponent::SetOnTimelineFinishedFunc() that takes a native (non-dynamic) delegate
- Added a way to set the owning player of a UUserWidget via a local PlayerController (since ULocalPlayer isn't a BP type) - used to establish the owner of a WidgetComponent's widget
#rb none
#tests PIE crafting
Change 3194616 on 2016/11/11 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.3 @ CL 3194604
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3194615 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3193875 on 2016/11/10 by Andrew.Grant
Removed GameThreadWaitForTask fatal timeout if running in editor (assumption is that some operations can cause significant blocks, and that's ok..
#jira UE-38496
#tests compiled
#rb none
#c0dereview Marcus.Wassmer
Change 3193368 on 2016/11/10 by Mieszko.Zielinski
Fixed a bug in UCharacterMovementComponent::OnMovementModeChanged making UPathFollowingComponent::OnStartedFalling being sent too late #UE4
#rb Lukasz.Furman
#test golden path
Change 3193280 on 2016/11/10 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3193232
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3193279 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3192376 on 2016/11/09 by Laurent.Delayen
RootMotion Sources: removed second check, as that was a perfectly valid case. Fixes https://jira.it.epicgames.net/browse/OR-31490
#rb none
#tests riftmage blackhold multiPIE
Change 3192243 on 2016/11/09 by Laurent.Delayen
UAbilityTask_ApplyRootMotionMoveToActorForce replicates TimeMappingCurve to potentially fix https://jira.it.epicgames.net/browse/OR-31266
#rb none
#tests Jump pads on Sovereign2 multiPIE
Change 3191985 on 2016/11/09 by Laurent.Delayen
Additional debug info for https://jira.it.epicgames.net/browse/OR-31300
#rb none
#tests compiles
Change 3191565 on 2016/11/09 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3191371
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3191564 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3190702 on 2016/11/08 by David.Ratti
Fix PIE autologgin mcp problem
#rb JoshM
#tests PIE autologgin
Change 3190591 on 2016/11/08 by Mieszko.Zielinski
Added a way to RecastNavMesh to retrieve navigation links in a given tile #UE4
#rb Lukasz.Furman
#test golden path
Change 3190363 on 2016/11/08 by Frank.Gigliotti
Root motion velocity clamping and bug fixes;
* Added option to clamp velocity when ending MoveToActorForce, MoveToForce, and RadialForce root motions.
* Disabled partial ticking on the FRootMotionSource_ConstantForce when applying the finishing velocity or clamping velocity on root motion ability tasks. This ensures the desired velocity is set correctly.
* Added AbilityTask_ApplyRootMotion_Base as a base class for all root motion ability tasks.
#RB David.Ratti, Zak.Middleton
#c0dereview Zak.Middleton
#Tests PIE - Multiple heroes with root motion abilities
Change 3190344 on 2016/11/08 by Laurent.Delayen
RootMotionSources: Tracking down https://jira.it.epicgames.net/browse/OR-31266
Testing for 'Matches' rule in more places, to track down where it breaks. Added more info. Switched check to ensure, so it doesn't prevent playtests.
Minor tweaks:
- Test for ID before TimeStamp
- Changed auto to proper type.
- Trim RootMotionIDMappings of outdated mappings since we can iterate over that array quite a bit.
#rb none
#tests multiPIE
Change 3190217 on 2016/11/08 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3190009
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3190216 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3188560 on 2016/11/07 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3187796
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3188499 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3188012 on 2016/11/05 by Andrew.Grant
Merging using ROBO://Orion/Main->//Orion/Dev-General
#rb #tests na
Change 3187818 on 2016/11/04 by Michael.Noland
Editor: Refactored the game instance PIE creation hooks, allowing them to pass an error message back that will be displayed to the user explaining why PIE was aborted/failed to start
- Fixed a potential crash trying to tear down a null world when UGameInstance::StartPlayInEditorGameInstance fails
Upgrade notes:
- UGameInstance::InitializePIE overrides should now override InitializeForPlayInEditor instead
- UGameInstance::StartPIEGameInstance overrides should now override StartPlayInEditorGameInstance instead
- These methods return a FGameInstancePIEResult which can be created via FGameInstancePIEResult::Success() or FGameInstancePIEResult::Failure(), and take a parameter struct to make it easier to send additional information in the future without breaking the signature again
#rb matt.kuhlenscmidt
#tests Tested various PIE configurations in Paragon
Change 3187756 on 2016/11/04 by Michael.Noland
Editor: Added support for games to respond to Play in Editor setting changes (by properly calling PostEditChange when the PIE/SIE menu options are picked/toggled)
#tests Tested in Paragon by binding to FCoreUObjectDelegates::OnObjectPropertyChanged
#rb ben.ziegler
Change 3187258 on 2016/11/04 by Dan.Hertzka
- UTextBlock::SetText is now virtual
- OrionTextBlock has a property ("All Caps") that, if true, will always convert all text it's given to ALL CAPS
#c0dereview Sean.Smith, Philip.Buuck, Marcel.Swanepoel, Bryan.Rathman
#rb none
#tests PIE
Change 3187157 on 2016/11/04 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Case fix for staged files
#rb Ben.Marsh
#tests preflighted
#R0B0MERGE-SOURCE: CL 3187153 in //Orion/Release-34/... via CL 3187154 via CL 3187155 via CL 3187156
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3186870 on 2016/11/04 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3186846
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3186855 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3186243 on 2016/11/03 by Michael.Noland
Engine: Fixed reporting of ScreenPct when the cvar is set directly rather than via game user settings
- Also fixed a place that was using ScreenPct as an integer instead of a float in the OSVR plugin
#jira OR-23184
#tests Tested by setting r.screenpercentage directly to a different value and inspecting the chart results
#rb ben.ziegler
Change 3185134 on 2016/11/03 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3185065
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3185131 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3183689 on 2016/11/02 by Aaron.McLeran
OR-31091 Implementing 3175639 in Dev-General
#rb zak.middleton
#tests unplug headphones and observe no log spam or other issues
Change 3183292 on 2016/11/02 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3182926
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3183084 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3182323 on 2016/11/01 by Dan.Hertzka
Fix crash in sequencer when opening a widget BP with the sequencer tab closed (failed to null check)
#c0dereview Nick.Darnell
#rb Stephan.Jiang
#tests none
Change 3182295 on 2016/11/01 by Daniel.Lamb
Fixed up routing BeginDestroy.
#rb Andrew.Grant
#jira OR-31043
#test Paragon win64 -game
Change 3181975 on 2016/11/01 by Daniel.Lamb
Make sure to remove safe zone delegate when canvas is destroyed.
Moved registration of safe zone delegate to constructor.
#rb Michael.Noland
#jira OR-31043
#test Paragon win64 -game
Change 3181895 on 2016/11/01 by Daniel.Lamb
Make sure to remove safe zone delegate when canvas is destroyed.
Moved registration of safe zone delegate to constructor.
#rb Michael.Noland
#jira OR-31043
#test Paragon win64 -game
Change 3181892 on 2016/11/01 by Michael.Trepka
Copy of CL 3162466
By default, do not compile Mac OpenGL and Metal SM4 shaders while cooking
#rb Mark.Satterthwaite
#jira UE-37088
#tests Cooked MacNoEditor data on Windows
Change 3181624 on 2016/11/01 by David.Ratti
Pass attribute value by reference through SetNumericValue_Internal so that the final/clamped value is what is broadcasted to attribute change delegates
#rb none
#tests golden path w/ extra logging to verify final value is what is broadcasted
#c0dereview Billy.Bramer, Fred.Kimberley
Change 3181574 on 2016/11/01 by Jason.Bestimt
#ORION_DG - Fixing up R0B0MERGE issue
#RB:none
#Tests:none
Change 3180859 on 2016/10/31 by Brian.Karis
Removed SSAO from hair
Change 3180320 on 2016/10/31 by Daniel.Lamb
Added support for rebuild lighting commandlet to read maps to rebuild from ini file.
#rb Andrew.Grant
#test Paragon rebuild lighting
#jira OR-30841
Change 3180227 on 2016/10/31 by Laurent.Delayen
Disabled Warning to fix https://jira.it.epicgames.net/browse/OR-30965
Will be turned into a warning message in the BP editor.
#c0dereview benn.gallagher
#rb none
#tests none
Change 3179903 on 2016/10/31 by jason.bestimt
#ORION_MAIN - Merge 34.2 @ CL 3179886
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3179895 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3177903 on 2016/10/28 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34 @ CL 3177869
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3177901 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3175548 on 2016/10/26 by Michael.Noland
GameplayAbilities: Change it so that delegates registered via RegisterGameplayAttributeEvent are still called on the client when there is no aggregator entry
#rb david.ratti
#c0dereview billy.bramer
#tests Tested in multiplayer PIE client with a new minion callback and golden path in -game
Change 3175544 on 2016/10/26 by Bart.Hawthorne
Draft in replays improvements:
- Marker added to timeline bar that shows when the level change happens
- Added "Skip Draft" button when loading a replay which will bypass the draft
- Only PvP matches will record replays
- Added "Exit Replay" button to hamburger menu while in draft
- No longer load hero data before viewing a replay if not skipping draft
- Enable replay recording in PvP
#rb john.pollard
#c0dereview paul.moore
#tests nomcp golden path up to spawnpoint, created and loaded several replays
Change 3175533 on 2016/10/26 by Michael.Noland
Fix for FMallocBinned::GetAllocationSize() for aligned allocations.
#jira UE-37249
#jira UE-37243
#rb robert.manuszewski
#lockdown robert.manuszewski
[reimplementing CL# 3165739 from Release-4.13]
#tests Compiled
Change 3175311 on 2016/10/26 by Daniel.Lamb
Added support for safe zone change.
Messed up files in last checkin
#test Ps4 paragon
#jira OR-30506
#rb Matt.Kuhlenschmidt
Change 3175298 on 2016/10/26 by Daniel.Lamb
Added support for updating safe area
#rb Matt.Kuhlenschmidt
#c0dereview Andrew.Grant Nick.Darnell
#test Ps4 paragon
#jira OR-30506
Change 3175209 on 2016/10/26 by David.Ratti
Fix a few cases where default gameplay cue parameters weren't initialized properly and could not be translated by the skin system. Fixes some mayan steel issues.
#rb none
#tests pie
Change 3174858 on 2016/10/26 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34/33.2 @ CL 3174784
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3174857 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3174822 on 2016/10/26 by Marcus.Wassmer
Duplicate 3174187
#jira UE-37020
#rb marc.audy
#test create/destroy effects with HQ lights in editor.
Change 3174344 on 2016/10/25 by Ryan.Gerleve
Added a bIsNetStartupComponent flag to UActorComponent. This will be set for components that are owned by an actor when that actor's bNetStartup flag is set.
#rb john.pollard
#tests golden path
Change 3174270 on 2016/10/25 by Marcus.Wassmer
Add LightingChannel control to High Quality particle lights.
#rb none
#test tested different lighting channels.
Change 3173855 on 2016/10/25 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 34 @ CL 3173292
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3173361 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3173843 on 2016/10/25 by Michael.Trepka
Update custom window controls on toggle fullscreen and make sure that when we switch to windowed mode we don't use window size that wouldn't fit on desktop
#rb Matt.Kuhlenschmidt
#tests Tested in editor build on PC
Change 3173783 on 2016/10/25 by Dan.Youhon
Add VelocityOnFinish mode options to RootMotionRadialForce so that designers can control what happens to a character's velocity when the ability task ends (part of #OR-30249)
#rb None
#tests MultiPIE
Change 3173734 on 2016/10/25 by Dan.Youhon
Protect against invalid Duration in FRootMotionSource_MoveToDynamicForce on simulated clients #OR-27128
#rb None
#tests MultiPIE
Change 3173714 on 2016/10/25 by David.Ratti
Add Game and Engine Compat versions for replays
#coderview John.Pollard
#rb Lietz
#tests golden path, replays
Change 3173681 on 2016/10/25 by Bart.Hawthorne
Implement drafting in replays. A replay spectator is spawned in the draft lobby so that the draft is saved out to the replay server, and clients are now able to travel in replays both when they occur "naturally" (at the same time as if they were a client), and also by scrubbing to a place in the timeline that's a different level.
The feature is implemented but currently disabled by default - turn on by setting CVarEnableDraftInReplays to 1. Replays should function the same as before.
Also fixed a warning on the dedicated server related to abandoning a draft.
#rb john.pollard
#c0dereview josh.markiewicz, paul.moore
#tests nomcp golden path (up to spawning), recorded multiple replays and played back with lots of scrubbing
Change 3173677 on 2016/10/25 by Andrew.Grant
Reenabled audio thread
Added safety wrapper to prevent code accidentally using events after they are returned to the pool.
#tests na
#rb Gil.Gribb
Change 3173588 on 2016/10/25 by Ryan.Gerleve
Added a replication condition to skip replays.
#tests golden path
#rb john.pollard
Change 3172692 on 2016/10/24 by Marcus.Wassmer
Fix OR-30390 caused by missing mutex lock
#rb none
#test compile ps4
Change 3172025 on 2016/10/24 by Matt.Kuhlenschmidt
Fix blur widget not respecting clip rects
#rb none
#tests paragon blur widget clipping bugs
Change 3171570 on 2016/10/23 by Mieszko.Zielinski
Moved Bots' enemy selection eqs query triggering to native code #Orion
Did this to be able to manually trigger enemy selection when current enemy dies, to avoid having a "null" enemy in BB for couple of ticks.
Also, made couple of tweaks to positioning and tower attacking behavior of melee bots
#rb none
#test golden path
Change 3171100 on 2016/10/21 by Aaron.Eady
FGameplayCueTagDetails;
Adding a check for if the RawStructData.Num > 0 before trying to use it. There was a case where you could crash the editor if you create a new GC tag inside of a BP, compile the BP, click Add New, select a GC type, then when the file is created, click away from it in the content browser. This repro wasn't 100% but often enough to caus a problem.
#rb David.Ratti (actually wrote the code)
#tests PIE
Change 3171060 on 2016/10/21 by Ryan.Gerleve
Some cleanup and fixes for deathcam:
The recording demo net driver for the deathcam replay now uses checkpoint amortization to smooth out spikes.
Converted UOrionKillcamPlayback::IsKillcamWorld to IsKillcamActor, since IsKillWorld isn't useful for the new single-world implementation.
Converted a GetValueOnGameThread to GetValueOnAnyThread (wasn't in the merge) so that deathcam replay recording can happen on a thread.
Added comment to UAbilitySystemComponent::OnComponentDestroyed.
#rb john.pollard
#tests golden path, enabled deathcam
Change 3171041 on 2016/10/21 by Ryan.Gerleve
Make the CheckpointSaveMaxMSPerFrame value a member of UDemoNetDriver so it can be set per instance, and convert the demo.CheckpointSaveMaxMSPerFrame cvar into an override for this value.
#rb john.pollard
#tests golden path
Change 3170917 on 2016/10/21 by Mieszko.Zielinski
Made a change to OrionBTTask_ObjectiveGraphMove to make it fallback to regular move if the destination is in the same or second-closest objective graph node #Orion
#rb none
#test golden path
Change 3170914 on 2016/10/21 by Mieszko.Zielinski
Fixed EQS scoring bug resulting in some items getting NaN scored #UE4
The NaN was happening when scoring but not filtering using a bool-based test, or when unintentionally skipping items by moving item iterator without doing any work.
Removed a bunch of deprecated code while there
#rb Lukasz.Furman
#test golden path
Change 3170912 on 2016/10/21 by Mieszko.Zielinski
Manual merge of crucial BT fixed over from //Fortnite/Main #UE4
Original CL#3159145 , CL#3159892
#rb Lukasz.Furman
#test golden path
Change 3170478 on 2016/10/21 by David.Ratti
fix editor crash related to recompiling gamplay cue blueprint while a preview animation is playing that invokes that gameplay cue.
#rb none
#tests editor
Change 3170231 on 2016/10/21 by Ryan.Gerleve
Fix for an issue that was preventing moving your hero after spawning in PIE in Agora: set the net driver on static level collections as well.
#tests golden path, PIE
#c0dereview john.pollard
#rb none
Change 3170074 on 2016/10/20 by Ryan.Gerleve
Merging support for recording client replays in a task parallel with Slate (optimization for deathcam) from UE4/Dev-Networking.
CL 3169209
#tests golden path, replays
#rb none
Change 3170019 on 2016/10/20 by Ryan.Gerleve
Merging support for deathcam memory optimizations (level collection work) from UE4/Main and UE4/Dev-Networking.
CLs:
3134499
3134771
3135279
3137140
3138081
3140413
3150142
3142515
3162189
3162194
#tests golden path
#rb none
Change 3169686 on 2016/10/20 by Michael.Trepka
Fixed a Windows-specific problem with parts of the custom window buttons not accepting mouse clicks when the window is maximized due to window region used by FWindowsWindow::IsPointInWindow() being offset by border size.
#rb Jeff.Campeau
#tests Tested in editor build on PC
Change 3169668 on 2016/10/20 by Max.Chen
Sequencer - Don't crash when a bool track or visibility track has a null runtime object.
Copy from Odin
#rb none
#tests opened a recorded sequence
Change 3169657 on 2016/10/20 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_33 - Fix for localization export of web data
Fixed export of localized formatted text
- Removed the super-specific GetSourceTextsFromFormatHistory, and replaced it with the more-generic GetHistoricFormatData to get information about an FText that was generated via FText::Format.
- Added GetHistoricNumericData to get information about an FText that was generated via FText::AsNumber or FText::AsPercent.
- Updated the translation picker to use GetHistoricFormatData.
- Removed the code from FMultiLocHelper that used GetSourceTextsFromFormatHistory as it wasn't actually needed.
- Added code to FGameDataExporter to correctly localize a formatted text for a given culture, and re-format the result for export.
[c0dereviewed]: jamie.dale
#RB:none
#Tests:Exported game data!
#R0B0MERGE-SOURCE: CL 3169653 in //Orion/Release-33/... via CL 3169654 via CL 3169655 via CL 3169656
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3169616 on 2016/10/20 by David.Ratti
missed file
#rb none
#tests none
Change 3169597 on 2016/10/20 by David.Ratti
Missed include
#rb DanH
#tests none
Change 3169393 on 2016/10/20 by David.Ratti
AbilitySystem.GlobalAbilityScale cvar to help design iterate on animation/duration based tweaks
#rb none
#tests pie
Change 3168287 on 2016/10/19 by Mieszko.Zielinski
Expanded EQS info logged with vlog #UE4
#rb none
#test golden path
Change 3168282 on 2016/10/19 by David.Ratti
Restore warning when multiple GC notifies try to handle the same tag.
#rb none
#tests compile, launch editor, see warnings, cry
Change 3168196 on 2016/10/19 by Jon.Lietz
compile fix, removing the int version of FirstActiveIndex and leaving the in32 version.
#RB none
#tests compiles
Change 3168041 on 2016/10/19 by Michael.Trepka
Don't restore saved resolution on window activation in non-fullscreen modes
#rb Matt.Kuhlenschmidt
#tests Tested in editor build on PC
Change 3167859 on 2016/10/19 by Aaron.McLeran
UE-36288 Fixing concurrency resolution stop quietest
Implementing in Dev-General for Joey since he needs the fix ASAP.
#rb Jeff.Campeau
#tests perform tests described in JIRA bug.
Change 3167790 on 2016/10/19 by Andrew.Grant
Duplication of 3167569 from //Odion/Main for Paragon cinematics
#rb none
#tests compiled
Change 3167682 on 2016/10/19 by Laurent.Delayen
Integrated #ORION_33.1 - Disabled WindSources on Cloth and AnimDynamics, as it's not safe to access from the GameThread. https://jira.it.epicgames.net/browse/OR-30473
#rb ori.cohen, benn.gallagher
#tests Vamp, Kwang, Chains in Persona and PIE with WindActor in level.
Change 3167466 on 2016/10/19 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 33.2 @ CL 3167368
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3167456 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3167312 on 2016/10/19 by Mieszko.Zielinski
Fixed EQS template cache issues with multiple query run modes #UE4
#rb Lukasz.Furman
#test golden path
#jira UE-37496
Change 3166784 on 2016/10/18 by Laurent.Delayen
Don't leave PhysicsBodies::bWindEnabled uninitialized in case Wind is not enabled (Persona)
#rb none
#c0dereview benn.gallagher
#test Chains in Persona
Change 3166641 on 2016/10/18 by Mieszko.Zielinski
Made the value span used for EQS item score normalization configurable #UE4
#rb Lukasz.Furman
#test golden path
Change 3166632 on 2016/10/18 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Added support for multiple deployment sandboxes on PS4.
BuildCookRun -deploy=SomeDir
ps4.elf -deployedbuild=SomeDir
Omitting name in -deploy/-deployedbuild falls back to previous default of using 'GameName' as the deployment sandbox.
#tests BuildCookRun with -deploy and -deploy=Orion_v33, Ran PS4 with -deployedbuild and -deployedbuild=Orion_v33
[c0dereviewed] Marcus.Wassmer, Luke.Thatcher
#rb none
#R0B0MERGE-SOURCE: CL 3166622 in //Orion/Release-33/... via CL 3166629 via CL 3166630 via CL 3166631
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3166494 on 2016/10/18 by Michael.Noland
Engine: Removed irrelevant GPU stats from FPS chart server analytics reports
#jira OR-13877
#rb david.ratti
#tests Ran golden path on uncooked Win64, used forcewinmatch, and inspected the analytics arrays
Change 3166476 on 2016/10/18 by Michael.Noland
Cooker: Deleting dead GenerateManifestInfo methods
#tests Compiled
#rb none
#c0dereview daniel.lamb
Change 3166471 on 2016/10/18 by Michael.Noland
Making sure DebugWorlds/DebugWorldNames are in sync, since we expect an index from one to match the other (fixes an issue where users could select a debug world and the wrong one was chosen).
[reimplementing CL# 3157138 by Mike.Beach]
#jira UE-37107
#rb Dan.OConnor
#tests Tested multiplayer PIE and opening an anim BP
Change 3166460 on 2016/10/18 by Michael.Noland
Particles: Prevent log spam on servers about stripped emitters
#rb graeme.thornton
[reimplementing CL# 3157862 by Simon.Tovey]
#tests Ran an uncooked server and tested golden path
Change 3166339 on 2016/10/18 by Laurent.Delayen
oops, this file got away.
#rb none
#tests none
Change 3166337 on 2016/10/18 by Laurent.Delayen
Fix for AnimDynamics Wind crash.
https://jira.it.epicgames.net/browse/OR-30351
Access WindParameters on GameThread. Also minor optimization: don't iterate over bodies every frame if wind is off.
#rb benn.gallagher
#c0dereview lina.halper, thomas.sarkanen
#tests Vamp
Change 3166207 on 2016/10/18 by Mieszko.Zielinski
Bot perception work #Orion
Added a new sense that makes bots know about enemies visible on the minimap
Made jungle minions do not register as sight sources
Cleaned up bot perception component a bit
#rb none
#test golden path
Change 3166138 on 2016/10/18 by Michael.Noland
Blueprints: Converted a crash with the debug world name in the BP editor to an ensure until it can be fixed properly (see OR-29650)
#c0dereview dan.oconnor
#rb none
#tests Tested opening an anim BP during multiplayer PIE
Change 3165860 on 2016/10/18 by David.Ratti
remove some debug code that wasn't intended to be checked in
#rb none
#tests compile
Change 3165288 on 2016/10/17 by Ian.Fox
#XMPP - Add correlation id attribute to outgoing stanzas
#RB Rob.Cannaday
#Tests Correlation IDs come back in responses to xmpp messages we send
#JIRA OGS-409
Change 3165096 on 2016/10/17 by David.Ratti
Fix issue where gameplay tags net indices would be out of sync on cooked PS4 client playing on uncooked windows servers. Would cause some effects to not play.
#rb none
#tests PS4/PC crossplay
Change 3164973 on 2016/10/17 by Dan.Hertzka
Fix link error
#rb #tests compile
Change 3164910 on 2016/10/17 by Lukasz.Furman
fixed bug in merging behavior tree searches
copy of CL 3164903
#ue4
#rb Mieszko.Zielinski
#tests none
Change 3164908 on 2016/10/17 by Dan.Hertzka
Exposing the blur widget for use in Paragon
** Use OrionBlurWidget, not the base BackgroundBlurWidget
- Added it to the hero and default tooltips for reference
#rb none
#c0dereview Marcel.Swanepoel, Sean.Smith, Bryan.Rathman
#tests PIE
Change 3164482 on 2016/10/17 by David.Ratti
Editor loadtime improvements
* Refactor GameplayCue manager to support two distinct object library sets: Runtime and Editor. Editor library operates on all valid gameplay cue paths but never loads or scans, only reflects what asset registry has found. Runtime library is the initial loaded paths + any explicit requests. These scan when needed and async load at startup.
* Wrote UOrionAsyncLoadRequestQueue to feed the async load queue with requests at startup. This is to avoid submitting 300+ requests at startup and have them flushed by a sync load. The editor will wait until it is fully initialized before kicking these off.
* Changed UOrionUIManagerWidget to weakly reference all of its state widgets. In non editor builds these are all loaded at startup like before. In editor builds, we sync load them on demand. This allows us to not load everything in order to PIE.
* Added options for loading various pieces of data at editor startup: HUDwidget V4, last used hero data, and shared gameplay cues.
* -game -nomcp will now properly async load initial set of data
* BeginLoadAsyncData no longer takes netmode as parameter since it is confusing and can just use IsDedicatedServer() internally
* Added new log category: LogOrionStartup
#rb none
#c0dereview Dan.Hertzka
#tests pie, golden path, cooked PS4
Change 3163635 on 2016/10/14 by Laurent.Delayen
AnimInstance: Pass a few FNames by reference instead of by value. Added CalcSlotMontageLocalWeight to get local a slot's local weight without a frame a lag. Fixed Montage update happening after native update on gamethread, but before native update on worker thread. Now happens before both, so we can reliably get montage weights without a frame of lag regardless of where we access it.
#rb none
#c0dereview martin.wilson, thomas.sarkanen
#tests fixes Twinblast's primary fire blend out having a frame a lag.
Change 3163620 on 2016/10/14 by Laurent.Delayen
AnimNode_Slot debug: Show actual slot local weight, instead of always 1.
#rb none
#c0dereview martin.wilson
#tests twinblast debug
Change 3163061 on 2016/10/14 by Andrew.Grant
Pulling test framework changes into seprate CL
#rb #tests na
Change 3162675 on 2016/10/13 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Merging test framework changes down early.
#rb #tests na
#R0B0MERGE-SOURCE: CL 3162674 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3162062 on 2016/10/13 by Michael.Trepka
Replaced FWindowsCursor hack for warping the mouse cursor to the center of the viewport with a better fix for the original problem (users being able to resize the window while the cursor is hidden and the mouse controls the camera). This change removes round window corners in borderless window mode and disables window resizing when the cursor is hidden.
#rb Matt.Kuhlenschmidt
#tests Tested in editor build on PC
Change 3161489 on 2016/10/13 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 33.2 @ CL 3161453
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3161473 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3160664 on 2016/10/12 by Ben.Salem
Fix logic order error fuzzy matching on automated tests - we were only allowing one match per filter instead of one match per test.
#rb adric.worley
#tests Ran All Ftests that start with S
Change 3159866 on 2016/10/12 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 33.2 @ CL 3159727
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3159865 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3158870 on 2016/10/11 by John.Barrett
Fixed issue where some PacketHandler parsing errors, would not stop NetConnection processing of packets, and would not trigger a disconnect.
#JIRA OR-29219
#rb none
#tests compiles, client/server
Change 3158336 on 2016/10/11 by Lukasz.Furman
string pulling for local navigation grids
#ue4
#rb Mieszko.Zielinski
#tests PIE
Change 3158203 on 2016/10/11 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 33.2 @ CL 3158043
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3158154 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3158162 on 2016/10/11 by Matt.Kuhlenschmidt
Added a blur widget to umg that applies a blur effect to whatever is behind the widget
- The widget has a content slot that can be used to display unblurred content on top of the blur
- The widget has a low quality mode brush that can be applied instead of the background blur. This is enabled by the cvar Slate.ForceBackgroundBlurLowQualityOverride=1
- This widget is currently expermental and must be subclassed to be used
#tests Tested on PS4, PC, Mac (opengl and metal)
#rb nick.darnell
Change 3157232 on 2016/10/10 by Lukasz.Furman
added local navigation grids: dynamic obstacles on static navmesh
#ue4
#rb Mieszko.Zielinski
#tests none, disabled by default
Change 3157112 on 2016/10/10 by Laurent.Delayen
Removed my layer anim node fix, since Martin did a similar fix.
#rb none
#tests compiles
#c0dereview martin.wilson
Change 3156789 on 2016/10/10 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 33.2 @ CL 3156726
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3156788 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3156717 on 2016/10/10 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Merging 3156681 from //Orion/Release-33 to Main
#rb #tests na
#R0B0MERGE-SOURCE: CL 3156713 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3156596 on 2016/10/10 by Martin.Wilson
Fix pose flickering on LOD change when using Layered Blend by Bone node (recreated from dev-framework CL 3112086)
#Jira OR-30017
#rb Lina.Halper
#tests Tested affected anim nodes in editor
Change 3156149 on 2016/10/08 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Merging test framework changes from //Orion/Release-33.2 to Main (//Orion/Main)
#rb #tests na
#R0B0MERGE-SOURCE: CL 3156148 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3155444 on 2016/10/07 by David.Ratti
-Fix crashes from FScalableFloats caching raw curve pointers by invalidating cache on curve table swaps
-Removed the old code that was trying to do this in the editor on reimport, which never actually worked properly.
#rb none
#tests golden path
Change 3155228 on 2016/10/07 by Michael.Trepka
Partial (Windows implementation only) copy of CL 3151851 from //UE4/Main
Added DesktopRect and WorkArea to FMonitorInfo for desktop platforms and used that to fix an issue in SceneViewport where windowed fullscreen mode would be forced to primary monitor and incorrectly positioned on desktops where a taskbar/dock/etc. was on the left
#rb Dmitry.Rekman
#tests Tested in editor build on PC
Change 3154910 on 2016/10/07 by Lukasz.Furman
added new accessors in TSimpleCellGrid and inlined bunch of functions
#ue4
#rb none
#tests none
Change 3154906 on 2016/10/07 by Lukasz.Furman
adjusted comments for FGraphAStar
#ue4
#rb none
#tests none
Change 3154679 on 2016/10/07 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 33 @ CL 3154662
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3154677 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3153638 on 2016/10/06 by Andrew.Grant
Duplicating fix for UE-36087 from UE4
#rb #tests na
Change 3153325 on 2016/10/06 by David.Ratti
CurveTableSets: support for multiple spread sheets
-Sovereign data located in Sovereign subfolder, cloned from base data.
#rb none
#tests PIE, golden path
Change 3153318 on 2016/10/06 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge DUI @ CL 3152667
#RB:none
#Tests:none
[c0dereviewed]: kerrington.smith, matt.schembari
#R0B0MERGE-SOURCE: CL 3153310 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3153268 on 2016/10/06 by David.Ratti
Missed file for engine changes
#rb none
#tests none
Change 3153264 on 2016/10/06 by David.Ratti
Move some DetailCustomziation classes to public folder so that games can override/extend them. Also made some virtual functions to override the things paragon needs to.
#rb none
#tests paragon editor
Change 3153204 on 2016/10/06 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2/33 @ CL 3152587
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3153171 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3152699 on 2016/10/05 by Andrew.Grant
I apologize for the mega-checkin but there are a lot of dependencies here, the work spiralled, and I've been cranking to get this in for the v33 branch. Please review and comment on what you know about and don't worry about the rest :)
-Added options-struct to MallocLeak detection to allow filtering open callstacks by frame range and size. This is now used in Paragon automatic tests to dump out memory left loaded by the previous map.
-PS4StackWalk now uses lowercase filenames as this is how non-UFS files are staged
-Renamed Orion.Foo.cs test scripts to OrionTest.Foo.cs
-Split some Orion tests into seprate scripts
-Added concept of "TestControllers". These are constructed by OrionEngine based on the -test= commandline and provide a super-simple way to implent state-based logic and checks by overriding base class functions.
-Added controllers for Boot, Soak, and Leak checks
-Renamed SimpleSolo bot to SimpleSoak. Moved a lot of logic about match composition and state to OrionTestControllerSoak
-Added new MatchStarted/MatchEnded delegates to OrionGameState for clients
-Fixed issues where OrionGameState_Base::HasMatchStarted would return true for WaitingForPlayers and MatchCountdown
-OrionBot code no longer caches command line since some TestControllers set it at runtime
-Added some ensures in Draft logic to catch/guard against a crash being triggered by bots.
#rb none
#tests verified all of the above and much more!
#c0dereview David.Ratti, Marcus.Wasmer,Michael.Noland
Change 3152605 on 2016/10/05 by Andrew.Grant
Suppressed warning about missing parent if parent package was in the KnownMissingPackageList
Added Editor ScaleRef stuff to Orion to suppress cooked warning
#rb none
#c0dereview Marcus.Wassmer
#tests Verified warning about ScaleRef being missing is gone
Change 3152596 on 2016/10/05 by Andrew.Grant
Made ASLR an option that can be disabled.
Disabled ASLR for Paragon PS4 Test builds so symbol lookup is available for diagnostics.
Made "don't optimize adaptive unity files" an official feature, off by default but turned on in Paragon
#c0dereview Luke.Thatcher
#rb none
#tests Verified test build has symbols that can be resolved. Verified an adaptive unity file is non-optimized, but non-adaptive files are optimized as normal
Change 3152399 on 2016/10/05 by Josh.Markiewicz
#UE4 - temporary fix for OSS R0B0MERGE issue
#rb david.nikdel
#test compiles
Change 3150916 on 2016/10/04 by Daniel.Lamb
Removed warning when shader compiler is in a bad state.
#rb Andrew.Grant
#jira OR-29580
#test Cook paragon
Change 3150889 on 2016/10/04 by Ben.Salem
Add log feedback to automation harness when processing commands, including syntax helpers when an unhandled command is added.
#rb adric.worley
#tests Ran several commands to see log output.
Change 3150844 on 2016/10/04 by Lukasz.Furman
compilation fix
#rb none
#tests none
Change 3150759 on 2016/10/04 by Lukasz.Furman
added "hidden" state to gameplay debugger category
#ue4
#rb Mieszko.Zielinski
#tests config changes and PIE
Change 3150758 on 2016/10/04 by Lukasz.Furman
pass on SimpleCellGrid template to make it usable for local navigation grids
#orion
#rb Mieszko.Zielinski
#tests PIE on agora, AI tactics debug on agora
Change 3150567 on 2016/10/04 by Dan.Hertzka
Rough initial implementation of a generic UI layer for moving widgets around to and from arbitrary locations. Lots of possible uses. For example, equipping a card in the card shop that then animates down into the correct hand slot.
- Not in actual use anywhere yet
#rb none
#tests PIE
Change 3150307 on 2016/10/04 by Laurent.Delayen
Removed check() not considering SimulatedRootMotion for RemoteClients.
#rb none
#tests compiles
Change 3150236 on 2016/10/04 by Josh.Markiewicz
#UE4 - added documentation to FNetworkNotify interface
- fixed bad UE_LOG category while double checking the above
#rb none
#tests compiles
Change 3150206 on 2016/10/04 by Josh.Markiewicz
#UE4 - moved ClientTravelToSession out of AGameSession and into UGameInstance
- removed similar function from UGameInstanceCommon
- more common usage location
#rb none
#c0dereview paul.moore
#tests rejoin vectors and golden path
Change 3150073 on 2016/10/04 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2/33 @ CL 3150010
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3150072 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3150031 on 2016/10/04 by Mieszko.Zielinski
New AIData provider that generated random numbers #UE4
#rb Lukasz.Furman
#test golden path
Change 3149946 on 2016/10/04 by Ben.Woodhouse
Make UPrimitiveComponents (and derived variants) take proxy memory into account in GetResourceSize()
We do this by dereferencing the SceneProxy directly, but this should be safe, since we NULL it on the gamethread before the proxy is released.
#jira OR-26778
#rb luke.thatcher
#tests compile, run Win64 with -game, run editor
Change 3149743 on 2016/10/03 by Ben.Salem
Null check for blank test names when making functional tests to repair crash on server.
#rb nick.darnell
#tests Ran multiple FTests
Change 3149460 on 2016/10/03 by Laurent.Delayen
Refactored TickCharacterPose.
Now calls 'ShouldTickPose' so it can get properly obey bPauseAnims, MeshComponentUpdateFlag and other conditions.
Still forces updates when playing networked root motion montages, and that check is now done inside of USkeletalMeshComponent::ShouldTickPose().
Fixes human players always calling TickPose regardless of settings on dedicated servers.
Also addresses Jira UE-34720
#rb martin.wilson
#tests networked Vamp x2 + golden path
Change 3149435 on 2016/10/03 by Mieszko.Zielinski
Fixed a bug in EQS item score normalization for the purposes of drawing #UE4
Also, made printed out scores not normalized since seeing original EQS calculated score desirable
#rb Lukasz.Furman
#test golden path
Change 3148550 on 2016/10/03 by John.Barrett
Fixed bad/blocking ensure added in FBitReader. OR-29219
#tests compile
#rb none
Change 3147460 on 2016/09/30 by Laurent.Delayen
Fixed AOrionChar::UpdateAnimationTicking never setting EMeshComponentUpdateFlag::OnlyTickPoseWhenRendered, because OnMontageEnded() is called before the MontageInstance is actually removed and deleted.
Added OnAllMontageInstancesEnded to AnimInstance, and used that to call UpdateAnimationTicking.
#rb michael.noland
#tests Golden Path
Change 3146677 on 2016/09/30 by Jamie.Dale
Fixed UGatherTextFromSourceCommandlet::ParseSourceText being able to underflow while parsing
#rb Andrew.Rodham
#tests Ran the gather
Change 3146555 on 2016/09/30 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3146524
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3146553 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3146129 on 2016/09/29 by Michael.Noland
Engine: Fixed the spectator camera (used in ToggleDebugCamera) so it moves consistently regardless of the slomo value by using the raw frame delta rather than trying to counter-correct for time dilation
#c0dereview marc.audy
#rb none
#tests Tested ToggleDebugCamera with slomo 0.00001
Change 3145574 on 2016/09/29 by Adric.Worley
Fix FunctionalTestingManager not compiling when included
#tests compile
#rb mieszko.zielinski
Change 3145224 on 2016/09/29 by Michael.Trepka
Better check for whether or not PreFullscreenWindowPlacement in FWindowsWindow is valid
#rb Dmitry.Rekman
#tests Tested editor build on PC
Change 3145132 on 2016/09/29 by Alexis.Matte
Make sure we use GetMesh instead of the SkeletalMeshPtr variable.
#jira OR-29617
#rb matt.kuhlenschmidt
#test none
Change 3144926 on 2016/09/29 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3144835
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3144925 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3144920 on 2016/09/29 by Benn.Gallagher
Added "Reset Clothing Sim" anim notify to trigger a clothing reset from an animation, to help with issues arising from extreme movements in animations.
#rb James.Golding
#tests Editor + -game vamp RMB abilities using new notify
Change 3144055 on 2016/09/28 by Jason.Bestimt
#R0B0MERGE-AUTHOR: ben.marsh
BuildGraph: Fix builds created with preconditions on nodes behind triggers, causing nightly builds to run forever due to conditions never evaluating to true.
#rb none
#tests Compared exported job definition before and after
#R0B0MERGE-SOURCE: CL 3143992 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3143801 on 2016/09/28 by Mieszko.Zielinski
Made UAIBlueprintHelperLibrary::CreateMoveToProxyObject deduce WorldContextObject from Pawn if not received from BP #Orion
Also, made failing to do so not fails a check
#rb Lukasz.Furman
#test golden path
#c0dereview Aaron.Eady
Change 3142377 on 2016/09/27 by Jason.Bestimt
#R0B0MERGE-AUTHOR: marcus.wassmer
Fix crashes when using GBuffer resources in simpleforward mode.
#rb Daniel.Wright
#test vamp Q on low settings.
#R0B0MERGE-SOURCE: CL 3142376 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3141628 on 2016/09/27 by David.Ratti
Guard against recursion in WaitGameplayEffectApplied ability task
#rb none
#tests pie crash case
Change 3141497 on 2016/09/27 by Marcus.Wassmer
Duplicate 3123743
Separate skeletal/static mesh lod interfaces
#rb none
#test created an LOD for vamp locally.
Change 3140832 on 2016/09/26 by Jason.Bestimt
#R0B0MERGE-AUTHOR: marcus.wassmer
Remove dubious non-threadsafe GBuffer reference adjustments.
Possibly fix OR-29506
#rb none
#test PC on all settings
#R0B0MERGE-SOURCE: CL 3140831 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3140828 on 2016/09/26 by Uriel.Doyon
Workaround (reverting previous attemp) at fixing issue with FTextRenderSceneProxy when running command let.
#rb marcus.wassmer
#tests running lighting build with command let & loading editor
Change 3140331 on 2016/09/26 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Cloning fix for UE-36253 from //UE4/Dev-Framework/...
#rb #tests na
#R0B0MERGE-SOURCE: CL 3140329 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3139976 on 2016/09/26 by David.Ratti
balance tweaker + some prep for multiple data tables support
#rb none
#tests pie, golden path
Change 3139904 on 2016/09/26 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Adding code to log name of package that refuses to load...
#rb none
#tests compiled
#R0B0MERGE-SOURCE: CL 3139902 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3139871 on 2016/09/26 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Fixes for OR-29229 and OR-29413
#rb #tests na
#R0B0MERGE-SOURCE: CL 3139870 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3139751 on 2016/09/26 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3139692
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3139740 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3139451 on 2016/09/25 by Uriel.Doyon
Submitted a workaround for the lighting build command let crash.
#rb none
#tests loaded editor, built lighting command let
Change 3138304 on 2016/09/23 by David.Ratti
Fix checkslow in Debug editor
#rb none
#tests debug editor
#c0dereview Martin.Wilson
Change 3138068 on 2016/09/23 by Laurent.Delayen
Don't try to match invalid GUIDs in FSmartNameMapping::GetNameByGuid.
Fixes Steel's curves all getting matched to 'DistanceCurve'
#rb martin.wilson
#tests Steel's curve are not all 'DistanceCurve'
Change 3137830 on 2016/09/23 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3137699
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3137746 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3137657 on 2016/09/23 by Ben.Marsh
Fix initialization order warning.
#rb none
#tests none
Change 3137628 on 2016/09/23 by bruce.nesbit
Fixed non-unity compiles in LandscapeSplines and LandscapeSplineRaster
#rb none
#tests Compiled NU
Change 3137538 on 2016/09/23 by Thomas.Sarkanen
Fix crash rendering sequence with keyframed material parameters
Ported Frank F's fix from Dev-Sequencer. Original CL 3136577:
Sequencer - Always use a unique name when creating dynamic material instances for animation to prevent reuse and resource issues.
#tests Rendered out problematic sequence successfully multiple times
#rb none
#jira UE-36175 - Keyframing material parameters can cause crashes when rendering
#c0dereview Frank.Fella
Change 3136580 on 2016/09/22 by Ben.Marsh
Merging CL 3136158 to fix support for generating project files with Visual Studio Express.
#rb none
#tests none
Change 3136574 on 2016/09/22 by Michael.Trepka
Fixed a crash caused by trying to redraw window contents while switching from fullscreen to windowed mode
#rb Marcus.Wassmer
#tests Tested editor build on PC
Change 3136293 on 2016/09/22 by Adric.Worley
Add BlueprintType to EFunctionalTestResult
#tests editor
#rb ben.salem
#c0dereview nick.darnell
Change 3136240 on 2016/09/22 by Andrew.Grant
Merging from //UE4/Main @ 3135156
#rb none
#tests QA pass and local golden path
Change 3136197 on 2016/09/22 by Jamie.Dale
Merging CL# 3094477 and CL# 3111827 to fix some tesselated landscape crashes
#rb Gareth.Martin
#tests Loaded the map that was crashing
Change 3135914 on 2016/09/22 by Dan.Youhon
Fixed CharacterMovementComponent impulse net correction handling during additive root motion (part of #OR-5545)
- Fixes #OR-28478, heroes tethered by Kwang cannot be knocked up
- Fixes #OR-18985, Gideon R ability negating knockback/knockup effects (including Howitzer E)
#rb None
#tests MultiPIE
#R0B0MERGE: MAIN, 32.2, 32.1
Change 3135893 on 2016/09/22 by David.Ratti
GameplayCueeditir Change override type from a checkbox to a combobox to make things a little clearer
#rb none
#tests gameplaycue editor
Change 3135843 on 2016/09/22 by jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3135756
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3135820 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
#R0B0MERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
//Orion/Dev-General/OrionGame/Content/Balance/HeroData.uasset - can't integrate exclusive file already opened
//Orion/Dev-General/OrionGame/Content/Cards/Effects/P_ThunderCleaver.uasset - can't integrate exclusive file already opened
//Orion/Dev-General/OrionGame/DataTables/HeroData.xlsm - can't integrate exclusive file already opened
#c0dereview: jason.bestimt
Change 3134639 on 2016/09/21 by jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3133910
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3134086 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
#R0B0MERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human.
#c0dereview: jason.bestimt
Change 3134367 on 2016/09/21 by Ben.Woodhouse
More complete fix for SSAO issues. Disable vertex fogging automatically if forward shading is disabled
#rb daniel.wright
#tests none
Change 3134176 on 2016/09/21 by Jason.Bestimt
#ORION_DG - UnrealPak speed improvements
Moving shelved CL to DG and submitting for DanielL
#RB:none
#Tests:none
#c0dereview: andrew.grant, daniel.lamb
Change 3134129 on 2016/09/21 by Jamie.Dale
Added the "unattended" flag when running the localzation commandlets via UAT
#rb none
#tests Built UAT
Change 3133864 on 2016/09/21 by Ben.Woodhouse
Default r.VertexFoggingForOpaque to 0, since it only makes sense for forward shading. This was causing fog to be modulated by SSAO in Orion.
Note: this setting is overridden to 1 in Odin's DefaultEngine.ini, so it should work in that case.
#c0dereview daniel.wright
#rb luke.thatcher
#jira OR-29262
#tests yes
Change 3133849 on 2016/09/21 by Martin.Wilson
Fix pose blending for on non-additive pose blending + remove normalising of weights for weights less than 1
#rb Jurre.DeBaare
#tests Editor tests with mambo pose asset
#jira UE-36189
Change 3133546 on 2016/09/20 by Jason.Bestimt
#R0B0MERGE-AUTHOR: marcus.wassmer
Null merge of 3131588. Fix from 31.1 is unncecessary as a more complete fix came from the engine integration that's in v32.
#rb none
#tests none
[c0dereviewed] Jason.Bestimt
#R0B0MERGE-SOURCE: CL 3132617 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3133487 on 2016/09/20 by Michael.Noland
Automation: Added Automation to the manual autocomplete list
Change 3133363 on 2016/09/20 by Daniel.Lamb
Added Jaymee Sanford and Tony Oliva to the rebuild lighting email list.
#rb Trivial
#test Compile automation tool
Change 3132956 on 2016/09/20 by Benn.Gallagher
Fixed crash when importing clothing with mismatching number of triangles when compared to the original render data
#tests Editor, apex reimport
#rb none
Change 3132403 on 2016/09/20 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3132254
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3132353 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3132332 on 2016/09/20 by Andrew.Grant
Replicated UE4/Main fix for missing materials pane
#rb none
#tests verified material pane shows
Change 3132131 on 2016/09/20 by Jason.Bestimt
#R0B0MERGE-AUTHOR: andrew.grant
Merging automation work from //Orion/Release-32.2 to Main
#rb none
#tests verified functionality
#R0B0MERGE-SOURCE: CL 3132130 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
Change 3131698 on 2016/09/19 by Andrew.Grant
Qucik fix to unblock build. Will follow up correct way tomorrow
#rb none
#tests blueprint compiles
Change 3131489 on 2016/09/19 by Andrew.Grant
Merging from //UE4/Orion-Staging (Source: //UE4/Main @ 3111290)
#rb none
#tests QA pass in Orion-Staging, Golden path post merge
Change 3131350 on 2016/09/19 by Adric.Worley
Fix functional test reporting typo
#tests PIE
#rb ben.salem
Change 3130959 on 2016/09/19 by Mieszko.Zielinski
Compilation fix #UE4
#rb none
#test compilation
Change 3130904 on 2016/09/19 by Mieszko.Zielinski
Couple of generic AI perception fixes #UE4
Made unregistering AI sight source broadcast "no longer visible" information to all observers currently "seeing" the source
Fixed FActorPerceptionInfo::GetLastStimulusLocation not carying whether selected stimulus was successfully sensed
Fixed dominant sense not really working if not set with UAIPerceptionComponent::SetDominantSense call
#rb Lukasz.Furman
#test golden path
Change 3130304 on 2016/09/19 by Jason.Bestimt
#R0B0MERGE-AUTHOR: jason.bestimt
#ORION_MAIN - Merge 32.2 @ CL 3130115
#RB:none
#Tests:none
#R0B0MERGE-SOURCE: CL 3130164 in //Orion/Main/...
#R0B0MERGE-BOT: ORION (Main -> Dev-General)
[CL 3205566 by Andrew Grant in Main branch]
==========================
MAJOR FEATURES + CHANGES
==========================
#lockdown Nick.Penwarden
Change 2903938 on 2016/03/10 by Frank.Gigliotti
Added an instance ID to FAnimMontageInstance
#CodeReview Laurent.Delayen
#RB Laurent.Delayen
#Tests PIE
Change 2903745 on 2016/03/10 by Wes.Hunt
Update Oodle TPS
#rb none
#tests none
#codereview:john.pollard
Change 2903689 on 2016/03/10 by Uriel.Doyon
New "LogHeroMaterials" console command, displaying the current state of materials and textures on the character hero.
#rb marcus.wasmer
#codereview marcus.wassmer
#tests editor, playing PC games, trying the new command
Change 2903669 on 2016/03/10 by Aaron.McLeran
OR-17180 Make stat soundcues and stat soundwaves NOT display zero volume sounds
- Change only effects debug stat commands for audio guys
#rb none
#tests played paragon with new debug stat commands, confirms doesn't show zero-volume sounds
Change 2903625 on 2016/03/10 by John.Pollard
XB1 Oodle SDK
#rb none
#tests none
#codereview Jeff.Campeau
Change 2903577 on 2016/03/10 by Ben.Marsh
Remaking latest build scripts from //UE4/Main @ 2900980.
Change 2903560 on 2016/03/10 by Ben.Marsh
Initial version of BuildGraph scripts - used to create build processes in UE4 which can be run locally or in parallel across a build farm (assuming synchronization and resource allocation implemented by a separate system). Intended to supersede GUBP.
Build graphs are declared using an XML script using syntax similar to MSBuild, ANT or NAnt, and consist of the following components:
* Tasks: Building blocks which can be executed as part of the build process. Many predefined tasks are provided (<Cook>, <Compile>, <Copy>, <Stage>, <Log>, <PakFile>, etc...), and additional tasks may be added be declaring classes derived from AutomationTool.CustomTask in other UAT modules.
* Nodes: A named sequence of tasks which is executed to produce outputs. Nodes may have input dependencies on other nodes before they can be executed. Declared with the <Node> element in scripts.
* Agent Groups: A set of nodes nodes which is executed on the same machine if running as part of a build system. Has no effect when building locally. Declared with the <Group> element in scripts.
* Triggers: Container for groups which should only be executed when explicitly triggered (using the -Trigger=<Name> or -SkipTriggers command line argument). Declared with the <Trigger> element in scripts.
* Notifiers: Specifies email recipients for failures in one or more nodes, whether they should receive notifications on warnings, and so on.
Properties can be passed in to a script on the command line, or set procedurally with the <Property Name="Foo" Value="Bar"/> syntax. Properties referenced with the $(Property Name) notation are valid within all strings, and will be expanded as macros when the script is read. If a property name is not set explicitly, it defaults to the contents of an environment variable with the same name.
Local properties, which only affect the scope of the containing XML element (node, group, etc...) are declared with the <Local Name="Foo" Value="Bar"/> element, and will override a similarly named global property for the local property's scope.
Any elements can be conditionally defined via the "If" attribute, and are largely identical to MSBuild conditions. Literals in conditions may be quoted with single (') or double (") quotes, or an unquoted sequence of letters, digits and underscore characters. All literals are considered identical regardless of how they are declared, and are considered case-insensitive for comparisons (so true equals 'True', equals "TRUE"). Available operators are "==", "!=", "And", "Or", "!", "(...)", "Exists(...)" and "HasTrailingSlash(...)". A full grammar is written up in Condition.cs.
File manipulation is done using wildcards and tags. Any attribute that accepts a list of files may consist of: a Perforce-style wildcard (matching any number of "...", "*" and "?" patterns in any location), a full path name, or a reference to a tagged collection of files, denoted by prefixing with a '#' character. Files may be added to a tag set using the <Tag> Task, which also allows performing set union/difference style operations. Each node can declare multiple outputs in the form of a list of named tags, which other nodes can then depend on.
Build graphs may be executed in parallel as part build system. To do so, the initial graph configuration is generated by running with the -Export=<Filename> argument (producing a JSON file listing the nodes and dependencies to execute). Each participating agent should be synced to the same changelist, and UAT should be re-run with the appropriate -Node=<Name> argument. Outputs from different nodes are transferred between agents via shared storage, typically a network share, the path to which can be specified on the command line using the -SharedStorageDir=<Path> argument. Note that the allocation of machines, and coordination between them, is assumed to be managed by an external system.
A schema for the known set of tasks can be generated by running UAT with the "-Schema=<FileName>" option. Generating a schema and referencing it from a BuildGraph script allows Visual Studio to validate and auto-complete elements as you type.
#rb none
#codereview Marc.Audy, Wes.Hunt, Matthew.Griffin, Richard.Fawcett
#tests local only so far, but not part of any build process yet
Change 2903539 on 2016/03/10 by John.Pollard
Improve replay playback debugging of character movement
#rb none
#tests replays
Change 2903526 on 2016/03/10 by Ben.Marsh
Remake changes from //UE4/Main without integration history, to add support for BuildGraph tasks.
#rb none
#tests none
Change 2903512 on 2016/03/10 by Dan.Youhon
Modify minimum Duration values for JumpForce and MoveToForce ability tasks so that having minimum Duration values doesn't trigger check()s
#rb None
#tests Compiles
Change 2903474 on 2016/03/10 by Marc.Audy
Fix crash if ChildActor is null
#rb None
#tests None
Change 2903314 on 2016/03/10 by Marc.Audy
Fix ParentComponent not being persisted and fixup content that was saved in the window it was broken
#rb James.Golding
#tests Selection of child actors works as expected
#jira UE-28201
Change 2903298 on 2016/03/10 by Simon.Tovey
Disabling the trails optimization.
#tests none
#rb none
#codereview Olaf.Piesche
Change 2903124 on 2016/03/10 by Robert.Manuszewski
Small refactor to pak signing to help with exe protection
#rb none
#tests none
[CL 2907678 by Andrew Grant in Main branch]
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2888098 on 3/1/2016 by Nick.Darnell
Adding back the SetWidgetToFocusOnActivate call and deprecating it. Will need to also do this in 4.11.
#lockdown Nick.Penwarden
Change 2851669 on 2016/02/01 by Alexis.Matte
#jira UE-25928
Skeletal mesh import now support _skinXX that are not sequential.
Static mesh was already supporting non sequential _skinxx ordering
#codereview nick.darnell
Change 2851672 on 2016/02/01 by Alexis.Matte
#jira UE-25971
The proxy camera mesh is now properly reset to zero
#codereview nick.darnell
Change 2851675 on 2016/02/01 by Alexis.Matte
#jira UE-25525
Update the tooltips
#codereview nick.darnell
Change 2851764 on 2016/02/01 by Alexis.Matte
#jira UE-25595
The fbx plus and minus icons are now brighter
#codereview nick.darnell
Change 2852116 on 2016/02/01 by Bob.Tellez
#UE4 Submitting pull request 2013 from GitHub (Pull request 2013). Thanks for the fix hoelzl!
Fix file selection when reimporting curve from moved CSV file
When reimporting a data curve after moving the CSV file from which it was generated, the file selection dialog does not present an option to select CVS files. This patch fixes the issue by assigning the correct 'SupportedClass' value for `UReimportCurveFactory` instances.
#codereview Nick.Darnell
#JIRA UE-26247
#2013
Change 2852375 on 2016/02/02 by Richard.TalbotWatkin
Spline component improvements: added facility to not restore component instance cache after the construction script has run, so the points can act as inputs to the construction script. Created a new property bInputSplinePointsToConstructionScript for that. Added SetUpVectorAtSplinePoint, and corrected some bugs.
#jira UE-24931 - Set Location at Spline Point doesn't do anything
Change 2852726 on 2016/02/02 by Richard.TalbotWatkin
Fixed FPropertyChangedEvent::GetArrayIndex when called from PostEditChangeProperty.
#jira UE-25316 - PropertyChangedEvent.GetArrayIndex broken
#codereview Robert.Manuszewski
Change 2853152 on 2016/02/02 by Jamie.Dale
Fixed multi-line editable texts not updating their font when changed in UMG
Also made all the SetStyle functions use the default if they're passed null (to match SEditableTextBox), and tidied up some of the property panel layout when editing styles.
#codereview Chris.Wood
Change 2853220 on 2016/02/02 by Alexis.Matte
#jira UE-26303
We now apply the scene option transform to the vertex of meshes instead of the root node of the scene. This allow re-alignment of the mesh to go with animation.
#codereview nick.darnell
Change 2853282 on 2016/02/02 by Alexis.Matte
Back out changelist 2853220
Change 2854211 on 2016/02/03 by Nick.Darnell
Widget Reflector - Limit the minimum scale that can be applied to something more reasonable 50%, instead of 10%.
Change 2854216 on 2016/02/03 by Nick.Darnell
Scene Viewport - The scene viewport handles application scale better now, allowing click locations to be interepreted correctly and transformed into pixel hit location, rather than local space widget location, which may not match.
Change 2854220 on 2016/02/03 by Nick.Darnell
Slate - Allowing mousewheel or gesture to be routed directly for a widget path like has been done for other mouse events, this permits more kinds of mouse like actions in a VR environment onto widgets in the scene. (not actually hooked up to do it, but this now permits it at the slate level to be done correctly).
Change 2854449 on 2016/02/03 by Alexis.Matte
-Fix the fbx import options, for the scene transform value that was not apply correctly
-Add an inspector on the scene import option in the reimport dialog
Change 2855659 on 2016/02/04 by Alexis.Matte
-Fix the bake pivot when there is a hierarchy, we now accumulate the pivot effect in the hierarchy to place the object at the correct place.
#codereview nick.darnell
Change 2855922 on 2016/02/04 by Alexis.Matte
#jira UE-26303
The animation is now align with the imported skeletal mesh, the bakepivot is also supported
#codereview nick.darnell
Change 2856989 on 2016/02/05 by Jamie.Dale
Some improvements to the source code loc gatherer
* We now strip any comments out of any pre-processor tokens before we start handling them.
* Fixed a case where "#if defined" and "#elif defined" would parse incorrectly.
* Fixed a case where "#define LOCTEXT_NAMESPACE" and "#define LOC_DEFINE_REGION" may not be paired correctly with their corresponding "#undef".
[CL 2888106 by Nick Darnell in Main branch]
#lockdown Nick.Penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2720537 on 2015/10/07 by Aaron.McLeran
Audio Optimization: Implementing an audio update delta time so audio isn't updated with every engine tick
Change 2746582 on 2015/10/29 by Aaron.McLeran
Implementing single ray-cast sound occlusion
- Fixing/Implementing sound occlusion using one ray cast
- Update rate of the ray cast is conifgurable by the user
- User can enabled/disable occlusion and set various properties of the occlusion at the audio component level
- Occlusion ray-casts are made at a slower rate than the audio engine is updated
- The following properties are supported:
* LowPassFilterFrequency (the LPF cutoff frequency of the per-voice filter to apply if a sound is occluded)
* OcclusionVolumeAttenuation (the volume attenuation to apply to sounds that are occluded)
* OcclusionInterpolationTime (how fast a sound moves from occluded to unoccluded... allows user-defined interpolation times, avoids fast parameter setting for smoother transitions)
- Fixed how low-pass filter frequency is applied on platforms that support it.
* Changed the older HighFrequencyGain parameter to a more understandable and correct LowPassFilterFrequency parameter
* Updated the parameter for the various other features that use per-voice LPF (e.g. audio volumes, distance-based filtering)
* Added backward-compatibility code to take old HighFrequencyGain params to new LowPassFilterFrequency params.
* At the lowest level, there is only one filter which is applied to a sound, but the parameter that has the lowest cutoff frequency is the one used
* Fixed how the parameter is applied at the lower-level in XAudio2 and CoreAudio. The old parameter was incorrectly applied.
* XAudio2 documentation on the low-pass-fitler frequency cutoff param is confirmed incorrect through testing.
#rb zak.middleton
Change 2765174 on 2015/11/12 by Aaron.McLeran
UE-23091 More fixage for NaN audio log spam
Last checkin for this (CL 2760896) was fixing a legit issue but there was still an issue that I was rarely catching during the FN gate encounter in AITestbed after about 5 min of gate defense.
To track down, I added a lot more logging and asserts on NaN numbers in the audio code, enabled ENABLE_NAN_DIAGNOSTIC in UnrealMathUtility.h.
- Was able to trace another cause of the NaNs in audio to 2 uninitialized variables in SoundAttenuationSettings struct: OmniRadius and StereoSpread.
- Zak M suggested the change of the const ref position vector in ListenerPosition and the usage of GetSafeNormal() in Audio.cpp since the value returned by GetLocation() is a temporary and Normalize() is unsafe.
- I removed the flag for the XAudio2 call to compute doppler since we don't use that value and it could've been as source of more NaNs in X3DAudioCalculate
#codereview Zak.Middleton
#rb Zak.Middleton
Change 2765467 on 2015/11/13 by James.Golding
- Allow -ms option to work with 'stat dumphitches' for controlling min time logged
#rb gil.gribb
Change 2765746 on 2015/11/13 by Benn.Gallagher
Added buckets for update rate shift tags (for staggering anim updates)
#jira UE-23213
#rb Bruce.Nesbit
Change 2765747 on 2015/11/13 by Benn.Gallagher
Fixes for bone length calculation in anim dynamics chains.
#rb Bruce.Nesbit
Change 2765749 on 2015/11/13 by Benn.Gallagher
Removed allocations from local CS blends for skeletal controls.
#rb Bruce.Nesbit
Change 2765752 on 2015/11/13 by Benn.Gallagher
Lod mapping support for URO customization
#jira UE-23211
#rb Bruce.Nesbit
Change 2765965 on 2015/11/13 by Marc.Audy
Remove outdated code in LoadMap previously used for matching up downloaded packages from servers. These code paths no longer operate, but in the case where a PIE client was connecting to a non-PIE server (not really supported, but possible), it would cause the Editor Level package to be flagged as as PIE package and cause a crash on exit of PIE
#jira UE-21181
#rb Josh.Markiewicz
Change 2766071 on 2015/11/13 by Mieszko.Zielinski
Fixed dumb mistake in AEQSTestingPawn::PostLoad #UE4
the 'bTickDuringGame == bTickDuringGame' thing
#rb John.Abercrombie
Change 2766086 on 2015/11/13 by Mieszko.Zielinski
Exposing NavModifierComponent to ENGINE_API #UE4
#codereview Lukasz.Furman
Change 2766345 on 2015/11/13 by Mieszko.Zielinski
No longer compiling AISystem's creation out from client builds #UE4
Instead AISystem's instantiation on clients is configurable via UAISystemBase::bInstantiateAISystemOnClient config variable
Change 2766346 on 2015/11/13 by Mieszko.Zielinski
Improvements to EQS test scoring function preview #UE4
#rb Lukasz.Furman
Change 2766528 on 2015/11/13 by Stan.Melax
multiple materials/chunks on a single cloth sim mesh
This supposedly used to work in 4.7 but broke for 4.8
It looks like previous change 2493547 may have introduced the condition statement that makes multiple materials not include all of there verts.
Changing this to instead check for the bounds on the skinningmap instead of the NumRealSimVerts which doesn't look like it takes the offset into consideration.
jira:
#UE-23300
https://jira.ol.epicgames.net/browse/UE-23300https://answers.unrealengine.com/questions/287833/apex-not-working-on-multiple-materials-since-48.html
Double tested code change with test asset from https://jira.ol.epicgames.net/browse/UE-10674
#rb Benn.Gallagher
Change 2766546 on 2015/11/13 by Marc.Audy
Throw warning for orphaned looping sounds caused by a looping sound node
Don't do somewhat expensive (due to weak pointer) orphaned sound checks in test or shipping
#rb Aaron.McLeran
Change 2766917 on 2015/11/14 by Jurre.deBaare
Fix UE4-23349 Simplygon doens't support sub 64 pixel textures
Change 2767742 on 2015/11/16 by Marc.Audy
Restructure SignificanceManager to store significance manager references in a FGCObject Module class instead of using a singleton.
Improve performance by eliminating StaticFindObjectFast calls in ::Get and force inlining Get calls
#rb Zak.Middleton, Rob.Manuszewski
Change 2767827 on 2015/11/16 by Zak.Middleton
#ue4 - Perf: avoid SmoothClientPosition() calls once the target mesh offset has been reached.
- New flag bNetworkSmoothingComplete indicates whether smoothing has reached the destination. This is set to false when a new network position is received.
- Also fixes trying to smooth rotation towards identity rotation before receiving network updates.
- Deprecated FNetworkPredictionData_Client_Character::CurrentSmoothTime in favor of saving last update time, to prevent needing to update time every tick (since we skip updates now).
#rb Dan.Youhon
Change 2768070 on 2015/11/16 by Marc.Audy
Change StaticDuplicateObject and DuplicateObject to take FName instead of char* (existing usages can automatically convert to FName so no backwards compatibility issues)
Fixup usages to avoid unnecessary string -> char* -> name conversions
Change AActor::CreateComponentFromTemplate to take an FName instead of FString, deprecated FString version
#rb Gil.Gribb
Change 2768121 on 2015/11/16 by Marc.Audy
Forceinline GetFName
Change 2768161 on 2015/11/16 by Aaron.McLeran
Checking occlusion back in
- Bug was due to improper interpolation of LPFFrequency values in audio volumes.
Change 2769428 on 2015/11/17 by Thomas.Sarkanen
Fixed backwards-compatibility issues with FExposedValueCopyRecord
Added PostSerialize function to patch up older data to the new format (copies properties->property FNames).
Made sure to zero FExposedValueCopyRecord in its constructor, prevents uninitialized variable issues when generating CRCs. This is necessary despite these members being UPROPERTYs because they are simply built on the stack then stuffed into the new CDO during compilation.
UE-23268 - EDITOR CRASH: Assertion failed: ((UObject*)ContainerPtr)->IsA((UClass*)GetOuter())
#rb James.Golding
#codereview Mike.Beach,Bob.Tellez
Change 2769488 on 2015/11/17 by Benn.Gallagher
DrawCanvas and debug string support for skeletal controls - accessed using "Skeletal Controls" option in Show->Display Info in Persona
#rb Martin.Wilson
Change 2769545 on 2015/11/17 by Benn.Gallagher
Added space conversion options to copy bone node.
#jira OR-9430
#rb Martin.Wilson
Change 2770228 on 2015/11/17 by Marc.Audy
Fix cause of assert firing when detaching if AttachTo(AttachParent) returns false
#rb Ori.Cohen
#jira UE-23366
Change 2770489 on 2015/11/17 by Marc.Audy
Make ::Serialize WITH_EDITORONLY_DATA since it did nothing otherwise
Change 2770761 on 2015/11/17 by Aaron.McLeran
Removing optimization disablement
- Forgot to remove these lines before checking in/testing.
Change 2771375 on 2015/11/18 by Thomas.Sarkanen
Added initialzation of internal state machine desc ptrs to (finally) remove random crashes when using sub-state machines
#rb Benn.Gallagher
Change 2771697 on 2015/11/18 by Jeff.Farris
Sensible defaults for APlayerController::ClientPlayCameraAnim and ClientPlayCameraShake
#rb marc.audy
Change 2771755 on 2015/11/18 by Marc.Audy
Put back in the recursion block for destroy actor
#rb James.Golding
Change 2772217 on 2015/11/18 by Marc.Audy
Update axis inversion to work the same way as sensitivity instead of old problematic way
Also change to use Reset instead of Empty(Array.Num())
#rb Jeff.Farris
Change 2772686 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization coordinate bug.
Don't need to convert to xaudio2 coordinates for HRTF spatialization
#rb chad.taylor
Change 2772766 on 2015/11/18 by Aaron.McLeran
Fixing HRTF spatialization with xaudio2 voice pools
- Issue was caused by 2 issues:
- effect chains weren't properly clearing their state between uses (SetEffectChain(nullptr) releases the effect for use with other voices)
- Not re-setting MaxEffectChainChannels = 0 in CreateSource() was causing re-used SoundSources to release their XAudio2 voices to the wrong pool.
#rb chad.taylor
Change 2773027 on 2015/11/19 by Thomas.Sarkanen
PR #1765: Git Plugin can find the git.exe binary installed on the Local AppData user directory (Contributed by SRombauts)
#rb Thomas.Sarkanen
Change 2773142 on 2015/11/19 by Benn.Gallagher
Optimized SafeSetCSBoneTransforms, no longer doing 2 iterations over the whole pose.
- Only iterating beyond the index of the first bone transform, cutting off all bones before
- No longer using a bone mask the size of the skeleton, just an array of interesting nodes
- No longer attempting to convert a transform if it isn't necessary (which was happening a lot)
#rb Laurent.Delayen
Change 2773212 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Removing ugly comment. Not going to remove the node itself for backward compatibility.
Change 2773351 on 2015/11/19 by Zak.Middleton
#orion - Make sure we don't skip a final visual update when character mesh interpolation tries to stop smoothing once it reaches its destination. We keep setting bNetworkSmoothingComplete to false until the first visual update, at which point if it remains true we will stop getting updates.
#rb Dan.Youhon
Change 2773599 on 2015/11/19 by Marc.Audy
Fix shadow variable, initialization order, and incorrect placement of ENGINE_API that fails compiles on clang
#codereview Aaron.McLeran
Change 2773661 on 2015/11/19 by Richard.Hinckley
#jira UEDOC-2685
Following up by deprecating the CastToPlayerController function for 4.11.
Change 2774707 on 2015/11/19 by Stan.Melax
FCollisionQueryParams constructor API pitfall
Deprecating something that will call the unintended constructor if the programmer provides a string literal instead of explicitly creating an FName.
So this line of code:
FCollisionQueryParams Param(FName(TEXT("DragDropTrace")));
will invoke:
FCollisionQueryParams::FCollisionQueryParams(FName,bool=false,...)
But this line of code:
FCollisionQueryParams Param(TEXT("DragDropTrace"));
invokes:
FCollisionQueryParams::FCollisionQueryParams(bool)
Yes that actually happens, the string literal (the TEXT("whatever")) ends up specifies a bool parameter instead of a FName parameter. So the name is lost and a flag (that is usually set to false) is now set to true (since the string literal address is non-NULL). Yeah, that's could potentially be not what the programmer had intended.
It looks like this interface was introduced in CL 1792949
back in august 2013. Since its been a couple of years, we'll phase it out using the deprecation approach.
Making an API change would break things for existing projects.
If it had been a more recent change we could have probably just gone down to a single constructor right away.
Figured out that going one step further and removing bool param's default and adding a default constructor would minimize the number of places that will be hit with this deprecation. So, yes this is *increasing* the number of construtors temporarily, but this solution has minimal impact on the community. Later after other to-be-deprecated constructor gets removed, the two remaining can be combined into one with defaults for all parameters.
see also
https://udn.unrealengine.com/questions/269512/dangerous-fcollisionqueryparams-overloads.html
#codereview ori.cohen
[CL 2775460 by Marc Audy in Main branch]
Added new property to all EnvQueryTests: TestComment. This is a simple string used to optionally label the purpose for a test.
For now, it only shows up in the details view, but eventually we will surface this comment for users in a better UI manner so it can be easily seen when viewing the EQS data asset.
#ReleaseNoteNeeded
--------
Integrated using branch Ue4-To-UE4-Fortnite-Simple (reversed) of change#2699000 by Daniel.Broder on 2015/09/21 10:56:38.
[CL 2699005 by Daniel Broder in Main branch]
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.
#codereview Robert.Manuszewski
[CL 2481343 by Jaroslaw Palczynski in Main branch]
The reason behind it being it was possible to get wrong results by not using * operator on the iterator, resulting in it being cast to bool first, then to int, which in most use cases resulted in simply getting results for actor at index 1
#codereview Daniel.Broder
[CL 2391030 by Mieszko Zielinski in Main branch]
CL#2272587
Added "BlueprintReadWrite" to bNoneIsAllowedValue in FBlackboardKeySelector to avoid breaking any usage of it in blueprints through Break node which people were already using. That matches the usage for AllowedTypes, which is conceptually a related idea and was already set to BlueprintReadWrite.
CL#2272599
Fixed crash when AI were killed in the same frame they were spawning into the world.
CL#2274068
behavior tree search can be reverted, task will be aborted AFTER finding a valid replacement
fix for move action crashing on pawn's death
CL#2274177
fixed behavior tree's search range when there are mutliple restart requests in the same frame
CL#2274359
Fixes RotateToFaceBBEntry not working correctly when focusing on an actor
- the GetFocalPoint call to AIController had different behavior if you called it with a priority vs. without
- with a priority we would just look at the Priorities and return the position, but that position was never being updated for Actors
- without a priority we would go through all the priorities, check for an Actor, and if it existed we would return its location
- while I could have just modified the RotateToFaceBBEntry call to just call GetFocusActor for the appropriate focus priority, this seems like the better fix)
- solution was to make the GetFocalPoint with a focus priority work exactly like the one without the focus priority. while I would have liked to reduce the copy/paste code between the functions it didn't seem like a good idea.
Also fixed Precision not considering vectors that were in the same direction (>= vs just > with the angle threshold value)
CL#2274719
Fix crash related to AnimCameraActor.
TTP #344968 CRASH: TAKER: If the world owner leaves the game in the middle of a Taker Soul sucking another player, the Client will crash.
CL#2274988
#UE4 Proper handling of saving level assets that were created without a valid non-read only path. TTP#344899
CL#2275045
#UE4: Include "IHttpBase.h" in IHttpResponse.h since it's using a base class from there (they're truly dependent). Would be nice if this file just had the enum though.
CL#2275152
TTP# 336668
Moved the input check for VOIP from the child widgets into the base SFortHUDLayer to capture that event on different screens. Removed code duplication.
CL#2275528
Fixed StaticMeshComponent destruction blocking on the rendering thread instead of using the UObject async destruction interface
CL#2275960
fixed behavior tree search being discarded after merge with non discardable request
decorator observers will be added even after failed search
CL#2276294
Added support to EQS "Dot" test for 2D dot-product AND taking absolute value of dot-product (for biasing for lateral over forward/back).
They are separate options which can be used together or separately.
CL#2277344
fixed BT decorator indices for abort range preview in editor
CL#2277473
NavCollision settings of static mesh will persist through reimport
ttp# 344853
CL#2277509
fixed multiple nodes connected to special pins in behavior tree editor
CL#2278042
Fixes EQS not returning the best item when the last EQS test is a filter.
- To do this, on the last test if we know it's just a filter and eventually we will use the first item that passes the test, then we sort prior to filtering.
Made the filter and score test types display "Filter Only" & "Score Only"
CL#2278111
Improved EQS Dot test "Description Title" to display "Absolute" and " 2D" as appropriate.
CL#2278115
Added "Random" EQS test, which can be used for adding a random value to items.
Potentially needed for hunting EQS query Phil is working on, and should be useful for other cases as well.
CL#2278286
Fixes crash when trying to use the VisLog due to a spelling correction made in CL 2276628.
CL#2281762
Moved VLOG in Vlog Redirect function to avoid ensure
- Ensure was caused because we were trying to log to a redirect when the redirect hadn't be set yet
CL#2282248
Fixed EQS "Random" test to work with ANY query item type, not just VectorBase item types.
CL#2282639
Enhanced debug information data for single item in EQS Debugger (GameplayDebugger feature) #ue4
- Fixed few compilation issues with disabled USE_EQS_DEBUGGER flag
- Fixed crash in EQSRenderingComponent
- Fixed EQS debug data for sorted EQS itesm (it's slower way to sort items but only with active USE_EQS_DEBUGGER flag)
CL#2282678
fixed crash on reimporting static mesh without NavCollision data
ttp# 345454
CL#2282919
Renamed BTTask_MoveDirectlyToward.bForceMoveToLocation to more clear bDisablePathUpdateOnGoalLocationChange #UE4
- also fixed a bug in FortBTTask_GameMoveDirectlyToward that was misusing that variable. This addressed TTP#343489
CL#2282927
Fixed paths rendering while using GameplayDebugger (client/server too) #Fortnite
CL#2283374
Fixes crowd following AIs (ie. regular husks) trying to rotate in the direction of their CrowdAgentMoveDirection while falling or not moving
(Fixes ttp 344776)
CL#2283475
Comment/code refactor that occurred but wasn't saved prior to check in of CL 2283374
CL#2283644
#UE4 Fix various issues seen when changing graphics settings with r.detailmode causes all components to reregister
Fix it so particle system components track if they were active when unregistering, reactivate on next register if true
Fix it so character movement components don't throw away timestamp data on unregister, this broke networking entirely
Fix it so single anim skeletal meshes restore state accross reinitializations
CL#2283688
Make bPendingKillPending no longer a UProperty so it won't be serialized.
Fixes TTPs 342221, 342634
CL#2283879
#UE4 Fix it so the scalability settings are correctly written to the user config file when saving settings, and are properly reset to in memory values when reset. Has been broken since they got refactored.
CL#2284368
fixed crash on using blueprint-based EQS contexts in PIE
CL#2284405
HotSpots auto expire #UE4
Also, Fortnite-specific:
- made FortAIHotSpotManager the owner of hotspots spawning process
- added support for having multiple hotspots assigned to one BuildingSMActor, one per approach vector
CL#2285167
Fixed Fortnite client to match FriendsService API change for pending invites
CL#2285650
#UE4: Allow JsonObjectConverter to convert Strings to FDateTime fields using ISO-8601
CL#2286127
fixed pathfinding eqs test
CL#2286208
fixed EQS tests reverting to Score Only settings after reopening editor
ttp# 345719
CL#2286296
Game Invites work in Fortnite again
Fixed game to match a backend API change
CL#2286378
Removing TickAnim from InitAnim as that seems unnecessary and should avoid if we can.
CL#2286408
- TTP#345476 Slate: Fixed MenuPlacement_AboveAnchor not being respected.
CL#2286777
Fixed bug in GameplayDebuggingComponent which would cause debug display of EQS queries sharing the same name never to update after the initial query of a certain name is made. (In Fortnite, Goal Manager queries all have the same name, and the data would never update. In fact, even choosing a second actor would not clear out the data from the earlier actor, because they weren't updating data when the Timestamp updated.)
CL#2289211
Fix for TTP #345752 "CRASH: DEDICATED SERVER: ToggleAILogging with a gate active causes a server crash"
CL#2289279
LatentActionManager: value from iterator (over ObjectToActionListMap) was invalidated, when ObjectToActionListMap was changed.
Unique Ptr should be used instead of SharedPtr, but UniquePtr is currently not compatible with TMap.
CL#2289897
Fixes flying AIs (like the Taker) trying to move their feet to their destination, causing them to float higher than they should be.
CL#2290041
Fix a number of properties in the Action_Move hierarchy that aren't exposed and therefore aren't duplicated when we duplicate Pawn Actions.
CL#2290210
#UE4 Fix it so UEngine::ShutdownWorldNetDriver shuts down all net drivers associated with a world and not just a primary one. Fixes a crash when transferring maps with an active beacon net driver. Also fix issue where UEngine::ShutdownAllNetDrivers would miss some net drivers due to indexes being removed
- Duplicating actions occurs as part of adding a Pawn Action Sequence comprised of multiple Pawn Actions. The bug causes undesired behavior because the properties that were set on the initial Pawn Action are not carried over to the duplicate.
- We will continue to use the feet location as the origin of the Actor for determining requested velocity with walking AIs, but use the Actor's location as the origin for non-walking AIs
CL#2290255
#UE4 Fix to previous netdriver checkin, only kill world net drivers if the world is actively set, idle net drivers are fine and needed for beacons to work properly
CL#2290585
Fixed some PawnActions' bool properties not being marked as UPROPERTIES #UE4
It was resulting in copied actions loosing parts of its configuration.
Also:
- added a parameter to PawnAction_Move to controll "finish on overlap" path following behavior
CL#2290675
Extended GameplayDebugger view in Simulation. I added a way to switch debug views, to have all functionality from PIE. #ue4
CL#2290778
fixed invalid nav nodes in paths after offseting
CL#2290784
moved pathfollowing's reachability test out of FollowPathSegment function (it's supposed to handle only velocity calculations), agent will always use feet location for moving on path segment
CL#2292104
Fixes for GameplayDebugger, it mostly fixes activation in different configurations (PIE, standalone, client-server, etc.).
CL#2292198
Fixed issues related to NavMesh rendering and EQS query switching for GameplayDebugger. #ue4
CL#2292766
Fixed crash if touch event without valid MovieStreamer
CL#2292967
GameplayDebuggingComponent now tries to pick the correct nav-mesh for the selected actor, rather than always displaying the default nav-mesh.
NOTE: If you switch from one actor to another with nav-agent properties that are associated with different nav-meshes, it may continue to display the original nav-mesh for a while until it needs to update the position where the nav-mesh should display.
CL#2293116
#UE4 #HTTP: Make LibCurl reuse connections by default on windows/android to mirror the change in CL# 2025870. Also added [Networking]UseLibCurl as an option to have LibCurl get used in addition to command line.
CL#2293217
Added suffix override to allow StagingInfo instances without platform in the staging path
This is to handle where platform is already in each build product instead of as a root dir, eg. \\WindowsClient instead of \\Windows\\WindowsClient
CL#2293263
#UE4: Make JsonObjectConverter skip null values in arrays and structs (this is consistent with skipping missing keys)
CL#2293534
fixed parent node usage in navigation octree (navmesh stays unchanged after deleting an actor)
CL#2293536
fixed updating parent chain in navoctree after removing last attached node
CL#2293543
changed navigation octree parent map to use weak object pointers (merged from main)
CL#2293952
Changes/improvements to curl http module:
- Properly get bUseCurl from a configuration file.
- Do less work when creating requests (checking commandline settings moved to CurlHttpManager).
- Do not init/shutdown unless actually used.
CL#2294062
Added virtual function OnCharacterStuckInGeometry for Characters that get stuck in geometry to CharacterMovementComponent
- Allows subclasses to define behavior when this occurs
- Comment states that this only will be called when the character is walking
[CL 2305577 by Bob Tellez in Main branch]