Commit Graph

966 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Yoan StAmant
0b7b1f2f92 [EQSTestingPawn] refresh display and query on Undo/Redo
#jira UE-112041
#rb mieszko.zielinski
#preflight 627b9ddc0a5817c9d940a967

[CL 20136400 by Yoan StAmant in ue5-main branch]
2022-05-11 07:42:15 -04:00
Mieszko Zielinski
3fcbacfc7e Fixed FGameplayDebuggerCategory_EQS's FEQSRenderingDebugDrawDelegateHelper not getting set up properly
The issue resulted in EQS's item scores not getting displayed in gameplay debugger.

#review-20039272
#jira UE-151005
#preflight 627274867b6d0faffa6b7b33

[CL 20040972 by Mieszko Zielinski in ue5-main branch]
2022-05-04 09:38:41 -04:00
Stephen Holmes
0164cbb79d GitHub 8649 : Added ReportTouchEvent function for touch sense (AI module)
#preflight 6262a500bc24759dc735c568
#review
#rb @Mieszko.Zielinski
#8649
#jira UE-135576

[CL 20039770 by Stephen Holmes in ue5-main branch]
2022-05-04 07:13:03 -04:00
Stephen Holmes
cb5c589a60 GitHub 8453 : Avoid nullptr dereference when the Crowd Manager is missing
#jira UE-130073
#8453
#review-19864876
#preflight 6262c2ebe87284a93cd12b33

[CL 20039542 by Stephen Holmes in ue5-main branch]
2022-05-04 06:40:06 -04:00
Stephen Holmes
39b64cf0bf Added Log to make it clearer when a perception component is not attached to a controller. Some of the sense to do not function under these circumstances.
#jira UE-114033
#review-19861865
#preflight beaa4606a014a256fd4

[CL 19862656 by Stephen Holmes in ue5-main branch]
2022-04-22 06:43:16 -04:00
douglasjose
a76d51fe56 PR #9092 - fix spelling of "continuous" in the Blueprint node "AI > Tasks > Move To Location or Actor" (and elsewhere). Thank you for the submission, douglasjose!
https://github.com/EpicGames/UnrealEngine/pull/9092


#jira UE-149320
#preflight 625da0d0b21bb49791c4a531
#rb lauren.barnes
#fyi martin.sevigny

[CL 19790872 by douglasjose in ue5-main branch]
2022-04-18 14:30:53 -04:00
yoan stamant
3bbbdfbca9 [GameplayBehavior] renamed manager to subsystem and converted to a world subsystem. This removes our last dependency on the newly deprecated TDefaultManagerInstanceTracker
#rnx
#jira UE-148445
#rb mikko.mononen
#preflight 6255b50b3f5641db59ff0cc0

#ROBOMERGE-OWNER: yoan.stamant
#ROBOMERGE-AUTHOR: yoan.stamant
#ROBOMERGE-SOURCE: CL 19726266 via CL 19727323 via CL 19727832
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19733198 by yoan stamant in ue5-main branch]
2022-04-12 21:16:50 -04:00
Matt Peters
b44fab825a UWorld: Remove NewWorld argument from CleanupWorldInternal, and replace it with bWorldChanged. bWorldChanged was being incorrectly calculated in the recursive CleanupWorldInternal calls on streaming levels, resulting in them incorrectly setting bUnloadFromEditor=true when the toplevel CleanupWorld was called from CleanupLevelThatWasInitializedFromSave during cooking, resulting in indeterminism in the cook due to removing RF_Standalone flags.
#jira UE-147729
#rb Patrick.Enfedaque
#rnx
#preflight 62559c8acd5ed4dd09184417

[CL 19723275 by Matt Peters in ue5-main branch]
2022-04-12 12:22:43 -04:00
ilya loshchinin
d43cacb9b7 Fixed DefaultManagerInstanceTracker not properly subscribing to OnPostWorldCleanup delegate, causing an occasional failed assertion (!IsRooted()) at world destruction time, depending on the order of static initialization.
#rb Mieszko.Zielinski
#preflight 624ae6de470aff98e9a032ed

#ROBOMERGE-AUTHOR: ilya.loshchinin
#ROBOMERGE-SOURCE: CL 19608302 via CL 19608334 via CL 19608370
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19609210 by ilya loshchinin in ue5-main branch]
2022-04-04 10:58:32 -04:00
BenAD83
3ba8c20883 PR #9005: Fix EEnvTestScoreOperator Multiply (Contributed by BenAD83)
#review-19524468
#preflight skip

[CL 19524504 by BenAD83 in ue5-main branch]
2022-03-28 04:33:25 -04:00
joe zabriskie
d88eacdda1 AIController - Provide protected overridable StopBrainComponent function
#ROBOMERGE-AUTHOR: joe.zabriskie
#ROBOMERGE-SOURCE: CL 19472915 via CL 19472922 via CL 19472928 via CL 19488878 via CL 19489006
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v936-19480137)

[CL 19489786 by joe zabriskie in ue5-main branch]
2022-03-23 20:34:40 -04:00
Maxime Mercier
d519315189 Show the sight/lose sight radius number in the gameplay debugger
Github #7079 tag

#jira UE-94656
#review
#rnx
#preflight 6234cbe8e14776a6ebd35b8d

[CL 19439100 by Maxime Mercier in ue5-main branch]
2022-03-18 14:26:31 -04:00
Maxime Mercier
ce531e0d8f Fix range loop being change while iterating through stimuli in AI perception component
#jira UE-136950
#review-19438062
#rb Mieszko.zielinski
#preflight 6234cbbada56b5683ac967b8

[CL 19439061 by Maxime Mercier in ue5-main branch]
2022-03-18 14:24:37 -04:00
marc audy
cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
dave jones2
5b99600dfb [Backout] - CL18941178
[FYI] dave.jones2
#jira UE-140854
#prelight 62153898c06cac272ddc3c34
#rb julien.marchand
#lockdown julien.marchand

An executive decision was made to stick with "float" for "real" types.

Original CL Desc
-----------------------------------------------------------------
UE-140854 - Floats are still supported in Blackboard system

The easiest fix here is to update the metadata to display "real" instead of "float" where appropriate. The alternative would require class&function renaming, which involves fixup, and is likely not desirable during lockdown.

#rb mieszko.zielinski
#jira UE-140854
#preflight 620315019e10f6918e15c247
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 19082616 in //UE5/Release-5.0/... via CL 19097136
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140901 by dave jones2 in ue5-main branch]
2022-02-24 23:34:20 -05:00
stephan delmer
ec1dd2882d Changing the Pathfinding and PathfindingBatch EQS tests to use a function to get the nav filter.
#rb Daniel.Broder
#rnx

#ROBOMERGE-AUTHOR: stephan.delmer
#ROBOMERGE-SOURCE: CL 19028451 via CL 19028460 via CL 19028968 via CL 19029041 via CL 19029156 via CL 19031956
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v917-18934589)

[CL 19032180 by stephan delmer in ue5-main branch]
2022-02-17 03:44:22 -05:00
yoan stamant
45f30251c7 THierarchicalHashGrid2D::CalcCellBounds as a const method
#rnx
#rb aris.theophanidis

#ROBOMERGE-AUTHOR: yoan.stamant
#ROBOMERGE-SOURCE: CL 18960623 via CL 18961040 via CL 18961280 via CL 18963705 via CL 18964131
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18964160 by yoan stamant in ue5-main branch]
2022-02-11 17:57:24 -05:00
dave jones2
31362f7593 UE-140854 - Floats are still supported in Blackboard system
The easiest fix here is to update the metadata to display "real" instead of "float" where appropriate. The alternative would require class&function renaming, which involves fixup, and is likely not desirable during lockdown.

#rb mieszko.zielinski
#jira UE-140854
#preflight 620315019e10f6918e15c247
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18941178 in //UE5/Release-5.0/... via CL 18941648 via CL 18941886
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941893 by dave jones2 in ue5-main branch]
2022-02-10 15:22:00 -05:00
mieszko zielinski
f041d0ee86 Formally marked as deprecated EQS-configuration properties that have been annotated as deprecated for a long while now. The properties are to be removed entirely for 5.1.
#jira UE-140959
#preflight 61fa964adb42673a602ed580
#rb julien.marchand

#ROBOMERGE-AUTHOR: mieszko.zielinski
#ROBOMERGE-SOURCE: CL 18827202 in //UE5/Release-5.0/... via CL 18827229 via CL 18827545
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18827559 by mieszko zielinski in ue5-main branch]
2022-02-02 10:55:41 -05:00
fred kimberley
7fbfaf57c8 Require explicit constructors/casts when converting between FVector, FVector3d, and FVector3f.
#jira UE-122078
#rb Andrew.Davidson, Colin.McGinley
#preflight standard build

#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 18817999 in //UE5/Release-5.0/... via CL 18818012 via CL 18822871
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824721 by fred kimberley in ue5-main branch]
2022-02-02 07:59:31 -05:00
yoan stamant
ddc93930cb Fix localization issue #119824
[FYI] mieszko.zielinski
#preflight 61f7dd8abf3980c331f14727

#ROBOMERGE-AUTHOR: yoan.stamant
#ROBOMERGE-SOURCE: CL 18788432 in //UE5/Release-5.0/... via CL 18788434 via CL 18788479
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18788485 by yoan stamant in ue5-main branch]
2022-01-31 08:11:04 -05:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00
mieszko zielinski
4ebbb1b689 Added an option to EnvQueryGenerator_PerceivedActors to control whether all actors known to the AIPerceptionComponent will be gathered or only the ones actively, currently being perceived (like "visible at this very moment").
#preflight 61e687127f0c4b5aad56a991

#ROBOMERGE-AUTHOR: mieszko.zielinski
#ROBOMERGE-SOURCE: CL 18637533 in //UE5/Release-5.0/... via CL 18637633 via CL 18637709
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18637732 by mieszko zielinski in ue5-main branch]
2022-01-18 04:58:57 -05:00