Commit Graph

4 Commits

Author SHA1 Message Date
Ben Marsh
82d79d8289 UnrealVS: Fix remaining thread safety issues highlighted by static analysis.
* P4Commands now invokes a callback on UI thread for any UI operations
* StdOut and StdErr are now both returned when executing child processes to avoid contention on member variable
* Added locks around manipulating child process list.
* Fixed some issues where paths containing spaces were not quoted correctly
* Fixed detection of working directory where P4CONFIG is set to something other than p4config.txt.

[CL 17095905 by Ben Marsh in ue5-main branch]
2021-08-07 15:48:22 -04:00
Ben Marsh
0f44b8b446 UnrealVS: Fix thread safety warnings when building.
Mainly done by naively adding ThreadUtils.ThrowIfNotOnUIThread() in places where warnings occur and code looks likely to be on UI thread, then tested a few basic operations in the experimental instance. Remaining warnings look more problematic to solve; I will test these more closely and fix them in a future change.

[CL 17091658 by Ben Marsh in ue5-main branch]
2021-08-06 20:29:50 -04:00
Ben Marsh
fcd594e875 UnrealVS: Fix exception on startup due to missing configuration in launch settings.
[CL 17091060 by Ben Marsh in ue5-main branch]
2021-08-06 19:50:46 -04:00
Joe Kirchoff
e41d300382 UnrealVS: Move all code to a shared project
#rb none
#rnx

[CL 16712619 by Joe Kirchoff in ue5-main branch]
2021-06-17 17:40:28 -04:00