Commit Graph

4 Commits

Author SHA1 Message Date
Ben Marsh
5e93bf83a0 UnrealVS: Publish recent changes to fix crash on startup.
[CL 17268667 by Ben Marsh in ue5-main branch]
2021-08-23 12:29:58 -04:00
Ben Marsh
82d79d8289 UnrealVS: Fix remaining thread safety issues highlighted by static analysis.
* P4Commands now invokes a callback on UI thread for any UI operations
* StdOut and StdErr are now both returned when executing child processes to avoid contention on member variable
* Added locks around manipulating child process list.
* Fixed some issues where paths containing spaces were not quoted correctly
* Fixed detection of working directory where P4CONFIG is set to something other than p4config.txt.

[CL 17095905 by Ben Marsh in ue5-main branch]
2021-08-07 15:48:22 -04:00
Ben Marsh
0f44b8b446 UnrealVS: Fix thread safety warnings when building.
Mainly done by naively adding ThreadUtils.ThrowIfNotOnUIThread() in places where warnings occur and code looks likely to be on UI thread, then tested a few basic operations in the experimental instance. Remaining warnings look more problematic to solve; I will test these more closely and fix them in a future change.

[CL 17091658 by Ben Marsh in ue5-main branch]
2021-08-06 20:29:50 -04:00
andrew firth
44707451e9 [UnrealVS] - fixes and cleanup
- add option to allow async checkout
- resolved problems that caused with many commands running at once
- fix issue with P4V command waiting for exit
- resolve issue where Checkout on Edit was not honoring the user option
- add ReleaseNotes to the plugin
- add UpdateInstructions for future engineers

#rb none
#fyi luke.thatcher brandon.dawson

[CL 16877172 by andrew firth in ue5-main branch]
2021-07-16 23:44:50 -04:00