Commit Graph

84 Commits

Author SHA1 Message Date
sebastian nordgren
4497b3b0b8 Added commands to open File History, Revision Graph and Timelapse views from the UnrealVS.P4 menu.
Don't abort p4 checkout if the file is writable if the command is executed manually.

#review-18454959 @andy.firth
#preflight 61e58138006b17a6865a0327

[CL 18632973 by sebastian nordgren in ue5-main branch]
2022-01-17 09:59:30 -05:00
Ben Marsh
5e93bf83a0 UnrealVS: Publish recent changes to fix crash on startup.
[CL 17268667 by Ben Marsh in ue5-main branch]
2021-08-23 12:29:58 -04:00
andrew firth
5b7946ca6a [UnrealVS] - convert reconcile over to using local paths, add up* to the paths + small code review feedback
#review-17131056 @Ben.Marsh
#rb Ben.Marsh
(no new version of the VSIX)

[CL 17186244 by andrew firth in ue5-main branch]
2021-08-16 23:28:45 -04:00
andrew firth
401b9801a3 [UnrealVS] - enable warnings as errors
#review-17163679 @ben.marsh
#rb ben.marsh

[CL 17186213 by andrew firth in ue5-main branch]
2021-08-16 23:24:10 -04:00
Ben Marsh
82d79d8289 UnrealVS: Fix remaining thread safety issues highlighted by static analysis.
* P4Commands now invokes a callback on UI thread for any UI operations
* StdOut and StdErr are now both returned when executing child processes to avoid contention on member variable
* Added locks around manipulating child process list.
* Fixed some issues where paths containing spaces were not quoted correctly
* Fixed detection of working directory where P4CONFIG is set to something other than p4config.txt.

[CL 17095905 by Ben Marsh in ue5-main branch]
2021-08-07 15:48:22 -04:00
andrew firth
593972e94b [UnrealVS] - add p4FastReconcile
#review-17080114 @brandon.dawnson
#rb brandon.dawnson ben.marsh

[CL 17092844 by andrew firth in ue5-main branch]
2021-08-06 23:11:30 -04:00
Ben Marsh
0f44b8b446 UnrealVS: Fix thread safety warnings when building.
Mainly done by naively adding ThreadUtils.ThrowIfNotOnUIThread() in places where warnings occur and code looks likely to be on UI thread, then tested a few basic operations in the experimental instance. Remaining warnings look more problematic to solve; I will test these more closely and fix them in a future change.

[CL 17091658 by Ben Marsh in ue5-main branch]
2021-08-06 20:29:50 -04:00
Ben Marsh
fcd594e875 UnrealVS: Fix exception on startup due to missing configuration in launch settings.
[CL 17091060 by Ben Marsh in ue5-main branch]
2021-08-06 19:50:46 -04:00
Ben Marsh
120dd67343 UnrealVS: Fix compile errors due to ReleaseNotes.txt not existing in separate UnrealVS.2019 and UnrealVS.2022 directories.
#fyi Andrew.Firth

[CL 17089649 by Ben Marsh in ue5-main branch]
2021-08-06 18:36:50 -04:00
andrew firth
44707451e9 [UnrealVS] - fixes and cleanup
- add option to allow async checkout
- resolved problems that caused with many commands running at once
- fix issue with P4V command waiting for exit
- resolve issue where Checkout on Edit was not honoring the user option
- add ReleaseNotes to the plugin
- add UpdateInstructions for future engineers

#rb none
#fyi luke.thatcher brandon.dawson

[CL 16877172 by andrew firth in ue5-main branch]
2021-07-16 23:44:50 -04:00
andrew firth
cd92a4de9f [UnrealVS] - put CompileSingleFile back into the stub menu allowing UnrealVS.CompileSingleFile and add all other commands into the same stub allowing simple commandline/binding mechnisms
#rb none
#fyi joe.kirchoff

[CL 16831006 by andrew firth in ue5-main branch]
2021-07-12 16:26:23 -04:00
Joe Kirchoff
d01f5847b4 UnrealVS: Set minimum 2019 version to 16.9 and downgrade referenced nuget packages to match.
Updating nuget packages past the VS version prevents the extension from loading correctly.

#rb none
#rbx

[CL 16829063 by Joe Kirchoff in ue5-main branch]
2021-07-12 14:53:03 -04:00
joe kirchoff
ea08c968f4 [Backout] - CL16826799
#fyi Joe.Kirchoff
Original CL Desc
-----------------------------------------------------------------
UnrealVS: Force nuget references in the .vsix

https://github.com/NuGet/Home/issues/5899

#rb none
#rbx

[CL 16826910 by joe kirchoff in ue5-main branch]
2021-07-12 12:51:28 -04:00
Joe Kirchoff
c1d9d668a5 UnrealVS: Force nuget references in the .vsix
https://github.com/NuGet/Home/issues/5899

#rb none
#rbx

[CL 16826799 by Joe Kirchoff in ue5-main branch]
2021-07-12 12:39:17 -04:00
andrew firth
8323a23c36 [UnrealVS] - add UBT menu add CompileSingleFile (already existed) and PreprocessSingleFile (slight variance on CompileSingleFile.
#rb none

[CL 16811866 by andrew firth in ue5-main branch]
2021-07-06 14:06:32 -04:00
andrew firth
b6bf903744 [UnrealVS] - cleanup P4Commands, apply some coding guidelines
#rb none (no functional changes)

[CL 16810845 by andrew firth in ue5-main branch]
2021-07-05 23:25:32 -04:00
andrew firth
52dadad97e [UnrealVS] - add P4ShowfileInP4VS & P4GetLast10Changes commands
#rb none

[CL 16809463 by andrew firth in ue5-main branch]
2021-07-04 22:46:05 -04:00
andrew firth
d4f4622eb4 [UnrealVS] - implement RunningDocumentTable and use onSave callback to cover all edit/save operations (Better than manually figuring out the right hooks to enter)
#rb none

[CL 16808089 by andrew firth in ue5-main branch]
2021-07-02 22:48:14 -04:00
andrew firth
63f8d404b7 [UnrealVS] - add further hooks for operations that require checkout before save.
cleanup a few code guidelines problems
fix Diff titles
- checking this in without a VSIX drop.

#rb none
#fyi joe.kirchoff

[CL 16806227 by andrew firth in ue5-main branch]
2021-07-01 23:04:26 -04:00
andrew firth
dc5cb01870 [UnrealVS] - add support for P4VC, add commands: open selected CL, open integration aware timelapse view, and Diff within Visual Studio + Optionally override diff in VS settings
$rb none
#fyi Joe.Kirchoff

[CL 16798598 by andrew firth in ue5-main branch]
2021-06-28 20:51:05 -04:00
andrew firth
9edd99ec3d [UnrealVS] - fix issues with p4 setup, the CWD was hitting timing issues and the OnSave callbacks were being duped across solution load/unload
#fyi joe.kirchoff
#fyi ben.marsh

#rb none

[CL 16791847 by andrew firth in ue5-main branch]
2021-06-25 23:26:34 -04:00
Joe Kirchoff
267867b1a2 UnrealVS: Rebuild VS2022 extension for experimental p4 edit functionalily
Check if the file is read only before editing

#fyi Andy.Firth
#rb none
#rnx

[CL 16785917 by Joe Kirchoff in ue5-main branch]
2021-06-25 13:40:59 -04:00
andrew firth
1f4ec14d8c [UnrealVS] - version bumps for assemblyinfo
#rb joe.kirchoff

[CL 16785423 by andrew firth in ue5-main branch]
2021-06-25 12:45:02 -04:00
andrew firth
1c0c0eea8d [UnrealVS] - respond to C# feedback
#review-16784249 @luke.thatcher
#rb luke.thatcher (Post - this is from his review feedback)

[CL 16784883 by andrew firth in ue5-main branch]
2021-06-25 12:16:23 -04:00
andrew firth
d42ffc69db [UnrealVS] - add annotate command
- this is a basic form that will hit issues where our integration patterns somewhat reduce its efficacy
- version 2 will improve on this

#review-16783097 @ben.marsh
#rb ben.marsh

[CL 16783372 by andrew firth in ue5-main branch]
2021-06-25 10:37:23 -04:00