Commit Graph

167 Commits

Author SHA1 Message Date
Juan Canada
960c9cd2fb Fixed Lightmass wrong string formatting
#jira UE-151144
#GitHub 9153
#rb yujiang.wang
#9153
#preflight 627a576e937a047d622b5a8b

[CL 20121586 by Juan Canada in ue5-main branch]
2022-05-10 08:32:22 -04:00
fred kimberley
e7e64e1749 Make FVector conversions explicit.
#preflight 6221270ea00412627d0b7dd3
#jira UE-122078
#lockdown Julien.Marchand
#rb Andrew.Davidson

#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 19253774 in //UE5/Release-5.0/... via CL 19257968
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263535 by fred kimberley in ue5-main branch]
2022-03-04 03:48:53 -05:00
michael sartain
5b6c9341fc Add an ON_SCOPE_EXIT for LightmassMain cleanup with local swarm interface
When running UnrealLightmass with -help and various other arguments we were just doing "returns" without any cleanup.

This would lead to various crashes in destructors, etc.

#jira UE-140898
[REVIEW] [at]Will.Damon, [at]Brandon.Schaefer
[FYI] Juan.Canada
#preflight trivial

#ROBOMERGE-AUTHOR: michael.sartain
#ROBOMERGE-SOURCE: CL 18816329 in //UE5/Release-5.0/... via CL 18816342 via CL 18822821
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824375 by michael sartain in ue5-main branch]
2022-02-02 07:40:09 -05:00
Michael Sartain
bcfb02e2d4 Fix UnrealLightmass spewing UE_LOGs to console for Linux
Add bIsWindowShown option to Linux Console Output Device
Default to true to match old behavior.
Add -nostdout by default in UnrealLightmass

#rb Brandon.Schaefer
#jira none
#preflight trivial

[CL 18817282 by Michael Sartain in ue5-main branch]
2022-02-01 18:14:33 -05:00
zak middleton
94c867345e #ue5 - Fix lightmass after Matrix changes
#jira none
#preflight skip
[FYI] Andrew.Davidson, Juan.Canada

#ROBOMERGE-AUTHOR: zak.middleton
#ROBOMERGE-SOURCE: CL 18755241 in //UE5/Release-5.0/... via CL 18755263 via CL 18757616
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18758578 by zak middleton in ue5-main branch]
2022-01-27 14:37:52 -05:00
juan canada
96d6707e4b Fixed compilation error in lightmass as a fallout of 18751249
#rb none
#jira none
#preflight 61f29421c0033b39f8b83f9c

#ROBOMERGE-AUTHOR: juan.canada
#ROBOMERGE-SOURCE: CL 18752538 in //UE5/Release-5.0/... via CL 18752542 via CL 18756770
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18757079 by juan canada in ue5-main branch]
2022-01-27 14:05:43 -05:00
andrew davidson
9890a21527 LWC: Increase WORLD_MAX to a more reasonable value. Note: This is NOT final!
#jira UE-125072
#rb ben.ingram
#preflight 61dffb451e7c2075bb1d0800
#preflight 61e017591e7c2075bb205b36

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18595474 in //UE5/Release-5.0/... via CL 18595487 via CL 18595497
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18596703 by andrew davidson in ue5-main branch]
2022-01-13 10:10:35 -05:00
michael sartain
d702188054 Fix crash in UnrealLightmass on exit with stats enabled. Repro'd via:
1. Open QAGame in UE
  2. Open StaticLightingFromMat level
  3. In the Content Browser, search for 'M_Emissive_Grtr' and place it on the sphere mesh in the map
  4. In the details of Panel for the Sphere Mesh, search for 'Use Emissive for Static Lighting' and check the box if it is not already checked
  5. Build lighting in Production

We were doing this at the end of LightmassMain:

  FTaskGraphInterface::Shutdown();
  FEngineLoop::AppExit();

FTaskGraphInterface was being used in FThreadStats::StopThread() and we'd crash.

FEngineLoop::AppExit() does the thread stats shutdown before calling FTaskGraphInterface::Shutdown. Ie:

  void FEngineLoop::AppExit()
  {
    // when compiled WITH_ENGINE, this will happen in FEngineLoop::Exit()
#if !WITH_ENGINE
#if STATS
    FThreadStats::StopThread();
#endif
    FTaskGraphInterface::Shutdown();
#endif // WITH_ENGINE

This will stop the stats thread (if needed) before shutting down FTaskGraphInterface.

[at]Brandon.Schaefer
[FYI] Will.Damon
#jira none
#preflight trivial

#ROBOMERGE-AUTHOR: michael.sartain
#ROBOMERGE-SOURCE: CL 18568433 in //UE5/Release-5.0/... via CL 18568435
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18568438 by michael sartain in ue5-release-engine-test branch]
2022-01-10 21:29:26 -05:00
yujiang wang
3e7654a0ec Fix CPU Lightmass Mac/Linux compilation
#rb none

#ROBOMERGE-AUTHOR: yujiang.wang
#ROBOMERGE-SOURCE: CL 18270956 in //UE5/Release-5.0/... via CL 18270970
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18270981 by yujiang wang in ue5-release-engine-test branch]
2021-11-23 11:31:55 -05:00
yujiang wang
d30fed9551 Fix CPU Lightmass by coverting LWC types to single precision
#rb juan.canada
#preflight 619c5386fa0b360c407f9573

#ROBOMERGE-AUTHOR: yujiang.wang
#ROBOMERGE-SOURCE: CL 18266488 in //UE5/Release-5.0/... via CL 18266508
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18266515 by yujiang wang in ue5-release-engine-test branch]
2021-11-22 22:06:39 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
69fe095547 Merge from Release-Engine-Staging @ 17636544 to Release-Engine-Test
This represents UE4/Main @17638339 and Dev-PerfTest @17636504

[CL 17638842 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-27 19:54:25 -04:00
andrew davidson
57beb335f2 Merging //UE5/Dev-LargeWorldCoordinates [at] 17581892 to //UE5/Main
#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 17595295 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v871-17566257)

[CL 17595306 by andrew davidson in ue5-release-engine-test branch]
2021-09-22 10:01:48 -04:00
andrew davidson
e73db5f9e6 LWC: Large World Coordinates toggle defaults to ON.
Frosty and Fortnite default to OFF.

Preflight validation runs: 611c2b645e73720001a4ccf3, 611c318caabad10001091e20,611c2ba99db7df000111041b

#rb chad.garyet
#jira UE-121664
#preflight 611d33b23a81b00001365b33

#ROBOMERGE-SOURCE: CL 17218586 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17218602 by andrew davidson in ue5-release-engine-test branch]
2021-08-18 13:58:57 -04:00
andrew davidson
f14e5dd9bc Undo //UE5/Main/... changelist 17203923
#ROBOMERGE-SOURCE: CL 17205235 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17205246 by andrew davidson in ue5-release-engine-test branch]
2021-08-17 16:28:05 -04:00
andrew davidson
96da376167 LWC: Large World Coordinates toggle defaults to ON.
Frosty and Fortnite default to OFF.

Preflight validation runs: 611aa00f3a81b00001d2998f, 611ad177aabad10001ca6a74, 611ad5773a81b00001d9947c, 611b8a2876f1fd00010eac6d

#rb ryan.durand
#jira UE-121664
#preflight 611b72d3aabad10001e5e3c3

#ROBOMERGE-SOURCE: CL 17203923 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17203933 by andrew davidson in ue5-release-engine-test branch]
2021-08-17 15:33:22 -04:00
andrew davidson
cf3ad023de LWC: Miscellaneous double/float type conversion fixes
#preflight 6115311a9c7bb100011a2452

#ROBOMERGE-SOURCE: CL 17153993 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17154002 by andrew davidson in ue5-release-engine-test branch]
2021-08-12 12:35:40 -04:00
dmytro vovk
fe1651081e Fixed UnrealLightmass compilation
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 17050253 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v850-17047176)

[CL 17050268 by dmytro vovk in ue5-release-engine-test branch]
2021-08-04 09:53:52 -04:00
Andrew Davidson
3ddc3a4da3 Merge up from //UE5/Dev-LargeWorldCoordinates
#rb none

[CL 16211417 by Andrew Davidson in ue5-main branch]
2021-05-05 15:07:25 -04:00
charles bloom
a5ee4d69bf remove duplicate Color::ComputeLuminance , use GetLuminance
also fix bug in ProxyLOD AverageColor , iterating on Size instead of 4

#rb none

[CL 16047335 by charles bloom in ue5-main branch]
2021-04-18 13:54:06 -04:00
charles bloom
6331ae849c remove MemStack constructor with unused int argument
#rb none
#fyi yuriy.odonnell

[CL 16047263 by charles bloom in ue5-main branch]
2021-04-18 13:06:22 -04:00
Matt Peters
10a3e11b48 #jira UE-110028
SplitTriangleList: Fix loop conditions to avoid off-by-one dereference of end of the list.
#rb Kriss.Gossart
#rnx

[CL 15802956 by Matt Peters in ue5-main branch]
2021-03-24 13:13:04 -04:00
Sebastien Lussier
d52aa4ee35 #jira UTA-694, UE-24337, UE-39611, UE-21840, UT-1713
kDOPTree - Fix lost precision in mean/variance computation when accumulating using a float
Would end up crashing with an OoB access as the code would put all triangles on the left of the splitting plane, which was not expected

Also optimized SplitTriangleList() to avoid going through the triangle list 6x...
#rb richard.malo

[CL 15388280 by Sebastien Lussier in ue5-main branch]
2021-02-11 12:01:01 -04:00
Andrew Davidson
9313e569b2 Double math ambiguity Engine further fixes
#rb trivial

[CL 14975276 by Andrew Davidson in ue5-main branch]
2021-01-04 11:19:23 -04:00