Commit Graph

372 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
jonathan bard
6115839c10 Prevent crash when unloading a World Composition level whose package cannot be unloaded because there's at least one reference to it preventing the world to be garbage-collected. This test allows the WorldBrowser to survive until the GCObjectReferencer can run and display the actual reason preventing garbage collection (via a fatal error)
#rb patrick.enfedaque
#jira UE-150092
#preflight 6284fb021f474f0660ecbf70

[CL 20260747 by jonathan bard in ue5-main branch]
2022-05-18 10:22:02 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Patrick Enfedaque
aca2ccef34 WorldPartition: Use UWorld::IsPartitionedWorld instead of HasSubsystem<UWorldPartitionSubsystem> (prepare for subsystem always existing)
#rb richard.malo, jeanfrancois.dube
#preflight 6214e114a97c2c3348cb166d
#rnx

[CL 19071881 by Patrick Enfedaque in ue5-main branch]
2022-02-22 08:54:19 -05:00
fred kimberley
7fbfaf57c8 Require explicit constructors/casts when converting between FVector, FVector3d, and FVector3f.
#jira UE-122078
#rb Andrew.Davidson, Colin.McGinley
#preflight standard build

#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 18817999 in //UE5/Release-5.0/... via CL 18818012 via CL 18822871
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824721 by fred kimberley in ue5-main branch]
2022-02-02 07:59:31 -05:00
sebastien lussier
3c59f35efa #jira UE-132273
WP Landscape HLOD - Properly stitch landscape HLODs & the actual landscape components

FLandscapeMeshProxySceneProxy now register the LOD they represent in the LandscapeRenderSystem object, causing the neighbor landscape components to morph their vertices to fill any gap.
#rb patrick.enfedaque
#preflight 61f89420f657e25a5907bcc3

#ROBOMERGE-OWNER: sebastien.lussier
#ROBOMERGE-AUTHOR: sebastien.lussier
#ROBOMERGE-SOURCE: CL 18803905 in //UE5/Release-5.0/... via CL 18807861 via CL 18821697
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822082 by sebastien lussier in ue5-main branch]
2022-02-02 02:16:47 -05:00
andrew davidson
3debbbd465 Fix FVector2D variant casts
Submitted on behalf of fred.kimberley
#rb andy.davidson
#preflight 61f8719ea6632a34f35e654b

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18801709 in //UE5/Release-5.0/... via CL 18802160 via CL 18821533
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18821619 by andrew davidson in ue5-main branch]
2022-02-02 01:45:23 -05:00
richard malo
481f65fe16 New Actor Folders objects.
- When enabled, folders are actual objects : modifying a folder won't affect actors (more compliant with OFPA).
- Enabled by default for World Partition and Level Instances.
- Can be enabled on regular levels (experimental feature 'Use Actor Folder Objects').
- If Level uses OFPA, ActorFolders will also be saved in their own package (but will use __ExternalObjects__ root folder).
- In a future refactoring, external actors will also be moved in the same root folder.
- Generalized saving object in an external package (different from its outer package)
- World outliner supports old folders and new actor folder objects : Levels using the actor folder objects will show a root Level node (like Level Instances).
#rb patrick.enfedaque, jeanfrancois.dube
#preflight 61d84b356511bc498e5cb858

#ROBOMERGE-AUTHOR: richard.malo
#ROBOMERGE-SOURCE: CL 18543443 in //UE5/Release-5.0/... via CL 18543482
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18543525 by richard malo in ue5-release-engine-test branch]
2022-01-07 10:01:19 -05:00
jason walter
2ce31e23cf Ensure that the world is marked dirty when removing a sub-level.
#jira UE-134249
#rb patrick.enfedaque
#preflight 61b8c82d9c7c3936c8c7cd08

#ROBOMERGE-AUTHOR: jason.walter
#ROBOMERGE-SOURCE: CL 18458039 in //UE5/Release-5.0/... via CL 18458043
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18458045 by jason walter in ue5-release-engine-test branch]
2021-12-14 15:09:14 -05:00
daren cheng
674a3e3efc Expand any parent items when selecting a level.
#jira FORT-437669
#rb trivial
#preflight 61b79f01dd0e83c861ac4b5d

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 18447814 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v897-18405271)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0
#ROBOMERGE[bot1]: Main

[CL 18448036 by daren cheng in ue5-release-engine-test branch]
2021-12-13 15:20:38 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
luc eygasier
f1cc1342ec Checks if levels/actors are dirty before saving levels. This avoids checkouting all external actor when OFPA is enabled.
#rb Sebastien.Lussier

#changelist validated

#ROBOMERGE-AUTHOR: luc.eygasier
#ROBOMERGE-SOURCE: CL 17980515 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v885-17909292)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0

[CL 17980530 by luc eygasier in ue5-release-engine-test branch]
2021-10-29 11:13:35 -04:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
patrick enfedaque
209be396b4 World Partition:
- New Level Dialog: Empty Open World Template
- Remove IsWorldPartitionEnabled project setting

#rb jeanfrancois.dube, richard.malo
#preflight 615477fc03f3320001fefe99

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 17663222 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v875-17642767)

[CL 17663241 by patrick enfedaque in ue5-release-engine-test branch]
2021-09-29 12:29:37 -04:00
aditya ravichandran
b63c6159fe Levels window now only shows a save modified icon if a level is dirty,
Fixed an issue where new folder default names would not increment correctly,
Updated lock icons and added save modified and solid light bulb icons.

#jira UE-115797
#rb lauren.barnes
#preflight 611ff9b7aabad100017b070a

#ROBOMERGE-SOURCE: CL 17252473 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17252488 by aditya ravichandran in ue5-release-engine-test branch]
2021-08-20 16:03:35 -04:00
vincent beauchemin
d6dc3b04df Fixed "Levels" UI empty on New Projects /w World Partition - It mentions it explicitely now
#rb jeanfrancois.dube
[FYI] tim.gautier
#jira UE-113855

#ROBOMERGE-SOURCE: CL 16898678 via CL 16916232
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16916440 by vincent beauchemin in ue5-release-engine-test branch]
2021-07-21 18:06:33 -04:00
matt hoffman
11740875ec Matinee: Changes required to delete matinee editor module. Removes the Interp edit mode and UnrealEds dependency on the Matinee editor module.
#rb Max.Chen, Ludovic.Chabant
#jira UE-105313
#p4v-preflight-copy 16616138
#preflight 60c1bb5eb68c700001c956d5
#preflight 60c24c03730f8a0001772aca
#preflight 60c2602f79a7fe0001785630

#ROBOMERGE-SOURCE: CL 16629318 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v831-16623017)

[CL 16629342 by matt hoffman in ue5-release-engine-test branch]
2021-06-10 16:22:51 -04:00
matt hoffman
8e166827a8 Undo //UE5/Main/Engine/Source/... changelist 16613917
#jira None
#rb None

#ROBOMERGE-SOURCE: CL 16615633 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16615656 by matt hoffman in ue5-release-engine-test branch]
2021-06-09 19:26:30 -04:00
matt hoffman
305e2f6805 Matinee: Changes required to delete matinee editor module. Removes the Interp edit mode and UnrealEds dependency on the Matinee editor module.
#rb Max.Chen, Ludovic.Chabant
#jira UE-105313

#ROBOMERGE-SOURCE: CL 16613917 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16613923 by matt hoffman in ue5-release-engine-test branch]
2021-06-09 18:03:04 -04:00
luc eygasier
b064641c8d Adds "mark for add" when saving new levels in the "Levels" Windows
#rb Sebastien.Lussier
#jira UE-115800

#changelist validated

[CL 16509213 by luc eygasier in ue5-main branch]
2021-05-31 10:41:55 -04:00
danny couture
9332b64809 Prepare for the deprecation of direct access to the Resource member of UTexture in favor of the GetResource() accessor.
#rb Francis.Hurteau
#preflight 609e5182ef86d30001ad0a18
#rnx

[CL 16328103 by danny couture in ue5-main branch]
2021-05-14 07:17:32 -04:00
Andrew Davidson
3ddc3a4da3 Merge up from //UE5/Dev-LargeWorldCoordinates
#rb none

[CL 16211417 by Andrew Davidson in ue5-main branch]
2021-05-05 15:07:25 -04:00
Patrick Boutot
120fa81941 Slate: Add an option to update the attributes and cache the invalidation for later. Update the visibility attribute before doing layout out of the regular SWidget paint path.
#jira UE-113307
#preflight 607993474af1c70001f7ae8e

[CL 16033397 by Patrick Boutot in ue5-main branch]
2021-04-16 10:07:05 -04:00