#rnx
#rb none
#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870586 by ryan durand in Main branch]
#jira UE-76461
#rb none
#ROBOMERGE-SOURCE: CL 7283619 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v369-7254125)
[CL 7283624 by max chen in Main branch]
The curve editor supports three view types by default - an absolute view (default, matches old behavior), a stacked view and a normalized view. Stacked views draw each curve separately (so non-overlapping) and normalized against their own min/max values. The normalized view draws all curves overlapping with each one normalized against its own min/max values.
A tree view has been added to help effectively manage large numbers of curves. Selecting curves in the treeview controls which curves are visible in the view area. The treeview also supports pinning curves. These pinned curves will always be visible regardless of your selection in the tree view.
A transform tool and a retiming tool have been implemented (via a plugin) which is enabled by default. The transform tool allows you to do a marquee selection of keys and then translate and scale the positions of these keys. The retiming tool allows you to create a 1 dimensional lattice to adjust the timing of your keys with a linear falloff between each lattice point. These tools work across multiple views at the same time which is especially useful if you are representing one dimensional data (such as event keys) in a view, as it allows you to adjust this data at the same time as your animation curves. A smoothing filter has been implemented (via a plugin) to allow running highpass and lowpass filters on your keys.
Opening the curve editor in Sequencer/UMG now creates a separate dockable tab which can be resized and docked as desired. A time slider has been added to the Curve Editor which is synchronized to the playback time in Sequencer. This allows you to scrub time in the curve editor without having to find the Sequencer window and adjust time there while looking at your keys and previewing your animation in the viewport at the same time.
Rudimentary support has been added for saving and later restoring a set of curves in your current session. This allows you to do a rudimentary copy/paste of entire curves but can also be useful for saving a curve, making adjustments to it and then deciding you want to go back - simply reapply the saved curve! Each curve added supports an intention name (such as "Location.X" or "FieldOfView"), and these intention names will be used when trying to apply curves. This allows you to reliably take all of the curves of a transform on one object and apply them to another object (and ensure that Location.X gets applied to the new Location.X, etc.) this can be helpful if you have a mixed set of curves buffered (such as a location and a field of view). In the event that no curves match by intention you can store and apply a single curve at a time from any intention to any other intention.
The Curve Asset editors (float, vector and color curve assets) have been changed to use the new editor. They support the same treeviews, filtering and tools that the Sequencer editor does. In addition, the Color Curve asset editor adds an additional view which provides a 1 dimensional gradient editor as an easier way to visualize and edit colors instead of the channels individually.
#rb Max.Chen, Andrew.Rodham
#ROBOMERGE-SOURCE: CL 6631811 via CL 6633746
#ROBOMERGE-BOT: (vundefined-6620334)
[CL 6633863 by matt hoffman in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3801826 by Max.Chen
PR #4304: Level Sequence crash fix - Guarded against dereferencing null componen. (Contributed by DSDambuster)
Change 3801828 by Max.Chen
PR #4302: Movie Scene Visibility Template unitialised variable, causing random . (Contributed by DSDambuster)
Change 3801837 by Max.Chen
Sequencer: Delay spawning/construction for convert to possessable. This fixes a bug where property values would be lost when
converting back and forth from possessable to spawnable.
#jira UE-52400
Change 3801841 by Max.Chen
Sequencer: Make spacer nodes not selectable.
PR #4194: Improvements to Sequencer (Contributed by projectgheist)
#jira UE-53117
#jira UE-52139
Change 3804183 by Max.Preussner
MediaAssets: Added missing lock in media sound component
Change 3805414 by Max.Preussner
MediaAssets: Setting valid GUID when initializing media texture resource
Change 3819578 by Max.Chen
PR #4370: When enabling the "MovieCapture", do not turn off the Stereo-3D display. (Contributed by yehaike)
#jira UE-53647
Change 3823414 by Max.Chen
Curve Editor: Lock down the first and last keys in the redundant keys removal range so that they're unaffected.
#jira UE-53591
Change 3826406 by Max.Chen
Sequencer: Move OnStartedPlaying() to within first update in UpdateTimeCursorPosition(). This fixes an issue where setting the
hud/player visibility was getting stomped on later.
#jira UE-52772
Change 3827044 by Max.Preussner
MediaAssets: Added sprite visualization to media sound component
#jira UE-53594
Change 3827988 by Max.Preussner
MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together
#jira UE-53532
Change 3828506 by Max.Preussner
MediaPlayerEditor: Added attenuation visualizer for media sound components
#jira UE-53594
Change 3832590 by andrew.porter
EngineTest: Added a keep state check in Property Animation sequencer test
Change 3833053 by andrew.porter
EngineTest: Adding Hierarchical Bias test
Change 3835683 by andrew.porter
EngineTest: Adding UMG Animation screenshot test
Change 3836076 by Max.Chen
Sequencer: Fix audio volume and pitch multiplier deprecation.
Change 3836230 by andrew.porter
EngineTest: Adding Sequence Bone Position automation test
Change 3836347 by Max.Chen
Sequencer: Fixes to shot name parsing.
When a shot doesn't contain a shot number, assume, [ShotName]_[TakeNumber].
When duplicating a shot, put the new shot in the same path of the original shot, so that the take numbers will increment
properly.
#jira UE-51868
Change 3836552 by Max.Chen
Sequencer: Sub section now has a takes menu
Change 3838094 by Max.Chen
UMG: Fix template finish not getting called on stop. This fixes a bug where sections aren't restored when finished.
#jira UE-52285
Change 3838708 by Max.Chen
Sequencer: Add notification when the blend type is changed.
#jira UE-54046
Change 3840295 by Max.Chen
Sequencer: Fix copy/paste crash for lights
#jira UE-54084
Change 3840957 by Mike.Zyracki
Added Show Only Keyable and Show Only Animated to the filter list in the property editor.
Added IsPropertyAnimated to IDetailKeyframe Interface which already had support for showing properties which are keyable (which
is used for the key icon next to the properties.). Could have created another interface but then would have had to mimic the sequencer
binding, releasing also, so this seemed best way.
One issue still left is that custom built detail items currently don't store associated properties(usually) and so certain
properties, in particulalry transforms, won't show up as keyable or animated. Note this also shows up with the keyable icon not showing
up next to transform tracks, and other filters like Show Only Modified not working with transforms/customs. Not sure best way to tackle
this.
#jira UESEQ-328
Change 3841756 by Max.Chen
Sequencer: Fix unbound possessable components when pasting spawnables.
#jira UE-54104
Change 3843950 by andrew.porter
EngineTest: Renaming LevelStreaming tests/content to LevelVisibility
Change 3844082 by Mike.Zyracki
Missing file for animated filter in property editor.
When finding if a track is animated we need to find it but we can't easily induce the MovieTrack class for any particular
property. So we don't set a class for it and just search by it's ID and name.
#jira UESEQ-328
Change 3846902 by Max.Preussner
ImgMedia: Fixed image media player never finished initialization if loading failed
#jira UE-54247
Change 3849820 by Mike.Zyracki
Reassigning deleted widgets didn't work since the menu extender mechanism needs a valid UObject in order to perform an operation
on it. So to fix we replaced GetObjectBindingContextMenuExtender in WidgetBlueprint with new delegate mechanism
(OnBuildCustomContextMenuForGuid) that supports FGuid in addition to UObjects which is needed to handle re-binding deleted widgets. Note
that the default sequencer hacks this for replacing deleted actors in SequencerObjectBindingNode to check to see if a LevelSequence is
active. We could move to this mechanism there also.
#jira UE-53163
Change 3852211 by Max.Chen
UMG: Indicate name of the property that is not bound.
#jira UE-54350
Change 3854120 by Max.Chen
Sequencer: Fix sibling folders being allowed to have the same folder name.
#jira UE-54363
Change 3854627 by Max.Chen
Sequencer: Step to next/previous key should work for all tracks if there aren't any selected.
#jira UESEQ-391
Change 3855825 by andrew.porter
EngineTest: Adding animation blending automation test
Change 3855950 by andrew.porter
EngineTest: Adding correct expected valuues to animation blending test
Change 3856237 by Matt.Hoffman
UESEQ-336 - Sequencer Track Reordering
Adds the ability to re-order Master Tracks, Folders and Object Bindings within sequencer hierarchies (including UMG). Adds the
ability to do a one-off sorting of the content under the old sorting behavior if the user wants to reset their layout to how it was
under legacy behavior.
Modifies SequencerTrackNodes, SequencerFolderNodes and SequencerObjectBindingNodes to handle CanDrop/OnDrop for above, below and
ontop of.
Fixes a Slate Issue that forcibly expanded a TreeviewRow if an item handled OnDrop. Slate will now only forcibly expand the row
if the item says the drop happened ontop of the item, and not above or below it like it previously did.
Change 3856503 by andrew.porter
EngineTest: Adding automation test for using animation blueprint with blend multi node in sequencer
Change 3857875 by Max.Chen
Sequencer: Assign the sequence id after the template is compiled.
#jira UE-54462
Change 3858344 by Max.Chen
Sequencer: Prevent Goto and Transform boxes from overlapping by allowing them to be visible at the same time in an autosized
horizontal box. Also, added close button to the goto box.
PR #4425: Prevent Goto and Transform boxes from overlapping in Sequencer ... (Contributed by projectgheist)
#jira UE-54210
Change 3860566 by andrew.porter
MediaFrameworkTest: Set the option to index 0 for the audio and video track list by default
Change 3860654 by andrew.porter
EngineTest: Enabling Camera Cut + FOV test
Change 3860981 by andrew.porter
EngineTest: Updating skeletal mesh tests with a delay after set playback position
Change 3861256 by Max.Chen
Sequencer: Add all bindings if none selected.
#jira-54440
Change 3862154 by Andrew.Rodham
Added TimeManagement module
Change 3862424 by andrew.porter
EngineTest: Turned on the test Bone Positions with Blend Multi Node
Change 3862573 by andrew.porter
EngineTest: Adding test to compare bone positions in a sequence that is blending an animation that is using an AnimBP
Change 3865117 by Max.Chen
Sequencer: Stop auto scroll on mouse release of movement.
#jira UE-31212
Change 3865303 by Max.Chen
Sequencer: Add drag and drop transactions
#jira UE-54662
Change 3865304 by Max.Chen
Sequencer: Fix crash when an actor factory is not found.
Change 3865361 by Max.Chen
Sequencer: Don't change the camera/shot lock button when popping out of a sequence.
#jira UE-54665
Change 3865412 by Max.Chen
Sequencer: Determine whether a transform track is for a camera by using the spawned object or template
#jira UE-54666
Change 3865685 by Max.Chen
Sequencer: Clear autoscrub offset when stopping autoscroll
#jira UE-31212
Change 3865886 by Max.Chen
Sequence Recorder: Log an error if the number of frames changes while recording. This can happen if the skeleton changes while
recording.
#jira UE-48715
Change 3866925 by Andrew.Porter
MediaFrameworkTest: Changing the current PNG test video image sequence to 1024 x 576
Change 3867705 by andrew.porter
QAGame: Adding Audio Sort Sequence to dev folder
Change 3867890 by andrew.porter
QAGame: Adding a sequence for testing a sorting crash to my dev folder
Change 3872628 by Max.Chen
Movie Scene Capture: Split delay before warmup into split delay before shot warmup so that there's separate controls for when
the movie scene capture warmups up vs. shot boundaries.
Change 3873131 by Matt.Hoffman
UE-54732 - Crash reordering a folder with a track.
This was caused by folders being the only type of track to check if someone was putting a parent track into a child track.
Object Binding tracks and Tracks now check as well so that you can't use the above/below drop targets to add parents as children.
This also fixed a typo in the localization keys.
#jira UE-54732
Change 3873301 by Mike.Zyracki
Added ability to support continous euler angle changes when changing rotations, in particularly with the rotation gizmo's. To do
this we effectively added a form an of 'euler filter'(https://en.wikipedia.org/wiki/Euler_filter) to find the closest euler angle to the
current euler angle.
Three functions were added to FRotator to make this possible, one to get the euler angle that's has the same rotation as it, one
to get the difference between two euler angles via Manhattan distance and a third using the previous two to choose a Rotator value
that's closest to it. We then use these functions before calling UComponent::SetRelativeRotation to make sure we use the correct Euler
after the Quat conversion. We also no longer limit(bound) the euler angles to -180,180, which is obviously necessary to avoid flips.
I also changed how we caluclate yaw and roll when pitch is -90 or 90 to make it the standard approach of zeroing out roll and
just setting yaw. Main reasons are the previous implementation had precision issues so things like 180, 90, -180 would show up due to
numbers being nearly zero but negative,(this would break any smooth interpolations), and this facilitates having a 'gimbal' rotation
mode (like Maya, Blender etc..) if we ever want that also. If needed we could keep the previous implementation but would need to add
some FMath::IsNearlyZero checks, with less performance.
Note we only do this special filtering when applying delta's to actors or components in the editors, which then call
UComponent::SetRelativeRotationExact, which is a new function to foces the RelativeRotation to be equal to the new rotation. This allows
us to store un-nomalized Rotators at the cost that the RotationCache may be broken. We didn't change any of the other UComponent
functions that set rotations (via Quats or Transforms) so they will still be bounded and unwound.
In SetInternalWorldLocationAndRotation we only set the rotation if the rotation has changed, which fixes the rotation getting
changed and re-normalized if just translate happens.
In TransformTrackEditor, we correclty use the bUndwing flag and in MovieScene3DTransformSection there was an un-needed winding
check there, it will be unwound earlier if needed, which happens if Sequence Recording is happening. Max we should talk about what to do
about this .
Note the euler angle drag via the widget is still bound to 0-360. I think we should just unbound that now since the rotations
value are now unbound.
This review now includes fixes suggested by Zak.
#jira UE-UE-22228
Change 3873483 by Matt.Hoffman
Sequencer Tracks can now be inserted above the spacer at the bottom of the tree.
#jira UE-54706
Change 3873899 by Max.Chen
Sequencer: Add section selection throbbing
Change 3873908 by Max.Chen
Movie Scene Capture: Added logging per frame
Change 3873924 by Matt.Hoffman
Adds the ability to store Sequence Recorder setups into profiles that stay with the map and can be re-loaded later. Profiles
store the Actor Recordings so the settings for each actor should carry with them.
#jira UESEQ-339
Change 3874726 by Matt.Hoffman
Disable drag-and-drop targets on spacers that come between rows in Sequencer. This prevents extra drag/drop targets showing up
between each row.
#jira UE-54706
Change 3874862 by Matt.Hoffman
Audio Track no longer gets reordered when adding sub-audio tracks, as sub-tracks are no longer counted towards the sorting order
index when normalizing indexes.
#jira UE-54727
Change 3875905 by Matt.Hoffman
Disable Fade Track UI if a fade track already exists in the sequence.
#jira UESEQ-393
Change 3876163 by Max.Chen
Sequencer: Swap the camera object to the camera component's owner if it's not the same.
#jira UE-54874
Change 3876971 by Andrew.Porter
EngineTest: Moved Media Player Seek test to new folder. Also enabled the test with new ground truth image.
Change 3877040 by Max.Chen
Cine Camera: Split camera properties to two groups, "Camera Options" and "Camera Settings". The cine camera now hides properties
in the "Camera Settings" group so that properties like bConstrainAspectRatio (in the "Camera Options" group) can be visible.
#jira UE-54192
Change 3877763 by Max.Chen
Curve Editor: Fix curve changed on end drag so that only curves that had keys/tangents that were changed receive notification,
otherwise all loaded curves were getting notified that they were changed.
#jira UE-54951
Change 3878234 by Matt.Hoffman
Disable "Drop Below" targets for Sequencer Tree nodes to prevent a confusing UX issue where dropping underneath a Object Binding
Node puts it after the object binding node but the UI looks like it's inserting it inside the Object Binding node.
#jira UE-54743
Change 3879359 by Mike.Zyracki
If a track is inactive we dim it a bit which seems to be the UE4 way to show inactive or disabled state. We changed the active
logic so that all subtracks need to be inactive for the track to also be inactive(instead of all active for active). This conforms to
how the active state actually works, e.g if you have two sections and only one is active the track is still active above it.
#jira UESEQ-388
Change 3879462 by Max.Chen
Sequencer: Allow dragging onto a particular row which would move out any overlapping sections to make space for the newly
created section. Newly created sections are now selected and throbbed to draw attention to themselves.
#jira UE-54664
Change 3879464 by Max.Chen
Sequencer: Fixed overlapping ranges being inserted into the evaluation field during compilation
- The issue was that track segments that had been combined with adjacent segments (due to them being identical) would
potentially cause a subsequently compiled frame to overlap with a range that had already been inserted into the evaluation field.
- The insertion code previously asserted that only minor overlaps were catered for (due to fp rounding errors) and assumed
that a supplied range could not entirely contain any other range in the field.
- The solution is to supply the insertion time along with the range to know exactly where the data should live in the field,
and crop the range to the maximum allowable space between adjacent ranges.
#jira UE-54922
Change 3879590 by Matt.Hoffman
Items that are now added to the Sequencer via the "+Track" menu will be selected after being added.
Items can now be added inside of folders instead of just to the root level.
#jira UE-27397
Change 3879612 by Mike.Zyracki
Display Nodes with no children are always active.
#jira UESEQ-388
Change 3879730 by Matt.Hoffman
Sequence Recorder's actor recording groups now remove items from the group when removed via the UI.
#jira UESEQ-339
Change 3880256 by Mike.Zyracki
Fix issue with inactive display with folders and other track nodes.
#jira UESEQ-388
Change 3883491 by Max.Chen
Fix issue where tick is skipped due to last ticked pose isn't cleared after AnimInstance changes.
Copy from Release-4.19
#jira UE-51323
Change 3883603 by Max.Chen
Movie Scene Capture: Add option toggle disable screen percentage. By default this is on (no change in current behavior).
#jira UE-51898
Change 3885074 by Max.Preussner
MediaCompositing: Resetting media texture & freeing resource on section end; removed dead code
Change 3887220 by Max.Preussner
MediaCompositing: Defaulted media section duration to 1 sec (since we do not know the actual duration in most cases)
Change 3887478 by Matt.Hoffman
Sequences now show [Inactive] in their title bars when they're disabled. This helps communicate why a sequence isn't being
evaluated.
#jira UE-51469
Change 3888985 by Max.Chen
Movie Scene Capture: Clamp HDR Compression Quality between 0 and 1.
#jira UE-55136
Change 3893519 by Max.Chen
Sequence Recorder: Clarified tooltip for bRecordNearbySpawnedActors - spawned actors will still be recorded if they match the
ActorFilter.
#jira UE-55238
Change 3893546 by Max.Chen
Sequence Recorder: If a selected actor already has a recording, add a blank recording.
#jira UE-55239
Change 3894044 by Max.Preussner
MediaCompositing: Added support for seeking into a media section
Change 3894310 by andrew.porter
MediaFrameworkTest: Adding Img media sources for 1080 and 2160 ravent test content
Change 3894426 by Max.Preussner
MediaAssets: Letting media textures with AutoClear retain their clear color when player is reset
Change 3895717 by Max.Chen
Sequencer: Null checks to prevent crash when saving the default state of a spawnable
#jira UE-55304
Change 3897388 by Max.Chen
Sequencer: Don't update current time to be within the view range when stepping into a sequence.
#jira UE-55322
Change 3897452 by Max.Chen
Audio: Fix crash when trying to record audio without any active capture devices. Log warning if the number of input channels is
not 1 or 2.
#jira UE-55223
Change 3897619 by Max.Preussner
MediaCompositing: Removed commented out code
Change 3898072 by Max.Chen
Sequencer: Override the animation asset in the player state if it doesn't match the animation asset that's being evaluated.
#jira UE-55328
Change 3898272 by Max.Preussner
MediaPlayerEditor: Made slate brush constants static
Change 3898704 by Max.Chen
Sequencer: Skip if the binding id's sequence can't be found.
#jira UE-55337
Change 3899855 by Max.Preussner
MediaCompositingEditor: Added cache state visualization to media track
Change 3900300 by Max.Preussner
MediaCompositingEditor: Added loop indicators to media sections
Change 3900694 by Max.Preussner
ImfMedia: Looping cache only when player is looping
Change 3900892 by Max.Preussner
Stats: Added stats category for media framework
Change 3900954 by Max.Preussner
MediaCompositing: Don't evaluate at the end of media section
Change 3901348 by Max.Preussner
Core: Replaced TLruCache autos for better readability
Change 3901655 by Max.Preussner
ImgMedia: Added more perf stats to EXR reader
Change 3901972 by Max.Preussner
MediaAssets: Added getter for media player in media sound components
Change 3902233 by Max.Preussner
MediaAssets: Enabling media textures to receive samples right after player is assigned
Change 3902238 by Max.Preussner
MediaCompositing: Working around init/shutdown idiosyncracies in sequencer
Change 3904045 by Max.Chen
Sequencer: Fix copy/paste crash. Only process UMovieSceneCopyableBinding and objects that can be spawned by the movie scene
spawn register.
#jira UE-55314
Change 3905605 by Max.Chen
Sequencer: Restrict spawnables from being created if they have a ClassWithin that UMovieScene is not a child of.
#jira UE-55429
Change 3906550 by Max.Chen
Sequencer: Add media track icon
#jira UE-55480
Change 3907101 by Max.Chen
Sequence Recorder: Fix bugs related to not recording a level sequence. There were certain assumptions that creating a level
sequence meant that sequence recording was in progress. This is not always the case - the recorders can record animation assets and not
create a level sequence.
Changed the notion of IsRecording() to having at least one actor recording that is recording. Countdown timer, recording
displays, etc should function if IsRecording() and not based on whether a level sequence is created.
#jira UE-55485
Change 3907247 by Max.Chen
Sequence Recorder: Fix crash not removing PrepareToCleanseEditorObject delegate. Repros when opening sequence recorder, closing
it, and then opening or creating a level.
Change 3910343 by Max.Preussner
Core: Added async helper for executing functions on a given thread pool
Change 3910346 by Max.Preussner
ImgMedia: Added separate thread pools for loading/decoding and deleting image frames
Change 3910829 by Max.Preussner
Profiler: Increased visible range of profiler graph
Change 3910841 by Max.Preussner
MediaCompositing: Displaying asset name instead of full media source path in media section
Change 3910870 by Max.Preussner
ImgMedia: Using deallocation thread pool only in debug builds
Change 3919642 by Max.Chen
Sequence Recorder: Clarify active tooltip
#jira UE-55661
Change 3919660 by Max.Chen
Sequencer: Sequence template source signatures are now also compared to catch the case where a sub-sequence asset has been saved
but not modified
- The following sequence of events exposes this issue:
- Create a master sequence with a single shot that spawns a cube
- Add this sequence to a level and set it to auto-play
- Save everything and restart
- Resave just the inner shot asset without opening it
- PIE
- The inner shot never spawns its cube because its template was wiped on save, but its signature never changed. Since the
master sequence previously didn't check the template source signature, it ends up trying to evaluate an empty template.
#jira UE-55626
#jira UE-55490
Change 3921825 by Max.Chen
Sequencer: "Run Construction Script in Sequencer" is off by default for blueprints but on for Sequencer. This allows the content
author to switch it on for specific blueprints and sequencer will be default, run those with construction scripts enabled.
Change 3922232 by Max.Chen
Sequence Recorder: Reset countdelay on stop.
#jira UE-55755
Change 3922306 by Max.Chen
Sequence Recorder: Don't automatically mark transforms to be recorded by sequence recorder. Instead, log a warning if the user
toggled it off to warn that the resulting animation might not match gameplay.
#jira UE-55758
Change 3922912 by Max.Chen
Sequence Recorder: Fix refresh next sequence name
#jira UE-55757
Change 3927654 by Max.Chen
Movie Scene Capture: Added format mapping for the name of the current camera
#jira UE-55769
PR #4537
Change 3927658 by Max.Chen
Sequencer: Added fbx property mapping for "FocusDistance" to "FocusSettings.ManualFocusDistance"
#jira UE-55782
Change 3932022 by Max.Chen
Sequencer: Add import animation track section to next available row index.
#jira UE-55892
Change 3933919 by Max.Chen
Sequencer: Jump to playback start frame and not 0 to start playback for recording.
#jira UE-55933
Change 3934307 by Andrew.Rodham
Sequencer: Add template signature that is re-generated every time the base template is regenerated, which invalidates evaluation
fields
This fixes an issue where the same sequence is instantiated multiple times in a sequence.
If the source sequence was saved, its template would be wiped, which would invalidate the template ID
When an instance tries to evaluate the master template, it would only invalidate a range in the evaluation field that was the
hull of any invalid sub sequences overlapping the current time, potentially leaving invalid data in the evaluation field at positions
later (or earlier) on in the sequence
When the sub template was re-generated, it receives the same SequenceSignature as it had before (because the sequence hasn't
actually changed), which causes the stale evaluation field data to fail the IsDirty check (because the sequence is the same as it
thought, but the *template* has changed)
This has been addressed be adding a signature to templates themselves, and checking both the template signature and sequence
signature as a part of the IsDirty check. This ensures that we regenerate if either the template, or the sequence have changed.
#jira UE-55934
Change 3936327 by Andrew.Rodham
Sequencer: Removed increment when trimming right
UMovieSceneSection::TrimSection already explicity assigns an exclusive bound to the time passed in. The new behavior means we
can trim a section to the right, and insert another section without changing the time to create adjacent sections.
#jira UE-42652
Change 3936328 by Andrew.Rodham
Fixed KeyFrameManipulator assignment operators and copy/move constructors
- These types are potentially self-referential so cannot use default constructors/assignment
Change 3936330 by Andrew.Rodham
Converted UMGSequencePlayer to use frames internally
#jira UE-54878
Change 3936726 by Max.Chen
Sequencer: Set track node as the parent of the key area node. The key area switcher needs the object binding id from the parent
object binding node. Without this, the binding to the external value fails.
#jira UE-55931
Change 3936775 by Max.Chen
Sequencer: Should stop or loop should compare DurationFrames with Current Time from StartTime.
The bug is that if you set 30 warmup frames in movie rendering for a range of 0-100, the FrameRange will be starting at -30 and
have a duration of 130. Without this fix, the playback will continue until frame 130, rather than 100.
#jira UE-55933
Change 3936935 by Matt.Hoffman
Easing Curves are now represented in Play Rate resolution instead of internal resolution.
#jira UE-55937
Change 3937069 by Matt.Hoffman
Users can toggle if the is infinite on each side, limited by which tracks support infinite ranges.
#jira UE-55891
Change 3937516 by Max.Preussner
ImgMedia: Added support for single-threaded platforms
#jira UE-55986
Change 3937826 by Max.Preussner
MediaAssets: Disabling media sound components on HTML5 if AudioMixer is not enabled
Change 3937997 by Max.Chen
Curve Editor: Add Zoom to Fit Curves so that selected curves from Sequencer can be focused on. Tested that undo doesn't re-zoom.
#jira UE-55935
Change 3938000 by Max.Chen
Sequencer: Stop all sounds before generating audio waveforms.
#jira UE-55951
Change 3938376 by Max.Preussner
XGEController: Disabled XGE Controller in single-threaded apps to prevent crash
Change 3938444 by Max.Preussner
Core: Added async support for single-threaded applications
Change 3938445 by Max.Preussner
Networking: Added support for single-threaded applications in UDP socket sender/receiver
Change 3938447 by Max.Preussner
Messaging: Added support for single-threaded applications
Change 3939432 by Max.Chen
Sequence Recorder: Append command list to global level editor actions so that shortcuts are accessible in level editor.
#jira UE-55798
Change 3940229 by Andrew.Rodham
Added prospective display rate upgrade to UMovieScene::PostLoad
- There was previously some very odd behaviour that would assign the fixed frame interval only when a sub sequence was focused
in SSequencer. This meant that many sequences could have a frame interval of 0 set in the data.
- Under the old method of snap interval display this would have fallen back to getting the display interval from the sequencer
settings, but we no longer look at these.
- The USequencerSettings properties have been removed and in their place, a prospective data upgrade for sequences that have a
fixed frame interval old 0fps that sets the play rate to the previous defaults based off the old USequencerSettings defaults.
- This could end up 'changing' the display rate for sequences where the user has changed the snap interval in the settings for
a particular sequence editor, but there's not much we can do about that given we don't have access to the USequencerSettings classes in
UMovieScene
#jira UE-55919
Change 3940277 by Andrew.Rodham
Sequencer: Added ability to default frame resolutions and play rates for newly created actor sequences
Change 3940378 by Andrew.Rodham
Sequencer: Post move import dialog now defaults to the playback framerate of the sequence, and floors to frame numbers
Change 3940559 by Andrew.Rodham
Reinstated primed or recording sequence color
Change 3940642 by Max.Preussner
ImagePlate: Removed image plate media playback functionality
Change 3940843 by Max.Preussner
Core: Made TCircularQueue actually thread-safe; improved code comments
Change 3940860 by Max.Chen
Sequencer: Changed StructNameToKey to StructPathToKey
Previously, keying a PropertyPath of [RenderTransform][Shear][X] would get trimmed to X, which doesn't map to a channel name as
considered by Sequencer2dTransformTrackEditor. Instead, trim the resulting property path to [Shear][X] so that track editors can
determine the desired struct path and channels to key.
#jira UE-52966
Change 3941292 by Mike.Zyracki
Fix for trajectories out of range not showing up.
1) If we had no key data we would pop the time, so wouldn't get the section ranges.
2) Calculating of upper bound was wrong, checking against -1 and not key == num of keys when doing algo::lower_bound.
3) No need to do the Bck-- for the bakward iterators since we fixed#2. We start now from the upper bound correctly.
4) If we had no keys (at section start,end) we would incorrectly say we were any key type, so since we draw constant keys as
dashed we would do so incorrectly around section end points.
#jira UE-55929
Change 3941424 by Max.Chen
Curve Editor: Change Zoom to Fit to use TArrayView
Change 3941498 by Max.Preussner
Core: Added FMath::DivideAndRoundNearest function
Change 3942097 by Matt.Hoffman
Drop Frame Timecode Support for NTSC rates.
Change 3942104 by Matt.Hoffman
Sequence Recorder Group is no longer visible inside the World Outliner after using one.
#jira 55266
Change 3942107 by Max.Chen
Sequencer: Resurrect logic to find or extend an existing section when adding keys.
Change 3942330 by Max.Chen
Sequence Recorder: Better tooltip for default animation settings.
#jira UE-55636
Change 3942339 by Max.Chen
Sequence Recorder: Better tooltip for default animation settings.
#jira UE-55636
Change 3942507 by Andrew.Rodham
Sequencer: We no longer pad the time overlap threshold with a small number that is not scaled by the current zoom level
- The presence of this pad was causing keys that were far apart to be grouped when zoomed in a long way
Change 3942509 by Andrew.Rodham
Sequencer: Only pad total view range, rather than section range as well when retrieving keys to render
- This stops us from rendering keys that are within the view range, but outside the section range
Change 3942512 by Andrew.Rodham
Added transactions to some sequencer details customizations
Change 3942513 by Andrew.Rodham
Sequencer: Reinstated validation checks to UMovieSceneSection::SetStartFrame and SetEndFrame, changed erroneous uses to use
SetRange
Change 3942560 by Andrew.Rodham
Pass by rvalue reference to appease error C2719 on Win32
('InChannels': formal parameter with requested alignment of 8 won't be aligned)
Change 3942697 by Andrew.Rodham
Newly Created Level Sequences and Actor Sequences now default to 24000 fps frame resolution (+/- ~24hrs range, supporting all
integer rates + 23.976)
Change 3942700 by Andrew.Rodham
Sequencer: Added legacy out-of-bounds errors for times that are not supported by the current legacy upgrade frame resolution
Change 3942989 by Max.Preussner
Core: Fixed circular queue count calculation
Change 3943538 by Max.Preussner
MediaAssets: Reverted workaround for procedural audio log spam in HTML5
(Actor component initialization cannot be skipped if the component is used in a level)
Change 3944071 by Max.Preussner
QAGame: Fixed Media Texture keeps last frame of Media when PIE ends
#jira UE-53360
Change 3944292 by Max.Chen
Sequencer: Added extra flags to ensure that asset initialization does not occur on template actor sequences
#jira UE-56113
Change 3944364 by Max.Chen
Sequencer: Prevent circular shot/master tracks.
Tested adding master -> child -> master as drag and drop cinematic shot tracks and sub tracks as well as through the + button.
#jira UE-56091
Change 3944422 by Max.Chen
Sequence Recorder: Disable transform recording if off.
#jira UE-56061
Change 3944745 by Andrew.Rodham
Sequencer: Key rendering fixes
- Fixed assert that occured when keys happened to reside on some times due to KeyTime + TimeOverlapThreshold - KeyTime being
slightly larger TimeOverlapThreshold
- Fixed keys sometimes being clipped when zoomed right in due to lack of half-frame offset
- Added missing documentation to MovieSceneTimeHelpers.h
#jira UE-56107
Change 3945231 by Andrew.Rodham
Sequencer: Reconstruct channel proxy on Serialize to catch all cases of undo/redo, PostLoad and duplication
#jira UE-56089
Change 3945301 by Andrew.Rodham
Sequencer: Added safety checks during initial sequence recording to guard against applying negative or 0-sized sequence ranges
#jira UE-56125
Change 3946627 by Max.Preussner
Fortnite: Fixed game crashes closing editor while in PIE - Pure virtual function being called
#jira UE-56144
[CL 3946896 by Max Chen in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3631172 by Max.Chen
Sequence Recorder: Record to the specified target animation for the target actor only. Newly tracked components will have newly created animations so that they don't record to the same target animation assets.
#jira UE-49304
#jira UE-49216
#jira UE-49300
Change 3632895 by Max.Chen
Sequencer: Fixed crash caused by erroneous persistent references to FSequencer.
#jira UE-48647
#jira UE-48383
#jira UE-47661
Change 3634864 by Max.Chen
Sequencer: Bake transforms
#jira UE-49136
Change 3634879 by Max.Chen
Sequence Recorder: Close the target animation asset editor if it exists before recording into it.
#jira UE-49216
Change 3650553 by Max.Chen
Sequencer: Switch shot display name to FString so that it's not localized.
#jira UE-49824
Change 3650848 by Darren.Pegg
Linear Timecode Plugin - first pass - still needs output interface
Change 3653174 by Max.Chen
Sequencer: Allow blending for vector tracks
#jira UE-49809
Change 3653205 by Max.Chen
Sequencer: Fix default burnin content.
#jira UE-49824
Change 3653570 by Darren.Pegg
Win32 Build fix: EmptyLinkFunctionForStaticInitializationLinearTimecode
Change 3658673 by Darren.Pegg
Timecode - Adding Accessors, renaming files
Change 3663633 by Max.Chen
Sequencer: Add option to export an object's transform to a camera anim asset.
#jira UE-49599
Change 3665971 by Max.Chen
Sequence Recorder: Add an active column for sequence recorder
Change 3666066 by Max.Chen
Sequencer: Suspend broadcast of selection delegates when performing multiple operations.
#jira UE-40371
Change 3671057 by Max.Chen
PR #4055: Fixed ACameraRig_Rail PreviewMeshes to match Spline Component (Contributed by Hemofektik)
Change 3677104 by Max.Chen
Sequencer: Add transaction for easing length.
#jira UE-50588
Change 3677105 by Max.Chen
Sequencer: Restore pre-animated state when changing active channels.
#jira UE-50473
Change 3681069 by Max.Preussner
LinearTimecode: Processing samples only if they have been dequeued successfully
Change 3681783 by Andrew.Rodham
Control Rig: Fixed crash attempting to zero out array with the wrong size
Change 3681949 by Darren.Pegg
OnTimecodeChange Delegate, Comments in DropTimecode, DropTimecode to string auto conversion
Change 3682222 by Andrew.Porter
EngineTest: Enabled MP4 Media Player test in the level ShaderModels. Set the texture ShaderModelPlayer_Video to use the correct media player.
#jira UE-47213
Change 3683523 by Andrew.Rodham
Sequencer: Display sub sequence name on binding ID pickers rather than the sub section name
Change 3684318 by Max.Chen
Sequencer: Fix crash in dragging a level sequence into the tree area.
#jira UE-50902
Change 3687609 by Max.Chen
Curve Editor: Add ModifyOwnerChange to CurveOwnerInterface. Call mark as changed when modifying keys or tangents.
#jira UE-50882
Change 3687617 by Max.Chen
Sequencer: Move some commands out of the generic sequencer command bindings so that they don't take over the viewport. ie. End for "Snap to Floor" should still function in the viewport.
#jira UE-50997
Change 3687969 by Andrew.Rodham
Sequencer: New compile on the fly logic
- Sequencer is now able to compile partially or completely out-of-date evaluation templates from the source data as it needs. This affords much more efficient compilation when working within sequencer.
- Added the concept of 'instance data' for sub sequences, available through the IMovieScenePlayer interface or persistent data stores. This replaces the compilation of specific templates for control rig templates.
- Moved sub tracks and sections to MovieScene module
- Removed the concept of shared tracks. Any previous uses should port over to shared execution tokens instead.
#jira UE-46789
Change 3689884 by Max.Chen
Sequencer: Remove null tracks on object bindings. Tracks can become null if they're from a plugin and the plugin is disabled.
#jira UE-50839
Change 3690130 by Andrew.Rodham
Sequencer: Fixed UMG animations not working with blueprint nativization
Change 3690162 by Andrew.Rodham
Sequencer: Fix assert when using filler shots
#jira UE-51029
Change 3691904 by Max.Chen
Sequencer: Fix overlap by looking at the key behind as well. This fixes a bug if there's 3 keyframes on consecutive frames, if you zoom out, you should see two bordered keys when the overlap threshold is passed.
#jira UE-50993
Change 3692149 by Andrew.Rodham
Sequencer: Change FSortByPrioritySegmentBlender::Blend to fall back to flag comparison if any sections are null for automation tests.
- Combinations of null/non-null will never happen in the wild because we either run with sections or without, but the static analysis doesn't know that
Change 3692212 by Andrew.Rodham
Core: Changed TRange to pass-by-value for small types, inlined some functions
Change 3693044 by Max.Chen
Sequencer: Update pivot location for selection when closing sequencer.
#jira UE-51132
Change 3693061 by Max.Chen
Sequencer: Remove force evaluate on end scrubbing. Backout previous fix because 3657907 is the real fix.
#jira UE-45905
Change 3694308 by Andrew.Rodham
Sequencer: Sub tracks now blend correctly again
#jira UE-51076
Change 3694365 by Andrew.Rodham
Sequencer: Fixed exponential slow down when compiling large quantities of sub sequences on cook caused by not clamping sub-sequence compilation correctly
Change 3698176 by Max.Chen
Sequencer: Enable the camera cut track when popping back to the master only if there's a camera cut track in the master. This fixes an issue where if you don't have a camera cut track in the master, the camera gets locked to a camera cut in a subscene and you can't toggle out of it.
#jira UE-51332
Change 3698979 by Max.Chen
Sequencer: Fix delay before warmup causing sequences not to render.
#jira UE-51307
Change 3700149 by Max.Chen
Sequencer: Fix delay at shot boundaries causing sequences to not play back and render out. The shot id needs to be tracked to determine whether a new shot is encountered.
#jira UE-51307
Change 3705624 by Max.Chen
Sequencer: Reset drop node on drag leave
Change 3718781 by Max.Preussner
MediaAssets: Removed obsolete pointer checks (Playlist is always valid); added checks to enforce this invariant
Change 3721586 by Max.Preussner
MediaAssets: Added verbose logging to MediaPlayer BP functions
Change 3721662 by Max.Preussner
WmfMedia: Fixed media session not generating PlaybackEndReached event when session forced to stop
#jira UE-50962
Change 3722954 by Max.Preussner
MediaAssets: Removed looping option from play lists
Change 3723076 by Andrew.Porter
Removed controls for looping playlist.
Change 3724202 by Max.Chen
Sequencer: Spawn time optimizations
#jira UE-32885
Change 3725359 by Max.Chen
Sequencer: Fix spawnables not playing back. bIsEditorPreviewActor = false for sequencer spawnables so that BeginPlay() doesn't get skipped.
#jira UE-51750
Change 3725362 by Max.Chen
Sequencer: Change check to ensure for null object in property actuate. This prevents a crash when there's a track without a binding object. This occur when pasting a property track to the root.
#jira UE-51713
Change 3725802 by Max.Chen
Sequencer: Add the ability to drag sections up.
#jira UE-43305
Change 3726520 by Max.Preussner
MediaAssets: Fixed OnMediaOpened called when looping a source
#jira UE-51773
Change 3728509 by Max.Chen
Sequencer: Fix crash pasting a camera cut track because the outer isn't set to the movie scene.
#jira UE-51787
Change 3729216 by Max.Chen
Sequencer: Fix pre edit property chain broadcast so that the property path will include possible struct/array node.
#jira UE-51525
Change 3729248 by Max.Chen
Sequencer: Add default expansion states to allow track editors to specify them per track type.
Material track is currently the only track that defaults to expanded.
#jira UE-21741
Change 3729392 by Max.Preussner
ImgMedia: Disabling video output when video track is selected
Change 3729452 by Max.Preussner
MediaPlayerEditor: Showing a notification if no video track available or selected
Change 3729462 by Max.Preussner
MediaPlayerEditor: Creating overlay font only once
Change 3731155 by Max.Chen
Sequencer: Set row index when creating a new take
#jira UE-51867
Change 3731446 by Max.Chen
Sequencer: Add null check and warning for invalid GetParameterCollectionInstance.
Change 3731640 by Max.Chen
Sequencer: Automatically create a camera cut track if a camera is dropped and there's no existing camera cut or there's no existing camera cut sections.
#jira UE-51846
Change 3731653 by Max.Chen
Sequencer: Defer details panel updates on scrubbing and playing.
#jira UE-48448
Change 3732597 by Max.Chen
Sequencer: Don't swap the camera cut section if it already exists and a camera is created.
Change 3733554 by Max.Chen
Sequencer: Fix crash when existing hotspot is null.
Change 3734305 by Max.Preussner
MediaAssets: Fixed assertion when assigning same media player to a media texture twice
#jira UE-51012
Change 3735735 by Max.Preussner
MediaFrameworkTest: Setting MediaAssets log category Verbose to prevent log spam in Editor
Change 3736393 by Max.Chen
Sequencer: Set min/max values for generic key area so that they don't default to 0,10.
#jira UE-52012
Change 3736804 by Max.Chen
Sequencer: Fix rotation rotator->quat->rotator conversion which prevents you from typing in a rotation of 0,0,320 into the key editor. Unwind rotations from the previous transform to the current transform so that the nearest rotation is set rather than the rotator->quat->rotator conversion.
#jira UE-52009
#jira UE-34816
Change 3737790 by Max.Chen
Sequencer: Follow up fix to quat->rot->quat so that unwinding is only processed if the last transform is valid.
Change 3739738 by Max.Chen
PR #4184: Unregister Missing TrackEditors in MovieSceneTools (Contributed by LordNed)
Change 3741910 by Max.Preussner
MfMedia: Simplified track switching code; enabled seeking
Change 3742171 by Max.Preussner
MediaAssets: Fixed timecode check to include current presentation time
Change 3744889 by Max.Chen
Sequencer: Use drag and drop actor factory if specifiied. This ensures that the correct actor factory is used in creating the object template for the sequencer spawner. This fixes some spawnables not getting created properly (ie. Empty Actor)
#jira UE-51678
Change 3746049 by Andrew.Rodham
FBX Import: Fixed tangent overrides producing the wrong type of key tangent modes
Change 3747870 by Max.Chen
Sequencer: Update auto scroll when moving keys/sections.
#jira UE-31212
Change 3747885 by Max.Chen
UMG: Remove template instance finish on pause. It appears that was only there to stop audio (CL #3161056). Instead, evaluate in the stopped position with the stopped playback state.
#jira UE-47749
Change 3747914 by Max.Chen
Sequencer: Add config for default completion mode for movie scene sequences. The default for level sequences is RestoreState. All others, such as UMG are set to KeepState.
#jira UE-49480
Change 3747915 by Max.Chen
Sequencer: Set default completion mode for all sections to project default.
#jira UE-49480
Change 3748377 by Max.Preussner
EngineTest: Fixed media player automation test BP
#jira UE-50637
Change 3748531 by Max.Preussner
EngineTest: Fixed media player not opening media during FTest setup
I fixed up the Blueprint. Also, don't use PlayOnOpen on the media player if you don't intend to play the movie after opening. You can call Pause right after opening. If you enable PlayOnOpen, the order of operations will not work, because it will first call Pause via the IsReady check in Tick and then Play via the PlayOnOpen checkbox. I disabled PlayOnOpen.
#jira UE-47207
Change 3750362 by Max.Chen
PR #4205: parameter not used bug fixes (Contributed by shrimpy56)
Change 3750885 by Max.Chen
Sequencer: Prevent throttling on the curve editor so that editor world tick can apply.
#jira UE-51624
Change 3757123 by Max.Preussner
MediaAssets: Allowing media players to be part of GC clusters
#jira FORT-59774
#jira UE-51943
Change 3764055 by Max.Chen
Sequencer: Add SetPlaybackPosition as latent action to fix crash when calling SetPlaybackPosition in an event.
#jira UE-52270
Change 3764555 by Max.Chen
Sequencer: Change camera cut binding from guid to object binding id to allow for subscene bindings
Change 3764613 by Max.Chen
Sequencer: Show binding ID picker customization on all details panels. Allow creation of new camera cut sections from existing bindings.
Deprecate AddNewCameraCut(FGuid)
Change 3766389 by Max.Chen
Sequencer: Don't override existing camera binding id on postload if it's valid.
Change 3766432 by Max.Chen
Sequencer: Switch constraint guid to constraint binding ID
#jira UE-52438
Change 3767160 by Max.Preussner
WmfMedia: Added more logging
Change 3767843 by Max.Preussner
MediaAssets: Fixed Crash in UMediaSoundComponent::UpdatePlayer
#jira UE-52594
Change 3771038 by Max.Preussner
Engine: Changed message log back to ensure
Cannot use message log on render thread as it may call LoadModule
Change 3771071 by Max.Preussner
MediaCompositing: Fixed default media plane material
Change 3771287 by Max.Preussner
Engine: Changed ensure to global log
Change 3771450 by Max.Preussner
MediaAssets: Fixed crash when dragging media player viewport
#jira UE-52675
Change 3771461 by Max.Preussner
ImgMedia: Fixed seeking not working when paused
#jira UE-52677
Change 3772999 by Andrew.Rodham
Sequencer: Added the ability to supply an instance data object to sequence runtime evaluation
- This allows systems to inject information into a sequence at runtime, enabling more dynamic control of tracks
- Level sequence actors use this by default to supply a dynamic 'transform origin' to all component transform tracks, to which all absolute transform sections will be added.
#jira UE-46003
Change 3774633 by Max.Preussner
MediaAssets: Fixed MediaPlayer.Prev/Next not playing automatically if player was playing previously
#jira UE-52714
Change 3774961 by Max.Preussner
UdpMessaging: Patch to make message serialization notification thread-safe
#jira UE-52624
Change 3778108 by Max.Chen
Sequencer: Scroll in track area.
#jira UESEQ-330
Change 3778270 by Max.Chen
Sequencer: Copy/cut/paste/duplicate object bindings
FMovieSceneCopyableBinding - struct containing the copied FMovieSceneBinding, FMovieScenePossessable and FMovieSceneSpawnable
MovieScene - AddPossessable, AddSpawnable with existing possessable or spawnable
ISequencer - FOnMovieSceneBindingsPasted to allow fixing up bindings on paste
#jira UESEQ-352, UESEQ-335
Change 3778674 by Max.Preussner
Engine: Fixed online documentation for external texture registry
Change 3778699 by Max.Preussner
Engine: Fixed external textures not registering correctly in all cases
#jira UE-52648
Change 3778776 by Max.Preussner
Engine: Corrected code comments for external texture registry
Change 3779153 by Max.Preussner
LinearTimecode: Fixed plugin category
Change 3779166 by Max.Preussner
WmfMedia: Reversing FourceCC display string, so it displays correctly
Change 3780576 by Max.Chen
Sequencer: Fix viewport invalidation so that it happens on sequence evaluation.
#jira UE-52836
Change 3780619 by Max.Chen
Sequencer: Always save default spawnable state regardless of focused sequence. This fixes a bug where if you step back to the master sequence (and the spawnable still exists), and then scrub outside the region where the spawnable exists, it gets destroyed but saved default spawnable state doesn't get called because it's no longer the focused sequence.
#jira UE-52008
Change 3781227 by Max.Chen
Sequencer: Add playback speed settings menu
#jira UESEQ-384
Change 3782213 by Max.Preussner
WmfMedia: Fixed H.265 frames being dropped due to false negative buffer size check
#jira UE-52859
Change 3782239 by Max.Chen
Sequencer: Add shortcut to tooltips
#jira UE-52795
Change 3782388 by Max.Preussner
WmfMedia: Fixed IYUV encoded AVI not playing correctly
#jira UE-52855
Change 3782541 by Chris.Babcock
Protect against asking for duration before prepare completed in movie player
#jira UE-52805
#ue4
#android
Change 3787676 by Max.Chen
Sequencer: Export unmatched float properties to custom attributes
#jira UE-52983
Change 3787788 by Max.Preussner
Extras: Natvis for FTimespan
Change 3789419 by Max.Chen
Sequencer: Fix import camera so that when new cameras are created, values from the fbx are going only to the newly created cameras.
Also, added bReduceKeys and bReduceKeysTolerance to import fbx.
#jira UE-52997
Change 3789628 by Max.Chen
Sequencer: Remove Shift-C and Shift-D as a hotkey for toggling the cinematic viewport as it was causing some confusion when users accidentally hit it.
Change 3789716 by Andrew.Rodham
Seqeuncer: Fixed slot animation not being restored for montages that are recreated during evaluation
- The issue here is that the animation system can deem montages as inactive at any point, and will re-create a new montage instance if this is the case. Previously, we stored pre-animated state on the anim instance, and cached the montage that we played, which meant that we attempt to restore a stale montage.
- The solution is to store pre-animated state for the montages, and cache the anim instance. This means we'll always store pre-animated state if the montage is re-created.
#jira UE-49981
Change 3789874 by Max.Chen
Sequencer: Add option to only show selected nodes only
ISequencer - Added OnGetIsBindingVisible(), OnGetIsTrackVisible()
LevelEditorSequencerIntegration - implement OnGetIsBindingVisible based on actor selection
#jira UESEQ-357
Change 3789877 by Max.Chen
Control Rig: Implement IsTrackVisible to show nodes in the sequencer tree that are selected.
#jira UESEQ-357
Change 3791514 by Andrew.Rodham
Image Plate: Fixed image plates not showing up in high res screenshots
- The image plate mesh had a LOD index of -1 which meant it never showed up when a LOD to render was specified
- Also simplified the bounds calculation
#jira UE-51764
Change 3791596 by Max.Chen
Sequence Recorder: Don't record editor only components
#jira UE-49071
Change 3791659 by Andrew.Rodham
Sequencer: Event struct payloads now support user defined struct default values on creation
#jira UE-45430
Change 3791718 by Max.Chen
Sequence Recorder: Fix level sequences not triggering when recording. Level sequences would not get recorded if the world settings actor was not recorded.
Change 3791761 by Max.Chen
Sequencer: Find available non-overlapping row index when adding subsections.
Change 3791837 by Max.Chen
Sequencer: Fix sequencer not updating after toggling Bind Sequencer to PIE/Simulate while PIE is active.
Change 3791875 by Max.Chen
Sequence Recorder: Add recording button now adds for any selected actors.
Change 3791880 by Max.Chen
Sequence Recorder: Fix end pie not stopping sequence recording if not recording world settings.
Change 3791932 by Max.Chen
Sequence Recorder: Record spawned actors immediately so that they won't be missed if they're deleted before tick. Clean up queued recordings that were from spawned actors.
Change 3791954 by Max.Chen
Sequence Recorder: Don't process if not recording on end pie.
Change 3791955 by Max.Chen
Sequence Recorder: Fix recording spawnables not getting the correct position for being spawned at.
Set a transform on the movie scene spawnable which will be used if the root component of the object template doesn't exist.
Change 3792061 by Max.Chen
Sequence Recorder: Change FOnRecordingStarted and FOnRecordingFinished to multicast delegate.
If a sequence being recorded into is currently open in sequencer, it gets reloaded to prevent crashes.
Change 3792271 by Max.Chen
Sequence Recorder: Duplicate the actor to trigger before playing so that a sequence can be recorded and played back at the same time.
#jira UE-49069
Change 3792292 by Max.Preussner
MfMedia: Fixed tracks being reported in reverse order
#jira UE-53074
Change 3792811 by Max.Chen
Sequencer: Add option to disable camera cuts on the movie scene player.
Change 3793341 by Max.Preussner
AvfMedia: Fix for crash when opening AVF Media after opening multiple players
Merged from shelved CL in Dev-Rendering
#author richard.wallis
#jira UE-52383
Change 3793642 by Max.Chen
Sequencer: Delete and rename icons.
PR #4194: Improvements to Sequencer (Contributed by projectgheist)
#jira UE-52139
Change 3794678 by Max.Chen
Sequencer: Fix crash on HandleRecordingFinished
#jira UE-53178
Change 3795007 by Max.Preussner
AudioMixer: Fix for AVF Media Player audio is garbled and has static
#author ethan.geller
#jira UE-52785
Change 3795103 by Max.Chen
Sequencer: Add bKeyCreated for FKeyPropertyResult and notify movie scene data changed when a key is created.
#jira UE-53175
Change 3795457 by Michael.Trepka
Reverted one of the changes from CL 3793341 as it was causing a crash at exit
#jira UE-53196
Change 3795739 by Max.Chen
Sequencer: Set ease in/out objects as transactional.
#jira UE-50594
Change 3796871 by Max.Preussner
MediaAssets: Fixed media texture initialization related crash on Metal; fixed white output on inactive media player; added proper support for clear color
#jira UE-51940
#jira UE-52932
Change 3796921 by Michael.Trepka
Fix for a crash in AvfMediaPlayer related to reusing FAvfMediaPlayer object
#jira UE-53181
Change 3797176 by Max.Preussner
MediaAssets: Fixed white flicker when rapidly swapping media players on a media texture
Also no longer clearing media textures each frame if they are not in use
#jira UE-52932
Change 3797515 by Max.Chen
Actor Sequence: Add nullptr check - fix actor sequence crash when actor sequence doesn't exist.
#jira UE-49103
[CL 3800998 by Max Chen in Main branch]
#lockdown Nick.Penwarden
#rb none
Change 3720210 on 2017/10/25 by Olaf.Piesche
Fixing dynamic material params for ribbons
#!codereview scott.kennedy
#!rb none
#!tests scott's test ribbon
Change 3720073 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: frank.fella
Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it.
#!Tests Minion automated tests no longer crash randomly.
#!rb SimonT
#!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3719233 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: philip.buuck
[OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead).
#!rb Matt.Schembari
#!tests PIE
[QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death
#!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3718474 on 2017/10/25 by Yannick.Lange
Niagara: Only show isolate menu items on track context menu if it is a system.
Rename "Isolate toggle" to "Isolated".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718095 on 2017/10/25 by Yannick.Lange
Niagara: Fix crash when not having dynamic parameter in material.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718069 on 2017/10/25 by Yannick.Lange
Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3717545 on 2017/10/24 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Removed read / write locks from PipelineStateCache.
#!rb Andrew.Grant, Gil.Gribb
#!test paragon ps4.
#!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3716928 on 2017/10/24 by Shaun.Kime
The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime.
#!rb olaf.piesche, simon.tovey
#!fyi olaf.piesche, simon.tovey, frank.fella
#!tests am now able to run Test_minionWave on PS4
Change 3715712 on 2017/10/24 by Yannick.Lange
Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3715430 on 2017/10/23 by Shaun.Kime
Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it.
#!rb none
#!fyi simon.tovey
#!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime
Change 3715368 on 2017/10/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main)
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3715226 on 2017/10/23 by Shaun.Kime
Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's.
#!rb none
#!fyi simon.tovey, olaf.piesche, frank.fella
#!tests ran in PIE
Change 3714645 on 2017/10/23 by Yannick.Lange
Niagara: Add ability to create particle system from this emitter in content browser.
#!rb Shaun.Kime
#!tests n/a
Change 3714200 on 2017/10/23 by Olaf.Piesche
Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target
#!codereview simon
#!rb none
#!tests Orion Niagara assets
Change 3713341 on 2017/10/23 by Yannick.Lange
Niagara: Fix NiagaraNodeIF output pins cannot be deleted.
Fix NiagaraNodeIF output pins cannot be renamed.
#!jira UE-50193
#!jira UE-50193
#!rb Shaun.Kime
#!tests n/a
Change 3713133 on 2017/10/23 by Yannick.Lange
Niagara: Isolate emitters in sequencer UI.
- Added being able to extend the sequencer track context menu with a delegate.
- Added entry in track context menu to toggle the selected emitters isolation state.
- Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters.
#!rb Shaun.Kime
#!tests n/a
Change 3712445 on 2017/10/22 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
UVScale, UniformAorBFloat, and LinearColorAlongVector added.
#!rb none
#!tests new autotest added
#!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3712420 on 2017/10/21 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1.
#!rb none
[CODEREVIEW] frank.fella
[FYI] simon.tovey, olaf.piesche, wyeth.johnson
#!tests created an emitter, disabled Acceleration Force.. still compiled.
#!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711602 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like:
LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData
#!jira UE-51511
#!rb Simon.Tovey
#!tests n/a
#!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711288 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: eric.ketchum
[Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work
#!rb: None
#!tests: PIE
[CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime
#!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711197 on 2017/10/20 by Olaf.Piesche
Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly
#!rb none
#!tests minion projectile ribbon trail
Change 3710634 on 2017/10/20 by Mic.Rooney
Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing.
#!RB: none
#!Test: tested/built locally ran preflight Editor/Monolithics build.
#!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3709686 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Added some more timerguards for slow timer manager tick objects.
Commented out for now.
#!rb Trivial
#!test Paragon Cooked ps4.
#!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708958 on 2017/10/19 by Shaun.Kime
Back out changelist 3708456 .. this was an unintentional change
#!rb none
#!tests n/a
Change 3708839 on 2017/10/19 by Shaun.Kime
Merging CL 3708835
Fixing Scott's common crash with adding an emitter with autocompile off
#!rb frank.fella
#!tests n/a
Change 3708784 on 2017/10/19 by Shaun.Kime
Merging CL 3708782
//Orion/Main/... to //Orion/DevGeneral/...
#!rb none
#!tests n/a
Change 3708600 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion
#!rb none
#!test golden path
#!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708473 on 2017/10/19 by Shaun.Kime
Merging Frank's changes for team color support from Main to Dev-General
#!rb Frank.Fella
#!tests test_minionwave worked
Change 3708456 on 2017/10/19 by Shaun.Kime
Particles.Random set to 0.0
#!rb none
#!tests n/a
Change 3708455 on 2017/10/19 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests passed minion fx autotest
Change 3707648 on 2017/10/19 by Shaun.Kime
Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made.
Defer deletion of dataset to RT.
Ensure resets don't mess with data inflight RT commands are using.
Checkin on behalf of Simon Tovey
#!jira OR-45423
#!rb Simon.Tovey
#!tests ran through the LaneMinionFXTests successfully on PC
Change 3707096 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago.
#!rb none
#!tests automated tests pass
#!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3706726 on 2017/10/19 by Rob.Cannaday
Merge XMPP resource version to use version 2 instead of version 3
#!rb trivial
#!tests compile
#!ROBOMERGE: Main, 44, Tencent
Change 3706349 on 2017/10/19 by Josh.Markiewicz
#!UE4 - Cross Voice code review feedback
- fixed up broken stack vs queue
- fixed GetRoomId returning int32 instead of uint64
- fixed switch room logic
- more/better logging
- more comments
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
#!rb none
#!tests local cheat codes
Change 3705453 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array)
#!RB Daniel.Wright
#!Tests LaunchOnPs4
#!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3705399 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: scott.kennedy
Default Niagara emitter changed color property to better default value.
Updated basic glow emitter
Added energy bubble base emitter
put a little more polish into siege minion impact FX.
#!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3704426 on 2017/10/18 by Shaun.Kime
Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423
#!rb simon.tovey
#!fyi hunter.kent
#!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure
Change 3703288 on 2017/10/18 by Olaf.Piesche
Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash
#!rb olaf.piesche, simon.tovey
#!tests minion test map PC and PS4
Change 3701373 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader.
#!rb Olaf.Piesche
#!tests test_minionwave runs
#!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3701108 on 2017/10/17 by Hunter.Kent
Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily.
#!RNX
#!Test PS4
#!rb @tim.elek
#!review-3701110 @andrew.grant, @daniel.lamb
Change 3701044 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: jon.lietz
- white space fixes
- added in more detail to logging
- fixed dragon GC to not hide when the mesh is hidden
#!rb none
#!tests complies and logging is updated
[FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen
#!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3700900 on 2017/10/17 by Shaun.Kime
Integrating possible crash fix from Dev-Niagara to Dev-Gen
#!rb none
#!tests n/a
#!fyi Olaf.Piesche
Change 3700492 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests done in branch
Change 3700217 on 2017/10/17 by Olaf.Piesche
Fix for potential crash in sprite renderer
#!rb none
#!tests minion test map
Change 3700216 on 2017/10/17 by Benn.Gallagher
Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master.
#!rb Lina.Halper
#!jira OR-45226
#!tests PIE + Standalone games hitting Rampage with Ghosts E
Change 3699660 on 2017/10/17 by Jason.Bestimt
#!ORION_DG - Fixes to UnrealHitchParser edge cases
#!RB:none
#!Tests: Ran on Logs from QA
#!CodeReview: ben.salem
Change 3699462 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!tests preflight ok
#!rb none
Change 3699010 on 2017/10/17 by Jeff.Williams
Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920
#!rb none
#!tests none
Change 3698519 on 2017/10/16 by Olaf.Piesche
Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts
#!rb none
#!tests minion wave test map
Change 3698380 on 2017/10/16 by Shaun.Kime
Updating logic to now support the autoattachment
#!rb none
#!tests autotests pass..
Change 3698263 on 2017/10/16 by Olaf.Piesche
Assume degrees for sprite rotation
#!rb none
#!codereview shaun.kime
#!tests test sprite emitter
Change 3697652 on 2017/10/16 by Olaf.Piesche
Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion
#!rb none
#!tests minion test map
Change 3696906 on 2017/10/15 by Shaun.Kime
Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers.
#!rb none
#!tests now no longer generates invalid errors
#!fyi frank.fella, olaf.piesche, simon.tovey
Change 3695456 on 2017/10/13 by Olaf.Piesche
Fix for potential ribbon crash and end-of-ribbon rendering artifacts
#!rb none
#!codereview scott.kennedy
#!tests minion wave test map
Change 3694545 on 2017/10/13 by Andrew.Grant
Fix for low frequency async loading crash (OR-42535)
#!rb gil.gribb
#!tests comppiled
Change 3694176 on 2017/10/13 by Jeff.Williams
Plugin manifest name changed to DLCFile name
#!rb none
#!tests compile, stage
Change 3693582 on 2017/10/12 by Don.Eubanks
Fixing PS4 Compile warning (constructor init order not matching member define order)
#!rb none
#!tests Compile Shipping Client PS4
#!fyi olaf.piesche
Change 3693516 on 2017/10/12 by Olaf.Piesche
Niagara: Remove mesh renderer assert, replace with early out
#!rb none
#!tests niagara mesh test asset
Merging
//Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
Change 3693051 on 2017/10/12 by Ben.Salem
Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log.
#!rb Clayton.Langford
#!tests Parsed a 5mb log with dumphitches down to 23k of hitch data.
Change 3692912 on 2017/10/12 by Olaf.Piesche
Merging: Niagara ribbon tiling distance
#!rb none
#!tests ribbon test asset
Change 3692835 on 2017/10/12 by Shaun.Kime
Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags.
#!rb none
#!fyi scott.kennedy, wyeth.johnson
#!tests n/a
Change 3692751 on 2017/10/12 by Shaun.Kime
Removing script that shouldn't have come over.
#!rb none
#!tests n/a
Change 3692746 on 2017/10/12 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests opened test level and created new emitter/system
Change 3692616 on 2017/10/12 by Don.Eubanks
OR-45131
Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking.
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
#!codereview nick.darnell
Change 3691912 on 2017/10/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none
#!tests compile, editor
#!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3690944 on 2017/10/11 by Jeff.Williams
Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC.
#!rb Daniel.Lamb
#!tests Compile, build
Change 3688989 on 2017/10/10 by Lina.Halper
LOD sync of attached/parent
#!rb: Laurent.Delayen
#!tests: price with shotgun skin/PIE/editor
Change 3687592 on 2017/10/09 by Ben.Salem
Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test.
#!rb clayton.langford
#!tests Ran sparrow shallow tests.
Change 3686560 on 2017/10/09 by Shaun.Kime
Flipping the min/max values to be standard
#!rb none
#!tests n/a
Change 3686046 on 2017/10/09 by Shaun.Kime
Merging latest from Dev-Niagara in preparation for Effects team work on Monday
#!rb none
#!tests successful preflight
#!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek
Change 3685613 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: simon.tovey
Implementing vector field matrix inverse fix from CL3675167 to 43.3.
#!rb none
#!tests none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685603 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
RotationalContent Improvements
- Fixed potential bug where tags could be updated when not intended on RotationalContentManager
- Fix for PIE assert
- Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option.
- Removing config tag from RotationalContentOverrides in OrionGlobals.
New Halloween Gauntlet Test
- Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box.
#!rb none
#!tests local builds / editor / PIE
#!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685408 on 2017/10/07 by ben.salem
Fixing robomerge error in DevGen
#!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. ben.salem, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml
--------------------------------------
Merging using DevGen->Release43.3
Repairing mailer for nightly Perf tests, fixing email headers.
#!tests run in devgen
#!rb none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685073 on 2017/10/06 by Andrew.Grant
Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3684717 on 2017/10/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where GT & RT times in profile info were reversed :(
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3684512 on 2017/10/06 by Laurent.Delayen
Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code.
#!rb lina.halper
#!tests minion AnimBP nativization
Change 3684059 on 2017/10/06 by Max.Preussner
Orion: Fixed ability videos not loading on PS4 and/or not looping
#!fyi stephan.jiang
#!jira OR-44682
#!rb none
#!rnx
#!tests none
Change 3683538 on 2017/10/06 by David.Ratti
batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions.
-Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players.
-Fixes case where killing minions with badass was not displaying pops (prediction key issue)
#!rb none
#!tests editor, pie
#!review-3683539 @Matt.Schembari
Change 3683364 on 2017/10/06 by Andrew.Grant
Changed warning to info
#!tests #!rb na
Change 3681999 on 2017/10/05 by Bart.Hawthorne
Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion.
#!rb cody.haskell
#!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore
#!jira OR-44111
#!tests Golden path, live spectated numerous matches.
Change 3681403 on 2017/10/04 by Josh.Markiewicz
#!UE4 - base pass for Tencent Cross SDK
- basic testing done with enter/exit/switch room
- basic testing of ShowUI
- checked in disabled
#!rb duck
#!tests see above
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
Change 3680623 on 2017/10/04 by David.Ratti
Rework for how max movement speed is calculated.
The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow.
Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored.
Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow.
GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc).
Suggested methods for inspection:
AbilitySystem debug hud (Home/End)
p.VisualizeMovement (displays final calculated movement speed)
Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar)
Technical information:
1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool.
2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows.
3. Added a notification for attribute sets when an aggregator is created for one of their attributes.
4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod)
5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension.
#!tests pie
#!rb FrankG
#!codereview Fred.Kimberley, Billy.Bramer
#!fyi colin.fogle
#!QAReview
#!RN
#!designchange
Change 3680580 on 2017/10/04 by Ben.Salem
Repair email titles for various reports.
#!rb none
#!tests Reran tests.
Change 3680438 on 2017/10/04 by Dan.Hertzka
GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect
- Fixes the HUD status effect feed not showing sources for a lot of itemization abilities
Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip
#!rb Dave.Ratti
#!tests OrionEntry PIE - equipped Sand Speeder
#!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on
Change 3680344 on 2017/10/04 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Speculative disable of defragging on volumetric lightmap textures.
#!rb andrew.grant
#!test monolith2 ps4
#!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3680302 on 2017/10/04 by Shaun.Kime
Integration from DevNiagara.
Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array.
#!rb none
#!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek
#!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass.
Change 3679946 on 2017/10/04 by Laurent.Delayen
Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches.
#!rb lina.halper
#!FYI andrew.grant
#!tests monolith2 old minions
Change 3679938 on 2017/10/04 by Daniel.Lamb
Allowed foliage cullall option to be modified by scalability options.
#!rb Trivial
#!test Compile paragon editor
Change 3679563 on 2017/10/04 by Jon.Lietz
OR-43599
- added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it.
#!rb Dave.Ratti
#!review-3679564 @John.Nielson
#!tests added these waits to hot pursuit and they worked as expected
Change 3679006 on 2017/10/03 by Ben.Salem
Try to fix broken nightly mailer issues for FX tests.
#!rb none
#!tests Preflighted a shallow fx pass successfully in EC.
Change 3677845 on 2017/10/03 by Andrew.Grant
Added an ensure to guard against OR-44826 while further investigations occur
#!tests compiled
#!rb none
Change 3677443 on 2017/10/03 by John.Nielson
Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase.
Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify).
#!RB: None
#!Test: Pie, Uncooked
#!review-3677445: @David.Ratti
Change 3676748 on 2017/10/02 by Laurent.Delayen
Minions: split body layer is now done in mesh space, to maintain upper body orientation.
#!FYI ray.arnett, lina.halper
#!rb none
#!test lane minion test map
Change 3675950 on 2017/10/02 by Don.Eubanks
Added several new supported tags / status effects to the Floating Status Effect Text system.
Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player.
Added ScaleOverDistance curve support for floating numbers / text.
Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out.
#!rb matt.schembari
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4
Change 3675186 on 2017/10/02 by Mic.Rooney
Support for other anim curve driving audio types (right now specifically DialogueWave)
#!RB: none
#!Test: compiled editor/monolithics/withoutunity and tested locally.
#!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3675167 on 2017/10/02 by Shaun.Kime
Changed unsafe InverseFast() to an Inverse()
#!jira OR-44671
#!rb Simon.Tovey
#!tests n/a
Change 3674888 on 2017/10/02 by David.Ratti
GGP V2
* Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration.
Item System:
* Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords.
* Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup).
Ability System:
* SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE)
#!rb none
#!tests editor pie cooked
#!review-3674889 @Jon.Lietz
Change 3674170 on 2017/09/30 by Mieszko.Zielinski
Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion
Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load.
#!rb none
#!test golden path
#!OR-44738
Change 3672937 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files
#!tests 3compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672867 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored previous behaviour of integer numbers being formatted as "1" and not "1.00"
#!tests ran game, checked playlist analytic
#!rb nikdel
#!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672575 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Remove warning that can happens normally with backwards compat replays
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672548 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Andrew.Grant
#!test Editor building hlods
#!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672542 on 2017/09/29 by Andrew.Grant
Merging
#!rb #!tests na
Change 3672390 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed memreport settings for frontend tests
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672385 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Reworked and pretty much final PipelineState cache code
- various comments incorporated
- namespaced functions
- removed redundant class and replaced with ref pointer
#!tests soaked a lot
[at daniel.lamb,] [at arne.schober] #!rb none
#!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672281 on 2017/09/29 by Rob.Cannaday
Add user ID to OnNetworkCheatDetected
#!jira TEN-272
#!jira TEN-273
#!jira TEN-274
#!rb rob.cannaday
#!tests Win64 AI match, simulate cheat detected by cheat command
#!review-3672282 @ian.fox @sam.zamani
Change 3671688 on 2017/09/29 by Frank.Gigliotti
Added ability to set developer comment when adding native tags.
#!RB David.Ratti
#!Tests None
Change 3670409 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for dump type made while doing cleanup
#!tests compiled Win64, PS4, ran PS4
#!rb none
#!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3670399 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed race condition in pipeline state cache
Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon
(Couple of extra tweaks planned, but this should be GTG for a v43 release)
#!rb codereviewed
#!tests soaked locally, lots
#!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669802 on 2017/09/28 by Andrew.Grant
From Dev-Framework
#!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed
#!rb michael.noland
#!codereview andrew.grant
#!tests na
Change 3669709 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669177 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Reflection Captures support Lighting Scenarios without recapturing
* Reflection Captures are now part of the Map Build
* Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message)
* Reflection Capture build data moved to the BuildData package
* Building lighting / reflection captures no longer dirties ULevels
* Sky lights which capture the scene now work correctly with Lighting Scenarios
* Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded)
#!rb Marcus.Wassmer
#!TESTS Paragon editor Monolith02
#!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669124 on 2017/09/28 by Daniel.Lamb
Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush
to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush
Fix cook in devgeneral
Bumped shader version to invalidate stale uniform buffer name.
#!rb none
#!TESTS none
#!fyi Daniel.Wright
Change 3667906 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667899 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Remove unused SM4 reflection capture cubemap
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667894 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] SM4 fallback for reflection captures.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667859 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] Removed old rasterized deferred reflection env path.
Removed reflection compute shader. Replaced with PS. Small perf gain.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667852 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed missing include
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667807 on 2017/09/27 by Daniel.Lamb
Tencent DLC can now remap the plugin content to the game root directory.
#!rb Ben.Marsh
#!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test
Change 3667753 on 2017/09/27 by Clayton.Langford
Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer.
#!RB Ben.Salem, Adric.Worley
#!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat
Change 3667408 on 2017/09/27 by Jordan.Walker
Optimization to bakedNormal layer blend on Low end material quality
-uses simple multiply and add normal map blend
Change 3667388 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times.
#!rb none
#!TESTS QAGame on console
#!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667383 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667265 on 2017/09/27 by Daniel.Lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Uriel.Doyon
#!test Editor building hlods
Change 3667159 on 2017/09/27 by Mieszko.Zielinski
Added simple logging to BT loading allowing us to identify missing BB keys #!Orion
#!test golden path
#!rb Lukasz.Furman
Change 3665944 on 2017/09/26 by Dan.Hertzka
Fix PS4 compile
#!rb none
#!tests compile PS4
Change 3665590 on 2017/09/26 by Daniel.Lamb
Fix for DLC cooking everything when it should only cook the DLC.
#!rb None
#!test None
Change 3665569 on 2017/09/26 by Dan.Hertzka
New status effect feed for the new HUD:
- Now placed in the mid-upper-left side of the HUD
- Biggest difference from before is that there are now names associated with each effect
- If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet.
Cleaning:
- Deleted all of the old buff widget classes & codepaths
- Removed redundant properties from StatusEffectDisplayInfo
- Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData
Also:
- Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events
- Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed)
@todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.)
#!rb Don.Eubanks
#!tests OrionEntry PIE with some cards and hero abilities
#!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial.
#!lockdown Billy.Rivers
Change 3665555 on 2017/09/26 by Daniel.Lamb
AudioStreaming mpsc queue fix up.
#!rb Andrew.Grant
#!test Compile paragon client / editor.
Change 3665517 on 2017/09/26 by Daniel.Lamb
Suspect fix for OR-44619
#!jira OR-44619
#!test Paragon editor compile
#!rb Trivial
Change 3664346 on 2017/09/26 by Jon.Lietz
- making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out.
- Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired.
- Updated all GC's data to use the new decal class
- removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent
#!rb Dave.Ratti
#!reivew Dave.Ratti
#!tests used characters that had decal comps in the GC and they recylce as expected.
#!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed.
Change 3664099 on 2017/09/26 by Jon.Lietz
OR-44510
- bringing over engine fixes for the Enum Redirector from Dev-Framework
#!rb none
#!tests compiles and warnings are gone
Change 3663019 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Gil: fixed race condition in the PipelineStateCache
#!rb Daniel.Lamb
#!test paragon ps4 with higher repro modified build
#!lockdown Andrew.Grant
#!jira OR-44441
#!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663014 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready.
#!tests ran locally
#!rb [at daniel.lamb] [at arne.schober]
#!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663004 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed dev check for extra commandline args from /data to /temp0
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662999 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Fixed DateTime used for folders not being set
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662255 on 2017/09/25 by Sam.Zamani
#!tencent
- fix for link error due to missing define of static OnNetworkCheatDetected delegate
#!rb none
#!tests none
Change 3662073 on 2017/09/25 by Sam.Zamani
#!tencent
Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server
Possible options
#!jira TEN-275 TSS detect and expose punish user callbacks
KickClient - User should be booted from the current game session via disconnect
KickMatch - User received info about being punished (eg. ban type etc)
PunishInfo - User received info about being punished (eg. ban type etc)
#!rb rob.cannaday
#!tests none
Change 3659487 on 2017/09/22 by Josh.Markiewicz
#!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin
#!review-3659190 john.barrett, ryan.gerleve
Change 3659485 on 2017/09/22 by Josh.Markiewicz
#!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins
#!fyi john.barrett, ryan.gerleve
Change 3659184 on 2017/09/22 by Josh.Markiewicz
#!UE4 - delete EpicSurvey module
#!fyi justin.sargent, nick.darnell
#!rb none
Change 3658697 on 2017/09/22 by Ryan.Gerleve
Fixes for server-side Tencent anti-cheat library integration:
-Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows
-Add getter for the TssSdkAntiInterf object
-Enable server anti-cheat in editor builds
#!codereview sam.zamani
#!rb none
#!tests enabled Tencent OSS, built & ran server
Change 3658200 on 2017/09/22 by Graeme.Thornton
Manual copy of CL 3587584 from Dev-Core
Logging improvements for pak signature check failures
- Added "PakCorrupt" console command which corrupts the master signature table
- Added some extra log information about which block failed
- Re-hash the master signature table and to make sure that it hasn't changed since startup
- Moved the ensure around so that some extra logging messages can make it out before the ensure is hit
- Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again
#!rb none
#!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General
Change 3657970 on 2017/09/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition.
We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game,
[at marcus.wassmer,] [at arne.schober] #!rb none
#!tests cycled 6-7 levels of Paragon
#!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657914 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing...
#!tests stepped through in non-pkg build
#!rb none
#!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657906 on 2017/09/21 by Andrew.Grant
Improved some logging
#!tests used locally
#!rb none
Change 3657891 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing
Fixed issue with -dev mode on PS4 not updating symbols
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657867 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Re-locked network CL to 3652780
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657857 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444
#!RB:arciel.rekman
#!Tests:Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf
#!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657852 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for case-insensitivity causing title.json not to be staged
#!rb daniel.lamb, bob.tellez
#!tests ran packaging script, verified contents match v42
#!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657831 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors
We can worry about a more permanent solution after we get this live.
#!RB:none
#!Tests: Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer
#!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657824 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb
--------------------------------------
Built new UnrealCEFSubprocess client
Changed OrionBuild.xml to build the shipping version of the above.
The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this.
[at justin.sargent,[at benjamin.crocker,[at wes.fudala]]]
#!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657488 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: anton.migulko
LIGHTING AND assets update
#!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3656388 on 2017/09/21 by Laurent.Delayen
Added default GetAxisVector static function to EAxisOption
#!rb none
#!FYI thomas.sarkanen
#!tests lane minions test map
Change 3656387 on 2017/09/21 by Laurent.Delayen
Initialize FAnimInstanceProxy with default constructor.
#!rb none
#!fyi lina.halper, thomas.sarkanen
#!tests lane minion test map
Change 3656003 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3650578 for patching
benjamin.crocker
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654403 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Merge DevCore -> Orion Release-43 CL 3641450
UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers.
#!rb Daniel.Lamb
#!test Compile
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654356 on 2017/09/20 by Andrew.Grant
Merging 3653658 from Dev-Rendering
#!tests compiled, ran editor
#!rb marcus.wassmer
Change 3653914 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access).
#!rb none
#!tests ran locally
#!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3652495 on 2017/09/19 by Andrew.Grant
Editgration of VR fix in 3643776 from Release-4.17
#!tests #!rb na
Change 3652244 on 2017/09/19 by Sam.Zamani
#!tencent
Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher
Added "-q" to whitelist of command line params for shipping builds
Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher
#!rb rob.cannaday
#!tests none
Change 3651493 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651490 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651489 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651445 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag
#!RB:none
#!Tests:none
[CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant
#!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651059 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed code to archive load-order during tests
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651043 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed error parsing from tests to put cause ahead of file info
#!tests ran self-test
#!rb none
#!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649683 on 2017/09/18 by Andrew.Grant
Bulk-merge of oustanding changes in Main to DG
#!tests #!rb na
Change 3649345 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Integrate fix for eidtor crash when switching between low and high scaleability options.
#!rb Olaf.Piesche
#!test Paragon editor
#!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649335 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - OR-44257 - Fix for hair not working
It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion.
#!RB:daniel.lamb
#!Tests:Re-tested in cooked build
[CODEREVIEW] daniel.lamb
#!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649231 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM
#!RB:none
#!Tests:none
[CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy
#!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649211 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix 'lowest' shadow settings (simple forward rendering)
#!rb arne.schober
[FYI] Daniel.Wright
#!tests monolith
#!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649141 on 2017/09/18 by Stephan.Jiang
Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source.
-- These are hacks for ability videos to work before we have the new Sequencer updates
-- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748
#!fyi Andrew.Grant, Max.Preussner
#!rb none
#!test compile
Change 3649087 on 2017/09/18 by Thomas.Ross
Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General
#!rb none
#!tests none
#!fyi Andrew.Grant,Jeff.Williams,dan.oconnor
Change 3649066 on 2017/09/18 by Max.Preussner
WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources
#!rb stephan.jiang
#!rnx
#!tests none
Change 3649049 on 2017/09/18 by Max.Preussner
Media: Changed audio sample rate warning to verbose log
#!fyi stephan.jiang
#!rb none
#!rnx
#!tests none
Change 3648752 on 2017/09/18 by Max.Preussner
WmfMedia: Fixed race condition in media sound wave
#!rb none
#!rnx
#!tests none
Change 3648748 on 2017/09/18 by Max.Preussner
WmfMedia: Hack for preventing flicker between media source switching
Do not merge to Dev-Main!
#!rb stephan.jiang
#!rnx
#!tests none
Change 3648596 on 2017/09/18 by Bart.Hawthorne
More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough.
Change 3648575 on 2017/09/18 by Sam.Zamani
#!tencent
Fix for missing library calls when initializing TSS anti cheat SDK
#!rb none
#!tests compiles win64 server
Change 3648556 on 2017/09/18 by Jeff.Williams
Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084
Clearing up robomerge
#!rb none
#!tests none
Change 3648533 on 2017/09/18 by clayton.langford
Unblocking RM.
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly.
#!RB Adric.Worley
#!tests none
#!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3648219 on 2017/09/18 by Sam.Zamani
#!tencent
fixed Tencent module thirdparty dll runtime dependency paths
fixed DLLHandle not being set
#!rb none
#!tests none
Change 3647998 on 2017/09/18 by Clayton.Langford
Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763.
#!tests compiled
#!rb Adric.Worley
Change 3647817 on 2017/09/18 by James.Golding
Mirror fix from 4.18 release stream (CL 3647799) to Dev-General
Fix out-of-bounds access of cloth mapping data during CPU skinning
#!rb benn.gallagher
#!jira UE-49628
#!fyi benn.gallagher
#!tests convert RiftMage to static mesh
Change 3647749 on 2017/09/18 by Benn.Gallagher
Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope.
This caused matrix transposition to fail after the data was copied in using memcpy
BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs.
#!rb none
#!tests Editor reimport of clothing assets
Change 3646242 on 2017/09/15 by Tyler.Cole
Revert shared engine LocalMCP scripts.
Change 3646153 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds
#!RB:daniel.lamb
#!Tests: Ran cooked Client
[CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy
#!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3646125 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews.
#!RB Marcus.Wassmer
#!tests automated performance tests
#!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3645861 on 2017/09/15 by clayton.langford
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW.
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added.
To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards
Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated.
#!tests ran local client/server, preflighted
#!rb Ben.Salem
#!rnx
[FYI] Sean.Tobin, Hunter.Kent, Edward.King
#!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3644062 on 2017/09/14 by Aaron.McLeran
#!jira OR-44171 Some looping sounds are extremely loud
#!rb Ethan.Geller
#!tests run paragon, run near water river, don't observe looping sound being very loud
Change 3643901 on 2017/09/14 by Laurent.Delayen
Integrated CL #!3604725 to fix bug with opening state machines from anim graph.
#!rb none
#!tests fixes bug
#!FYI lina.halper
Change 3643641 on 2017/09/14 by Rob.Cannaday
Fix unreachable code detected
#!rb rob.cannaday
#!tests Win64 compile
Change 3643326 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TerSafe.dll loading until staging issues can be resolved
#!rb none
#!tests none
Change 3643039 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TSS on servers due to linux build issues
#!rb none
#!tests none
Change 3642438 on 2017/09/13 by Rob.Cannaday
Handle new analytics param types (number, string, etc)
Stub implementation of FAnalyticsProviderETTencent DefaultAttrs
#!rb rob.cannaday
#!tests Win64 vs AI match
Change 3641655 on 2017/09/13 by Sam.Zamani
#!tencent
WIP added tss_sdk.dll (server) and TerSafe.dll (client)
JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client
JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers
#!rb none
#!tests PC run with RegionCN.pak enabling tencent mode
Change 3641559 on 2017/09/13 by Bart.Hawthorne
Fix up oodle dictionary generation scripts
#!rb none
#!jira none
Change 3641550 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3641393 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev.
Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled
- Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false)
- Added PGOInput option to TargetRules and passed through to compile environment
- Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for
- Updated PS4 toolchain to use both LTO and PGO depending on what was set
#!tests soaked locally, preflighted
#!rb codereviewed
FWIW here are before/after results for LTCG.
Orion Performance report from 3 games and 1441.51 seconds
MVP: 2.83 (Min: 2.05, Max: 3.22)
HPM: 4.29 (Min: 4.24, Max: 4.37)
AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms)
GT: 12.88ms (Min: 12.68ms, Max: 13.25ms)
RT: 13.71ms (Min: 13.48ms, Max: 14.08ms)
GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms)
Orion Performance report from 3 games and 1440.49 seconds
MVP: 1.42 (Min: 1.02, Max: 1.94)
HPM: 3.25 (Min: 2.75, Max: 3.62)
AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms)
GT: 11.93ms (Min: 11.64ms, Max: 12.47ms)
RT: 12.80ms (Min: 12.54ms, Max: 13.24ms)
GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms)
#!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640885 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Limited warning to once every 10 secs.
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640875 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed shipping config issue
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640870 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Fixing CIS builds #!Orion
The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors.
[CODEREVIEW] John.Nielson
#!rb none
#!test compilation
#!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640783 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
More temporary logging for finding the missing FX issue.
#!rb: none
#!Test: Pie
#!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639910 on 2017/09/12 by Rob.Cannaday
Build fix for AnalyticsETTencent
#!rb rob.cannaday
#!tests compile Win64 DebugGame Editor
Change 3639565 on 2017/09/12 by Laurent.Delayen
SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0.
#!rb lina.halper
#!FYI lina.halper
#!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime.
Change 3639228 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Tools - Added ability to postmortem a PS4 devkit for last crash
#!rb run locally
#!tests none
#!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639075 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Specifically requesting 'all' configuration, to avoid missing manifest in jar.
#!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639022 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
Remove dependency on the editor style set in the WidgetReflector
- Fixes a crash when trying to use the reflector in a client cooked build
- Also updated Focusable column name to shared var
#!rb none
#!tests Widget Reflected in a cooked build
#!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638984 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638696 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Swapped problematic ensure to LogError, made draft obey notimeouts.
#!tests compiled
#!rb none
[at daniel.lamb]
#!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638644 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Third time's the charm
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638628 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure in a PS4 friendly way
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638583 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure to get a cook
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638545 on 2017/09/12 by Bart.Hawthorne
Add analytics for oodle compression percentages
#!rb ryan.gerleve, wes.hunt
#!tests ran a 2 person game with dedicated server and verified analytics were reported
#!jira OR-26386
Change 3638172 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Duplicate 3620803
Partial Fix for Dither Opacity Mask
#!rb none
#!tests PC monolith
#!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637643 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Fixing version stream to Main
#!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637524 on 2017/09/11 by Andrew.Grant
Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests build Win64 editor, ran tests locally
#!rb none
Change 3637402 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Restored logging of runoptions when not verbose
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637357 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Made 'none' test specify Attended
#!rb Daniel.Lamb
#!tests compiled
#!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637305 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added temporary debug logging cmd line option for finding Jira OrionOR-43600
#!RB: none
#!Test: Pie
[at David.Ratti]
#!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636549 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues
#!RB:none
#!Tests:none
[CODEREVIEW] uriel.doyon
#!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636507 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
[OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG.
Also:
- Added distance formatting type for simple ability description values (will automatically append u to the value)
- SimpleAbility description values can now go up to two decimal places
Engine:
- Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName
#!rb Matt.Schembari
#!tests PIE OrionEntry & FrontEndScene - various bug repros
#!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636372 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Implement fast particle pool memory.
Default is 2mb, automatically cleans up oldest used pool slots.
Estimated 1/4 time for STAT_PARTALLOC.
#!rb Jason.Bestimt
#!test paragon ps4 cooked
#!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636319 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue with fatal error message not being shown in reports.
Fixed issue where some cancelled tests reported as succeeded
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636264 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance
#!RB:none
#!Tests: Ran client cooked build
[CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon
[QAREVIEW]
#!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635288 on 2017/09/10 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices
Fixed missing - in SoloSmoke args that were causing trailing params to be lost
#!tests preflighted, ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635145 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to pick up SDK change for patch packages
#!rb none
#!tests none
#!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635097 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added cleardevices option to Gauntlet that removes all devices after running.
Added to Orion build scripts
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634985 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Cleaned up some logging around device failures
Attempt to handle "Too Many Connections" error at a lower level
Added removeall command to PS4DevkitUtil (not yet used)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634897 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Checking in change to timeouts to test theory
#!tests ran test locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634765 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Scrape another .05ms out of GPU particle simulation.
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634422 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for Gauntlet shutdown issue on builders
Fix for BP editing crash from Dev-Framework
#!tests ran locally
#!rb none!
#!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634139 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running
#!tests ran locally with single and file-based devices
#!rb none
#!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633799 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only.
#!rb none
#!tests monolith02 turrets
[CODEREVIEW] lina.halper
#!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633647 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Possible fix for OR-43926 from Arne
#!tests ran locally, observed no ensures or negative side-effects in UI or HUD
#!rb none
#!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633637 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Upped timeout for editorbased tests
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632565 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed some test code...
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632385 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device handling.
Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems.
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632177 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43
#!rb none
#!test local commandlet
#!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632131 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix a bug with new local vector-field only project setting
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632034 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where problem devices were reset each attempt
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631812 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device management in Gauntlet
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631787 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes.
#!rb none
[CODEREVIEW] martin.wilson
#!test bot game
#!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631251 on 2017/09/07 by Andrew.Grant
Additional device selection improvements
#!tests #!rb na
Change 3630861 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3630620 on 2017/09/07 by Laurent.Delayen
RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions.
#!rb Ori.Cohen
#!codereview benn.gallagher
#!tests lane minions test map
Change 3629990 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fix for gpu hang on ps4.
#!rb Marcus.Wassmer
#!test Paragon cooked ps4
#!jira OR-43835
#!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629980 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Moved some missed code to FDebug::HasAsserted()
#!tests na
#!rb none
#!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629975 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Project optimization to only support local vector fields.
separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost.
#!rb olaf.piesche
#!tests monolith ps4/pc
#!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629917 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix for sizebyspeed on ps4
#!rb Simon.Tovey
#!tests pc
#!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629620 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629554 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored screenshot support to gauntlet (now driven externally)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629495 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: don.eubanks
Stat panel will only show stat changes or improvements that come from Item sources (cards / gems)
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
[RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base!
#!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629468 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring()
Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread.
#!tests ran locally
#!rb none
[at marcus.wassmer]
#!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629410 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs
--------------------------------------
Fix for generating project files
#!tests GPF
#!rb none
#!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629369 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests)
#!rb none
#!tests verified signing is disabled and game gets to main menu with -fileopenlog
[at graeme.thornton]
#!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629254 on 2017/09/06 by Laurent.Delayen
URO: ensure we don't skip more frames than desired when switching LODs.
#!rb lina.halper
#!codereview martin.wilson, benn.gallagher
#!test lane minions test map
Change 3629191 on 2017/09/06 by Laurent.Delayen
Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions.
#!rb lina.halper
#!codereview martin.wilson
#!test lane minions test map
Change 3629130 on 2017/09/06 by Laurent.Delayen
AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug.
#!rb none
#!tests lane minion test map
Change 3628300 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed exception that could occur during tests if all devices were in use
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627915 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Undoing Oodle check for the time being
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627875 on 2017/09/06 by Jason.Bestimt
#!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables)
#!RB:none
#!Tests:none
#!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker
#!ROBOMERGE: MAIN, 43
Change 3627694 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Improved warnings
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627642 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
More logging for OR-43892 and OR-43779
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627247 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed check that turns out to be bogus
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627240 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures
#!tests compiled OrionClient
[at daniel.lamb] #!rb none
#!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627211 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added ensure for OR-43777
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626839 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added wait to PS4DevkitUtil before trying to postmortem crashdump
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626755 on 2017/09/05 by Rob.Cannaday
Merge //Orion/Release-Tencent to //Orion/Dev-General
Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT
TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded
#!rb sam.zamani
#!lockdown andrew.grant
#!tests Win64 vs AI match, QA smoke test
#!fyi sam.zamani
Change 3626285 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed BaseDir argument not being correctly applied in tests
Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626221 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame.
Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement
#!rb none
#!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz
[at Laurent.Delayen] [FYI] [at Andrew.Grant]
#!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3625925 on 2017/09/05 by Laurent.Delayen
If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want.
#!rb benn.gallagher
#!codereview martin.wilson, lina.halper
#!tests lane minion map
Change 3624051 on 2017/09/02 by Andrew.Grant
Fixed issue with test params not being set.
Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability.
#!tests preflighted
#!rb none
#!review-3624052 @ben.salem
Change 3623907 on 2017/09/02 by Andrew.Grant
Fixed usesyncedbuild option being broken in Gauntlet
#!codereview @daniel.lamb
#!tests compiled
#!rb none
Change 3623906 on 2017/09/02 by David.Ratti
Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides
#!rb none
#!test future wukong pie
Change 3623766 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box
#!rb none
#!Tests PC QAGame
Change 3623518 on 2017/09/01 by Don.Eubanks
Fix for Shipping Client PS4
#!rb none
#!tests Compile Shipping Client PS4
#!fyi daniel.lamb andrew.grant
Change 3623515 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials applied to static meshes operate on the object's bounding sphere
#!rb none
#!TESTS QAGame PC
Change 3623503 on 2017/09/01 by Daniel.Wright
[Copy] Fixed ObjectRadius in Volume domain materials
#!rb none
#!TESTS none
Change 3623102 on 2017/09/01 by Marcus.Wassmer
Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand
#!rb none
#!tests monolith on PS4
#!fyi olaf.piesche,tim.elek
Change 3623096 on 2017/09/01 by Marcus.Wassmer
checkslow -> check to find issues with ILC
#!rb none
#!tests ran monolith on ps4
Change 3622744 on 2017/09/01 by Laurent.Delayen
RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now).
Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies.
Take gravity from movement component if present, to inherit custom gravity scaling.
Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used.
If LOD enables new bodies, they are now initialized during simulation.
Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default.
Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change.
Added AnimStats for PreUpdate, Update and Eval.
#!rb ori.cohen
#!codereview ori.cohen, lina.halper, benn.ghallager
#!tests lane minion test map
Change 3622743 on 2017/09/01 by Laurent.Delayen
Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes.
#!rb lina.halper
#!tests lane minion test map
Change 3622742 on 2017/09/01 by Laurent.Delayen
'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings.
Renamed DisplayDebugCustom to DisplayDebugInstance.
#!rb lina.halper
#!tests lane minion test map
Change 3622738 on 2017/09/01 by Laurent.Delayen
Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams
#!rb lina.halper
#!tests lane minion test map
Change 3622666 on 2017/09/01 by Jian.Ru
Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements
#!jira UE-48972, OR-43455
#!rb Chris.Bunner
#!tests editor
Change 3622579 on 2017/09/01 by Andrew.Grant
Fixed shutdown issues with some tests being detected as errors
Simplied and cleanup some things in state management of tests.
#!tests ShortSOloGame test locally
#!rb none
Change 3622322 on 2017/09/01 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-40366 from v43
#!tests compiled
#!rb Aaron.McLeran
#!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3621054 on 2017/08/31 by Andrew.Grant
Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests preflighted
#!rb none
Change 3620755 on 2017/08/31 by Daniel.Lamb
Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations.
#!rb Jason.Bestimt
#!test Cooked paragon ps4
Change 3620541 on 2017/08/31 by Ben.Salem
Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting.
#!rb none
#!tests compiled.
Change 3620443 on 2017/08/31 by Mieszko.Zielinski
Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4
#!rb none
#!test golden path
Change 3620428 on 2017/08/31 by Aaron.McLeran
#!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General
#!rb Ethan.Geller
#!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports.
Change 3620411 on 2017/08/31 by Mieszko.Zielinski
Fix to removal of simuli sources from the AISense_Sight #!UE4
Made sure given source gets removed from ObservedTargets.
#!rb none
#!test golden path
Change 3620343 on 2017/08/31 by Ben.Salem
Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on.
#!rb clayton.langford
#!tests ran shallow and normal FX tests, generated hitches to display.
Change 3620050 on 2017/08/31 by Luke.Thatcher
[ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/...
- USE_DEFRAG_ALLOCATOR was not always defined in all cases.
#!rb Daniel.Lamb
#!tests none
Change 3619836 on 2017/08/31 by Andrew.Grant
Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team)
#!tests preflighted, ran locally
#!rb none
Change 3618597 on 2017/08/30 by Dan.Hertzka
Fixed Additive UI materials not being affected by the widget opacity
- We needed to multiply the sampled color by the alpha of the vertex color
Also added fade in anim for scoreboard when showing after the endgame cinematic
#!rb Nick.Darnell
#!tests Widget alpha affects additive materials
Change 3618441 on 2017/08/30 by Laurent.Delayen
Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display.
#!rb lina.halper
#!tests lane minions
Change 3618404 on 2017/08/30 by Paul.Moore
- Update to new MMS client API from Fortnite.
- Add MMS API plugin.
#!rb none
#!tests matchmaking, v2 MMS matchmaking, draft lobby.
#!lockdown andrew.grant
Change 3618167 on 2017/08/30 by Marcus.Wassmer
Fix fog on PS4, also volume texture clears.
#!rb luke.thatcher
#!fyi Jordan.Walker
#!tests ran monolith on ps4
Change 3617911 on 2017/08/30 by Andrew.Grant
Fix for OR-43401, lighting remaining unbuilt
#!tests ran cook, verified that lighting for bp components is now correctly found.
#!rb marc.audy
Change 3617765 on 2017/08/30 by Andrew.Grant
Fix for lighting always being unbuilt on some blueprints
#!tests cooked data and verified BP components have the correct transform and receive cached lighting data
#!rb marc.audy, bp-team
Change 3617757 on 2017/08/30 by Laurent.Delayen
clang fix
#!rb none
#!tests none
Change 3617700 on 2017/08/30 by Laurent.Delayen
Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated.
#!rb lina.halper
#!tests lane minions map
Change 3617695 on 2017/08/30 by Laurent.Delayen
Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays.
#!rb lina.halper
#!tests test lane minions map
Change 3616757 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-43459 from Laurent
#!tests na
#!rb Lina.Halper, Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616745 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3609966 in anticipation of patch
#!rb #!tests na
#!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616551 on 2017/08/29 by Daniel.Lamb
Fix memory leak in paragon.
#!rb Andrew.Grant
#!test Paragon ps4
Change 3613700 on 2017/08/28 by Andrew.Grant
Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion
Renabled r.Cache.UpdatePrimsTaskEnabled
#!tests ran locally
#!rb none
Change 3613694 on 2017/08/28 by Andrew.Grant
Added -teamsize argument to Orion none test.
#!tests ran None test :)
#!rb none
Change 3613638 on 2017/08/28 by Ben.Salem
Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created.
#!rb clayton.langford
#!tests Ran shallow and deep test for multiple characters.
Change 3612731 on 2017/08/28 by Chris.Bunner
[DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook.
#!rb
#!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb
#!tests Cooking/running simple scene with grass foliage
#!jira UE-48698, OR-42612
Change 3612695 on 2017/08/28 by Andrew.Grant
Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading
Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things.
#!tests ran NoneTest with -nomcp
#!rb none
Change 3612002 on 2017/08/27 by Andrew.Grant
Fix for crash seen during nightly tests
#!tests baseline perf didn't crast 3/3
#!rb none
Change 3611980 on 2017/08/27 by Andrew.Grant
PS4DevkitUtil post-mortem improvements to logging
#!tests run ShortSoloGame
#!rb none
Change 3611758 on 2017/08/26 by Andrew.Grant
Fix for warning
#!tests #!rb na
Change 3611737 on 2017/08/26 by Andrew.Grant
Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering
3517039 -
GitHub #!2655: Optimization for shadow map resolution selection for spot lights
* Use the radius of the inscribed sphere at the cone end as the spot light's screen radius
Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly
3545241 -
Fixed spotlight whole scene shadows using a radius 2x too long
3545347 -
Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame.
#!rb none
#!tests compiled
Change 3611718 on 2017/08/26 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs
--------------------------------------
Improved parsing of callstacks and errors in test logs
Added unit test for error parsing
#!tests ran locally, unit tests
#!rb none
#!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611704 on 2017/08/26 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Test fixes - addresses issue with memory report failing
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611683 on 2017/08/26 by Andrew.Grant
Upgraded PS4 SDK to 4.508.111
#!tests SoloGames locally
#!rb none
Change 3611466 on 2017/08/25 by Andrew.Grant
Changed none test to use monolith02 by default
#!tests compiled
#!rb none
Change 3611167 on 2017/08/25 by Laurent.Delayen
Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated.
#!rb none
#!tests lane minions
#!codereview martin.wilson
Change 3610850 on 2017/08/25 by dan.hertzka
Unclog Robomerge
#!rb none
#!tests none
Change 3610325 on 2017/08/25 by Andrew.Grant
Compile fix for PS4
#!tests compiled
#!rb none
Change 3610018 on 2017/08/25 by Laurent.Delayen
UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later.
#!rb lina.halper
#!tests venus ult on minion lane test map
Change 3609967 on 2017/08/25 by Daniel.Lamb
Merging using //Fortnite/Main/->//Orion/Dev-General/
Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4.
CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping.
- The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out.
- Added an extra flag to reset mip bias values when texture memory budget is increased.
#!rb Uriel.Doyon
#!jira FORT-45385
#!jira FORT-47739
CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4.
- Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled.
- Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted.
- Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps.
#!jira FORT-45229
#!rb Ben.Woodhouse
CL 3564368
LLM Changes
Summary:
LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead.
Changes where LLM hooks into the various allocation functions and pools.
Added more LLM tracking scopes.
Changed the way LLM gets its internal memory.
Writing stats out to csv
Fixed a few bugs with the tracker code
Details:
* re-enabled LLM by default in Dev builds for XB1 and PS4
* Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update)
* track allocations made from the defrag pool (PS4)
* track non-drfrag pool garlic allocations (PS4)
* track allocations made from PS4 malloc
* combined the RHI and Malloc trackers into the Default tracker
* changed stat groups to LLM, LLMPlatform and LLMOverhead
* OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set
* XMemAlloc now uses AllocationType if no LLM scope has been set
* renamed VirtualMap to LLMMap
* added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled.
* support for tracking allocations that move in memory (for the PS4 defrag allocator)
* support for tracking explicit memory without pausing the tracker
* LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg
* fixed check in FNameToTag. It was checking the wrong value when verifying the name index
* show a warning on screen if LLM has been enabled without debug memory enabled (on consoles)
* fixed program size tracking
* fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope.
* optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times)
* fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them.
* fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled
* changed default alloc size for LLMMap to 16K
* Added lots more LLM scopes renamed some of the existing ones
* made FMemBlock::Allocators private and added accessor functions, which include LLM tracking.
* fixed LLM alignment tracking in CustomVirtualAlloc
* implemented LLM on XB1 so that it properly tracks D3D12Allocations
* added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator
* tracking of render targets
* fixed LLM pool total column value.
#!rb luke.thatcher
CL 3565905
[ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/...
3458941 - Initial submission of new PS4 memory allocator.
3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible.
3498440 - Flexible and framebuffer memory fallbacks
3515704 - Add stats to new PS4 memory system.
UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly.
#!rb Ben.Woodhouse
CL 3580934
[FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo.
- Neo has 512 MB more direct memory than a base kit.
- Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB.
#!rb Marcus.Wassmer
#!jira FORT-50206
CL 3590180
[FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted.
- Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB.
- Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool.
- Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails.
#!jira FORT-49700
#!rb Aaron.McLeran
CL 3593920
[FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system.
- Incorrect bitmask usage was truncating the available memory value to 32 bits.
- Also includes some minor refactoring to make parts more readable.
- Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile.
#!rb Jonathan.Fitzpatrick
#!jira FORT-50918
CL 3597577
[FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU.
- Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack.
- With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is.
#!rb Stewart.Lynch
#!jira FORT-50825
#!jira FORT-49688
#!jira FORT-49695
#!jira FORT-50054
CL 3601951
[FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system
- Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0.
- Added garlic, onion and defrag stats to the platform memory stats struct.
- Added fixed pool sizes to platform memory stats.
- Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools.
#!rb Stewart.Lynch
#!jira FORT-52910
#!test preflight with baseline performance memory report tests, local tests on neo
#!rb Luke.Thatcher
Change 3608480 on 2017/08/24 by Uriel.Doyon
Instanced static mesh lightmaps are now updated correctly after lighting scenario changes
#!jira UE-48522
#!tests Build lighting, loaded maps
#!rb michel.dupuis
Change 3608407 on 2017/08/24 by Andrew.Grant
Reintegrated ROlando's cloth optimizations
#!tests #!rb none
Change 3608349 on 2017/08/24 by Rolando.Caloca
O - Cloth vertex buffers no longer generate dummy vertices
#!rb Lina.Halper
#!fyi James.Golding
#!tests Check obj list memory with multiple characters, tested animations
Change 3607815 on 2017/08/24 by Laurent.Delayen
Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha.
https://jira.it.epicgames.net/browse/OR-43186
#!rb none
#!tests Price hand two bone IK
#!codereview lina.halper, thomas.sarkanen
Change 3607770 on 2017/08/24 by Andrew.Grant
Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong
#!tests ran locally, updated parser test
#!rb none
Change 3607546 on 2017/08/24 by Jian.Ru
Add more control to chromatic aberration effect
#!jira UE-47138
#!rb Brian.Karis
#!tests editor
Change 3607270 on 2017/08/24 by Andrew.Grant
Mirroring 3605735 from FN to address bug with MIC deduplication
#!tests compiled
#!rb none
Change 3607082 on 2017/08/24 by Laurent.Delayen
Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands.
List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph).
Current debug Target is highlighted in a green bounding box.
Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player.
Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors.
Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation.
#!rb dave.ratti
#!tests lane minion test map, debugging individual minions
#!codereview jon.lietz
Change 3606772 on 2017/08/24 by David.Ratti
Spot edigrate CL 3606417 for accurate CurveTable memory tracking
#!rb none
#!tests none
[CL 3748735 by Andrew Grant in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3623720 by Phillip.Kavan
#jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build.
Change summary:
- Temporarily excluded all AnimBP assets from nativization as a workaround.
Change 3626305 by Phillip.Kavan
#jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default.
Change 3629145 by Marc.Audy
Don't hide developer nativization tool behind ini
Change 3630849 by Marc.Audy
Fix nativization uncompilable code when using a non-referenceable term in a switch statement.
#jira UE-44085
Change 3631037 by Marc.Audy
(4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it
#jira UE-49440
Change 3631206 by Marc.Audy
Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT(""))
Change 3631232 by Marc.Audy
Remove outdated diagnostic code throwing false positives
#jira UE-47986
Change 3631573 by Marc.Audy
Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's'
Change 3633168 by Lukasz.Furman
fixed behavior tree changing its state during latent abort,
modified order of operations during abort to: abort & wait -> change aux nodes -> execute
Change 3633609 by Marc.Audy
Don't get unneeded string
Change 3633691 by Marc.Audy
Fix copy-pasting of a collapsed graph containing a map input losing the value type
#jira UE-49517
Change 3633967 by Ben.Zeigler
Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build
bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript
Fixed a few other fields to be private that were accidentally made public in 4.17
Change 3633984 by Michael.Noland
Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links
Change 3634464 by Ben.Zeigler
Header cleanups for Pawn, Controller, Character, and PlayerController
Change 3636858 by Marc.Audy
In preview worlds don't display the light error sprite
#jira UE-49555
Change 3636903 by Marc.Audy
Fix numerous issues with copy/pasting editable pin bases
#jira UE-49532
Change 3638898 by Marc.Audy
Allow right-click creation of local variables in blueprint function libraries
#jira UE-49590
Change 3639086 by Marc.Audy
PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin)
#jira UE-49591
Change 3639445 by Marc.Audy
Fix mistaken override and virtual markup on niagara schema function.
Change 3641202 by Marc.Audy
(4.17.2) Fix crash undoing pin changes with split pins
#jira UE-49634
Change 3643825 by Marc.Audy
(4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted
#jira UE-49756
Change 3645110 by mason.seay
Fixed up QA-ClickHUD map so it's usable and makes more sense
Change 3646428 by Dan.Oconnor
Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data
#jira None
Change 3647298 by Marc.Audy
PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist)
#jira UE-49748
Change 3647815 by Marc.Audy
Minor performance improvements
Change 3648931 by Lina.Halper
#Compiler : fixed so that each type of BP can provide module info, and compiler info
- Moved out AnimBlueprint Compiler
- Refactored WidgetBlueprint
- DUPE - Merging using ControlRig_Dev-Framework
Change 3654310 by Marc.Audy
Shrink USkinnedMeshComponent 64 bytes
Shrink USkeletalMeshComponent 224 bytes (160 bytes internal)
Change 3654636 by Lina.Halper
Fix crashing on shutdown
#jira: UE-50004
Change 3654960 by Lina.Halper
- Fix with automation test of creation/duplication
- Fixed shut down crash with editor again due to uobject GCed
#jira: UE-50028
Change 3655023 by Ben.Zeigler
#jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag
Change 3655426 by Ben.Zeigler
#jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them
Change 3657627 by Ben.Zeigler
#jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction
Change 3662086 by Mieszko.Zielinski
Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4
This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList
#jira UE-50101
Change 3662294 by Ben.Zeigler
Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check
Change 3662825 by Mieszko.Zielinski
Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4
there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no
Change 3664424 by Marc.Audy
UE-50076 test assets #rb none #rnx
Change 3664441 by Mieszko.Zielinski
PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist)
Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated.
Change 3664506 by Phillip.Kavan
#jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets.
Change summary:
- UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization.
- UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths.
- UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished.
- UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option).
- UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed.
- UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead.
- UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead.
- UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file.
- UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file.
- UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first).
- UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness.
- UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed.
- UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc.
- UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file.
- UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string.
- UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>.
- UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin.
- UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed).
- UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed).
- UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it.
- UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished.
- UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed.
- UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag.
- UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed.
- UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context.
- UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail.
- UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT).
- UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders.
Notes:
- After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release).
- Advanced users and build engineers can override this value per task. Instructions to do that are as follows:
- For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line.
- When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly.
- We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT.
- We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above).
Change 3665061 by Phillip.Kavan
Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum.
Mirrored from //UE4/Release-4.18 (CL# 3664993).
#3969
#jira UE-49233
Change 3665108 by Marc.Audy
(4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted
+ additional code cleanup
#jira UE-50076
Change 3665114 by Marc.Audy
Minor change that could potentially improve performance in some cases
Change 3665410 by Mieszko.Zielinski
Fixed naming of Vislog's BP API #UE4
Change 3665634 by Ben.Zeigler
#jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk
Change 3666970 by Phillip.Kavan
Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8.
#jira UE-46814
Change 3667058 by Phillip.Kavan
Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage.
Mirrored from //UE4/Release-4.18 (CL# 3667043).
#jira UE-50403
Change 3667150 by Mieszko.Zielinski
PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM)
Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend.
#jira UE-50249
Change 3667152 by Mieszko.Zielinski
PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM)
#jira UE-50298
Change 3667166 by Mieszko.Zielinski
Fixed FRichCurve baking so that it doesn't loose its curvature #UE4
Also, added some baking sanity checking (like if the range is larger than a single point).
Change 3668025 by Dan.Oconnor
Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed
#jira UE-50453
Change 3672063 by Ben.Zeigler
#jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case
Change 3672306 by Ben.Zeigler
#jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it
Change 3672683 by Marc.Audy
Code cleanup
Change 3672749 by Ben.Zeigler
Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build
Change 3672831 by Ben.Zeigler
#jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId.
Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project
Change 3673551 by Ben.Zeigler
#jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load
Change 3675074 by mason.seay
Test map for VisLog Testing
Change 3675084 by Mieszko.Zielinski
Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4
#jira UE-43430
Change 3676490 by Ben.Zeigler
#jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset
Change 3676579 by Lukasz.Furman
fixed crash in behavior tree's search rollback
Change 3676586 by Lukasz.Furman
added local scope mode to behavior tree's composite nodes
Change 3676587 by Ben.Zeigler
Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case
Add browse, use selected, and clear buttons, and make ID selector font the normal property font
Change 3676715 by Lukasz.Furman
changed order of behavior tree's aux node ticking
Change 3676867 by Ben.Zeigler
#jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup
Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early
Change 3677892 by Ben.Zeigler
Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites
Change 3678247 by Marc.Audy
Fix static analysis warning
Change 3678357 by Ben.Zeigler
#jira UE-50696 Add some container variables to diff test to track down crashes
Change 3678385 by Ben.Zeigler
#jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match
Change 3678600 by Ben.Zeigler
#jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference
Change 3679075 by Dan.Oconnor
Mirror 3679030 from Release-4.18
Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on
#jira UE-48692
Change 3679087 by Dan.Oconnor
Filter out unnecessary relink jobs from the compilation manager
#jira None
Change 3680221 by Ben.Zeigler
#jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary
Change 3680561 by Lukasz.Furman
fixed unsafe StopTree calls in behavior tree
#jira nope
Change 3680788 by Ben.Zeigler
Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind
Change 3683001 by mason.seay
Submitting various test maps and assets
Change 3686837 by Mieszko.Zielinski
Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion
#jira UE-50857
Change 3688451 by Marc.Audy
Fix up new material expression to work with String -> Name refactor
Change 3689097 by Mason.Seay
Test content for nativization and enum testing
Change 3689106 by Mieszko.Zielinski
Made NavMeshBoundsVolume react to undo in the editor #Orion
#jira UE-51013
Change 3689347 by Mieszko.Zielinski
Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4
Manual merge of CL#3689316 over from 4.18
#jira UE-51019
Change 3692524 by mason.seay
Moved some assets to folder for org, fixed up redirectors
Change 3692540 by mason.seay
Renaming test maps so they are clearly indicated for testing nativization
Change 3692577 by mason.seay
Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed
Change 3692724 by mason.seay
Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps
Change 3693184 by mason.seay
Assets for testing nativization with structs
Change 3693367 by mason.seay
Improvements to test content
Change 3695395 by Dan.Oconnor
Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced
#jira None
Change 3695484 by Marc.Audy
Fix sound cue connection drawing policy not getting returned.
#jira UE-51032
Change 3695494 by mason.seay
More test content for nativization testing
Change 3697829 by Mieszko.Zielinski
PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei)
Change 3700541 by mason.seay
Test map for containers with function bug
Change 3703459 by Marc.Audy
Remove poorly named InverseLerp
Fix degenerate behavior returning bad value
#jira UE-50295
Change 3703803 by Marc.Audy
Clean up autos
Minor improvement to ShouldGenerateCluster
Change 3704496 by Mason.Seay
More test content for testing nativization
Change 3706314 by Marc.Audy
PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar)
#jira UE-50874
Change 3707502 by Mason.Seay
Final changes to nativization test content (hopefully)
Change 3709478 by Marc.Audy
PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel)
Same as CL# 3689702 implemented in Fortnite
#jira UE-51453
Change 3709967 by Marc.Audy
PR #4139: fixed a typo in a comment (Contributed by derekvanvliet)
#jira UE-51372
Change 3709970 by Marc.Audy
PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman)
#jira UE-51495
Change 3709971 by Marc.Audy
PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas)
#jira UE-51492
Change 3710041 by Marc.Audy
Minor code cleanup
Change 3711223 by Phillip.Kavan
Move some Blueprint nativization log spam into the verbose category.
#jira UE-49770
Change 3713398 by Marc.Audy
PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM)
#jira UE-51517
Change 3713601 by Marc.Audy
Fix merge error
Change 3713994 by Marc.Audy
(4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event.
#jira UE-50738
Change 3714270 by Marc.Audy
Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors
#jira UE-51534
Change 3714406 by Marc.Audy
Fix dumb inverted boolean check
Change 3716594 by Dan.Oconnor
Integrate 3681301 from 4.18
Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior
#jira UE-50780, UE-51568
Change 3686450 by Marc.Audy
PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString.
CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither.
CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters.
Material Expressions now store input and output names as FName instead of FString
FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString
Most existing pin related functions using string have been deprecated.
Change 3713796 by Marc.Audy
Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not.
IsTickable no longer a pure virtual (defaults to true).
Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject.
Change 3638554 by Marc.Audy
Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected.
Change 3676502 by Ben.Zeigler
Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635
[CL 3718205 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb na
Change 3604978 on 2017/08/23 by Andrew.Grant
Fix for OR-42722 from 4.17 branch
#!tests compiled
#!rb max.chen
Change 3604960 on 2017/08/23 by Andrew.Grant
Proper fix for OR-43001, removed hack-around.
#!tests compiled
#!rb max.chen
Change 3604881 on 2017/08/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed LostReservation message in tests to info from warning.
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3604871 in //Orion/Release-42.3/... via CL 3604878 via CL 3604880
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3604566 on 2017/08/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - return -1 for a test if there's a fatal error. Removed network errors failing tests (should be down to test to determine)
Made SoakTest better able to detect failed drafts and incomplete matches
#!tests ran multiple soaks and SoloAllHeroes
#!rb none
#!ROBOMERGE-SOURCE: CL 3604560 in //Orion/Release-42.3/... via CL 3604563 via CL 3604565
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3604181 on 2017/08/23 by David.Ratti
Set ULandscapeHeightfieldCollisionComponent to be NetAddressable so that it can be replicated as a movement base without error.
OR-42615
#!rb none
#!tests pie
Change 3603647 on 2017/08/22 by Laurent.Delayen
AnimProxy: initialize Actor/Component transforms.
#!rb none
#!tests lane minion test map
Change 3603343 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: don.eubanks
Added several more stats to the Card Shop stat panel.
+ Basic Attack Damage
+ Max Move Speed
+ Armor Penetration / Percent
+ Ability Penetration / Percent
Added utility function to AbilitySystemComponent to calculate an ability's value with additional Required/Ignore tags and Target tag container (functionality moved from AttributeView)
#!rb matt.schembari
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
#!ROBOMERGE-SOURCE: CL 3603172 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3603121 on 2017/08/22 by Laurent.Delayen
Added FAnimationRuntime::LerpPosesPerBone
#!rb none
#!tests lane minions split body anims.
Change 3603010 on 2017/08/22 by Laurent.Delayen
Draw box around Actor being debugged by 'ShowDebug' command, to help identify what we're viewing.
#!rb none
#!tests lane minions
Change 3602574 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed linux warning
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3602571 in //Orion/Release-42.3/... via CL 3602572
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602396 on 2017/08/22 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Updated Gauntlet log parser for new callstack format
Added offline and runtime Gauntlet tests to verify error generation and parsing
#!tests ran lots of tests locally
#!rb codereviewed
#!ROBOMERGE-SOURCE: CL 3601948 in //Orion/Release-42.3/... via CL 3601950
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602373 on 2017/08/22 by Andrew.Grant
Fixed compile error
#!tests compiled
#!rb none
Change 3602321 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
LogAssertFailedMessage
- Removed callstack dumping from LogAssertFailedMessage (now in StaticFailDebug)
- Moved script dumping inside GIsCritial check
StaticFailDebug
- Now dumps the callstack if supported for non-ensures. This results in PS4 (and other platforms) now displaying a callstack on a Fatal log.
- Removed log flush, was redundant
- Removed LowLevelOutputDebugStringf. If a platform needs this it can be done later in its error device
OutputMultiLineCallstack
- Renamed to FDebug::LogFormattedMessageWithCallstack and exposed in headers (calling locations have been updated to remove their extern declarations)
- No longer writes into the buffer to format it (!)
- LogName is now the first param. If NAME_None it writes using LowLevelOutputDebugString
- While writing out error information all callstack likes are prefixed with [Callstack]
Added brief documentation about the order of ops for ensures/asserts/fatal logs
#!tests ran lots of tests locally
#!rb codereviewed
#!ROBOMERGE-SOURCE: CL 3601943 in //Orion/Release-42.3/... via CL 3601944
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602316 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed various platform-specific implementations of ProgramCounterToHumanReadableString to return info in a canonical format of address module!func [file:line].
E.g.
0x00416A5F OrionClient.self!FEngineLoop::Tick() [D:\Epic\Orion\Release-Next\Engine\Source\Runtime\Launch\Private\LaunchEngineLoop.cpp:3295]
#!tests ran lots of tests locally
#!rb codereviewd
#!ROBOMERGE-SOURCE: CL 3601940 in //Orion/Release-42.3/... via CL 3601941
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602311 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Sony don't allow exception handling on PS4 so for sometime we've had an issue where crashes have no presence in logs*
This change adds postmortem analysis to PS4DevkitUtil. If the OS terminates the process then it process the minidump and writes the cause and the callstack to stdout. As a bonus PS4DevkitUtil can now display cause & callstacks from minidumps via "PS4DevkitUtil postmortem -dump=path\to\crash.orbisdmp"
(*if you're lucky the kit may have been setup correctly to submit dumps to crashreporter, it may have actually worked, and you may be able to find it).
#!tests run many times on Orion tests
#!rb CR
#!ROBOMERGE-SOURCE: CL 3601929 in //Orion/Release-42.3/... via CL 3601930
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3599823 on 2017/08/21 by Jian.Ru
Allow MaxCascades cvar be set to 0 (should perobject shadow be forced on?)
#!jira UE-48468,OR-42749
#!rb Daniel.Wright
#!tests editor
Change 3598765 on 2017/08/19 by Andrew.Grant
Disable regeneration of missing cubemap data in cooked build.
Need some way of handling this, but currently this breaks PS4 anytime someone makes a map change and doesn't build lighting...
#!review-3598766 @daniel.lamb
#!tests ran PS4 successfully
#!rb none
Change 3597800 on 2017/08/18 by Laurent.Delayen
Added FAnimationRuntime::LerpPoses. Blends two poses together, but first pose is also storing results. To save on copying poses when not necessary.
Removed individual use of ZERO_ANIMWEIGHT_THRESH, instead use FAnimWeight functions.
FAnimationRuntime weight functions use FAnimWeight for consistency. (IsFullWeight was different).
#!rb none
#!codereview martin.wilson, lina.halper
#!tests minion test lane map
Change 3597332 on 2017/08/18 by Laurent.Delayen
SkelMeshComponent LOD update only refreshes transforms when rendered.
If AnimGraph eval is done, make sure Graph has been updated at least once.
Fixes:
- Significance Manager setting MinLOD on non recently rendered minions, causing them to refresh bones.
- Minions calling eval with graph not updated due to having bUseRefPoseOnInitAnim set. It means it's possible to refresh bones on a graph that has never been updated, causing a crash.
#!rb martin.wilson, lina.halper
#!codereview martin.wilson, lina.halper
#!tests minions test lane map. placing skelmeshes in editor and making sure LOD update works as expected.
Change 3597042 on 2017/08/18 by Daniel.Lamb
Added onlinesubsystemmcp to the cooksettings blacklist.
#!rb Trivial
#!test none
Change 3596575 on 2017/08/18 by Shaun.Kime
Fixing nonunity build issues
#!rb none
#!tests compiled OrionGame with unity builds disabled
Change 3595475 on 2017/08/17 by Andrew.Grant
Fixed issue with PS4 asserts not being detected during test shutdown
#!tests ran locally
#!rb none
Change 3595415 on 2017/08/17 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added check for network failure to tests
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3595412 in //Orion/Release-42.3/... via CL 3595414
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3594725 on 2017/08/17 by Ben.Salem
Add "Worst offenders" table and runtime to FX perf reports.
#!rb adric.worley
#!tests Ran a few FX Perf tests and generated reports.
Change 3594195 on 2017/08/17 by Shaun.Kime
Integration from Dev-Niagara to Dev-General. Note that this may cause assets to need to be recooked. Please be prepared for longer than normal cook times once syncing past this changelist.
#!rb none
#!tests preflight'ed change, QA ran multiple soak tests
Change 3594177 on 2017/08/17 by Andrew.Grant
Fixed issue that was causing exceptions not to be recognized
#!tests ran locally
#!rb none
Change 3594090 on 2017/08/17 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fix for mesh desyncing during online play.
https://jira.it.epicgames.net/browse/UE-45947
#!rb none
#!tests none
[CODEREVIEW] zak.middleton
#!ROBOMERGE-SOURCE: CL 3590625 in //Orion/Release-42.3/... via CL 3590626
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3594022 on 2017/08/17 by Laurent.Delayen
SkeletalMeshComponent::InitAnim
- Do not call RefreshBoneTransforms without calling TickAnim first. AnimGraph could get in a bad state.
- Do not call RefreshBoneTransforms if AnimInstance has not been initialized.
- Do not call RefreshBoneTransforms if bUseRefPoseOnInitAnim is set. Which it could if bForceReinit was false.
#!rb martin.wilson
#!tests minion test lane map.
Change 3593972 on 2017/08/17 by Chris.Bunner
Duplicating instanced static mesh fixes from Dev-Editor - 3502581, 3570934, 3593597.
#!rb None
#!tests Editor, -game, PC
#!jira UE-48521, OR-42612
Change 3590611 on 2017/08/16 by David.Ratti
Spot edigrate CL 3584203 to fix show collision crash in mono 2
#!rb none
#!tests compile
Change 3590452 on 2017/08/16 by Laurent.Delayen
Fix for mesh desyncing during online play.
https://jira.it.epicgames.net/browse/UE-45947
#!rb none
#!tests none
#!codereview zak.middleton
Change 3590378 on 2017/08/16 by Laurent.Delayen
Integrated CL #!3585145 from Main.
>>
Fix for https://jira.it.epicgames.net/browse/OR-42337 and https://jira.it.epicgames.net/browse/OR-42338
Don't call UpdateMontageSyncGroup() when doing EMeshComponentUpdateFlag::OnlyTickMontagesWhenNotRendered.
Fixed auto ranged iterator.
#!rb none
#!tests bot match with Twinblast
<<
Change 3590263 on 2017/08/16 by Matt.Kuhlenschmidt
Added the ability to remove vertex colors from static meshes from the content browser
#!rb none
#!tests none
#!fyi jordan.walker
Change 3590026 on 2017/08/16 by Jurre.deBaare
HLOD: When mesh has auto LOD generation disabled it prevents user from dragging meshes to make a cluster
#!fix changed the tooltip and error handling for cluster creation, if there is any valid mesh now it will show up as a warning
#!jira OR-41584
#!rb none
#!test have tested several 'error' meshes which would before prevent the user from creating a cluster,
Change 3588580 on 2017/08/15 by Laurent.Delayen
Fix for https://jira.it.epicgames.net/browse/OR-42755
#!rb none
#!tests bot match
Change 3588360 on 2017/08/15 by Charles.Anderson
Phat
- Fixed up the materials to turn off the Render Before DOF so that we can see what were doing in Phat again.
Change 3587983 on 2017/08/15 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fixed up audio issue on the new dawn intro movie
#!jira OR-42144
#!rb Max.Preussner
#!test Paragon ps4
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3581466 in //Orion/Release-42.1/... via CL 3581468 via CL 3581469
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3587746 on 2017/08/15 by Daniel.Lamb
Build launcher now has option for custom test.
Dumps generated buildcooktest commandline to log when using -interactive for reference.
#!rb trivial
#!test BuildCookTest with and without test options.
Change 3587733 on 2017/08/15 by Daniel.Lamb
Reenabled binned 2 stats in not shipping.
#!rb Andrew.Grant
#!test Paragon editor.
Change 3587727 on 2017/08/15 by Daniel.Lamb
Removed all the checks to help track down Texture GC issue.
#!rb Trivial
#!test Paragon editor
Change 3584487 on 2017/08/14 by Laurent.Delayen
https://jira.it.epicgames.net/browse/OR-42754 making sure this is not firing because of false positives.
#!rb none
#!tests compiles
Change 3582074 on 2017/08/11 by Laurent.Delayen
TimeStretchCurve system for AnimMontages.
Allows adjusting playback time of montages in a non constant way. This optional curve allows the user to determine how animation frames are influenced by play back time scaling, instead of using a constant play rate scaling.
For example, with an attack animation, the strike could have zero influence (no play rate), and the recovery time could have 100% influence (most play rated).
This system is entirely optional and compatible with current Montage API. You still determine desired play back time via the Play Rate parameter. Based on desired playback time, if there is a curve named 'MontageTimeStretchCurve' then, it will use the curve to determine animation frames to play based on playback time and TimeStretchCurve. Otherwise, if no curve exists, it is done using the constant supplied PlayRate.
#!rb martin.wilson
#!codereview lina.halper, james.golding
#!tests wukong primary attacks
Change 3582063 on 2017/08/11 by Brian.Fasten
Removing Monolith02_LowTest from automated builds until errors can be cleared
#!codereview: daniel.lamb
#!rb - none
#!tests - none
Change 3581229 on 2017/08/10 by Lina.Halper
- Back out revision 21 from //Orion/Dev-General/Engine/Source/Runtime/SlateCore/Private/Rendering/DrawElements.cpp
- Comment out issue that causes crash in the draw box
#!jira: UE-48222
#!code review: Jurre.DeBaare, Nick.Darnell, Daniel.Lamb
#!rb: Jurre.DeBaare
#!tests: building HLOD as specified in the ticket, and anim blueprint graph
Change 3577839 on 2017/08/08 by Daniel.Lamb
Revert CL 3576931. To fix crash when generating HLOD in Monolith 2.
#!rb Andrew.Grant
#!test Rebuild HLOD paragon editor
#!fyi Lina.Halper
Change 3577684 on 2017/08/08 by Andrew.Grant
Removed ensure and merged proper fix for crash from UE4/Main (3572777)
#!tests #!rb none
Change 3577562 on 2017/08/08 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Potential fix for https://jira.it.epicgames.net/browse/OR-42383
Clear NotifyQueue prior to ticking montages. Also dispatch events right away, since ticking ends here, and no rendering is happening. In the event TickPose() is called directly and Component does not get ticked.
#!rb lina.halper
[CODEREVIEW] lina.halper, martin.wilson
#!tests bot match
#!ROBOMERGE-SOURCE: CL 3577071 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3577358 on 2017/08/08 by Harrison.Moore
Updating Colorchecker
Change 3576931 on 2017/08/08 by Lina.Halper
Fix for missing arrowhead of the transition on state machine graph
#!rb: Nick.Darnell
#!tests: editor
Change 3576847 on 2017/08/08 by Jason.Bestimt
#!ORION_DG - OR-42361 - Removing assert that was causing crash report client to break (during shipping builds of Paragon due to directories that didn't exist)
#!RB: Guillaume.Abadie
#!Tests:none
Change 3576794 on 2017/08/08 by Laurent.Delayen
Removed call to DebugCanvas->Flush_GameThread(); to fix 'showdebug' commands not rendering anymore.
#!rb Matt.Kuhlenschmidt
#!codereview Matt.Kuhlenschmidt
#!tests Ghost in PIE, showdebug animation works.
Change 3576302 on 2017/08/08 by Jurre.deBaare
Fix for Materials get switched up while building HLODs in case the section order is different than the material order
#!rb none
#!tests Rebuild problematic clusters in Monolith2
#!fix materials remapping was done using the section index instead of material index in the hlod path (static mesh merge one was fine)
Change 3575221 on 2017/08/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for PS4 shipping
#!tests compiled PS4 shipping
#!rb none
#!ROBOMERGE-SOURCE: CL 3575112 in //Orion/Release-42.1/... via CL 3575114
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3575165 on 2017/08/07 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Runtime/PS4/PS4RHI/Private/GnmManager.cpp
--------------------------------------
PS4 GPU time now shows correct values instead of vsync time.
#!tests Ran on PS4
#!rb Luke.Thatcher
#!ROBOMERGE-SOURCE: CL 3574821 in //Orion/Release-42.1/... via CL 3574823
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3574408 on 2017/08/06 by Ben.Salem
Switch nightly solo smoke/fx tests to have -unattended on their commandlines.
#!rb none
#!tests compiled.
Change 3574308 on 2017/08/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Include session time, MVP, and hitches on new health report
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3574305 in //Orion/Release-42/... via CL 3574306 via CL 3574307
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3574217 on 2017/08/05 by Jeff.Williams
Fixing UAT compile error
#!review-3574218 @andrew.grant
#!rb na
#!tests na
Change 3574139 on 2017/08/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3571982 for future v42 patches
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3574136 in //Orion/Release-42/... via CL 3574137 via CL 3574138
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3574130 on 2017/08/05 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/SelfTest/Gauntlet.SelfTest.LogParserTest.cs
--------------------------------------
Non-shipping Gauntlet changes -
Log parser cleanup that provides better access to log channel info, errors, warnings, and ensures
Updated BaselinePerf test to record number of units travelled. This should highlight tests where a bot gets blocked :(
#!tests ran locally on PS4
#!rb none
#!ROBOMERGE-SOURCE: CL 3574116 in //Orion/Release-42/... via CL 3574123 via CL 3574124
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3573197 on 2017/08/04 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Merging //Orion/Release-42.1 to Dev-ContentUpdate (//Orion/Dev-ContentUpdate)
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3573179 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3573079 on 2017/08/04 by Andrew.Grant
Removed some code that was preventing Wacom from working
#!tests #!rb none
Change 3572790 on 2017/08/04 by Jurre.deBaare
Moving over fixes from 4.17 stream related to HLOD:
"UE-47360
Non Uniform baking of HLOD materials causes texture stretching
UE-47031
Generating a HLOD cluster with multiple actors that contain lods will not bake correctly"
#!rb none
#!tests none
Change 3572663 on 2017/08/04 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - copy elf files to temp dir and launch from there
#!tests ran gauntlet
#!rb none
#!ROBOMERGE-SOURCE: CL 3572657 in //Orion/Release-42/... via CL 3572659 via CL 3572662
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3572622 on 2017/08/04 by Jurre.deBaare
Moving over:
"Guard against zero sized boxes being sent to the slate batcher. This was exposed by the clipping changes since zero sized elements would have been previously clipped.
#!rb nick.darnell
#!jira UE-46919"
#!tests none
Change 3572428 on 2017/08/04 by Benn.Gallagher
Added per-axis inertia and parent dominance settings to physics assets
#!rb Thomas.Sarkanen
#!tests Shrapnel in editor and -game (seems to be the only character using old inertia scaler for rigid body node)
Change 3572142 on 2017/08/04 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Disabling r.Cache.UpdatePrimsTaskEnabled for PS4 due to lock-ups
#!tests none
#!rb none
#!ROBOMERGE-SOURCE: CL 3572139 in //Orion/Release-42/... via CL 3572140 via CL 3572141
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3572133 on 2017/08/04 by Andrew.Grant
Merging
//UE4/Main/Engine/Source/Runtime/SlateCore/Private/Input/HittestGrid.cpp
to //Orion/Dev-General/Engine/Source/Runtime/SlateCore/Private/Input/HittestGrid.cpp
#!tests #!rb none
Change 3572065 on 2017/08/03 by Andrew.Grant
Fixed bug in Gauntlet parsing of perf data for tests
Added perf-parsing test to SelfTest
#!tests ran self test
#!rb none
#!ROBOMERGE: 42.1
Change 3572033 on 2017/08/03 by Andrew.Grant
Merging //UE4/Main @ 3571062 through Orion-Staging
#!rb none
#!tests Engine QA pass
Change 3571262 on 2017/08/03 by Uriel.Doyon
StaticMeshComponent and LandscapeComponent now register AO material mask and sky occlusion texture in the texture streamer.
Changing the current lighting scenario now triggers an update of the texture streamer.
Added an option to the "liststreamingtextures" named UNKOWNREF allowing to inspect texture without references in the texture streamer.
#!rb none
#!tests played monolith2 on PS4 and loaded the map in the editor.
Change 3571247 on 2017/08/03 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Integrate Dev-UI -> Release42
Reduced the sensitivity on the slow tick timer warning
#!rb Trivial
#!test Cooked paragon ps4
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3571239 in //Orion/Release-42/... via CL 3571244 via CL 3571246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3570431 on 2017/08/03 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed a change that was inadvertendly included in a larger fix and seems to be having problems on windows server.
#!tests ran windows server locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3570428 in //Orion/Release-42/... via CL 3570429 via CL 3570430
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3570343 on 2017/08/03 by Jurre.deBaare
HLOD: opening a level with HLOD defaults to forcing HLOD on for all clusters
#!fix forcing the HLODs to show up in the editor changes the MinDrawDistance of the static mesh component, this was getting saved and not restored during runtime (now does it in PostLoad)
#!jira UE-47712
#!rb none
#!tests PIE in Editor while having HLOD forced on
Change 3570047 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for ensure leading to deadlock
#!jira OR-42071
#!tests compiled, ran ShortSoloGame test
#!rb none
[QAREVIEW] - this fixes the PC locks in OR-42071 and probably the PS4 too, but please recheck both platforms to be sure.
#!ROBOMERGE-SOURCE: CL 3570044 in //Orion/Release-42/... via CL 3570045 via CL 3570046
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3569932 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Integration from UE4 - fixed a set of critical bugs that would cause rare crashes in the async IO subsystems.
#!rb gil.gribb
#!tests ran 10x solo games, ran LoadTest, all PS4
#!jira UE-47483
#!ROBOMERGE-SOURCE: CL 3569929 in //Orion/Release-42/... via CL 3569930 via CL 3569931
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3569839 on 2017/08/02 by Daniel.Lamb
Added the low quality monolith map to the build launcher and cook maps list.
#!rb Trivial
#!test Compile UAT
Change 3569441 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Re-enabled OnlyTickMontagesWhenNotRendered animation optimization, after fixing edge case where 'Evaluate' could be called on out of sync cached data.
Only update cached data when the graph will be updated, to ensure we don't have mismatching update and evaluate data.
#!rb none
[CODEREVIEW] martin.wilson, lina.halper
#!tests bot match w/ dedicated server.
#!ROBOMERGE-SOURCE: CL 3569235 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3569397 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: ben.salem
Merging using Dev-Gen_->_Release-42.1 Support for skins in perf reporting, also report overall test run time.
#!rb various
#!tests ran with new shallow test maps.
#!ROBOMERGE-SOURCE: CL 3568892 in //Orion/Release-42.1/... via CL 3568967
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3568639 on 2017/08/02 by Adric.Worley
Add individual FTest enumeration to Orion perf tests
Moved methods to run FTests to helper for reuse.
Effects perf tests now show individual test cases for more granular runs.
All perf tests now do map check and draft logic as setup.
#!tests ran updated tests in client/server
#!rb ben.salem
Change 3568616 on 2017/08/02 by Ben.Salem
Switch shallow fx tests to report to their own mailing list.
#!rb bob.ferreira
#!tests recompiled
Change 3568607 on 2017/08/02 by Daniel.Lamb
Added staticmeshcomponent to the memreportfull command.
#!rb Trivial
#!test Paragon
Change 3568018 on 2017/08/01 by Ben.Salem
Add skin and character name to test reports, and also test runtime.
#!rb none
#!tests ran steel shallow test
Change 3567995 on 2017/08/01 by Bob.Ferreira
[FXTests] Updating FXTests and ShallowFXTests to call OnComplete() when doing check point validation.
[Gauntlet] Changed InnerTestResult to be protected so that inherited test nodes can modify it.
#!rb Ben.Salem
#!TESTS Ran local automationtool run on a cooked main build.
Change 3567912 on 2017/08/01 by robomerge
#!ROBOMERGE-AUTHOR: ori.cohen
Added support for physical materials in immediate mode
#!rb none
#!tests none
[CODEREVIEW] Benn.Gallagher
#!ROBOMERGE-SOURCE: CL 3567865 in //Orion/Release-42/... via CL 3567901 via CL 3567904
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3567594 on 2017/08/01 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Disabling animation optimization until I can fix an edge case.
#!rb none
#!tests arcade mode
#!ROBOMERGE-SOURCE: CL 3567593 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3566953 on 2017/08/01 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Animation Optimization: Added EMeshComponentUpdateFlag::OnlyTickMontagesWhenNotRendered to only update montages when not rendered, instead of doing a whole pose update. This means on dedicated servers we'll only update montages when needed, and not the AnimGraph, which we have no need for.
This is also affects non rendered meshes on clients.
#!rb martin.wilson
[CODEREVIEW] lina.halper, martin.wilson
#!tests ghost and wukong networked doing montage abilities.
#!ROBOMERGE-SOURCE: CL 3566950 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3564610 on 2017/07/31 by Uriel.Doyon
Integrated CL 3543210 : Fixed an issue when computing material scales where the default material ends up being used instead of the required material.
Deprecated previous material data as it was causing some waste.
Integrated CL 3526859 : Texture mip bias is now reset whenever the streaming budget increases
#!rb none
#!tests played monolith2 on PS4
Change 3564509 on 2017/07/31 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fixed warning when opening Kwang AnimBP the first time, due to missing virtual bone name. (When Skeleton doesn't have PostLoad() called on it yet - happens only the first time the AnimBP is opened).
[CODEREVIEW] jurre.debaare, dwayne.martin, lina.halper, martin.wilson
#!rb none
#!tests Kwang AnimBP opens without a warning.
#!ROBOMERGE-SOURCE: CL 3564506 in //Orion/Release-42/... via CL 3564507
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
[CL 3613306 by Andrew Grant in Main branch]
#lockdown Nick.Penwarden
#rb none
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3433074 by Matt.Kuhlenschmidt
Fix crash when clicking on certian tutorial blueprints.
#jira UE-44593
Change 3433075 by Matt.Kuhlenschmidt
Remove hittest grid log spam. The underlying problem causing this has been fixed
Change 3433077 by Matt.Kuhlenschmidt
Fix lighting becoming unbuilt when mesh painting
#jira UE-44837
Change 3433081 by Matt.Kuhlenschmidt
PR #3553: Crashfix for static array properties (Contributed by Pierdek)
Change 3433104 by Alexis.Matte
Make sure re-import skeletal mesh follow the import morph option
#jira UE-42846
Change 3434825 by Matt.Kuhlenschmidt
Fix crash when GC happens while the vr editor radial menu is open.
Change 3434831 by Matt.Kuhlenschmidt
Added missing file
Change 3434868 by Shaun.Kime
If you have a reroute node between a Material Function texture input and its usage, the parent material will fail to resolve the reroute node.
#jira ue-44670
Change 3434998 by Alexis.Matte
Meshes editors material/section panel are now fully transactional
- Staticmesh editor: section material slot, section cast shadow, section collision, material slot instance, material slot name
- Skeletal mesh editor: material slot instance, material slot name
Also fix some transaction description
#jira UE-44462
Change 3435195 by Jamie.Dale
Fixed incorrect handling of some LTR scripts that require shaping
These scripts need to go through HarfBuzz, and this also fixes a case where HarfBuzz wasn't applying font scale correctly.
#jira UE-44767
Change 3435199 by Jamie.Dale
Fixed some crashes/artifacts with bidirectional text
It was possible for a line to compute an incorrect range, which could cause crashes or other highlighting issues. The highlighting logic has also been updated as the old code didn't handle all bidirectional cases correctly.
Change 3435200 by Jamie.Dale
Fixed a grapheme cluster metrics issue in the font editor viewport
The viewport also now respects the default shaping method CVar.
Change 3435771 by Alexis.Matte
Fix degenerated bounds calculation for skeletalmesh when the skeleton is remove from a re-import
(PhysicAsset API change, adding 1 function)
#jira UE-44609
Change 3436856 by Jamie.Dale
Added some missing Unicode block ranges
Change 3436914 by Jamie.Dale
Adding some missing combining character ranges to the text shaper
Change 3436923 by Alexis.Matte
PR #3463: Get bounds for all triangles, not just the first one. WedgeIndex was . (Contributed by DaveC79)
#jira UE-43764
Change 3436948 by Jamie.Dale
Updated the Portal to use the predefined Unicode block ranges
Change 3436961 by Max.Chen
Sequencer: Show camera shake/anim track menus even if there aren't any assets.
Change 3437244 by Max.Chen
Sequencer: Clear locked cameras when releasing Sequencer.
#jira UE-44967
Change 3437515 by Arciel.Rekman
UBT: improvements for LocalExecutor.
- Larger number of parallel jobs on 16GB+ machines.
- Use WaitForExit() instead of polling.
- Tested on Linux and Mac.
Change 3437629 by Matt.Kuhlenschmidt
Improve asset import data display in static and skeletal meshes
Change 3438047 by Arciel.Rekman
Fix overlapping ranges being passed to memcpy().
Change 3438822 by Yannick.Lange
ViewportInteraction: Move gizmo handle files to make them private.
Change 3438906 by Matt.Kuhlenschmidt
PR #3556: Git Plugin: fix new option "init Git LFS" that make assets read-only (master/UE4.17) (Contributed by SRombauts)
Change 3438907 by Matt.Kuhlenschmidt
PR #3565: add -quality option to buildlighing commandlet (Contributed by kayama-shift)
Change 3438908 by Matt.Kuhlenschmidt
PR #3558: UE-44862: Always update SColorPicker color on OK button (Contributed by projectgheist)
Change 3439393 by Matt.Kuhlenschmidt
Force highest LOD for highres screenshots
Change 3439819 by Matt.Kuhlenschmidt
Turned FAssetData into a struct for some upcoming script exposure of FAssetData
Change 3439949 by Arciel.Rekman
Fixed selection logic for the UE4_LINUX_USE_LIBCXX environment variable.
- Allows disabling libc++ by setting the variable to 0.
- Pull request #3576 contributed by jared-improbable.
Change 3441078 by Jamie.Dale
The culture/language/locale console commands are now available in all build configs
Change 3441109 by Jamie.Dale
Text containing surrogate pairs now runs through HarfBuzz when shaping in Auto mode
This is needed as the kerning-only shaping code assumes that everything is within the BMP
Change 3441275 by Matt.Kuhlenschmidt
Disable spinning on location and scale. These dont work because we have no notion of infinite spinning
Change 3442748 by Yannick.Lange
ViewportInteraction: Remove unused console variables.
Change 3442775 by James.Golding
Add support for editing MaterialFunctions to MaterialEditingLibrary
Pull Material recompile/update code into UMaterialEditingLibrary::RecompileMaterial
Pull MaterialFunction update code into UMaterialEditingLibrary::UpdateMaterialFunction util
Move RebuildMaterialInstanceEditors to UMaterialEditingLibrary
Added test content for Material/MaterialFunction editing
Add needed BlueprintReadWrite to expressions (constants, function input/output)
Expose UMaterialExpressionMaterialFunctionCall::SetMaterialFunction to BP, rename old func (which takes old function) to SetMaterialFunctionEx, also expose GetInputNameWithType
Change 3442779 by James.Golding
Fix header order
Change 3442817 by Yannick.Lange
ViewportInteraction: Add can execute checks for level editor commands.
Change 3443038 by Michael.Dupuis
#jira UE-43377: When you select a foliage actor we will move all instance contained in it to the new level as we can't move a foliage actor
Only permit moving foliage instance if there is some selected
Change 3443855 by Michael.Dupuis
#jira UE-44885: Unregister from PerModuleDataObjects when the object is destroyed
Change 3446096 by Max.Chen
Sequencer: Add OnFinished() event when a level sequence completes playback
#jira UE-45173
Change 3446097 by Max.Chen
Sequencer: Evaluate one last time before the sequence is torn down and reset
#jira UE-45174
Change 3446242 by Jamie.Dale
Fixed caret not appearing in empty text layouts
Caret selections have no range, and therefore have no width
Change 3446361 by Matt.Kuhlenschmidt
Fix WITH_EDITOR only functions causing generated code compile errors when the all functions on the class are WITH_EDITOR
Change 3446457 by Alexis.Matte
Polish the speed tree import dialog
#jira UE-44963
Change 3446946 by Michael.Trepka
Modified FWindowsWindow::GetRestoredDimensions to return correct window position for normal windows for which GetWindowPlacement returns position in workspace coordinates
#jira UE-37934
Change 3447543 by Arciel.Rekman
Reduce VMAs on Linux.
- Trades off increased address space (VIRT in terms of ps/htop) for smaller number of distinct mappings (VMAs, virtual memory areas).
This decreases possibility to run into vm.max_map_count limit on Linux.
- Tested on Linux and Mac.
Change 3448468 by Arciel.Rekman
Fix race condition during creation of GMalloc.
- On Mac GMalloc can be created on two different thread that are racing with each other - app's main thread and a system thread.
Change 3449012 by Max.Chen
Sequencer: Add time to transform, color and vector key structs so that key times are editable from the key editors.
#jira UE-45089
Change 3449018 by Max.Chen
Sequencer: Add OnCameraCut event that fires when there is a camera cut.
#jira UE-45137
Change 3449195 by Max.Chen
Sequencer: Add setting for limit scrubbing to playback range.
#jira UE-43502
Change 3449198 by Max.Chen
Sequencer: Reorder hierarchical bias so that group priority takes precedence.
Change 3449217 by Max.Chen
Sequencer: Add setting to activate realtime viewports when in sequencer.
Change 3449219 by Max.Chen
Sequencer: Focus on search boxes when opened.
Change 3449238 by Max.Chen
Sequencer: Assign actor should replace the actor itself after it has updated all the components. Also, replace components be fullname rather than by class.
Change 3449239 by Max.Chen
Sequencer: Fix offsets when moving multiple sections. Dragging should be clamped to the bounds that any of the selected sections hits against the unselected sections.
Change 3449241 by Max.Chen
Sequencer: Restore section selection after full tree rebuild.
Change 3449279 by Max.Chen
Sequencer: Set movie scene capture frames only when not using custom frames. This allows the user entered frame numbers to persist in config, rather than overwriting them when doing a "Render Shot"
Change 3449280 by Max.Chen
Sequencer: Spawn in the persistent level. Otherwise, they get spawned into whatever sublevel is current.
#jira UE-44552
Change 3449294 by Max.Chen
Sequencer: Null check for sequencer ed mode crash.
Change 3449297 by Max.Chen
Sequencer: Fix delay in sliding values. Mark changed when sliding values. Mark refresh immediately when committing values since OnValueChanged will be called and needs to have the correct value that was refreshed immediately.
#jira UE-42866
Change 3449542 by Max.Chen
Sequencer: Fix scrubber hit testing so that the time scrubber is really favored over the playback ranges.
#jira UE-44569
Change 3451507 by Matt.Kuhlenschmidt
Fix extra slate uv coords not functioning on ES2
Change 3451510 by Matt.Kuhlenschmidt
PR #3595: Fixed wrong colour for level status (Contributed by ronve)
Change 3451529 by Alexis.Matte
fbx scene importer: Make sure we set INVALID_UNIQUE_ID to node that has no attribute.
#jira UE-34410
Change 3451611 by Yannick.Lange
ViewportInteraction: Dragging gizmo without second pass for snapped calculations.
Change 3452134 by Jamie.Dale
Fixed constant font cache flushing if a widget had no font set
Change 3452239 by Jamie.Dale
Fixed constant font measure flushing if a widget had no font set
Change 3452243 by Jamie.Dale
Removed deprecated code for creating fonts from bulk data
Change 3452277 by Jamie.Dale
The concept of "stale" composite fonts is now editor-only
Change 3452358 by Alexis.Matte
Fbx scene importer: Do not remove existing attribute reference from the blueprint if the reimport of the associate mesh attribute is not tick.
#jira UE-45232
Change 3452678 by Max.Chen
Sequencer: Fix crash on export if there's no shot data.
Change 3453057 by Matt.Kuhlenschmidt
Exposed asset exporting to script
Change 3453782 by Andrew.Rodham
Sequencer: Fixed deterministic cooking issues with movie scene data
- Movie scene signatures are now initialized in PostInitProperties
- A warning is now presented when attempting to cook old data that was never serialized with a signature.
- Removed redundant legacy data upgrade logic that could dirty level sequences on load.
#jira UE-44912
Change 3453788 by Yannick.Lange
ViewportInteraction: Custom scene proxy for gizmo handles.
Change 3453938 by Max.Chen
Sequencer: Hotkeys (shift , and shift .) to step to next/previous shot
#jira UE-45119
Change 3454058 by Michael.Dupuis
Fixed StaticAnalysis
Change 3454077 by Max.Chen
Sequencer: Fix not saving the pre-animated track value when creating a track/key.
On pre object change, broadcast property change so that a track or key can be created. That track/key needs to be evaluated immediately so that the pre-animated state can be saved properly. This is done now with RefreshAllImmediately and is only called when a track has been created. Also, added a return value for OnKeyProperty, so that it's known what changed in particular (ie. track created, track modified, etc)
Also, fixed transform keying so that if a transform track already exists for the object or the scene component, the existing track is used.
#jira UE-45130
Change 3454108 by Nick.Darnell
UMG - Fixing the WIC to properly record cursor delta so that scrollbars work.
Change 3454109 by Jamie.Dale
Cache the text layout source info in non-shipping builds so you can inspect it in the debugger
Change 3454202 by Matt.Kuhlenschmidt
Fix bogus error message about the number of usable texture coordinates on ES2 when compiling a UI domain material
Change 3454390 by Yannick.Lange
Fix creating a plugin in a C++ project opens a second instance of Visual Studio. Use SourceCodeAccessor to open solution when necessary.
#jira UE-45035
Change 3454564 by Matt.Kuhlenschmidt
#rnx Fix deprecation warnings
Change 3455471 by Yannick.Lange
ViewportInteraction: Fix entering and exiting VR Mode disables gizmo in desktop editor viewport.
#jira UE-44965
Change 3456183 by Max.Chen
Sequencer: Auto key, auto track refactor.
Auto key - create a key when the property changes and there's an existing track.
Auto track - create a track when the property changes. This is only exposed in the level sequence editor.
All - create a key and a track when the property changes. This is only exposed in VR Editor.
None - do nothing.
#jira UE-43469
Change 3456349 by Andrew.Rodham
Sequencer: Only perform legacy signature checks on instances, and only where signatures match the CDO
Change 3456678 by Alexis.Matte
Allow to add null level instance override material via the advance material array. But still limit the override material number to the mesh material number.
#jira UE-45306
Change 3456945 by Max.Chen
UMG: Add restore state to 2d transform section.
#jira UE-45372
Change 3457196 by Arciel.Rekman
Linux: serialize allocations from the memory pool.
Change 3458434 by Max.Chen
Sequencer: Remove obsolete set tick prerequites functions.
Change 3458671 by James.Golding
Added MIC editing support to MaterialEditingLibrary
Fix static analysis warning
Change 3458888 by Matt.Kuhlenschmidt
PR #3615: More detailed log messages for debugging warnings/errors (Contributed by projectgheist)
Change 3458893 by Matt.Kuhlenschmidt
PR #3583: UE-44960: Delta value wasn't being used (Contributed by projectgheist)
Change 3458895 by Matt.Kuhlenschmidt
Fix typo
Change 3458902 by Matt.Kuhlenschmidt
PR #3607: Improved InputKeySelector functionality (Contributed by projectgheist)
Change 3458917 by Matt.Kuhlenschmidt
Fix crash with invalid object properties in the class picker
#jira UE-39000
Change 3458939 by Matt.Kuhlenschmidt
Fix compile error
Change 3458984 by andrew.porter
QAGame: Initial check in of sequencer smoke test map
Change 3459510 by Matt.Kuhlenschmidt
Fixed ensure when deleting a map that contains build data which also happens to be the currently loaded map.
#jira UE-45052
Change 3460985 by Max.Chen
Sequencer: Snap play time to keys now allows scrubbing between keys and snaps to key times within a certain screenspace tolerance.
#jira UE-45090
Change 3461698 by Arciel.Rekman
Avoid using ARRAY_COUNT in Vulkan.
- Sometimes those arrays can have no extensions whatsoever, and it is illegal to declare a 0 element C array.
Change 3462053 by Max.Chen
Sequencer: Show sequencer spawnables in the world outliner and add the icon overlay for spawnables.
#jira UE-43470
Change 3462139 by Max.Chen
Property Editor: Add objects to FPropertyAndParent
Change 3462202 by Arciel.Rekman
Fix FSocket::Recv() blocking with Peek when there's no data.
Change 3462253 by Nick.Darnell
Slate - New Clipping System
Clipping is now a stateful choice made during composition of the slate hierarchy. Previously every widget got to respect or modify the clipping rect on an as needed basis. The problem was that clipping was only allowed in the layout space of the widget, and it wasn't possible to properly clip elements with render transforms. The new system permits all kinds of transforms on any widget, and they will all be clipped correctly. It tries to use Scissor Rects as they are much cheaper, but will switch over to stenciling if need be to represent a complicated masking structure with several rotated clipping rects all needed to be combined together.
Here are the new clipping states a widget can have, almost all widgets are set to No. Only change it from No if your widget actually needs to clip, generally speaking most widgets don't need to clip.
/**
* This widget does not clip children, it and all children inherit the clipping area of the last widget that clipped.
*/
Inherit,
/**
* This widget clips content the bounds of this widget. It intersects those bounds with any previous clipping area.
*/
ClipToBounds,
/**
* This widget clips to its bounds. It does NOT intersect with any existing clipping geometry, it pushes a new clipping
* state. Effectively allowing it to render outside the bounds of hierarchy that does clip.
*
* NOTE: This will NOT allow you ignore the clipping zone that is set to [Yes - Always].
*/
ClipToBoundsWithoutIntersecting UMETA(DisplayName = "Yes - Without Intersecting (Advanced)"),
/**
* This widget clips to its bounds. It intersects those bounds with any previous clipping area.
*
* NOTE: This clipping area can NOT be ignored, it will always clip children. Useful for hard barriers
* in the UI where you never want animations or other effects to break this region.
*/
ClipToBoundsAlways UMETA(DisplayName = "Yes - Always (Advanced)"),
/**
* This widget clips to its bounds when it's Desired Size is larger than the allocated geometry
* the widget is given. If that occurs, it behaves like [Yes].
*
* NOTE: This mode was primarily added for Text, which is often placed into containers that eventually
* are resized to not be able to support the length of the text. So rather than needing to tag every
* container that could contain text with [Yes], which would result in almost no batching, this mode
* was added to dynamically adjust the clipping if needed. The reason not every panel is set to OnDemand,
* is because not every panel returns a Desired Size that matches what it plans to render at.
*/
OnDemand UMETA(DisplayName = "On Demand (Advanced)")
- Large API Change -
All FSlateDrawElement::Make_____ calls have been deprecated that involved passing in a clipping rect. You no longer should are passed a Clipping rect via OnPaint. You are still passed a rect, but this rect represents a Culling Rect, which is valuable if you need to just out right not paint things the user can't possibly see.
If you were previously trying to determine if you should cull widgets, by doing something like this,
if ( FSlateRect::DoRectanglesIntersect(MyClippingRect, CurWidget.Geometry.GetRenderBoundingRect()) )
That's no longer a good option since there are ways for widgets to ignore the culling bounds. You should convert anything like above to the one below,
if (!SWidget::IsWidgetCulled(MyCullingRect, CurWidget))
To assist in debugging efforts, there are several new debugging console flags in Slate,
Slate.ShowClipping 1 - Controls whether we should render a clipping zone outline. Yellow = Axis Scissor Rect Clipping (cheap). Red = Stencil Clipping (expensive).
Slate.DebugCulling 1 - Disables pushing clipping or stencil rects to the GPU, but continues to intersect culling rects, so that you can tell if a widget is properly culling children it can't possibly draw.
Slate.ShowTextDebugging 1 - Show debugging painting for text rendering.
I've added a new Experimental Feathering Option, it adds AA geometry around the outside of Box and Image brushes.
Slate.Feathering 1
If you're using RenderDoc or something similar, you can now enable render events for slate, so that you can better grok how we're batching and changing states for each UI render pass.
Slate.EnableDrawEvents 1
#jira UE-4659
#rn
Change 3462714 by Nick.Darnell
Fixing a few more compiler issues with the clipping changes.
Change 3462726 by Max.Chen
Switch OnEditStructChildContentsChanged to use FObjectWriter instead of FMemoryWriter which supports serializeing UObjects. This fixes a crash when adding actor array elements to a user defined event struct.
#jira UE-45431
Change 3462801 by Nick.Darnell
Adding a UMG dependency to EngineTestBuild.
Change 3462914 by Max.Chen
Sequencer: Fix regression where spawnables aren't getting saved. Caused by 3407138
#jira UE-30007
#jira UE-39003
Change 3462946 by Nick.Darnell
Automation - Tweaking the UI automation tests converting them over to use the new UI Screenshot automation test.
Automation - Adding a blur widget test.
Change 3462987 by Matt.Kuhlenschmidt
Back out changelist 3458893
Change 3464774 by Matt.Kuhlenschmidt
PR #3629: Bugfix: Missing small icon in Project Launcher profile editor (Contributed by aarmbruster)
Change 3464785 by Nick.Darnell
Fixing some clipping stuff in the editor.
Change 3464830 by andrew.porter
QAGame: Second pass on sequencer smoke test map
Change 3464902 by Nick.Darnell
Loading - Adding some additional checks to the the loading code to ensure we're on the main thread. Additionally adding a fix from UDN that prevents deadlocks in the rare case a user hits Alt+Tab in a fullscreen game while in a hard loading screen.
Change 3464988 by Max.Chen
Sequencer: Add attenuation settings for attached audio components.
#jira UE-33080
Change 3465024 by Nick.Darnell
MoviePlayer - Impoving the playback mode displaynames.
Change 3465074 by Arciel.Rekman
Fix shadowing issues of GraphicsPSOInit.
Change 3465097 by Matt.Kuhlenschmidt
Some refactoring of the details panel
Exposed new methods of adding a struct on scope to a details panel and have it work properly with customizations. The scruct on scope has a "fake" ustructproperty that allows the details panel to show the whole struct not just an individual property.
Refactored the API for adding rows to details panels to make it more consistent\
AddChildCustomBuilder->AddCustomBuilder
AddChildGroup->AddGroup
AddChildContent->AddCustomRow
AddChildPropert->AddProperty
AddChildStructure->AddExternalStructureProperty
AddStructure->AddAllExternalStructureProperties
AddExternalProperty->AddExternalObjectProperty or AddExternalStructureProperty
Change 3465186 by Max.Chen
Sequencer: Save the BindingID in the pre animated token producer so that it can be destroyed properly. This fixes a bug where the default state of a spawnable isn't saved.
#jira UE-43780
Change 3465315 by Matt.Kuhlenschmidt
Fix Fortnite and Orion details panel customization warnings
Change 3465424 by Nick.Darnell
Automation - Moving the step for setting the link to the automation reports to be set before we start the engine.
Change 3465488 by Nick.Darnell
Automation - Forcing textures to load before taking screenshot, so that the scene gets another opportunity to render before we render with Slate. This should fix the Blur UI Test.
Change 3466277 by Arciel.Rekman
Linux: fix window drift when dragging (UE-40380).
- Change by Cengiz Terzibas.
Change 3466370 by Nick.Darnell
UMG - Fixing the colors for the resize handle in the designer.
Change 3466372 by Nick.Darnell
UMG - Fixing the ruler ticks sometimes not being drawn.
Change 3466374 by Nick.Darnell
UMG - Fixing the designer showing multiple options for sequencer.
Change 3466377 by Nick.Darnell
UMG - Cleaning up some clipping bits.
Change 3467025 by Andrew.Rodham
Re-saving assets that contain legacy (<4.15) movie scene data to remove deterministic cook warning.
If conflicts arise during merging of these assets, please ignore the changes made in dev-editor, and accept game-side changes.
(CIS step 62283298, jobId 7773146)
(CIS step 62283297, jobId 7773146)
Change 3467099 by Max.Chen
Fix GetObjectPropertyClass ensure logic. This was returning UObject::StaticClass when valid.
Change 3467172 by Max.Chen
Sequencer: Evaluation optimizations. Also, fixes subsequences not getting expired, leaving dangling spawnables.
#jira UE-43690
Change 3467192 by Matt.Kuhlenschmidt
Fix transactions getting stuck in the color grading controls. This prevents PIE from working properly and causes shutdown crashes
#jira UE-45527
Change 3467251 by Yannick.Lange
ViewportInteraction: Fix scale and rotation snap while dragging with two lasers.
#jira UE-43489
Change 3467331 by Matt.Kuhlenschmidt
Fix D3D shader compiler hard coding shader path and not giving proper warnings when it cannot find the shaders
Change 3467335 by Matt.Kuhlenschmidt
Remove DarkStyle attribute from SNumericEntryBox and allow a spin box style to be passed to it.
Change 3467558 by Max.Chen
Scene Outliner: Generic support to add default columns to a scene outliner.
Change 3467565 by Jamie.Dale
Removing old screenshot data for test
Change 3467589 by Nick.Darnell
Editor - Random cleanup.
Change 3467596 by Nick.Darnell
Progress Bar - Exposing Border Padding to UMG.
Change 3467600 by Nick.Darnell
Slate - Adjusting the rendering of the splitter, previously it could be off by a pixel or two, which becomes more apparent now with the clipping changes.
Change 3467601 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467662 by Nick.Darnell
Automation - Fixing a bug with the screenshot comparison tool not replacing (removing) the old screenshot data.
Change 3467674 by Max.Chen
Property Editor: Fix static analysis warning
Change 3467737 by Max.Chen
Sequencer: Added OnMovieSceneBindingsChanged delegate
Change 3468053 by tim.gautier
QAGame: Updating Editor Smoke Map
- Updated landscapes into Stations for testing
- Added Foliage Sublevel
Change 3468194 by Arciel.Rekman
Linux: fix problems communicating with various STL-using libs.
- Stop hiding global new/delete signatures.
- Disable CEF3 since this change uncovers the problem with libcef.so not built to use bundled libpng.
Change 3468678 by Max.Chen
Sequencer: Set "Sequencer Actor" tag before setting the actor label so that the outliner refreshes after the actor has the tag.
Change 3469314 by tim.gautier
QAGame: Added Painted Foliage / Spline section to EditorSmoke map
Change 3469377 by Nick.Darnell
Slate - Fixing some warnings in a couple of sample games due to the clipping changes.
#rnx
Change 3469767 by Max.Chen
Sequencer: Outliner column and sequencer binding data
#jira UE-43470
Change 3469974 by Arciel.Rekman
Fix code projects not working in Linux installed build.
Change 3470082 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470174 by Nick.Darnell
Slate - Get the last widget in a widget path utility.
Change 3470176 by Nick.Darnell
UMG - User Widgets now have an easy way to know if they're part of or have been removed from the focused widget path, which is handy for doing effects.
Change 3470261 by Nick.Darnell
Slate - The GetRenderer() call on SlateApplication no longer returns a SharedPtr, rather than convert it to a thread safe ptr, going to just make accessing it a raw ptr return, so it can be safely referenced on the game thread while being used on the slate loading thread.
Change 3470286 by Max.Chen
Sequencer: Scene Component's HiddenInGame now goes through the VisibilityTrack and the visibility template.
Change 3470366 by Nick.Darnell
Slate - We now version focus per user, that way during focus events, we can safely abort focus events and state transitions if someone interrrupts the active focus event with something new.
Change 3470649 by Matt.Kuhlenschmidt
Fix deprecation warnings
Change 3470695 by Matt.Kuhlenschmidt
Fixed typo
#jira UE-45580
Change 3470721 by Matt.Kuhlenschmidt
Fix static analysis
Change 3471254 by Michael.Dupuis
#jira UE-42952: Keep occlusion result per view
Change 3471287 by Nick.Darnell
UMG - Render Focus Rule now defaults to never.
Change 3471291 by Nick.Darnell
Slate - Fixing FSlateRenderer* change fallout.
Change 3471299 by Nick.Darnell
Slate - Fixing FSlateRenderer* change.
Change 3471323 by Nick.Darnell
Automation - Fixing automation and Static Analysis warning.
Change 3471413 by andrew.porter
QAGame: Added test content for anim blending and material parameteres to sequencer smoke level
Change 3471649 by Max.Chen
Sequencer: Modify the track when adding animation
#jira UE-45618
Change 3471659 by Matt.Kuhlenschmidt
Added a way to check if a movie is playing from the engine.
Prevented viewport redraws for canvas loading screens if a slate based loading movie is playing
Change 3471734 by Matt.Kuhlenschmidt
Added basic material hookup to USD. Similar to FBX it will find materials based on rules specified by the user in the import settings
Change 3472176 by Nick.Darnell
UMG - Improving the display of the +Track menu in sequencer for UMG. Renamed it from +Add, which is repetitve to +Track. Additionally, the dropdown now shows the currently selected widgets, as well as a submenu containing all the 'important' widgets, so we no longer populate that list with a ton of irrelevant widgets that are just Buton_1 - N, which is pointless in showing people, they'll never guess which is the right button.
Change 3472740 by Max.Chen
Sequencer: Add GetThisFrameMetaData accessor
Change 3472748 by Max.Chen
Sequencer: Added OnBeginScrubbing and OnEndScrubbing event delegates
Change 3472753 by Max.Chen
Sequencer: Add EMovieSceneDataChangeType parameter to OnMovieSceneDataChanged delegate
Change 3472870 by Nick.Darnell
Clipping - Fixing the deprecated tip for scissor rect boxes to be correct. Removing it's usage from UT.
Change 3473340 by Max.Chen
Scene Outliner: Add ability to register additional filters
Change 3473348 by Max.Chen
Details View: Make ForceRefresh virtual. Added accessors to delegates (ie. GetIsPropertyReadOnlyDelegate)
Change 3473441 by Max.Chen
Sequencer: Autokey Refactor Part 2.
Autokey is now a single toggleable state.
Allow Edits Mode has 3 states:
Allow All Edits - Allow any edits to occur, some of which may produce tracks/keys or modify default properties.
Allow Sequencer Edits Only - All edits will produce either a track or a key.
Allow Level Edits Only - Properties in the details panel will be disabled if they have a track.
#jira UE-45229
Change 3473670 by Nick.Darnell
Modules - The module manager no longer returns sharedptrs to IModuleInterfaces, this was the source of rare hard to track down crashes due to a shared ptr reference leak when GetModule was called on non-main threads. We now store a TUniquePtr internally, and only lease out raw pointers.
#rn
Change 3473711 by Nick.Darnell
Disabling the ensure in the module manager.
Change 3473747 by Max.Chen
Sequencer: Fix tooltip
Change 3474091 by Jamie.Dale
Added a warning when cooking a UFontFace that is outered to a UFont asset
These cause issues with iterative COTF, and should be split off into their own assets (as the UI has been asking people to do for several versions)
Change 3475052 by Yannick.Lange
VR Editor: Fix Crash when quitting the editor with VR Mode enabled. VR Editor was being enabled when saving the map on closing the editor.
#jira UE-45415
Change 3475054 by Yannick.Lange
Fix crash when adding a camera to the world in VR Mode the second time. The slate application did not reset when stop dragging in VR Mode, so the second time when starting to drag a camera out of the UI it would already by in a dragging state.
#jira UE-45574
Change 3475263 by Nick.Darnell
Fixing some additional cases of IModuleInteface SharedPtr usage.
Change 3475268 by Max.Chen
Sequencer: Set jumped state when looping playback. This fixes an issue where audio doesn't stop and restart when looped.
#jira UE-45654
Change 3475269 by Max.Chen
Scene Outliner: Additional filters should only apply to actor browsing mode
Change 3475407 by Nick.Darnell
Fixing some clipping / module shared ptr changes in the launcher code.
Change 3475542 by Max.Chen
Sequencer: Update thumbnail and section highlighting to use new clipping behavior.
#jira UE-45692
#jira UE-45689
Change 3475743 by Michael.Dupuis
#jira UE-45183: When updating phyx region take into account simple collision mip
Change 3475949 by Arciel.Rekman
Remove PhysX deoptimization (no longer needed).
- OR-24947 has been closed three months ago.
Change 3476022 by Michael.Dupuis
#jira UE-45560: Make sure we're not going out of range
Change 3476063 by Michael.Dupuis
#jira UE-45562: Do not try to unregister from static mesh if no static mesh is specified for the component
Change 3476168 by Michael.Trepka
Added handling of directory symlinks to FApplePlatformFile::IterateDirectory
#jira UE-43704
Change 3476172 by Nick.Darnell
Fixing a Imoduleinterface change.
Change 3476183 by Jamie.Dale
Exposing GoTo/ScrollTo to single-line editable text for API parity with multi-line editable text
Change 3476385 by Arciel.Rekman
Linux: handle symlinks when iterating directories.
Change 3476522 by Michael.Trepka
Solved a problem with Mac FMallocTBB::Malloc() returning nullptr for 0 bytes allocations, which is inconsistent with other platforms. On Mac we always scalable_aligned_malloc, which behaves differently than scalable_malloc, so for 0 bytes requests we allocate sizeof(size_t), which is exactly what scalable_malloc does internally in such case.
Change 3476806 by Nick.Darnell
UMG - Focus the designer after dropping a widget onto the surface.
Change 3476809 by Nick.Darnell
Curve Editor - Enable Clipping on the curve editor.
Change 3477475 by Nick.Darnell
Fixing a module interface shared ptr usage in UT.
Change 3477553 by Yannick.Lange
VR Editor: Removed AssetEditorPanelID and replaced it with TabManagerPanelID. A panel for AssetEditorPanelID was never created making it impossible to open an asset editor.
Change 3477734 by Yannick.Lange
VR Editor: Fix Warning: SetRelativeScale3D : Invalid Scale entered (X=inf Y=inf Z=inf). Resetting to 1.f. warning when adding CineCameraActor to World from Modes Panel. Make sure to not divide by zero when there is no boundary scale.
#jira UE-44933
Change 3477761 by Jamie.Dale
Some improvements to avoid loading the native .locres files twice when we don't need to
Change 3477780 by Nick.Darnell
PR #3250: Return correct VirtualUserIndex (Contributed by projectgheist)
Change 3477786 by Nick.Darnell
PR #3650: Changed TestNull to accept const pointers. (Contributed by e-agaubatz)
Change 3477795 by Nick.Darnell
PR #2844: UE-36936: Don't stretch container for Plugin Image (Contributed by projectgheist)
Change 3478092 by Nick.Darnell
PR #2341: Optional Middle Mouse Button panning in Graph Editor (Contributed by flipswitchingmonkey)
Engine Edit - Made some small changes to the enum type, and some naming.
Change 3478450 by Nick.Darnell
Fixing some uninitialized variable errors.
Change 3479827 by Andrew.Rodham
Sequencer: Addressed serialization issues with some struct types
Change 3479874 by Jamie.Dale
Fixed "NativeGameLanguage" not being used correctly during localization initialization
Change 3480012 by Andrew.Rodham
Sequencer: Fixed loading tagged properties as native for track identifiers
#jira UE-45823
Change 3480337 by Alexis.Matte
Fix morph target crash missing some valid index check
Change 3480804 by Alexis.Matte
Fix crash with ColorGradingMode custom detail
#jira UE-45638
Change 3480892 by Andrew.Rodham
Sequencer: Ensure that movie scene sequences know about the editor object version
#jira UE-45842
Change 3481073 by Nick.Darnell
Fix the shader compiler error from main in Slate.
Change 3481303 by Nick.Darnell
UMG - Fixing a bug with the drag handle not working correctly in HDPI mode.
Change 3481308 by Nick.Darnell
Slate - Tweaking the IsWidgetCulled logic to consider both the layout and rendering bounds. If we do this, we get a much more desireable outcome for people that want to animate widgets and such and plan to have temporary animations to move the widget offscreen, but want the layout bounds to anchor that widget in the visible frame so that it animates even when normally it would be culled b/c the render transform and therefore the renderbounds moved it completely outside the culling rect.
Change 3481629 by Max.Chen
Sequencer: Add Level Sequence Actor as an output for CreateLevelSequencePlayer()
#jira UE-45785
Change 3481899 by Yannick.Lange
VR Editor: Added debug modetoggle command with an event that is broadcasted whenever this happens. Currently this is used to show all the floating UIs of the UI system to debug without HMD using VREd.ForceVRMode.
Change 3481984 by Michael.Dupuis
#jira UE-45845: always validate if we have a static mesh before trying to access it as user can decide to not assign one and use the tools
Change 3482047 by Nick.Darnell
Slate - Adding some comments to IsWidgetCulled.
Change 3482110 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482136 by Jamie.Dale
The CamelCase break iterator now treats digits around character tokens as part of the identifier
Change 3482138 by Michael.Dupuis
#jira UE-45854: Properly unregister during undo operation
Change 3482150 by Michael.Dupuis
#jira UE-45845 : Add missing nullcheck for GetStaticMesh
Change 3482153 by Nick.Darnell
Slate - IsWidgetCulled is no longer static and is now called IsChildWidgetCulled.
Change 3482180 by Nick.Darnell
UMG - Widget Components do not need to define a widget class to be rendererd, they can have native slate widgets only. This was a regression from main.
Change 3482273 by Nick.Darnell
UMG - Tweaking some more things about the widget component box outline.
Change 3482308 by Alexis.Matte
Fixing morph target smooth group support. Do not call FillSkeletalMeshImportData more then once on FbxNode since this fonction is doing some conversion and change the FbxNode, applying those conversion twice do not return the same faces smooth group.
#jira UE-45696
Change 3482327 by Nick.Darnell
UMG - More tweaks to the WidgetComponent so both shows the box outline, but works in game and VR editor.
Change 3482705 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484245 by Max.Chen
Sequencer: Evaluate on end scrub. This fixes a bug where audio doesn't evaluate in a stopped position at the end of scrubbing, causing it to not stop all sounds. This fixes a bug introduced from 3365018 where evaluate on end scrub was removed.
#jira UE-45905
Change 3484263 by Max.Chen
Sequencer: Fix crash on forcing refresh of details panel on release.
#jira UE-45911
Change 3484431 by Andrew.Rodham
Resaving assets that contain legacy data to suppress CIS warnings.
- If conflicts arise in these assets, please take game-side changes and ignore these.
Change 3484474 by Alexis.Matte
Fix the morph target animation curve name matching.
#jira UE-20294
Change 3484475 by Alexis.Matte
When removing a LOD, make sure we remove all morph target data associate to the LOD.
Change 3484489 by Nick.Darnell
PR #3668: UE-45908: Cache debug line locations when performing a LineTraceMulti (Contributed by projectgheist)
#jira UE-45908
Change 3484692 by Nick.Darnell
Slate - Reverting a change from a game stream. All Arranged Children don't need to allocated 42 to begin with. Do need to initialize WidgetPaths better.
Change 3484703 by Nick.Darnell
Player Input - Making the input event loop for players obey EKeys::NUM_TOUCH_KEYS, rather than being set to Touch10, as the maximum touch input amount, to make supporting greater than 10 touches easier. Also making the seeding of keys use EKeys::NUM_TOUCH_KEYS.
#jira UE-43213
Change 3484918 by Jamie.Dale
Fixed font measuring regression with RTL text
RTL applies the character count to the next glyph, so it shouldn't process the end of the loop (this was how the older code used to work).
Change 3485718 by Nick.Darnell
Editor - Removing Super Search & User Feedback button.
Change 3485719 by Nick.Darnell
Portal - Removing SuperSearch.
Change 3485751 by Matt.Kuhlenschmidt
Fix crash accessing platformer game menu if the menu is open during a console based load
#jira UE-45950
Change 3486047 by Arciel.Rekman
Linux: add OpenEXR implementation (UE-40270).
#jira UE-40270
Change 3486467 by Max.Chen
Sequencer: Reset max tick rate when destroyed.
#jira UE-45956
Change 3486477 by Max.Chen
Sequencer: Refresh outliner when column is removed.
#jira UE-45891
Change 3486667 by Andrew.Rodham
Added missing include
Change 3486724 by Andrew.Rodham
Sequencer: Fixed curves with no default value, and no keys being evaluated and applied to properties
- Also fixed an edge case where a zero (but non-animated) channel could be applied to a final transform
Change 3486730 by Alexis.Matte
In the Auto-Reimport options, hide the mout point only for the default /Game/ folder
#UE-45684
Change 3486749 by Alexis.Matte
Make sure the parent window of the monitor directory browse folder is set properly
#jira UE-45682
Change 3486805 by Matt.Kuhlenschmidt
Additional safety against invalid objects being accessed by slate
Change 3486848 by Alexis.Matte
Make sure Monitor folder feature support root mount point map folder
During auto import, give priority to asset import factory over the scene import factory
#jira UE-45691
Change 3486879 by Andrew.Rodham
Removing obsolete QA assets
Change 3486950 by Nick.Darnell
PR #2281: Scrollbar missing features and SScrollbar fixes (Contributed by SNikon)
Review - made some adjustments from the original.
Change 3486954 by Nick.Darnell
Slate - Moving the STableViewBase over to the FOverscroll class, rather than it's own clone.
Change 3486967 by Nick.Darnell
Slate - Fixing some HDPI calculations for fitting new windows on screen, it was using the unscaled size of the widgets for fitting, when it needed to scale them up.
Change 3486970 by Andrew.Rodham
Sequencer: Delay mouse capture until drag for sequencer time slider
- Fixes context menus not opening as a result of mouse capture being taken on mouse down
#jira UE-45937
Change 3486984 by Andrew.Rodham
Sequencer: Improved blending type iconography
Change 3486996 by Nick.Darnell
UMG - Adding a way for games to opt-out of the slow widget path, to completely prevent them from being cooked.
UMG - The movie data is no longer cloned for each new instance that inhabits. It now keeps a reference to the now publically accessible movie scene data on the class instead.
Change 3487070 by Andrew.Rodham
Sequencer: Added graphics for key areas that represent empty space
Change 3487195 by Andrew.Rodham
Sequencer: Changed evaluation groups to always flush implicitly
- Due to the latent nature of blended token types, it's no longer safe to rely solely on execution token order between tracks
- This fixes an issue where events set in the PostEvaluation stage were executed before blended token actuation
Change 3487322 by Nick.Darnell
PR #2457: Add .gitdeps.xml-files for plugins support (Contributed by bozaro)
Change 3487363 by Nick.Darnell
PR #2481: Fix for packing of a project with users plugins (Contributed by yatagarasu25)
Change 3487439 by Nick.Darnell
PR #2642: Changed private to protected in SVirtualJoystick.h (Contributed by Skylonxe)
Change 3487500 by Arciel.Rekman
Removed LinuxNativeDialogs.
- No longer used; has been superceded by SlateDialogs since UE 4.8 (2 years ago).
Change 3487630 by Lauren.Ridge
Don't create Landscape Info Maps for Editor Preview Worlds or thumbnail worlds
#jira UE-44885
Change 3487864 by Matt.Kuhlenschmidt
Exposed the asset registry to blueprints and script. Works in editor scripts and runtime scripts
AssetRegistry is now a UInterface object.
Blueprint users can access various asset registry methods using the asset registry interface (via GetAssetRegistry) and various static helpers in the AssetRegistryHelpers object
C++ users should still continue to use IAssetRegistry.
Change 3487879 by Matt.Kuhlenschmidt
Renamed asset tools uobject helper to UAssetToolsHelpers
Change 3487926 by Lauren.Ridge
Fixing reset to default not showing up for custom widgets
#jira UE-44164
Change 3488184 by Matt.Kuhlenschmidt
PR #3656: Make References/Referencers List copyable (Contributed by user37337)
#jira UE-45763
Change 3488240 by Matt.Kuhlenschmidt
Fix compiler issue
Change 3488350 by Lauren.Ridge
Landscape info map transactional state is based on its world's transactional state
#jira UE-44885
#jira UE-46019
Change 3488412 by Matt.Kuhlenschmidt
Fix reset to default showing up in two different places for some customizations
Change 3488413 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488414 by Matt.Kuhlenschmidt
Fix slate font customization
Change 3488415 by Matt.Kuhlenschmidt
Missed file
Change 3488565 by Arciel.Rekman
Add pretty printers for gdb (UETOOL-1171).
- Committing shelf by Cengiz.Terzibas, with some modifications.
#jira UETOOL-1171
Change 3489094 by Nick.Darnell
Slate - The Slate RHI Renderer now caches the TextureLODGroups so that it can properly lookup the filtering of different texture groups that are set to Default, instead of a particular filter override on a texture.
Engine/Rendering - Simplifying some of the setup logic in TextureLODSettings so that code is shared for setting them up properly after loading from a config file.
Change 3489095 by Nick.Darnell
PR #2699: GameViewportClient - Added a method to allow setting the viewport cur. (Contributed by rfenner)
Review - Fixed spacing.
Change 3489108 by Matt.Kuhlenschmidt
Fix deprecation warning
Change 3489120 by Nick.Darnell
PR #3478: Fix possible UComboBoxString crash (Contributed by nakosung)
Change 3489147 by Andrew.Rodham
Sequencer: Adding return value to function to appease static analysis
- This function is never compiled, and if it is, it won't compile, but static analysis doesn't know that
Change 3489264 by Nick.Darnell
Testing - Finishing the thought behind an enum comment.
Change 3489265 by Nick.Darnell
PR #2750: UE-35164: Button padding (Contributed by projectgheist)
Change 3489267 by Nick.Darnell
PR #3645: UE-45464: Handle SSlider mouse interaction more accurately (Contributed by projectgheist)
Change 3489632 by Arciel.Rekman
Correctness changes to MallocPoisonProxy.
- Missing forwarding functions added. Incorrect comment removed.
- Change by Steve.Robb, doing here so it is in 4.17.
Change 3489689 by Arciel.Rekman
More MallocPoisonProxy changes I missed in previous CL.
Change 3489751 by Matt.Kuhlenschmidt
Moved editor performance settings out of per-project settings so they can be shared across projects
Change 3489837 by Lauren.Ridge
Keyboard shortcut for entering/leaving VR Mode is now Alt+V
Change 3491082 by Arciel.Rekman
Linux: better fix for the crash due to name collision (UE-46040).
- Put classes in Sequencer module into Sequencer namespace instead of SceneOutliner namespace.
- Undid change in the SceneOutliner module.
#jira UE-46040
Change 3491096 by Arciel.Rekman
Fix UAT compilation on the newest mono.
Change 3491240 by Max.Chen
Sequencer: Disable key button when allow level edits only is on.
#jira UE-46060
Change 3491406 by Yannick.Lange
Fix editor crashes when opening a project that includes a plugin with more than two custom Volume classes. This issue was caused because registering show volume commands is based on finding volume classes. Finding these classes at multiple times resulted in a mismatch of the returned array of volume classes because modules/plugins were still being loaded.
#jira UE-45806
Change 3491559 by Alexis.Matte
Make sure we use the good preview mesh when doing a preview
#jira UE-45963
Change 3491563 by Alexis.Matte
Fix crash with staticmesh editor LodLevel selection
Change 3491564 by Nick.Darnell
UMG - Fixing an offset with the grab handles in HDPI mode.
Change 3491595 by Nick.Darnell
Editor - Fixing a clipping artifact in the pin type dropdown in the blueprint editor.
Change 3491604 by Nick.Darnell
Back out changelist 3489265
Change 3491615 by Arciel.Rekman
Added malloc replay proxy (Linux only for now).
- Allows to dump malloc callstream (without regard to threads) and replay later to study the behavior of different mallocs and/or repro problems.
Change 3491684 by Arciel.Rekman
Added FMalloc functions I missed.
- Also moved function bodies into the .cpp file, this does not make a difference in performance in this case.
Change 3491692 by Matt.Kuhlenschmidt
Some minor fixes to the static mesh editor
- Fix UV combo button looking non-standard on the toolbar
- Fix a few combo buttons in the details panel looking too big.
Change 3491702 by Arciel.Rekman
Do not compile replay proxy-specific code when not used.
Change 3491717 by Michael.Dupuis
#jira UE-35083:
The component is now the owner of the PerInstanceRenderData instead of the proxy
Add an Update path to only update specified instances range
Always call BuildTreeIfOutdated so we have a standard code path to make sure static mesh are fully loaded before trying to build the tree
Moved the Instance Buffer aysnc to the base class, as it's not related to UHierarchicalInstancedStaticMeshComponent
Expose a new property to decide if we require dynamic instance buffer
Change 3491758 by Matt.Kuhlenschmidt
Fix crash on static mesh editor shutdown
Change 3491873 by Cody.Albert
Fixed clipping issue in Sequencer curve editor
#rnx
Change 3491956 by Matt.Kuhlenschmidt
Fix crash opening the Previewing sub-menu in the level editor settings menu
#jira UE-46095
Change 3492046 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492076 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492165 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492222 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492274 by Michael.Dupuis
#jira UE-46105: Fixed Clang warning
Change 3492338 by andrew.porter
QAGame: Testing ensure when submitting
Change 3492371 by Nick.Darnell
UMG - Reverting the animation sharing, cossed GLEO regressions in cooking. Will look for a better solution.
Change 3492462 by Matt.Kuhlenschmidt
Fix ensure checking in files through perforce
Change 3492491 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492505 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3492517 by Jamie.Dale
The package localization ID is no longer used at all at runtime, and is now truly editor-only
This should have always been the case, but it was leaked into manifest/archives/PO files in 4.14, and while 4.15 removed it from PO files it was still present in the manifest/archives. This change removes it entirely (unless gathering editor-only data, and even then the PO file will still collapse the entries together for translation), and the deprecated 4.14 export behavior will now produce an error if you attempt to use it.
After taking this change you'll need to run a gather, import, and compile of your LocRes files to update your game localization to use the new localization IDs.
Change 3492630 by Nick.Darnell
UMG - Removing some extra cleanup code that's probably overkill and is causing a crash for uses of "Within" in class meta.
#jira UE-46124
Change 3492692 by Matt.Kuhlenschmidt
Fix drop shadows inheriting the outline color of the font. The outline should still appear but not have a different outline color from fill color
Change 3492714 by Matt.Kuhlenschmidt
Added outline with drop shadow to font automation test
Change 3492737 by Matt.Kuhlenschmidt
Fix linux
Change 3492992 by tim.gautier
Resaving Ocean Widget Blueprints / Sequences to resolve Legacy Sequence Data warnings
#jira UE-46132
Change 3493089 by Jamie.Dale
Ensure that the composite font of a font asset is flushed when the font object is GC'd
Change 3493322 by Jamie.Dale
Fixing null crash
#jira UE-45758
Change 3494467 by Andrew.Rodham
Fix Xbox warning
Change 3494852 by tim.gautier
QAGame: Changed streaming method of QA-EditorSmoke-Landscape to Always Loaded
Change 3494853 by Nick.Darnell
Another attempt at fixing the automation blueprint SA warning.
Change 3494896 by Arciel.Rekman
Fix possible null pointer access during Vulkan init.
- May fix static analysis warnings in UE-46142, although warnings seem to be referring to something else.
#jira UE-46142
Change 3494987 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495010 by Matt.Kuhlenschmidt
Adding additional logging to track down html5 issue
Change 3495212 by Michael.Dupuis
#jira UE-46143: Properly init the InstanceRenderData during the cooking phase (required by fortnite)
Change 3495536 by Jamie.Dale
Updating UGameEngine to call its Super::PreExit after performing its own teardown
This prevents UEngine cleaning up resources that UGameEngine still needs.
#jira UE-46159
Change 3495551 by Arciel.Rekman
Another attempt to fix analyzer problem (UE-46142).
Change 3495794 by Jamie.Dale
Fixing some font cooking warnings by splitting out font faces from their font assets
#jira UE-45843
Change 3495905 by Matt.Kuhlenschmidt
Fix USD crash when importing a meshwith no material
[CL 3499771 by Matt Kuhlenschmidt in Main branch]
Lauren Barnes
max chen
Matt Kuhlenschmidt
Michal Valient
ryan durand
Chris Gagnon
Stefan Boberg
matt hoffman
Lauren Ridge
Marc Audy
Ben Marsh
Andrew Grant