Commit Graph

137 Commits

Author SHA1 Message Date
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
brooke hubert
c26a6ff719 Fix a crash in the mode manager when some mode's exit sequence accidentally calls enter on itself.
#preflight 625f35673b5b2e3f1a9cc9cb
#Jira UE-145760
#rb lauren.barnes
#lockdown jeanmichel.dignard

#ROBOMERGE-AUTHOR: brooke.hubert
#ROBOMERGE-SOURCE: CL 19843196 in //UE5/Release-5.0/... via CL 19849703
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19853263 by brooke hubert in ue5-main branch]
2022-04-21 14:41:18 -04:00
fred kimberley
7fbfaf57c8 Require explicit constructors/casts when converting between FVector, FVector3d, and FVector3f.
#jira UE-122078
#rb Andrew.Davidson, Colin.McGinley
#preflight standard build

#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 18817999 in //UE5/Release-5.0/... via CL 18818012 via CL 18822871
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824721 by fred kimberley in ue5-main branch]
2022-02-02 07:59:31 -05:00
patrick enfedaque
03bb3a2f2a - Prevent 'Save Current Level As' through editor modes
- Avoid adding newly saved level if RemoveLevelFromWorld fails

#rb richard.malo, brooke.hubert
#preflight 61e1ae58076be0fc4e15ea77

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 18620036 in //UE5/Release-5.0/... via CL 18620344 via CL 18620779
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18621059 by patrick enfedaque in ue5-main branch]
2022-01-14 14:01:23 -05:00
brooke hubert
46a1aedcaf Rename function on mode manager to prevent naming confusion with deactivate/delete.
#Jira none
#rb trivial
#preflight 61e099ab250b9537f781a347

#ROBOMERGE-AUTHOR: brooke.hubert
#ROBOMERGE-SOURCE: CL 18605637 in //UE5/Release-5.0/... via CL 18605667 via CL 18605696
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18605713 by brooke hubert in ue5-main branch]
2022-01-13 16:49:43 -05:00
tyson brochu
e33f9f308e Static Mesh Editor: prompt user to Accept/Cancel current modeling tool (if any) when shutting down SME
#jira UE-137979
#rnx
#preflight 61e06ba3797757aace83aeec

#ROBOMERGE-AUTHOR: tyson.brochu
#ROBOMERGE-SOURCE: CL 18600116 in //UE5/Release-5.0/... via CL 18600130 via CL 18600156
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18600178 by tyson brochu in ue5-main branch]
2022-01-13 13:39:41 -05:00
julien stjean
23596ba9c7 Fixed code that depends on the selection order without a proper normalization of the selection set.
#jira UE-132003
#preflight 61b0d8b1c17a9a154abfe810
#rb Brooke.Hubert

#ROBOMERGE-AUTHOR: julien.stjean
#ROBOMERGE-SOURCE: CL 18431233 in //UE5/Release-5.0/... via CL 18435330
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18435562 by julien stjean in ue5-release-engine-test branch]
2021-12-10 17:48:48 -05:00
patrick enfedaque
77435048b2 EditorMode:
- Guard against legacy mode getting GCed while Deactivating modes
- ForEachMode iterates over array copy in case original array is modified while iterating
- New IsSelectionDisallowed virtual allows mode to refuse selection of actor regardless of other modes

#rb brooke.hubert, lauren.barnes, julien.stjean

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 18311266 in //UE5/Release-5.0/... via CL 18311467
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18311589 by patrick enfedaque in ue5-release-engine-test branch]
2021-11-29 12:07:42 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
christina tempelaarl
8a43e6f448 Fix local rotation bug that occurs on static mesh instances within a hierarchy of transformations (e.g. attached to an actor).
#jira UE-127114
#rb brooke.hubert
#preflight 6148bc06ee16e2000160e7bb

#ROBOMERGE-AUTHOR: christina.tempelaarl
#ROBOMERGE-SOURCE: CL 17585622 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v871-17566257)
#ROBOMERGE[bot1]: main

[CL 17585629 by christina tempelaarl in ue5-release-engine-test branch]
2021-09-21 14:11:20 -04:00
ryan schmidt
55e4644fd1 Add support for UEdMode-level InteractiveToolsContext which exists at the same time as the existing ModeManager-level ITC.
- rename UEdModeInteractiveToolsContext to UEditorInteractiveToolsContext, made all functions virtual so they can be customized for the new Editor/EdMode implementations where necessary
- add UModeManagerInteractiveToolsContext and UEdModeInteractiveToolsContext subclasses. Most functionality stays in the base class. Mouse-handling functions that manipulate the InputRouter move to ModeManagerITC.
- EdModeITC now is initialized based on a ModeManagerITC, and shares it's InputRouter
- ModeManagerITC creates the child EdModeITCs, forwards Tick/Render/DrawHUD calls
- FEditorModeTools now creates a ModeManagerITC

- Add EToolsContextScope enum, with options for Editor and EdMode ToolsContext
- UEdMode::Enter() now creates a child EdModeITC via new EditorITC::CreateNewChildEdModeToolsContext() function above, in addition to storing reference to the ModeManagerITC. Internal code updated to handle both ITCs.
- The EdModeITC is shut down on ::Exit() and unregistered from the EditorITC parent
- UEdMode ITC access functions (GetToolsContext, GetToolManager, RegisterTool) now take an optional Scope argument
- UEdMode::GetDefaultToolScope() allows EdModes to define default scope for the entire mode, defaults to Editor scope

- removed unused CanStartTool()/etc wrapper functions from FModeToolkit, they were not being called
- FModeToolkit::Init() now listens to events from both the ModeManagerITC and EdModeITC, delete cleans them both up
- FModeToolkit::OnToolStarted() checks both ITCs to see which one owns the new Tool

- updated all EdModes that were directly accessing the UEdMode::ToolsContext member, replaced with calls to GetToolsContext() / GetToolManager() APIs
- updated ModelingToolsEditorMode to use EdMode ToolScope

#rb brooke.hubert
#rnx
#jira none
#preflight 6140cc1130c00d0001dc4b9e

#ROBOMERGE-AUTHOR: ryan.schmidt
#ROBOMERGE-SOURCE: CL 17510176 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17510201 by ryan schmidt in ue5-release-engine-test branch]
2021-09-14 17:11:13 -04:00
julien stjean
9af8446874 Changed the TypedElementInterface to use UInterfaces instead of an object base api.
#jira UETOOL-4054
#preflight 6132413c1a52e20001dce90d
#rb Jamie.Dale

#ROBOMERGE-SOURCE: CL 17424653 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17424661 by julien stjean in ue5-release-engine-test branch]
2021-09-03 14:18:34 -04:00
lauren barnes
5bd8c74d4e FAssetEditorModeUILayer now serves as a layer between a given asset editor and the mode toolkits, so that the mode toolkits can request UI panels and the asset editor determines where they are located in the asset editor layout. The first implementation is in the level editor, and all default mode UI has been moved to FModeToolkit.
#jira UETOOL-3555
#preflight 61143dbf9c7bb10001f080b3
#rb Matt.Kuhlenschmidt

#ROBOMERGE-SOURCE: CL 17152278 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17152291 by lauren barnes in ue5-release-engine-test branch]
2021-08-12 10:54:54 -04:00
brooke hubert
c785e9cef0 Fix local space gizmos not working with static mesh instance selections.
#Jira none
#preflight 61119c1a0d783d0001c97b46
#rb jamie.dale

#ROBOMERGE-SOURCE: CL 17118074 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17118092 by brooke hubert in ue5-release-engine-test branch]
2021-08-10 12:18:52 -04:00
christina tempelaarl
8f93edb7ba Fix crash in mode manager due to dereferencing null pointer.
#jira UE-119834
#rb brooke.hubert, jamie.dale
#preflight 60f6e2f8e885f200019dd272

#ROBOMERGE-SOURCE: CL 16898040 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16898048 by christina tempelaarl in ue5-release-engine-test branch]
2021-07-20 12:33:46 -04:00
semion piskarev
7f1297cd8b MeshModelingTools: Change mode manager's HoveredViewportClient back to acting as LastHoveredViewportClient, to work around MouseLeave/MousEnter mismatch when flying in viewport. Also fix to GizmoBoxComponent not using correct position for scale calculation.
#rb Ryan.Schmidt
#rnx
#jira UE-119476

#ROBOMERGE-SOURCE: CL 16850746 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16850749 by semion piskarev in ue5-release-engine-test branch]
2021-07-14 11:44:34 -04:00
brooke hubert
d3089b1f9e Fix an issue where hit proxies were not being updated after placement mode painted assets.
Start/EndTracking was not being called for the mode manager after input reshuffles; additionally if we are circumventing the normal viewport start/end tracking, we need to make sure that hit proxies redraw for items that may have been placed via an ITF tool by invalidating the viewport.

#preflight 60ca57306092ba000113f2a7
#Jira none
#rb jamie.dale
[FYI] semion.piskarev

#ROBOMERGE-SOURCE: CL 16697572 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16697574 by brooke hubert in ue5-release-engine-test branch]
2021-06-16 18:24:42 -04:00
semion piskarev
c06adcc33d MeshModelingTools: Refactored modeling tools gizmos to avoid communication between component and proxy and prevent race conditions that resulted in incorrect view information being used in hit tests. Also fixed a minor issue with view plane-parallel circle gizmos, and created option to have scaling handles align better to view.
#rb Ryan.Schmidt
#rnx
#jira UETOOL-3468

#ROBOMERGE-SOURCE: CL 16611870 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16611883 by semion piskarev in ue5-release-engine-test branch]
2021-06-09 16:29:27 -04:00
danny couture
25c6066c53 Prepare for the deprecation of direct access to the Resource member of UTexture in favor of the GetResource() accessor.
#rb Francis.Hurteau
#preflight 609e5182ef86d30001ad0a18
#rnx

#ROBOMERGE-SOURCE: CL 16328103 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v804-16311228)

[CL 16328107 by danny couture in ue5-release-engine-test branch]
2021-05-14 07:17:49 -04:00
Marc Audy
f02d489290 Update Release-Engine-Test from Release-Engine-Staging @ 16264272
[CL 16264458 by Marc Audy in ue5-release-engine-test branch]
2021-05-11 01:10:20 -04:00
Lauren Barnes
39f1923ed0 Deprecating .Icon() as a slate attribute on SDockTab. By default, tab icons fall back to using the one for the tab spawner's menu item. SetTabIcon can be used in the edge cases where an icon needs to be set that doesn't match the default. Updating all found cases of .Icon() usage on SDockTab.
#jira UETOOL-3429
#preflight 60996a2bdd2e00000126ff25
#rb Matt.Kuhlenschmidt

[CL 16251489 by Lauren Barnes in ue5-main branch]
2021-05-10 14:19:15 -04:00
brooke hubert
5df00b6c31 Asset Placement mode and its tools use a context object from ITF to access typed element common actions and the selection set.
#Jira UE-110554
#preflight 6092d76f93d92d00018dcb74
#rb jamie.dale
#fyi christina.tempelaarl

[CL 16211739 by brooke hubert in ue5-main branch]
2021-05-05 15:22:49 -04:00
brooke hubert
61cfd942d5 Fixing input flow fallout from CL 15851576. Specifically - allow ViewportClients to pass input to mode toolkits again.
#Jira none
#preflight 607a116bc894390001599d8c
#rb semion.piskarev
#fyi jeanmichel.dignard
#fyi lauren.barnes

[CL 16054735 by brooke hubert in ue5-main branch]
2021-04-19 16:24:16 -04:00
brooke hubert
73e3368dd3 Fix a leak when a world is destroyed and a mode in the global mode tools is active which holds references to that world.
#Jira UE-112517 UE-112330
#preflight 6078621575d00d0001e1123f
#rb lauren.barnes

[CL 16025902 by brooke hubert in ue5-main branch]
2021-04-15 16:32:33 -04:00
brooke hubert
8582368eed Fix an issue with deferred delete of modes not calling exit on the modes when the manager is cleaned up.
#Jira none
#preflight 6075ef066d226800019bddd3
#rb lauren.barnes semion.piskarev

[CL 16004938 by brooke hubert in ue5-main branch]
2021-04-14 10:05:27 -04:00