Commit Graph

9440 Commits

Author SHA1 Message Date
Benn Gallagher
8757cb3641 Physics interface cleanup.
* Removed deprecated or dead code paths
* Simplified build system setup for physics support
* Deprecated build system flags and unsupported macros

#jira none
#rb Chris.Caulfield, Kriss.Gossart
#preflight 62963ec0fe779f23c8ea0c5e

[CL 20450744 by Benn Gallagher in ue5-main branch]
2022-06-01 06:59:18 -04:00
mic rooney
fc120ce54f Fixing crash in AssetThumbnail.cpp due to unchecked pointer to an unloaded asset.
[REVIEW] [at]josh.andersen, [at]Aaron.eady, [at]Robert.Manuszewski

#ROBOMERGE-AUTHOR: mic.rooney
#ROBOMERGE-SOURCE: CL 20441202 via CL 20441261 via CL 20441384 via CL 20441412
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20449482 by mic rooney in ue5-main branch]
2022-06-01 04:23:35 -04:00
robert manuszewski
64f6b716fd Fixing non-unity build
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20434109 via CL 20435527 via CL 20435606
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448525 by robert manuszewski in ue5-main branch]
2022-06-01 03:47:46 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
josh adams
46a830d6b4 - Replacing many uses of LoadGlobalIniFile and LoadExternalIniFile with FCOnfigContext
#rb matt.peters
#p4v-preflight-copy 20293528
#preflight 629665d15238916c514359ad

[CL 20441581 by josh adams in ue5-main branch]
2022-05-31 16:25:06 -04:00
vincent beauchemin
b6be525b06 Revert Log to Display and keep it only to display the generate ini file location.
#rb jeanfrancois.dube
#preflight skip
#rnx

[CL 20437514 by vincent beauchemin in ue5-main branch]
2022-05-31 11:22:14 -04:00
Matt Peters
eb86c46cef Cooker PumpPollables: Add support for manually triggered pollables. Change Pollables into an indirect array, to allow the pointer be used as a handle for the manual trigger. Change pollables into a heap so we don't have to view the entire array each tick.
#rb Devin.Doucette
#rnx
#preflight 62954dcbfb0fca7e581f7872

[CL 20433687 by Matt Peters in ue5-main branch]
2022-05-30 21:44:05 -04:00
vincent beauchemin
4debb6a9a3 Simply add the name and location of generated INI files to the World Partion Convert Commandlet. Make sure the log on Display to see them in the editor when using Tool -> Convert level option
#rb patrick.enfedaque
#jira UE-107026 - Add the name and location of generated INI files to the Commandlet Output Log when GenerateINI = True
#preflight skip
#rnx

[CL 20432222 by vincent beauchemin in ue5-main branch]
2022-05-30 14:42:25 -04:00
julien stjean
7aab0a6a26 Try to generate some import options base on the mesh when importing a lod on a static mesh without import options. (This should probably be revisited at some point)
#rb Alexis.Matte
#preflight 6290def0dd2be751aedb7401

#ROBOMERGE-AUTHOR: julien.stjean
#ROBOMERGE-SOURCE: CL 20431424 via CL 20431428 via CL 20431433
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20431658 by julien stjean in ue5-main branch]
2022-05-30 12:37:28 -04:00
robert manuszewski
d278b31acb Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 62921429172dce3e61b64335

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20407208 via CL 20407223 via CL 20407350 via CL 20407425
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20408514 by robert manuszewski in ue5-main branch]
2022-05-28 11:52:55 -04:00
Ben Marsh
ab142f400f Horde: Use a parsable format for localization errors, allowing us to link files for build health issues.
#fyi leon.huang
#preflight 62912405f6625a3541a0b1ea

[CL 20400528 by Ben Marsh in ue5-main branch]
2022-05-27 18:27:52 -04:00
Matt Peters
81a3ae5b81 Cooker: Multiprocess support: Remove some deprecated code and move some out of place functions that should not be executed on CookWorker into the proper calling function that will be called on the director only.
#rb Zousar.Shaker
#rnx
#preflight 629135e11b686da53f41b463

[CL 20398652 by Matt Peters in ue5-main branch]
2022-05-27 16:48:59 -04:00
Matt Peters
8e80f6dc13 Cooker PakChunk files: Suppress the creation of empty pakchunkN.txt files for empty chunks. It causes a performance problem when the project is using high chunkid values for organization while leaving lower values unused.
#rb Justin.Marcus
#rnx
#preflight 6290f5e1b83292836e08957c

[CL 20394815 by Matt Peters in ue5-main branch]
2022-05-27 12:31:23 -04:00
Julien StJean
2eba3b5a65 Improved the performance of the TypedElementSelectionSet Selection.
From 119 Seconds to 269 ms when measuring the time redo a large marquee selection (30 384 static mesh instances).

#jira UE-148888
#preflight 627146b75e6ce673f443ccea

[CL 20393379 by Julien StJean in ue5-main branch]
2022-05-27 10:44:22 -04:00
robert millar
98c732f674 Unify PIE world leak reporting with LoadMap reporting.
#rb Robert.Manuszewski

#ROBOMERGE-AUTHOR: robert.millar
#ROBOMERGE-SOURCE: CL 20388345 via CL 20388353 via CL 20388361 via CL 20388363
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20390034 by robert millar in ue5-main branch]
2022-05-26 23:02:24 -04:00
Sebastien Lussier
08221d2534 Make sure we dirty external actors packages when performing a Precomputed Static Visibility build on an OFPA level.
#rb dominic.couture, jeanfrancois.dube
#jira none
#preflight 62903a64ec47e782d4d7fda1

[CL 20389983 by Sebastien Lussier in ue5-main branch]
2022-05-26 22:56:51 -04:00
rex hill
9db42e34bc Post merge cleanup
#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 20383901 via CL 20383995
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20385798 by rex hill in ue5-main branch]
2022-05-26 17:12:15 -04:00
rex hill
242a5e3567 Move TemplateMapInfo to a different header so UnrealEdEngine.h does not need to be included
#rb jason.stasik

#ROBOMERGE-OWNER: rex.hill
#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 20382316 via CL 20382325 via CL 20383860 via CL 20383896
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20385786 by rex hill in ue5-main branch]
2022-05-26 17:12:05 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
lauren barnes
53488dc718 Updating CrashReportClient style to only use images from certain folders, and moving developer tool style setup to individual style classes.
#jira UE-152623
#rb Josh.Adams, Patrick.Boutot, Patrick.Laflamme, Louise.Rasmussen
#preflight 628d6c5faf7a2e956b8de990

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20366551 via CL 20368551 via CL 20369147 via CL 20369164
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20370889 by lauren barnes in ue5-main branch]
2022-05-25 16:27:45 -04:00
sebastian nordgren
0f3bd5cbaf Basic shapes can now be searched for in the Add Component list.
#jira UE-153639
#preflight 628e42e082597362d1f7021a

[CL 20365067 by sebastian nordgren in ue5-main branch]
2022-05-25 11:08:30 -04:00
JeanFrancois Dube
ebb09132c3 World Partition: added getter/setter for default HLOD layer and made member public.
#rb none
#preflight 628e24ddf838ce975c7c2332
#rnx

[CL 20363079 by JeanFrancois Dube in ue5-main branch]
2022-05-25 09:01:27 -04:00
jason hoerner
11ea386451 RHI validation fix: avoid redundant RHI frame begin/end when cubemap capture occurs during UEngine::Tick, and other Tick related functions where the RHI frame will already be active. A boolean "bInsideTick" flag is passed to UReflectionCaptureComponent::UpdateReflectionCaptureContents, specifying whether the cubemap capture is happening during Tick.
The four places this applies include UEditorEngine::Tick, UGameEngine::Tick, FAdvancedPreviewScene::Tick, and FPreviewScene::UpdateCaptureContents.  The last example is called from FBlueprintEditor::Tick and FThumbnailPreviewScene::Tick.

The counter-example is "UEditorEngine::BuildReflectionCaptures", which doesn't appear to be called anywhere from a Tick related function.  It's called in startup functions, various commands, and as part of static lighting generation.  If we run into further validation errors, we could add a flag to that function to differentiate those cases.  Even though there's only one counter-example, I figured it was best to err on the side of not changing behavior of client code that may also be using the function, so by default "bInsideTick" is set to false.

#jira UE-153604
#rb mihnea.balta jason.nadro
#rnx
#preflight 628d89082f2409bc1e08a42e

[CL 20362380 by jason hoerner in ue5-main branch]
2022-05-25 07:11:28 -04:00
devin doucette
b2a07ea03e DDC: Merge from UE5/Main
#preflight 6288ff678828ea88c8af7034
#preflight 628ab5d93246d5019db76ed2
#rb none
#rnx

#ROBOMERGE-OWNER: devin.doucette
#ROBOMERGE-AUTHOR: Devin.Doucette
#ROBOMERGE-SOURCE: CL 20353148 via CL 20353832 via CL 20353839
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20355348 by devin doucette in ue5-main branch]
2022-05-24 16:40:25 -04:00
Matt Peters
c21db29e38 Cooker Stats: Fix the "Packages Cooked" stat line to use the number of packages cooked rather than the number of packages multiplied by the number of platforms.
#rb Devin.Doucette
#rnx
#preflight 628d0348c97e4beea3a51802

[CL 20350856 by Matt Peters in ue5-main branch]
2022-05-24 13:04:27 -04:00