Commit Graph

130 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
lauren barnes
5f7006fb53 Fixing EditorStyle->AppStyle merge errors
#rb trivial

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20073150 via CL 20073151
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20105751 by lauren barnes in ue5-main branch]
2022-05-09 13:31:58 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
thomas sarkanen
3f8fa9692b Converted a number of animation editor menus & toolbars to use tool menus
Also applied asset permissions to various UI sections

#rb Jurre.deBaare,Sara.Schvartzman
#preflight 6267d7dd272f4a558dbcdb6a

#ROBOMERGE-OWNER: thomas.sarkanen
#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 19918869 via CL 19921093 via CL 19923159 via CL 19923181
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19926251 by thomas sarkanen in ue5-main branch]
2022-04-26 15:03:55 -04:00
kiaran ritchie
2ac904be3d Adding compatible skeletons to Retarget Sources
#JIRA https://jira.it.epicgames.com/browse/UE-145950
#rb halfdan.ingvarsson
#preflight 6234aca13f685c2b421fcce6

[CL 19441181 by kiaran ritchie in ue5-main branch]
2022-03-18 16:55:51 -04:00
nick brett
7e1eab27e2 [UE][Feature] RBAN Better Debug Draw - 2nd attempt
- Added Debug Visualization of physics bodies and constraints for RBAN nodes in AnimBP editor
- Added checkboxes to filter debug Visualization to Phat skeleton tree
- Created a new PhysicsAssetRenderSettings class that incorporates the debug rendering and filtering settings from Phat
- Created a new PhysicsAssetRenderUtilities namespace that incorporates the debug rendering and filtering code from Phat
- Synchronize debug visualization of physics bodies and constraints between Phat and AnimBP editors

oringinaly submitted as cl-19242421 but failed on non-unity build so backed out

#rb [at]Chris.Caulfield, [at]Thomas.Sarkanen, [at]Cedric.Caillaud
#preflight 6221e57d335298c3145112d1

#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 19283727 via CL 19295417 via CL 19304854 via CL 19304870
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347122 by nick brett in ue5-main branch]
2022-03-10 21:02:14 -05:00
robb surridge
04588085d2 Fix broken links to documentation in header and source files.
#jira none
#rb trivial
#preflight 61f0445dff453b751b38959f

#ROBOMERGE-AUTHOR: robb.surridge
#ROBOMERGE-SOURCE: CL 18726086 in //UE5/Release-5.0/... via CL 18726097 via CL 18726340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18726365 by robb surridge in ue5-main branch]
2022-01-25 14:22:58 -05:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00
kiaran ritchie
4d8cfcaf85 Attempt #2 with fix to not break projects using EditorAnimUtils::RetargetAnimation()
- Replacing retarget manager with "Retarget Sources"
- Remove right-click retarget features from ABPs, anims and skeletons
- Deprecating URig asset

#rb:halfdan.ingvarsson
#JIRA:UE-137192
[FYI] benoit.gadreau
#preflight:https://horde.devtools.epicgames.com/job/61de1627f33c0754173a0887

#ROBOMERGE-AUTHOR: kiaran.ritchie
#ROBOMERGE-SOURCE: CL 18609946 in //UE5/Release-5.0/... via CL 18609978 via CL 18610008
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18610041 by kiaran ritchie in ue5-main branch]
2022-01-13 18:49:53 -05:00
kiaran ritchie
108d324377 [Backout] - CL18579636
[FYI] kiaran.ritchie
Original CL Desc
-----------------------------------------------------------------
- Replacing retarget manager with "Retarget Sources"
- Remove right-click retarget features from ABPs, anims and skeletons
- Deprecating URig asset

#rb:halfdan.ingvarsson
#JIRA:UE-137192
[FYI] benoit.gadreau
#preflight:https://horde.devtools.epicgames.com/job/61de1627f33c0754173a0887

#ROBOMERGE-AUTHOR: kiaran.ritchie
#ROBOMERGE-SOURCE: CL 18581158 in //UE5/Release-5.0/... via CL 18581164 via CL 18581169
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18581172 by kiaran ritchie in ue5-main branch]
2022-01-11 22:48:53 -05:00
kiaran ritchie
f9bd30d547 - Replacing retarget manager with "Retarget Sources"
- Remove right-click retarget features from ABPs, anims and skeletons
- Deprecating URig asset

#rb:halfdan.ingvarsson
#JIRA:UE-137192
[FYI] benoit.gadreau
#preflight:https://horde.devtools.epicgames.com/job/61de1627f33c0754173a0887

#ROBOMERGE-AUTHOR: kiaran.ritchie
#ROBOMERGE-SOURCE: CL 18579636 in //UE5/Release-5.0/... via CL 18579679 via CL 18579698
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18579719 by kiaran ritchie in ue5-main branch]
2022-01-11 20:22:40 -05:00
helge mathee
df40b0341d Skeleton Editor: Transform Widget Rework
#rb jack.cai
#jira na
#preflight https://horde.devtools.epicgames.com/job/61dd9f364533f92a4e2936fd

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18572595 in //UE5/Release-5.0/... via CL 18572598
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18572615 by helge mathee in ue5-release-engine-test branch]
2022-01-11 10:59:10 -05:00
jurre debaare
b44cf9aa74 Applying Blend Profiles with spaces in name to Blend Settings in AnimBPs does not work
#jira UE-133376
#fix ensure that users cannot generate blend profile names with invalid characters (as it is used to generate a UObject with)
#misc Added OnVerifyTextChanged to STextEntryPopup which routes it to its inner SEditableTextBox
#rb Thomas.Sarkanen
#preflight 61dd6ef73c7555edfdac7606

#ROBOMERGE-AUTHOR: jurre.debaare
#ROBOMERGE-SOURCE: CL 18571295 in //UE5/Release-5.0/... via CL 18571307
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18571332 by jurre debaare in ue5-release-engine-test branch]
2022-01-11 09:22:39 -05:00
thomas sarkanen
7ab82ca4c8 Fix crash deleting a skeleton
Hardened code that could potentially reference a deleted USkeleton

#rb Jurre.deBaare
#preflight 61d6d9b85d522c9b40987917

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18530619 via CL 18530626 via CL 18530631 via CL 18530826 via CL 18530846
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18530857 by thomas sarkanen in ue5-release-engine-test branch]
2022-01-06 09:36:26 -05:00
jose villarroel
262e9e63d3 Added virtual bone support to blend profiles
#jira none
[at]Louise.Rasmussen, [at]Thomas.Sarkanen
[FYI] Ray.Arnett, Aaron.Cox
#preflight 61b1084a5c61dba07bfe212c

#ROBOMERGE-AUTHOR: jose.villarroel
#ROBOMERGE-SOURCE: CL 18421025 in //UE5/Release-5.0/... via CL 18422624
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18422907 by jose villarroel in ue5-release-engine-test branch]
2021-12-09 14:52:34 -05:00
lucas dower
973c952b25 Fixed virtual bone skeleton tree item not selecting when a virtual bone is selected in the viewport.
Fixed font not found warning spam when a virtual bone skeleton tree item is selected.
Fixed virtual bone name not showing when selected in viewport.
Cleaned up parity of bone names text shadows

#rb Thomas.Sarkanen
#preflight 61b1fff9c674eb9fc9ce0c04

#ROBOMERGE-AUTHOR: lucas.dower
#ROBOMERGE-SOURCE: CL 18418203 in //UE5/Release-5.0/... via CL 18418204
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18418208 by lucas dower in ue5-release-engine-test branch]
2021-12-09 08:34:00 -05:00
helge mathee
c1eff17803 SAdvancedTransformWidget: Add helper functions for numeric value getters / setters
#rb na
#jira UE-134546
#preflight https://horde.devtools.epicgames.com/job/61a8e85fca183f8de48d2fe3

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18353001 in //UE5/Release-5.0/... via CL 18353040
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18353051 by helge mathee in ue5-release-engine-test branch]
2021-12-02 11:41:41 -05:00
helge mathee
7544779d47 SkeletonEditor: Use new SAdvancedTransformInputBox
#rb thomas.sarkanen
#jira UE-134546
#preflight https://horde.devtools.epicgames.com/job/61a8bab1ca183f8de48aaf15

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18351461 in //UE5/Release-5.0/... via CL 18351477
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18351480 by helge mathee in ue5-release-engine-test branch]
2021-12-02 08:38:55 -05:00
lucas dower
e30f90e20b Coalition skeleton tree item sorting
#jira UE-114248
#preflight 61a5f55fae3418c7dfcb074b
#rb Thomas.Sarkanen

#ROBOMERGE-AUTHOR: lucas.dower
#ROBOMERGE-SOURCE: CL 18322859 in //UE5/Release-5.0/... via CL 18322865
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18322867 by lucas dower in ue5-release-engine-test branch]
2021-11-30 05:22:19 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
helge mathee
dea1b6a460 Animation Tree UI: Introduce option to expand tree based on selection
#rb thomas.sarkanen
#jira UE-134209
#preflight https://horde.devtools.epicgames.com/job/618b9b7f8a559270a162e225

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18128607 in //UE5/Release-5.0/... via CL 18132226
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v889-18060218)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18133245 by helge mathee in ue5-release-engine-test branch]
2021-11-10 13:02:04 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00