Commit Graph

89 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
kriss gossart
36def7e3fe Fix missing cloth menu in skeletal mesh editor
Also fix static analysis warning

[Edigrate CL19942315]

#rb trivial
#preflight

#ROBOMERGE-AUTHOR: kriss.gossart
#ROBOMERGE-SOURCE: CL 19943181 via CL 19943191 via CL 19943199
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19945864 by kriss gossart in ue5-main branch]
2022-04-27 16:12:45 -04:00
thomas sarkanen
3f8fa9692b Converted a number of animation editor menus & toolbars to use tool menus
Also applied asset permissions to various UI sections

#rb Jurre.deBaare,Sara.Schvartzman
#preflight 6267d7dd272f4a558dbcdb6a

#ROBOMERGE-OWNER: thomas.sarkanen
#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 19918869 via CL 19921093 via CL 19923159 via CL 19923181
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19926251 by thomas sarkanen in ue5-main branch]
2022-04-26 15:03:55 -04:00
Alexis Matte
9775bb4fbd Add Interchange support for Import geo/skinning only workflow
#UETOOL-4729
#rb richard.talbotwatkin
#rnx
#preflight 62178d841a114ad504392e3f

[CL 19112941 by Alexis Matte in ue5-main branch]
2022-02-24 09:10:50 -05:00
Alexis Matte
e9e162a4fc Make sure old imported skeletalmesh (pre 4.24) have a "Regenerate" button verify the ddc key against the current state. This will ensure user apply there changes before quiting the persona editor.
#jira none
#rb rob.krajcarski
#rnx
#preflight 621688c537178b0175b49685
#preflight 62168e14c152c67496eb3efe

[CL 19098283 by Alexis Matte in ue5-main branch]
2022-02-23 14:46:38 -05:00
robb surridge
04588085d2 Fix broken links to documentation in header and source files.
#jira none
#rb trivial
#preflight 61f0445dff453b751b38959f

#ROBOMERGE-AUTHOR: robb.surridge
#ROBOMERGE-SOURCE: CL 18726086 in //UE5/Release-5.0/... via CL 18726097 via CL 18726340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18726365 by robb surridge in ue5-main branch]
2022-01-25 14:22:58 -05:00
Marc Audy
c43360f47c Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#[fyi] Aurel.Cordonnier

#ushell-cherrypick of 18448630 by Marc.Audy
#preflight none

[CL 18483677 by Marc Audy in ue5-main branch]
2021-12-17 03:41:59 -05:00
alexis matte
e4bdcc85d5 Fix crash when closing the persona editor and the cloth paint mode is active
#jira UE-136280
#rb brooke.hubert
#rnx

#ROBOMERGE-AUTHOR: alexis.matte
#ROBOMERGE-SOURCE: CL 18394298 in //UE5/Release-5.0/... via CL 18394302
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18394305 by alexis matte in ue5-release-engine-test branch]
2021-12-07 08:46:03 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
matt kuhlenschmidt
4b7cb96fe1 minor skeletal mesh editor cleanup
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 17570825 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v871-17566257)

[CL 17570834 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-09-20 10:53:03 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
lauren barnes
5bd8c74d4e FAssetEditorModeUILayer now serves as a layer between a given asset editor and the mode toolkits, so that the mode toolkits can request UI panels and the asset editor determines where they are located in the asset editor layout. The first implementation is in the level editor, and all default mode UI has been moved to FModeToolkit.
#jira UETOOL-3555
#preflight 61143dbf9c7bb10001f080b3
#rb Matt.Kuhlenschmidt

#ROBOMERGE-SOURCE: CL 17152278 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17152291 by lauren barnes in ue5-release-engine-test branch]
2021-08-12 10:54:54 -04:00
halfdan ingvarsson
67cfd7bfb6 Skelmesh Editor: Fix a crash when exiting the skelmesh editor but the persona scene ticks, and subsequently request capsule updates, before we remove the selection component.
#jira none
#rb helge.mathee
#rnx

#ROBOMERGE-SOURCE: CL 16834967 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16834970 by halfdan ingvarsson in ue5-release-engine-test branch]
2021-07-13 03:12:44 -04:00
lauren barnes
d27295ae12 Adding Bake Out Materials back to the Skeletal Mesh Editor (on the Asset Menu instead of the toolbar)
#jira none
#rb Helge.Mathee
#preflight 60ec51c1ef22fa00014ce1a3

#ROBOMERGE-SOURCE: CL 16826271 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16826291 by lauren barnes in ue5-release-engine-test branch]
2021-07-12 11:55:30 -04:00
helge mathee
a23ec5440e SkeletalMeshEditor: Clear dependency on selection actor
#jira UE-118607
#rb na

#ROBOMERGE-SOURCE: CL 16822859 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16822878 by helge mathee in ue5-release-engine-test branch]
2021-07-12 06:09:39 -04:00
helge mathee
c9f0e48737 SkeletalMeshEditor: Guard against invalid indices
[FYI] Josie.Yang, Peter.Knepley

#ROBOMERGE-SOURCE: CL 16619621 via CL 16619622
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16619624 by helge mathee in ue5-release-engine-test branch]
2021-06-10 03:15:04 -04:00
helge mathee
11ef52689b Back out of Back out CL16586449 that was integrated over from //UE5/Main that's causing opening any skeletal mesh in editor crashes
[FYI] Josie.Yang, Peter.Knepley

#ROBOMERGE-SOURCE: CL 16619605 via CL 16619608
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16619613 by helge mathee in ue5-release-engine-test branch]
2021-06-10 03:12:48 -04:00
josie yang
a3d0e6da38 Back out CL16586449 that was integrated over from //UE5/Main that's causing opening any skeletal mesh in editor crashes
[FYI] Helge.Mathee, Peter.Knepley

#ROBOMERGE-SOURCE: CL 16606425 via CL 16606447
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16606465 by josie yang in ue5-release-engine-test branch]
2021-06-09 11:53:18 -04:00
Helge Mathee
7c48a615f8 Persona: Adapt skeletalmesh editor to capsule based selection
#rb jurre.debaare
#jira UE-101243

[CL 16586449 by Helge Mathee in ue5-main branch]
2021-06-08 09:42:36 -04:00
halfdan ingvarsson
6f64873888 Add opt-in support for {Add,Remove}ViewportOverlayWidget to FAssetEditorToolkit derived editors.
Add implementation for it in the skeletal mesh editor.

#jira none
#rb brooke.hubert, louise.rasmussen
#preflight 609ae9244cb9400001cbe879

[CL 16305022 by halfdan ingvarsson in ue5-main branch]
2021-05-12 16:02:22 -04:00
Lauren Barnes
39f1923ed0 Deprecating .Icon() as a slate attribute on SDockTab. By default, tab icons fall back to using the one for the tab spawner's menu item. SetTabIcon can be used in the edge cases where an icon needs to be set that doesn't match the default. Updating all found cases of .Icon() usage on SDockTab.
#jira UETOOL-3429
#preflight 60996a2bdd2e00000126ff25
#rb Matt.Kuhlenschmidt

[CL 16251489 by Lauren Barnes in ue5-main branch]
2021-05-10 14:19:15 -04:00