Commit Graph

72 Commits

Author SHA1 Message Date
Matt Kuhlenschmidt
d47c5bd6dc Ensure uobjects added through external object customizations are not considered top level objects in a multi-top-level object details panel
#preflight none

[CL 19555660 by Matt Kuhlenschmidt in ue5-main branch]
2022-03-30 08:42:24 -04:00
vlad golovan
485406734e Engine change to allow only building the property nodes that user is going to see.
When property view widgets get reused, we are running (generate nodes) repeatedly while scrolling. Through some trial and error, I've identified that since I am only showing a fraction of the nodes I don't need to have all the nodes built; I can get away with generating the ones I will see, which improves performance from around 130 ms to 10-20ms per widget. I am adding a way to specify the properties you want to build and ignore the rest, which ultimately dramatically speeds up the PropertyView widget for the case where you are only showing a few properties from the object.


[REVIEW] [at]jay.Nakai, [at]sebastian.nordgren, [at]david.hamm

#rb sebastian.nordgren


#ROBOMERGE-OWNER: vlad.golovan
#ROBOMERGE-AUTHOR: vlad.golovan
#ROBOMERGE-SOURCE: CL 19036849 via CL 19036854 via CL 19038143 via CL 19038155 via CL 19039279
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19039995 by vlad golovan in ue5-main branch]
2022-02-17 14:54:44 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
denys dubinin
2acfc93f9b Fix return IPropertyHandle in IDetailLayoutBuilder::AddCustomRowToCategory
#rb Matt.Kuhlenschmidt

#ROBOMERGE-AUTHOR: denys.dubinin
#ROBOMERGE-SOURCE: CL 17705280 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v878-17703426)

[CL 17705296 by denys dubinin in ue5-release-engine-test branch]
2021-10-04 05:12:26 -04:00
sebastian nordgren
b35fb7c36d Subcategory nodes are no longer always visible in editor utility widgets with categories filtered out.
#rb paul.chipchase

#ROBOMERGE-SOURCE: CL 16275950 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v799-16237190)

[CL 16275968 by sebastian nordgren in ue5-release-engine-test branch]
2021-05-11 13:53:51 -04:00
sebastian nordgren
1324d9dd3d Subcategory nodes are no longer always visible in editor utility widgets with categories filtered out.
#rb paul.chipchase

[CL 16275950 by sebastian nordgren in ue5-main branch]
2021-05-11 13:53:32 -04:00
Marc Audy
f02d489290 Update Release-Engine-Test from Release-Engine-Staging @ 16264272
[CL 16264458 by Marc Audy in ue5-release-engine-test branch]
2021-05-11 01:10:20 -04:00
sebastian nordgren
97e8b5bf25 FDetailLayoutBuidlerImpl::IsPropertyVisible had the wrong default, which was causing properties in subcategories to be hidden under all circumstances.
#jira UE-114840
#rb paul.chipchase

[CL 16191712 by sebastian nordgren in ue5-main branch]
2021-05-04 05:52:32 -04:00
sebastian nordgren
d315282ff8 Resubmitting IsPropertyVisible and IsCustomRowVisible (originally submitted in 16122954) with additional changes to ensure FPropertyAndParent cannot contain a null pointer inside an FProperty&.
#rb paul.chipchase
#jira UE-96790

[CL 16183986 by sebastian nordgren in ue5-main branch]
2021-05-03 10:38:37 -04:00
sebastian nordgren
6d625d8bcb Added code for favoriting custom builders.
Also added code for favoriting groups, but this currently isn't enabled work since header widgets suffer from the same problem as custom widget rows do - their SWidget is created in place rather than through a function call, so thus cannot be duplicated. This needs some more thought, but the code for storing them is the same either way.

#jira UE-109586
#rb lauren.barnes

[CL 15802120 by sebastian nordgren in ue5-main branch]
2021-03-24 12:54:49 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
sebastian nordgren
5050b88330 Details view reskin phase 1.
The details view now displays gridlines between rows, and now has 4 columns - edit condition, name, value, and reset/extensions.

Edit condition widgets are now created in SDetailSingleItemRow and are placed in their own fixed column on the left of the details view. FEditConditionParser is now in FPropertyNode rather FPropertyEditor, which allows access to it more broadly - notably in SDetailSingleItemRow.

The Reset to Default SWidget can no longer be replaced - the logic for it being visible and a handler for when it is pressed is still customizable. SPropertyEditorAsset no longer has a special slot for the reset to default widget.

All extension widgets are now placed in a resizable column on the right of the panel, including the Keyframe button.

FDetailColumnSizeData is now publicly exposed by IDetailsView, and is no longer passed around as much.

#rb matt.kuhlenschmidt

[CL 14375859 by sebastian nordgren in ue5-main branch]
2020-09-23 08:16:20 -04:00
Marc Audy
a7c9001a94 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14075166
#rb
#rnx

[CL 14075271 by Marc Audy in ue5-main branch]
2020-08-11 01:36:57 -04:00
matt kuhlenschmidt
3fa44160fd Improved the details panel root object customization API to support multiple objects in the "root object set". Deprecated old functionality and removed pass through customizations that are no longer needed
#rb none

#ROBOMERGE-OWNER: matt.kuhlenschmidt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 11382968 via CL 11382988 via CL 11382990
#ROBOMERGE-BOT: (v654-11333218)

[CL 11383722 by matt kuhlenschmidt in Main branch]
2020-02-12 09:41:11 -05:00
matt kuhlenschmidt
e001ecc6a3 Fixed material editor crash when viewing the parameters overview
#ROBOMERGE-SOURCE: CL 11311520 via CL 11311540 via CL 11311544
#ROBOMERGE-BOT: (v653-11302973)

[CL 11311548 by matt kuhlenschmidt in Main branch]
2020-02-10 16:14:25 -05:00
matt kuhlenschmidt
2466840461 Added filtering to details panels to filter the set of incoming objects passed to a details panel
Changed the way details panels handle multiple root objects.  The filter can now specify this without setting a specific flag on a details panel at creation time.

[CODEREVIEW] chris.gagnon


#ROBOMERGE-OWNER: matt.kuhlenschmidt
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 11308033 via CL 11308037 via CL 11308040
#ROBOMERGE-BOT: (v653-11302973)
#rb none

[CL 11310703 by matt kuhlenschmidt in Main branch]
2020-02-10 15:43:53 -05:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
jamie dale
7d15247b60 Fixed categories in the details panel being unlocalized
#jira UELOC-2406
#rb Matt.Kuhlenschmidt

#ROBOMERGE-SOURCE: CL 9748824 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v543-9746878)

[CL 9748836 by jamie dale in Main branch]
2019-10-22 14:37:29 -04:00
Lina Halper
3fd7f76532 Copying //UE4/Dev-Anim to Dev-Main (//UE4/Dev-Main)
#fyi: Laurent.Delayn, Marc.Audy
#rb: none

[CL 9321182 by Lina Halper in Main branch]
2019-10-01 16:59:31 -04:00
Marc Audy
8df336162c Copying //UE4/Dev-Anim to Dev-Main (//UE4/Dev-Main) @ 8782600
#rb
#rnx

[CL 8783278 by Marc Audy in Main branch]
2019-09-17 19:12:19 -04:00
Chris Gagnon
2e87118a18 Copying //UE4/Dev-Editor to Dev-Main (//UE4/Dev-Main) Interim 4.24.
#rb none

[CL 8614014 by Chris Gagnon in Main branch]
2019-09-10 11:35:20 -04:00
patrick boutot
41b220f3ce Fix crash when a Property doesn't have a child node at the requested index. It would return no property so that the user knows that the path was wrong. Tested with A[Index] and A.B[Index].C
#rb sebastian.nordgren
#jira UE-79529
#lockdown cristina.riveron

#ROBOMERGE-SOURCE: CL 8572562 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v407-8568993)

[CL 8572563 by patrick boutot in Main branch]
2019-09-09 11:13:20 -04:00
Lina Halper
888010b766 Copying //UE4/Dev-Enterprise [at] cl 6890376 to Dev-Main (//UE4/Dev-Main)
#lockdown nick.penwarden
#rb none

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jeanmichel.dignard
#ROBOMERGE-SOURCE: CL 6890764 in //UE4/Main/...
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim) (v366-6836689)

[CL 6942267 by Lina Halper in Dev-Anim branch]
2019-06-11 16:56:39 -04:00
JeanMichel Dignard
0f9ad96858 Copying //UE4/Dev-Enterprise @ cl 6890376 to Dev-Main (//UE4/Dev-Main)
#lockdown nick.penwarden
#rb none

[CL 6890764 by JeanMichel Dignard in Main branch]
2019-06-07 11:22:52 -04:00