Commit Graph

121 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00
aditya ravichandran
d7a6de08dd Place Actors Panel: Fix checkbox styling
#rb Lauren.Barnes
#jira UE-138922
#preflight 62213592bf662715a8cdfa7c

[CL 19254055 by aditya ravichandran in ue5-main branch]
2022-03-03 16:53:20 -05:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
aditya ravichandran
9c09a76984 Reskin the Level Editor Main Toolbar,
Move Editor Modes to a Combo Button,
Combine Content and Create into one dropdown,
Reorder items in the Content Browser add and context menu to be more meaningful
#jira UETOOL-3814
#preflight 61434322599fd8000190b8bf
#rb Louise.Rasmussen, brooke.hubert

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 17538574 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17538604 by aditya ravichandran in ue5-release-engine-test branch]
2021-09-16 10:15:01 -04:00
matt kuhlenschmidt
e3daec26fc Sort "All Actors" in create menu alphabetically
#ROBOMERGE-SOURCE: CL 17101213 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v853-17066230)

[CL 17101294 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-08-09 09:29:55 -04:00
lauren barnes
0b7ecd97c1 The Create menu entry should pull its name from the asset vs. the factory in most cases
#jira none
#rb Brooke.Hubert

#ROBOMERGE-SOURCE: CL 16606590 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v828-16531559)

[CL 16606596 by lauren barnes in ue5-release-engine-test branch]
2021-06-09 11:59:28 -04:00
julien stjean
cc5d08a65b Fixed a crash when creating an actor while there is no viewport open in the level editor.
#jira UE-117383
#rb Lauren.Barnes
#preflight 60bfb58a9e139d0001a2ddca
#lockdown simon.tourangeau

#ROBOMERGE-SOURCE: CL 16590687 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v828-16531559)

[CL 16590688 by julien stjean in ue5-main branch]
2021-06-08 15:05:25 -04:00
lauren barnes
550deb637e Fixes for create menu - handling of missing factories fixed to prevent crashes, items checked for if they are placeable
#jira UE-117401
#rb Brooke.Hubert
#preflight 60bf3518545fbc0001c5de5b
#lockdown Simon.Tourangeau

#ROBOMERGE-SOURCE: CL 16586564 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v828-16531559)

[CL 16586585 by lauren barnes in ue5-main branch]
2021-06-08 09:59:23 -04:00
Sebastien Hillaire
baed13200f AtmosphericFog component removal from UE5.
Clean up atmospheric fog and have it instaciate a sky atmosphere by default instead
AtmosphericFog now inherits from SkyAtmosphere and looks vaguely similar. Serialisation is handled with a serialisation enum + ue5 version.
"ClassRedirects" could not be used because parameters are not compatible and also due to different serialisation on both component.

So instead Skyamtosphere now has a bool bIsAtmosphericFog (false by default).
AtmosphericFog component now inheriting from Skyatmosphere is setting that to true so that serialisation can be properly handled for both cases : pure Skyatmosphere or SkyAtmosphere replacing a AtmosphericFog with loading/saving. This also supports StaticLightingGUID once converted, see USkyAtmosphereComponent::Serialize.

SkyAtmosphere aerial perspective is now properly gated behind the base pass vertex shader designed for that using BASEPASS_SKYATMOSPHERE_AERIALPERSPECTIVE.

Removed all AtmosphericFog related render code.
Renamed a bunch of shader permutation.

UActorFactoryAtmosphericFog is removed so that the actor is no longer visible and instanciable from menu (existing actors in levels are still created correctly)
UAtmosphericFogComponent is made notplaceable.

ShooterGame compiled and ran succesfuly.
Colton Daniels (QA) will upate reference screneshot in a later CL.

#rb Charles.derousiers, Marc.Audy, Kevin.Ortegren

[CL 16455741 by Sebastien Hillaire in ue5-main branch]
2021-05-25 16:33:27 -04:00
Marc Audy
8f73cd7fa9 Merge UE5/Release-Engine-Staging @ 15630841 to UE5/Main
This represents UE4/Main @ 15601601

[CL 15631170 by Marc Audy in ue5-main branch]
2021-03-05 19:27:14 -04:00
louise rasmussen
bed322fb0e Fixed Assert after clicking Create>Cinematics or Create>Testing
#JIRA UE109854
#rb Lauren.Barnes

#ROBOMERGE-SOURCE: CL 15608635 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v777-15581079)

[CL 15608656 by louise rasmussen in ue5-main branch]
2021-03-04 12:53:26 -04:00
dave belanger
d7c401a67c Fix PlacementModeModule event declaration
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 15586483 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v777-15581079)

[CL 15586551 by dave belanger in ue5-main branch]
2021-03-03 15:42:02 -04:00
dave belanger
763e3d01c0 Manual merge from UE4
Placement tool item predicates
#rb Rex.Hill

#ROBOMERGE-SOURCE: CL 15586288 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v777-15581079)

[CL 15586411 by dave belanger in ue5-main branch]
2021-03-03 15:31:08 -04:00
dave belanger
a0918d345f Manual merge from UE4
Placement Tool:
- Add category blacklist
- Don't trigger OnAllPlaceableAssetsChanged event during initial loading of assets
#rb Rex.Hill

#ROBOMERGE-SOURCE: CL 15585527 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v777-15581079)

[CL 15585530 by dave belanger in ue5-main branch]
2021-03-03 14:33:59 -04:00
dave belanger
80a64983b4 Remove obsoiete code from placement tool
#rb trivial
#jira none

#ROBOMERGE-SOURCE: CL 15584943 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v777-15581079)

[CL 15584952 by dave belanger in ue5-main branch]
2021-03-03 13:54:11 -04:00
louise rasmussen
a21c23470c Create Menu Add Search for top Level Window, + misc cleanup of redundant menu rows.
#rb trivial

#ROBOMERGE-SOURCE: CL 15464750 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15466474 by louise rasmussen in ue5-main branch]
2021-02-18 20:47:30 -04:00
louise rasmussen
a78f62c1d6 Create Menu Cleanup - Place actor in front of camera on click
UETOOL-3054

#ROBOMERGE-SOURCE: CL 15463367 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15466451 by louise rasmussen in ue5-main branch]
2021-02-18 20:46:33 -04:00
louise rasmussen
0fab8e2ddd Create Menu / Place Actors Menu fixes
#JIRA UETOOL-3032

#ROBOMERGE-SOURCE: CL 15412977 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15412980 by louise rasmussen in ue5-main branch]
2021-02-15 20:22:50 -04:00
Louise Rasmussen
c1b37680e7 Fixes dragable AssetCard from Quick Place Actors Menu
#rb trivial

[CL 15226212 by Louise Rasmussen in ue5-main branch]
2021-01-27 18:31:11 -04:00
Louise Rasmussen
d52549d8d7 Placement Mode: shape category special icon handling and updates to plugins using FPlaceableItem
#rb lauren.barnes
#JIRA UETOOL-2864

[CL 15212946 by Louise Rasmussen in ue5-main branch]
2021-01-26 19:20:39 -04:00
Matt Kuhlenschmidt
24fd139385 Fixed up locations making one off thumbnail pools and converted them to use the shared thumbnail pool.
[CL 15211295 by Matt Kuhlenschmidt in ue5-main branch]
2021-01-26 17:21:08 -04:00
Louise Rasmussen
d47ed23a3d Quick Place Actors Menu creates an actor at the origin when the menu item is clicked. Holding CTRL leaves the menu open.
#rb Lauren.Barnes

[CL 15179670 by Louise Rasmussen in ue5-main branch]
2021-01-25 13:27:00 -04:00