Commit Graph

67 Commits

Author SHA1 Message Date
Benn Gallagher
8757cb3641 Physics interface cleanup.
* Removed deprecated or dead code paths
* Simplified build system setup for physics support
* Deprecated build system flags and unsupported macros

#jira none
#rb Chris.Caulfield, Kriss.Gossart
#preflight 62963ec0fe779f23c8ea0c5e

[CL 20450744 by Benn Gallagher in ue5-main branch]
2022-06-01 06:59:18 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
steven barnett
ebead19673 Shape selection in PHAT - selecting shapes in viewport selects them also in skeleton tree.
This appears to have already been implemented, but had 2 bugs.

PhysicsAssetEditor::FShapeData needs all data to represent a unique shape, but did not include primitive type. Primitive index is the index into the list of primitives of a type, not into the full list of primitives, so primitive type needed to be added to this struct.

FPhysicsAssetEditor::HandleViewportSelectionChanged was looking for shapes within the list of selected constraints rather than the list of selected bodies. This change adds code to check the body selection for shapes _as well as_ the constraint selection. I left the constraint selection bit in there in case we want selecting a constraint to select the shapes it's attached to.

[FYI] benn.gallagher, chris.caulfield, gates.aldridge, satchit.subramanian

#ROBOMERGE-AUTHOR: steven.barnett
#ROBOMERGE-SOURCE: CL 20341171 via CL 20341211 via CL 20341235
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20341859 by steven barnett in ue5-main branch]
2022-05-23 19:58:38 -04:00
cedric caillaud
273549a5b3 Phat : fix invalid reported number of bodies and ocnstraints when pasting from nothing, also fixed typo
#rb trivial
#jira none
#preflight 62841fa14c6f62e119883f71

[CL 20253620 by cedric caillaud in ue5-main branch]
2022-05-17 19:35:07 -04:00
nick brett
78a3520cbc [UE][FEATURE] PhAT - Move Simulation Floor Collisions option to Editor Options so that it persists across editor instances.
#rb Thomas.Sarkanen
#preflight 627cce5480307e522bc78107

#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 20162683 via CL 20162686 via CL 20162689
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20163248 by nick brett in ue5-main branch]
2022-05-12 08:09:12 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
nick brett
4438285ef9 [UE][FEATURE] Allow floor collisions to be disabled during simulation in PhAT
- Added a Floor Collision Enabled Checkbox to the 3-dots options menu attached to
the Simulate Tool bar button in PhAT.

#rb [at]Cedric.Caillaud
#preflight 626bdfcf7272eba608628667

#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 20022773 via CL 20022869 via CL 20022876
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20023223 by nick brett in ue5-main branch]
2022-05-03 06:39:43 -04:00
nick brett
7e1eab27e2 [UE][Feature] RBAN Better Debug Draw - 2nd attempt
- Added Debug Visualization of physics bodies and constraints for RBAN nodes in AnimBP editor
- Added checkboxes to filter debug Visualization to Phat skeleton tree
- Created a new PhysicsAssetRenderSettings class that incorporates the debug rendering and filtering settings from Phat
- Created a new PhysicsAssetRenderUtilities namespace that incorporates the debug rendering and filtering code from Phat
- Synchronize debug visualization of physics bodies and constraints between Phat and AnimBP editors

oringinaly submitted as cl-19242421 but failed on non-unity build so backed out

#rb [at]Chris.Caulfield, [at]Thomas.Sarkanen, [at]Cedric.Caillaud
#preflight 6221e57d335298c3145112d1

#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 19283727 via CL 19295417 via CL 19304854 via CL 19304870
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19347122 by nick brett in ue5-main branch]
2022-03-10 21:02:14 -05:00
cedric caillaud
d4defade73 Physics Asset editor fixes
- Refresh physics asset editor hierachy when pasting bodies from clipboard
- Copy of only constraints now works
- Change wording of the copy a/ paste commands to reflect teh body constraint dulaity
- Fix duplicate menu entry for constraint context menu

#rb none
#jira UE-126847, FORT-425181, FORT-425179, FORT-425180
#preflight 61f0cfb0e12e3fcf9b077ba8

#ROBOMERGE-AUTHOR: cedric.caillaud
#ROBOMERGE-SOURCE: CL 18732730 in //UE5/Release-5.0/... via CL 18732731 via CL 18732779
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18732783 by cedric caillaud in ue5-main branch]
2022-01-26 00:50:12 -05:00
Marc Audy
c43360f47c Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#[fyi] Aurel.Cordonnier

#ushell-cherrypick of 18448630 by Marc.Audy
#preflight none

[CL 18483677 by Marc Audy in ue5-main branch]
2021-12-17 03:41:59 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
danny chapman
2a43406efe Fix/improve transparency sorting and shading in editor when opacity is 1
Option for the grab/poke raycast distance

#jira UE-129539
#jira UE-130564

#rb cedric.caillaud
#preflight 615c2e46f556160001b5d5d5

#ROBOMERGE-AUTHOR: danny.chapman
#ROBOMERGE-SOURCE: CL 17719687 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v879-17706426)

[CL 17719705 by danny chapman in ue5-release-engine-test branch]
2021-10-05 07:48:54 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
julien lheureux
9389dda750 Improved copy/paste properties behavior in the physics asset editor to allow for cross-asset copy/paste.
Fixed issue where the rotation would be copied as well when it shouldn't be.

#rb cedric.caillaud
#preflight 6100824291123700017e94cf

#ROBOMERGE-SOURCE: CL 16981495 via CL 16981508
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16981510 by julien lheureux in ue5-release-engine-test branch]
2021-07-28 09:03:43 -04:00
alexis matte
888f708d3b Allow Physics asset to be a developper module with no dependencecies on any editor module.
#jira UETOOL-3603
#rb richard.talbotwatkin
#preflight 60d1e95f78c3b000010f6005

#ROBOMERGE-SOURCE: CL 16743468 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16743480 by alexis matte in ue5-release-engine-test branch]
2021-06-22 11:13:19 -04:00
aurel cordonnier
02c0f425e8 Copy up from Release-Engine-Staging @ 16738359
This represents UE4/Main @ 16738161 and Dev-PerfTest @ 16737719

[CL 16738582 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-22 00:27:54 -04:00
aurel cordonnier
25a11deeac Merge from Release-Engine-Staging @ 16579919
This represents UE4/Main @ 16579691 and Dev-PerfTest @ 16579576

[CL 16581170 by aurel cordonnier in ue5-release-engine-test branch]
2021-06-07 20:09:45 -04:00
cedric caillaud
1b74a65a0e Physics Asset Editor - Fix selection synchronization when changing filters
[CL 16176739 by cedric caillaud in ue5-main branch]
2021-05-01 01:01:07 -04:00
cedric caillaud
99765917bd Physics asset editor : improvement and bug fixes
- add isolate mode for showing colliding rigid bodies ( hotkey : C )
- fix right click menu clearing multi-selection

[CL 16176624 by cedric caillaud in ue5-main branch]
2021-05-01 00:26:30 -04:00
cedric caillaud
74bf605ddc Physics Asset editor - fix simulation stopping when clicking in the 3D viewport after editing atext field and starting the simulation
Issue was caused by the user focus been kept by the detail window and when clicking in the 3D viewport , textfield would get a lost focus eventand trigger OnFinishedChangingProperties

#jira UE-106308
#fyi benn.gallagher

[CL 15926953 by cedric caillaud in ue5-main branch]
2021-04-05 23:24:09 -04:00
Marc Audy
0cbbc781ca Merge UE5/Release-Engine-Staging @ 15740152 to UE5/Main
This represents UE4/Main @ 15709114

[CL 15740605 by Marc Audy in ue5-main branch]
2021-03-18 15:20:03 -04:00
cedric caillaud
08bdf4670f Physics Asset Editor - Allow bone selection to show the "Copy Collision From StaticMesh" contextual menu
Also add solid debug draw in preview for convex volumes

#rb none
#jira UE-108873

[CL 15510731 by cedric caillaud in ue5-main branch]
2021-02-23 22:25:50 -04:00
cedric caillaud
e2cfe4bebd Build fix : tentative fix for build break
#jira UE-107832
#rb trivial

[CL 15321559 by cedric caillaud in ue5-main branch]
2021-02-04 15:34:42 -04:00
cedric caillaud
6a86899740 Physics Asset Editor - Fix selection synchronization (select all does not select multiple primitive bodies )
- Simplify and fix the way skeleton tree is synchronized with selection ( also made it faster for large number of bones/bodies )

#jira UE-106927
#rb chris.caulfield zhenglin.geng brett.miller
#fyi benn.gallagher

[CL 15303162 by cedric caillaud in ue5-main branch]
2021-02-03 17:53:48 -04:00