#rnx
#rb none
#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870586 by ryan durand in Main branch]
#lockdown Nick.Penwarden
#rb none
#rnx
============================
MAJOR FEATURES & CHANGES
============================
Change 3722141 by Aaron.McLeran
#jira UE-51670 Added ability to split multi-channel mic input into separate USoundWave assets in recording manager.
- Will allow for sequencer recorder to record multiple audio streams, one for each actor
Change 3726096 by Ori.Cohen
Fixed welded bodies with negative scale not using the mirrored convex hull
#jira UE-51647
Change 3726233 by Ori.Cohen
Make sure RT doesn't try to create a physics mesh when debug drawing
#jira UE-51721
Change 3726254 by Aaron.McLeran
Fixing typo in GetCustomSpatializationSettingsClass interface
Change 3728295 by Ori.Cohen
Fix incorrect lock upgrading
Change 3728516 by Benn.Gallagher
Fix for crash loading reparented animation blueprints that do not have an animgraph but are no longer child blueprints.
#jira UE-51414
Change 3728522 by Benn.Gallagher
Added mesh paint settings to per-user settings and added preview vertex size so it's configurable by the user for use on differently sized meshes.
#jira UE-50087
Change 3728853 by Benn.Gallagher
[NvCloth] Fix sphere collision detection issue when clothing bounds are (almost) flat.
Change 3729031 by Ethan.Geller
#jira UEAP-316: Improvements to the audio side for our Opus VOIP implementation.
Change 3729910 by Benn.Gallagher
Fix for crashes editing destructible meshes caused by stale render data
Change 3729921 by James.Golding
- Remove 'bDisabled' flag from SkeletalMesh render data sections, use per-component ShowMaterialSection to hide sections instead
- Renamed flag on source data (FSkelMeshSection) to bLegacyClothingSection_DEPRECATED, to fix up old clothing assets
- Expose ShowMaterialSection to BP, added ShowAllMaterialSections and IsMaterialSectionShown as well
- Move SelectedEditorSection and SelectedEditorMaterial from USkeletalMesh to USkinnedMeshComponent, made private, added accessors
- Made SectionIndexPreview and MaterialIndexPreview in SkinnedMeshComponent private, added accessors
- Remove unused ChunkIndexPreview from USkinnedMeshComponent and SelectedClothingSection from USkeletalMesh
- Move SectionsDisplayMode from UDebugSkelMeshComponent to SAnimationEditorViewport
#jira UEAP-167
Change 3730054 by Martin.Wilson
Live Link: Add ability for sources to define their own settings
Change 3730134 by Jurre.deBaare
Editor crashes when opening animcompression setting on an alembic file
#jira UE-51840
#fix ensure that anim sequence actually contains a compression scheme, and set scheme during ABC import
#misc cleaned up comment
Change 3730428 by Thomas.Sarkanen
Fix copy/paste in the physics asset editor
When constraint data was being serialized the default profile was being substituted, however it wasnt being updated for all non-detials panel operations.
Added a UpdateProfileInstance() to propgate the changes correctly for copy/paste, axis cycling and toggling.
Also allow multi-paste of constraints/bodies.
#jira UE-51803 - Copy/paste doesn't work correctly in PhAT
Change 3730464 by Thomas.Sarkanen
Fixed copy/paste not working when the skeleton tree has focus
The skeleton tree was absorbing the command binding because socket copy/paste wasnt not checking whether sockets were selected.
#jira UE-51803 - Copy/paste doesn't work correctly in PhAT
Change 3730511 by Jurre.deBaare
Moving over fix from FN-Staging for [CrashReport] UE4Editor_Engine!FColorVertexBuffer::GetVertexColors() [colorvertexbuffer.cpp:313]
#jira UE-48988
Change 3730685 by Benn.Gallagher
Fix for sequencer crash when toggling spawnable for an actor containing a skeletal mesh component. Caused by CPFUO adding entries into the subinstance array while the component was unregistered.
#jira UE-51508
Change 3731560 by Aaron.McLeran
Removing gaurd on spatialization plugin settings and renaming enumerations
Change 3731714 by Ori.Cohen
Added the ability to profile scene query hitches.
Change 3731725 by Ori.Cohen
Change scene query hitch threshold to 50us by default
Change 3731770 by Ethan.Geller
Fix signed/unsigned comparison.
Change 3731777 by Ethan.Geller
Suppress static analysis warning.
Change 3732145 by Thomas.Sarkanen
[Duplicated from 4.18.1]
Fixed crash when simulating in the physics asset editor, dragging with Ctrl+RMB and then clicking LMB
Also fixed a selection issue that was exposed when this crash was fixed,
#jira UE-51597 - [CrashReport] Crash in PHAT on LeftMouse click while moving ragdoll asset during Simulate
Change 3732176 by Thomas.Sarkanen
Fixed hang when selecting all bodies or constraints in a physics asset
Implements a better fix for CL 3721129
#jira UE-51626 - Very long hang occurs when selecting all bodies in a physics asset
Change 3732177 by Thomas.Sarkanen
Fix crash when pasting properties in Physics Asset Editor
Makes sure that the tree is refreshed when underlying data changes, so we dont access stuff out of range.
#jira UE-51806 - Editor crashes when pasting properties of a body to multiple bodies
Change 3732492 by Martin.Wilson
Fix for ensure when compressing an animation whos skeleton has been switch due to skeletal mesh merging
#Jira UE-51794
Change 3732672 by Thomas.Sarkanen
Refactor view menus in animation editors
Moves show menu and buffer visualizations into a new CommonMenuExtensions module.
Reorders viewport menus in Persona-based editors so the "Show" menu is similar to the level editor's menu of the same name.
All character-specific stuff is now in a "Character" menu.
Original changes by Jonathan.Poncelet
#jira UE-41903 - Add relevant options from Level viewport Show menu to Anim tools viewports
Change 3732860 by Thomas.Sarkanen
Fix CIS errors/warnings
Change 3732877 by Thomas.Sarkanen
Fix missing Physics menu
Merge error on my part
Change 3733113 by Ori.Cohen
Fix CIS
Change 3734859 by Thomas.Sarkanen
Fix crash when opening a physics asset that uses a preview mesh with no skeleton
#jira UE-51916 - [CrashReport] UE4Editor_CoreUObject!FWeakObjectPtr::Get() [weakobjectptr.cpp:81]
Change 3736693 by Ethan.Geller
Added ability for submixes to define their own channel format. Written by aaron.mcleran
Change 3737943 by James.Golding
Fix crash when right-clicking during section selection in skel mesh tools
#jira UE-51873
Change 3738337 by Benn.Gallagher
Fix for crash switching between clothing assets with a gradient tool that has cached start/end indices.
#jira UE-51921
Change 3738404 by Lina.Halper
Add comment for bImportBoneTrack option in FBX importer
Change 3738816 by Benn.Gallagher
Added "Anim Drive" to clothing assets and added runtime interaction for simulations (Merged from Siren)
Change 3738960 by Ethan.Geller
Fix Linux compiler errors for implicit enum casting
Change 3739214 by Lina.Halper
- Removed unnecessary Initialize
- Make sure invalidate the other part if not used (socket->bone or bone->socket)
#jira: UE-51931
Change 3739215 by Lina.Halper
compile error
- added one more ) when pasted to the other line
Change 3739442 by Lina.Halper
pose asset crash when skeleton changes
#jira: UE-52036
Change 3739795 by Ethan.Geller
fix linux build with implicit enum class casts, pt 2
Change 3740553 by James.Golding
Sweeps with an initial overlap now put more useful info (from PhysX) into HitResult::ImpactPoint
#jira UE-47566
Change 3740560 by James.Golding
- Don't rebuild render data on SkeletalMesh interactive property changes
- Remove unnecessary render resource release in SkeletalMesh PreEditChange
#jira UE-51652
Change 3740562 by James.Golding
Extensibility improvements to PhysicsAssets (from NVIDIA)
Change 3740563 by James.Golding
PR #4066: Physical Animation Crash fix - Prevent crashing if the scene has already been removed or index was invalid. (Contributed by DSDambuster)
#jira UE-50546
Change 3740564 by James.Golding
PR #4175: Added functions to SpringArmComponent to get relevant status of the Collision Test (Contributed by alexformosoc)
#jira UE-51761
Change 3740587 by Benn.Gallagher
CIS fixes for non-cloth platforms and initialization order fix
Change 3740658 by Thomas.Sarkanen
Update cloth appropriately in the physics asset editor
When moving primitives, just update the underlying extracted collision - we dont reset the entire simulation.
Reset simulation when making more 'major' potential changes (adding/removing collision etc.)
Optionally reset cloth when simulation starts/stops in the physics asset editor
#jira UE-50949 - Phat Editor with cloth collisions
#jira UE-48779 - Ability to reset clothing during physics simulation
#jira UE-48778 - Moving collision in Physics editor doesn't interact with cloth
Change 3743354 by Benn.Gallagher
CIS Fix
Change 3743419 by Thomas.Sarkanen
Preview buttons are now present where applicable
Preview mesh button reordered to be consistent with other anim editors.
Preview animation re-instated where applicable.
Also fixed skeleton tree icons hiding when bones are not relevant - this was confusing depending on bone layout
#jira UE-50894 - Animation Editors - Include Preview Mesh and Animation Buttons
Change 3743529 by Thomas.Sarkanen
Moved constraint and physical anim profile indicators to the top of the details panel
Indicators now show assignment status.
#jira UE-50895 - Constraint Profiles requests
Change 3743604 by Jurre.deBaare
Duplicating from 4.18.1:
[CrashReport] UE4Editor_Core!FMath::ComputeBaryCentric2D() [unrealmath.cpp:1951]
#fix pre-emptive early out on the collinear test, and found other minor bug with bounds test as well
#jira UE-51917
Change 3743757 by Lina.Halper
Adding more ensure to detect NaN
Change 3743791 by Ori.Cohen
Fix CIS and stack size issues
Change 3744008 by Benn.Gallagher
Gravity override support for clothing interactor.
#jira UE-51014
Change 3744439 by Michael.Karambelas
Updating and investigating CableActor automation tests
Change 3744566 by Martin.Wilson
Possible fix for very rare anim corruption (missing raw data). Moved Super::PostLoad call above track verfiy to make sure skeleton is loaded.
#jira UE-49335
Change 3745963 by Martin.Wilson
Fix ensure being hit because users could turn on both "Use Adaptive Error" and "Use Adaptive Error 2" at the same time
#Jira UE-52044
Change 3748585 by Aaron.McLeran
Fixing crash when loading editor with synth components.
Change 3749071 by Aaron.McLeran
Fixing ambisonics submix format
Change 3749969 by Danny.Bouimad
Updating TM-AnimPhys to be more performant on Switch
Change 3750103 by Danny.Bouimad
Checking in automated test to cover Debug Show Collision, Visibility Collision and Player Collision. (Disabled currently due to active bug causing incorrect ground truths to be generated UE-52052)
Change 3754465 by Ethan.Geller
Fixing panning in audio mixer after submix format feature
Change 3755637 by Lina.Halper
Back out changelist 3739214
- still add back invalidation
#jira: UE-52159
Change 3756385 by Lina.Halper
- Adding ground truth for the cable component test map
- Disabled first test as it has BP none access warning
#jira: UE-52370
Change 3756707 by Ethan.Geller
fix potential mem leak in mixer source
Change 3757148 by Aaron.McLeran
Fixing surround sound bugs due to recent changes to submix format.
Change 3757583 by Aaron.McLeran
Fix cook with synth component
Change 3758477 by Danny.Bouimad
Fixing Disabled cable actor test, checking in screenshots for a disabled test.
Change 3758873 by Ethan.Geller
#jira UE-52389 Remove assert on getting a hash for a unique net id.
[CL 3759284 by Marc Audy in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3627179 by Aaron.McLeran
Optimizing active sound by not processing active sounds if they are out of range.
Allowing virtualized sounds to be exempt.
Licensee says they saw a 6x improvement on active sound calculations in audio thread with this change.
Change 3640144 by Aaron.McLeran
#jira UE-49409 Attenuation focus audio tests on TM-AnimPhys on Cooked mac doesn't play any audio
Fixing the recent optimization to not play active sounds in range. Code attempts to check if there's any possibility for a sound to have it's distance affected before trying to prune by max distance.
Change 3686191 by James.Cobbett
Fixing Shape_Cube to have just one simple box collision instead of 3 primitives
Change 3688873 by Danny.Bouimad
Fixing TM-AnimPhys test content
Change 3689715 by Aaron.McLeran
Removing temp logging
Change 3692323 by Lina.Halper
Fixed crash when attached to no collision parent, causes crash on changing collision settings.
Change 3692526 by Lina.Halper
Fix issue where attach to any socket causes snapping
Change 3692975 by Aaron.McLeran
Lib opus tps file
Change 3693083 by Ethan.Geller
#jira UE-51183 Fix Attenuation Settings reverb display names. [Dev-AnimPhys]
Change 3695627 by Aaron.McLeran
Allowing multiple plugin settings so users can have different settings for different plugins.
Change 3697996 by Aaron.McLeran
#jira UE-51301 Fixing compile error for BP with changes to using array settings for plugins
Change 3698787 by Aaron.McLeran
Checking in missing file
Change 3707260 by Aaron.McLeran
#jira UE-51476 Adding ability to get envelope follower delegates to audio components and synth components.
- added ability to propogate up the envelope follower values from audio source manager/renderer to BP
- added 2 modes to get data for audio components: per-source/soundwave and a multi/aggregate callback for cases where multiple sources play for a given active sound/audio component.
- added ability to parameterize the envelope follower for an audio component, giving the attack/release time of the envelope follower
- added wrapper around callback to propogate to synth components
- only works (of course) in audio mixer
Change 3709356 by Martin.Wilson
Allow native anim instances to be set on skeletal mesh components
Change 3709360 by Martin.Wilson
Live Link integration into Persona
- Creation of preview controllers in Persona, allow customization of preview scene
- Original hard coded preview animation modes refactored into preview controllers and details customization reworks to allow selection of these
- Created live link preview controller that allows driving character from live link subject
- Added the ability to override the camera controller of an animation preview scene
- created live link camera controller to drive camera based on data from live link
Change 3709859 by Martin.Wilson
CIS Fix
Change 3711658 by Aaron.McLeran
PR #4134: Steam Audio Beta 10 (Contributed by freemancw)
Change 3711882 by Aaron.McLeran
Integrating CL 3701738 from 4.18 to Dev-AnimPhys
Change 3711913 by Aaron.McLeran
Integrating CL 3705882 to Dev-AnimPhys
Change 3711918 by Aaron.McLeran
Integrating CL 3707149 and CL 3708254 from 4.18 to Dev-AnimPhys
Change 3711972 by Aaron.McLeran
Fixing synth components after integration issue.
- Can't access audio components in constructor anymore.
Change 3713090 by Thomas.Sarkanen
Switch to using PhysXIncludes.h to avoid issues with Linux/HTML5 c-linkage errors
Change 3713115 by Laurent.Delayen
AnimDistanceMatching plugin framework. (Just a functional empty plugin to build from)
Change 3713418 by Laurent.Delayen
Added AnimDistanceMatching empty project to Samples/Showcases
Change 3714439 by Aaron.McLeran
Changes to synth component and procedural sound waves with audio mixer.
- Added callbacks for initiating procedural sound wave generation and ending it, so we can get proper pre- and post- hooks for DSP processes which need it.
- Added a constructor for procedural sound waves so it doesn't cause a hang during hotload
Change 3714444 by Aaron.McLeran
#jira UE-51471 Adding a microphone component.
- Gets audio directly from a microphone, renders it in a synth component for in-game microphone audio rendering.
- Movnig RtAudio lib to AudioCapture plugin, along with AudioRecordingManager (used by sequencer recorder)
- Also moved audio recording manager to an editor plugin
- Created new runtime plugin "audio capture" which is needed for audio capture component. Future capture-related features will go in this plugin.
- Updated RtAudio version to v 5.
Change 3715101 by Aaron.McLeran
Integrating CL 3715055 from FN to Dev-AnimPhys
#UE4 Fix to actually use the precached streaming audio DDC data when cooking.
Change 3716473 by Aaron.McLeran
#jira UE-51560 Fixing RtAudio compile error
Change 3718096 by Jurre.deBaare
GeomCache Alembic no longer renders correctly
#fix serialization path was incorrect, reading incorrect FDynamicMeshVertex layout from pre-change files
#jira UE-51592
Change 3718254 by Nick.Shin
HTML5 CIS warning fix
bringing over //UE4/Main's version to //UE4/AnimPhys
.../Engine/Source/ThirdParty/PhysX{3}/PhysX_3.4/Include/PxPhysics.h
#jira none
Change 3718647 by Martin.Wilson
Static analysis fix
#jira UE-51599
Change 3719638 by Aaron.McLeran
#jira UE-51598 Fixing static analysis warning.
not 100% sure if this fixes it, but I ran MSVC static analysis locally and it seems to have not triggered it.
Change 3720334 by Aaron.McLeran
#jira UE-51620 Fix for hang during multi-PIE shutdown when using a synth component.
Change 3355932 by Thomas.Sarkanen
Back out changelist 3354003
Reinstating merge from Main:
Merging //UE4/Dev-Main to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3353839
Change 3698735 by Aaron.McLeran
Adding ability for synth initialization to modify the requested sample rate
- This was needed so that some synth component types can modify the sample rate easily after calling init (e.g. a microphone will want to tell the synth what sample rate it should initialize with).
- It's also possible for a synth init to fail (again for mic component, this could fail if mic capture isn't supported for a platform or there is a problem with a device, etc)
Change 3702404 by Thomas.Sarkanen
Copying //UE4/Dev-Physics-Upgrade to Dev-AnimPhys (//UE4/Dev-AnimPhys) @ CL 3702362
Change 3703019 by Jurre.deBaare
HLOD with texture binning on introduces ugly black seams
#fix ensure that we ouput importance values according to baked out materials rather than per-section
#jira UE-51426
[CL 3720923 by Thomas Sarkanen in Main branch]