Commit Graph

767 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Matt Hoffman
10f4fc50b2 Matinee: Fixed a bug in the Matinee to LevelSequence converter that caused audio sections to get added to their track twice. This has been an issue for a long time but only surfaced now that the MVVM UI has checks for it.
#jira None
#rb Andrew.Rodham
#preflight 628fad0a911f194ea737ef3d

[CL 20380918 by Matt Hoffman in ue5-main branch]
2022-05-26 12:52:45 -04:00
Max Chen
0167d4ea0f Sequencer: MVVM2 branch and Layer Bars
Copying //Tasks/UE5/Dev-SequencerMVVM2 to Main (//UE5/Main) @20364093

#preflight 628866dfb94f739b152c1e29
#preflight 628866e4585e8f793ee80943
#rb ludovic.chabant, andrew.rodham
#fyi ludovic.chabant, andrew.rodham, andrew.porter
#jira UE-105322

[CL 20364493 by Max Chen in ue5-main branch]
2022-05-25 10:39:33 -04:00
max chen
482d3778f8 Sequencer/Valykrie: More asset filter permissions
#rb scott.nelson
#preflight 628d69022f2409bc1e01f612

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 20358898 via CL 20358911 via CL 20360271 via CL 20360327
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20360691 by max chen in ue5-main branch]
2022-05-25 02:13:28 -04:00
max chen
7f38066285 Sequencer/Valkyrie: Apply asset filters to asset pickers and drag and drop.
A private asset in a plugin can be seen and drag dropped into by a private asset in the same plugin. But a private asset cannot be referenced from another plugin.

#rb scott.nelson
#preflight 628721b30a57b0f54587500f

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 20337948 via CL 20339634 via CL 20339811 via CL 20339960
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20341224 by max chen in ue5-main branch]
2022-05-23 19:09:30 -04:00
Max Chen
9c03481d38 Curve Editor: Curve points now default to the same color as the curve. Selected points defaults to white and is controllable by a preference.
The default color for curves is now a darker gray instead of White since the selection color is White.
The blue channel for Z and B channels is now brighter because it was too dark on the dark background.

#jira UE-149063
#rb andrew.rodham, matt.hoffman
#preflight 6288345c95170b5599ffc30e

[CL 20335878 by Max Chen in ue5-main branch]
2022-05-23 15:39:25 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
max chen
c3a2cf0925 Sequencer: Fix actor reference track automatically creating keys
#rb andrew.rodham
#preflight 628676d3f15d967ff4bf6f2f

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 20283978 via CL 20284134 via CL 20284335 via CL 20284446
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20304682 by max chen in ue5-main branch]
2022-05-20 18:45:10 -04:00
lauren barnes
4b82e918fa Replacing legacy EditorStyle calls with AppStyle
#rb header and class name replacement

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20078276 via CL 20078825
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106316 by lauren barnes in ue5-main branch]
2022-05-09 13:51:26 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
max chen
bf7eb82263 Sequencer/Valkyrie: Track class permissions for what tracks can be added to movie scene.
Event Track and ConsoleVariable Track are disabled. Spawn Track is also disabled, which means you can't create spawnables in Valkyrie

Added FIsTrackClassAllowed to MovieScene which is bound in MovieSceneToolsModule to look at the class viewer rules.
Fix logic in MediaTrackEditor and LiveLinkPropertyTrackEditor which was always returning Supported for level sequences.

#preflight 6270563191629533ec2b6f79
#rb andrew.rodham

#ROBOMERGE-OWNER: max.chen
#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 20031346 via CL 20033139 via CL 20033318 via CL 20033325
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20035188 by max chen in ue5-main branch]
2022-05-03 19:50:52 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Mike Zyracki
49541ddc4c Sequencer: Linked Anim Sequences: When duplicating level sequences we also duplicate the linked anim sequence. Also added some BP/Python functions for creating linked anim sequences
#jira UE-149027
#jira UE-149731
#preflight 62607aa6de50cd99bbbab57c
#rb max.chen

[CL 19851796 by Mike Zyracki in ue5-main branch]
2022-04-21 13:12:26 -04:00
max chen
daa4ba3dc8 Sequencer: Set the ID directly if there is no sequencer. Otherwise, if we don't know the local sequence ID, or we have no hierarchy, or we're resetting the binding; set a relative ID.
This fixes a regression introduced by 18938437 which fixed an issue where if you create a binding when there is no hierarchy, the binding stays fixed and can't be used in a hierarchy afterwards.

The fix here is that sequencer doesn't exist (when setting the value through the level blueprint picker), so it should just set the ID directly.

#jira UE-148302
#preflight 624ce40b4c5db57ae6fe32a3
#rb andrew.rodham
#lockdown laurent.delayen

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19807476 in //UE5/Release-5.0/... via CL 19807942
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19812100 by max chen in ue5-main branch]
2022-04-19 13:27:48 -04:00
christopher waters
99ec480304 Cleaning up dependencies with select heavy-hitter headers in MovieScene and addressing the fallout from that.
MovieScene was targeted as its headers were at the top of profiling ShooterGame builds.
Tested with -disableunity and -nopch. Current timings take ShooterGameEditor rebuild from 480s to 440s

#jira none
#rb josh.adams
#preflight 624c97a63661c8f04a191889

[CL 19634779 by christopher waters in ue5-main branch]
2022-04-05 18:58:45 -04:00
max chen
8641821de3 Sequencer: Drag and drop should gather all skeletal mesh components (not just the root if it's a skeletal mesh component) so it can perform a animation skeleton match with all the possible skeletal mesh components.
follow up to CL 18963239

#rb mike.zyracki
#preflight 6201c11ebf1c4969112e7520

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19621351 via CL 19621365 via CL 19621370 via CL 19621375
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19621444 by max chen in ue5-main branch]
2022-04-05 02:02:23 -04:00
benoit gadreau
605c7b5582 fixed visual artifacts for space bars / keys
#rb mike.zyracki
#jira UE-144734
#preflight 624197518f37c03fd07665e5

[CL 19529580 by benoit gadreau in ue5-main branch]
2022-03-28 12:54:44 -04:00
daren cheng
9f0b63a667 Move BP extensions to private, expose getters / setters instead.
#rb Phillip.Kavan, Patrick.Boutot
#preflight 623b95b99304d833f4105401
#jira UE-145133

[CL 19487374 by daren cheng in ue5-main branch]
2022-03-23 18:12:22 -04:00
max chen
f2416db679 Sequencer: Change to AssetPickerConfig to List for better layout/sizing
#rb matt.hoffman

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19374025 via CL 19376455 via CL 19391702 via CL 19391993
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19402250 by max chen in ue5-main branch]
2022-03-16 03:02:40 -04:00
john vanderburg
efd25d9de8 Fix a filtering issue in sequencer, where it didn't show anim sequences of compatible skeletons.
#preflight 6230dbdf7b5cb407688be1e3

[CL 19390650 by john vanderburg in ue5-main branch]
2022-03-15 14:43:19 -04:00
philippe deseve
8218e80ef1 UDataLayer deprecated in favor of UDataLayerInstance & UDataLayerAsset
UDeprecatedDataLayerInstance allows to boot level using deprecated UDataLayers
Worlds using DataLayer can run the DataLayerToAssetCommandlet to transition their existing DataLayers
FActorDataLayer interface is deprecated.
DataLayers Blueprint referencers should now use DataLayerAsset to retrieve DataLayerInstances.
DataLayer Code referencers should now use DataLayerAssets or DataLayerInstance FName to retrieve DataLayerInstances.
DataLayerLabels now only used for display/UI purpose
Relabeling DataLayers is not permitted anymore on new DataLayerInstances (allowed on UDeprecatedDataLayerInstance)
Added Changelist Validation for DataLayers
Added a column to the datalayer outliner showing any data layer errors.

#rb richard.mal jeanfrancois.dube
#preflight 623098c2050dc69468b6a297 (errors only related to lyra, which do not exist in this stream)

#ROBOMERGE-OWNER: philippe.deseve
#ROBOMERGE-AUTHOR: philippe.deseve
#ROBOMERGE-SOURCE: CL 19385808 via CL 19387392
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19389077 by philippe deseve in ue5-main branch]
2022-03-15 13:52:28 -04:00
max chen
16d8af48fe Curve Editor: Buffered curve features
Buffered curves now can only operate on themselves, matching by LongDisplayName. The operations are also restricted to the selected curves (either selected in the tree or selected by way of selected keys). There is a new option to Swap Buffered Curves which stores the current curve to the buffer and restores the buffer to the current curve. The Store/Swap/Apply menus are now visible for all the context menus (keys, hovered curve, all curves). There is also a new toggle to show/hide buffered curves and they are also only visible when the curve is selected.

#jira UE-143895
#preflight 62294f800d5a90e98ed4ae68
#rb mike.zyracki

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19344793 via CL 19346614 via CL 19351363 via CL 19351424
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19351984 by max chen in ue5-main branch]
2022-03-11 04:29:44 -05:00
max chen
1d2865048c Sequencer: Activate the default mode in case FEditorModeTools::Tick isn't run before here.
This fixes a bug where the mode is set to "No Active Mode" when reopening the editor because the Sequencer modes are added before the default mode.  This can be removed once a general fix for UE-143791 has been implemented.

#jira UE-144086
#preflight 621d0b75037be0078ca9f7ef
#rb christina.tempelaarl
#lockdown laurent.delayen

#ROBOMERGE-AUTHOR: max.chen
#ROBOMERGE-SOURCE: CL 19179266 in //UE5/Release-5.0/... via CL 19180484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19204151 by max chen in ue5-main branch]
2022-03-01 14:56:17 -05:00
mike zyracki
8590068755 Animation Mode: Can hit ensure if actor is not in Sequencer when using Snapping tool
#jira UE-143755
#rb
#preflight

#ROBOMERGE-AUTHOR: mike.zyracki
#ROBOMERGE-SOURCE: CL 19123757 in //UE5/Release-5.0/... via CL 19124329
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19154428 by mike zyracki in ue5-main branch]
2022-02-25 15:15:35 -05:00
jimmy smith
929ebcd8d7 Fix spamming of Triggers by adding new Track type
#jira UE-138615
#rb rob.gay Ludovic.Chabant
#preflight 6216753437178b0175b2317f


#ROBOMERGE-AUTHOR: jimmy.smith
#ROBOMERGE-SOURCE: CL 19095469 via CL 19096552 via CL 19097708 via CL 19098551 via CL 19105431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147043 by jimmy smith in ue5-main branch]
2022-02-25 09:59:46 -05:00