Commit Graph

1121 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Brandon Schaefer
1abae7891d Check for a nullptr for the asset class
#jira UE-154147
#rb Lauren.Barnes
#preflight none

[CL 20438041 by Brandon Schaefer in ue5-main branch]
2022-05-31 11:57:28 -04:00
lauren barnes
53488dc718 Updating CrashReportClient style to only use images from certain folders, and moving developer tool style setup to individual style classes.
#jira UE-152623
#rb Josh.Adams, Patrick.Boutot, Patrick.Laflamme, Louise.Rasmussen
#preflight 628d6c5faf7a2e956b8de990

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20366551 via CL 20368551 via CL 20369147 via CL 20369164
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20370889 by lauren barnes in ue5-main branch]
2022-05-25 16:27:45 -04:00
yiliang siew
98f0fa3806 - Fixed nullptr dereference when the module is being unloaded since the tab's parent is already de-allocated if the engine is exiting.
- Also prevents this sort of bug from occurring in Slate altogether.

#rb Lauren.Barnes
#preflight 6287c2768828ea88c8662b2d

#ROBOMERGE-AUTHOR: yiliang.siew
#ROBOMERGE-SOURCE: CL 20298520 via CL 20298571 via CL 20298583 via CL 20298596
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20305684 by yiliang siew in ue5-main branch]
2022-05-20 19:13:25 -04:00
Marc Audy
310df188b4 CAC per instance properties
#preflight 62867d3e9016c6dd898d8fa2

[CL 20284659 by Marc Audy in ue5-main branch]
2022-05-19 14:43:57 -04:00
Max Chen
d2ea33ba30 Sequencer: Add asterisk to the Sequencer tab if the asset is dirty (similar to level editor)
#jira UE-150643
#preflight 627e7e076d7654cc68a9b195
#rb andrew.rodham

[CL 20255185 by Max Chen in ue5-main branch]
2022-05-17 22:18:24 -04:00
Jerome Delattre
3d4310d84b Expose BuildLightMaps command to python and blueprint utilities
#preflight 6283e68b024d020b2d657a97
#rb Juan.Canada, Yujiang.Wang
#jira none

[CL 20248191 by Jerome Delattre in ue5-main branch]
2022-05-17 14:36:34 -04:00
scott nelson
bf58e390bb Add Extender to middle of LevelViewportToolbar
#rb Jason.Stasik
[FYI] Elias.Lozadabenavent
#preflight 627d8e589f7ad2a14b01a94e

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 20182020 via CL 20183691 via CL 20184781 via CL 20185949 via CL 20186141
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20188814 by scott nelson in ue5-main branch]
2022-05-13 16:42:07 -04:00
louise rasmussen
8428a1ac62 Reference Viewer UI
- Moved view options into toolbar
- Migrated Functions to Commands
- Added Keyboard Shortcuts for View Options
- Added Keyboard Shortcuts to adjust Depth & Breadth
- Added Keyboard Shortcut to edit the selected node

#JIRA UE-151731
#rb Lauren.Barnes
#preflight 627d9303a82f3adab8b65a08

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20175507 via CL 20177195 via CL 20177309 via CL 20177412
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20177907 by louise rasmussen in ue5-main branch]
2022-05-13 00:45:19 -04:00
aditya ravichandran
632ef3784e Outliner:
Port ActorBrowsingMode over to the new Editor Config system to have separate settings for each outliner
Enable Stacked Hierarchy Headers by default
Add the ability to disable framing selection
Add the ability to get the most recently used outliner from the level editor
Fix a bug where renaming an item on one outliner would sometimes execute the rename on a different outliner

#rb richard.malo
#jira UETOOL-5014
#preflight 627aa9811e74993343331221

[CL 20126651 by aditya ravichandran in ue5-main branch]
2022-05-10 14:20:42 -04:00
lauren barnes
5f7006fb53 Fixing EditorStyle->AppStyle merge errors
#rb trivial

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20073150 via CL 20073151
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20105751 by lauren barnes in ue5-main branch]
2022-05-09 13:31:58 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
Richard Malo
dffb5b9557 Second pass on Editor Context
#jira UE-150705
#rb patrick.enfedaque
#preflight 626fe655645c64f3a2426e06

[CL 20008791 by Richard Malo in ue5-main branch]
2022-05-02 11:00:12 -04:00
vincent beauchemin
e50e6bce3c Build Menu - Display the World Partition section depending if we are in a world partition world or not. If not, display the previous hlod menu entry like before.
#jira UE-149173 - No feedback when attempting to build the minimap when World Partition is not enabled
#rb jeanfrancois.dube sebastien.lussier
#preflight skip
#rnx

[CL 20007598 by vincent beauchemin in ue5-main branch]
2022-05-02 09:15:55 -04:00
brooke hubert
2b59ecd263 Fix a crash in level editor viewports when the slate window is destroyed and recreated (like when reloading the default viewport).
#preflight 6260b1dd6c1237ea1236c555
#Jira UE-149356
#rb julien.stjean
#lockdown jeanmichel.dignard

#ROBOMERGE-AUTHOR: brooke.hubert
#ROBOMERGE-SOURCE: CL 19856122 in //UE5/Release-5.0/... via CL 19857724
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19869131 by brooke hubert in ue5-main branch]
2022-04-22 14:49:49 -04:00
brooke hubert
1664c8f9a8 Adding missing deprecation pragma guards from CL 19853509
#rnx
#Jira UE-149401
#rb trivial
#pf skip

#ROBOMERGE-AUTHOR: brooke.hubert
#ROBOMERGE-SOURCE: CL 19853998 in //UE5/Release-Engine-Staging/...
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19855298 by brooke hubert in ue5-main branch]
2022-04-21 16:29:52 -04:00
brooke hubert
5b46ca629b Fix a crash when changing layout or viewport type in Level editor viewports and running various exec commands that used typed element common actions.
#preflight 625f1a14fd255ad9e2ee4664
#Jira UE-149401
#rb lauren.barnes
#lockdown jeanmichel.dignard, cristina.riveron

#ROBOMERGE-AUTHOR: brooke.hubert
#ROBOMERGE-SOURCE: CL 19848657 in //UE5/Release-5.0/... via CL 19853509
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19855245 by brooke hubert in ue5-main branch]
2022-04-21 16:28:19 -04:00
zach rammell
392dfe8d69 [Backout] - CL19565596
Original CL Desc
-----------------------------------------------------------------
Prevent details panel from getting stuck on deleted elements when locked

It will now unlock and clear itself when an element is deleted

#jira UE-142503
#rb brooke.hubert
#preflight 6244d3829f4042341454d61a

[CL 19595303 by zach rammell in ue5-main branch]
2022-04-01 16:45:42 -04:00
zach rammell
400c4b2022 Prevent details panel from getting stuck on deleted elements when locked
It will now unlock and clear itself when an element is deleted

#jira UE-142503
#rb brooke.hubert
#preflight 6244d3829f4042341454d61a

[CL 19565596 by zach rammell in ue5-main branch]
2022-03-30 18:26:36 -04:00
Patrick Enfedaque
73f3cb29a4 LevelInstance: Extract ILevelInstanceInterface, FLevelInstanceActorImpl from ALevelInstance to allow LevelInstance implementation in existing AActor class hierarchies
#rb richard.malo, jeanfrancois.dube
#preflight 62420c81dc6183e3f5d47b90
#rnx

[CL 19541016 by Patrick Enfedaque in ue5-main branch]
2022-03-29 09:19:22 -04:00
aditya ravichandran
3fba7c938e StarshipStyle: Rename "EditorViewport.SubMenu.Layouts" to "Icons.Layout" and move it to StarshipCoreStyle
#rn deprecation editor
#jira UE-147073
#rb louise.rasmussen
#preflight 623e14b96d39f6b5a05b87fe

[CL 19517936 by aditya ravichandran in ue5-main branch]
2022-03-25 15:45:41 -04:00
Matt Peters
c1b46b1fed FAssetData: Callsites need to handle AssetData.GetClass() returning null. Added IsInstanceOf(UClass*) for the common operation GetClass() && GetClass->IsChildOf(BaseClass).
#jira UE-146521
#rb Zousar.Shaker
#rnx
#preflight 623874b789625f06129e466b

[CL 19450936 by Matt Peters in ue5-main branch]
2022-03-21 09:00:36 -04:00
Richard Malo
9a66faad7c Make Actor Editor Context respect "Hide Viewport UI" option.
#rb patrick.enfedaque
#preflight 62346319da56b5683ac64604
#robomerge FNNC

[CL 19433760 by Richard Malo in ue5-main branch]
2022-03-18 07:00:58 -04:00
aditya ravichandran
86faf11210 SceneOutliner: Fix a bug causing changes in PIE to apply to the actual level instead of replicating in the PIE session
#jira UE-146138
#fyi brooke.hubert
#rb Lauren.Barnes
#preflight 62321275736af8e08228e98f

[CL 19407552 by aditya ravichandran in ue5-main branch]
2022-03-16 12:52:34 -04:00