Commit Graph

139 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
George Rolfe
24ca811d19 EditorWidgetsStyle cis fix 176112
#jira none
#rb none
#preflight 629607c6be0ae0b33a3908a2

[CL 20435923 by George Rolfe in ue5-main branch]
2022-05-31 08:49:52 -04:00
George Rolfe
04df2dac7c TemplateString + customization
#jira none
#rb sebastian.nordgren
#preflight 6295f14f926be5fb68b3e29a

[CL 20435453 by George Rolfe in ue5-main branch]
2022-05-31 07:40:18 -04:00
aditya ravichandran
dde5cba0e2 SBasicFilterBar: Add an argument to extend the Add Filter Menu
SAssetFilterBar: Add functions to access and modify Asset Type Filters

#rb louise.rasmussen
#preflight 628fe838911f194ea741cd7b

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20386597 via CL 20388781 via CL 20388799 via CL 20388814
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20390042 by aditya ravichandran in ue5-main branch]
2022-05-26 23:02:40 -04:00
aditya ravichandran
abf7b099e2 FilterBar: Redo icon related changes squashed during merge with SFilterList
#rb trivial
#preflight skip

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20338812 via CL 20340308 via CL 20340321 via CL 20340324
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20341645 by aditya ravichandran in ue5-main branch]
2022-05-23 19:36:37 -04:00
bob tellez
c24eefba8a FilterBar: Fix deprecation warnings when including AssetFilter.h
#preflight skip
#rb trivial

#ROBOMERGE-OWNER: bob.tellez
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20339304 via CL 20339470 via CL 20339741 via CL 20339759
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20341215 by bob tellez in ue5-main branch]
2022-05-23 19:09:18 -04:00
aditya ravichandran
ec0203507a FilterBar: Fix missing space in copyright boilerplate
#jra none
#rb trivial
#preflight skip

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20332997 via CL 20337183 via CL 20338690 via CL 20338921
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20340796 by aditya ravichandran in ue5-main branch]
2022-05-23 18:40:16 -04:00
aditya ravichandran
53360c9ff0 Refactor SFilterList in the Content Browser into more globally usable Filter Widgets
SBasicFilterBar in ToolWidgets is the most generic filter bar, usable in non editor buillds as well
SAssetFilterBar in EditorWidgets is a complex filter bar with support for the built in asset filters from the content browser
SFilterBar in EditorWidgets is the most convinient filter bar to use in editor if you want asset filters and custom filters

#jira UE-151904
#rbJulien.StJean, jamie.dale
#preflight 628ba0da693c5e1de27cbc30

#ROBOMERGE-OWNER: aditya.ravichandran
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20330320 via CL 20337158 via CL 20338269 via CL 20338595
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20340436 by aditya ravichandran in ue5-main branch]
2022-05-23 18:18:06 -04:00
sebastian nordgren
c9017e4b69 SEnumCombo now only dismisses its own menu when an option is selected.
This was causing issues when an SEnumCombo was embedded into a menu builder, because the top-level menu was keeping the SEnumCombo alive, causing the OnEnumSelectionChangedDelegate to never fire.

Reported from UDN: https://epicgames.lightning.force.com/lightning/r/Case/5004z00001eEsHSAA0/view

#review-20322055 @lauren.barnes, @mikko.mononen
#preflight 628b9e7d573a7de2c4272968

[CL 20328054 by sebastian nordgren in ue5-main branch]
2022-05-23 10:54:07 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Cody Albert
6b721b69d6 Fixed issue where string table selection combobox wouldn't show the filter text box anymore if there were no results, making it impossible to clear
See UDN: https://epicgames.lightning.force.com/lightning/r/Case/5004z00001dnzLDAAY/view

#rb Lauren.Barnes
#preflight 62719c8afe09c0cfbc5d23f8

[CL 20033041 by Cody Albert in ue5-main branch]
2022-05-03 17:38:02 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
sebastian nordgren
7f55a9a168 Reverted change that broke SEnumCombos with hidden values.
#rb daren.cheng
#jira UE-143994
#preflight 624177c55c289ac26e46613e

[CL 19524586 by sebastian nordgren in ue5-main branch]
2022-03-28 04:59:08 -04:00
sebastian nordgren
1ceeb6b19c Reverting SEnumCombo changes in 19111919 due to causing crashes when UMETA(Hidden) values were at the start of the enum.
#jira UE-143994
#jira UE-143998
#rb daren.cheng
#preflight 622224a3335298c3145bc7c9

[CL 19265950 by sebastian nordgren in ue5-main branch]
2022-03-04 09:55:19 -05:00
sebastian nordgren
2876176f80 SEnumCombo now uses the cached tooltip and display name values instead of fetching them again every tick.
#review-19072594 @editor-ux
#preflight 621768fb22019f882b47aac7

[CL 19111919 by sebastian nordgren in ue5-main branch]
2022-02-24 06:23:05 -05:00
patrick boutot
3a767867aa Fix SWidget that are not incrementing their LayerId correctly.
#rb sebastian.nordgren
#preflight 61f934dec54b18c42dd2ac3d

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 18807375 in //UE5/Release-5.0/... via CL 18809186 via CL 18822226
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823250 by patrick boutot in ue5-main branch]
2022-02-02 05:29:19 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
matt kuhlenschmidt
5381ca07b4 Fix a number of details panel style issues
#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 17543878 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17543897 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-09-16 16:23:57 -04:00
steven dao
3418468662 Localization (advanced text settings) dropdown reskin for STextPropertyEditableTextBox
- Convert grid layout to row layout similar to property editor in appearance
- Preserve source string value when unlinking string table - fixes issue with being unable to unlink string table for enum display names
- Combine combo button with culture-invariant warning icon - this also prevents menu from potentially shifting when localizable toggled

#jira UETOOL-4227
#rb louise.rasmussen
#preflight 6140f6589dc6c8000156a4ab

#ROBOMERGE-AUTHOR: steven.dao
#ROBOMERGE-SOURCE: CL 17509480 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17509490 by steven dao in ue5-release-engine-test branch]
2021-09-14 16:15:13 -04:00
keith yerex
5fc97012b3 Clean up time slider widget code in Rewind Debugger
- new shared SSimpleTimeSlider widget
- double used for time values throughout Rewind Debugger
[REVIEW] thomas.sarkanen
#preflight 6130568679ce170001aa61fa

#ROBOMERGE-SOURCE: CL 17423140 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17423149 by keith yerex in ue5-release-engine-test branch]
2021-09-03 12:16:17 -04:00
matt kuhlenschmidt
26148b4444 Added missing header guards
#ROBOMERGE-SOURCE: CL 17371521 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17371597 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-08-31 12:50:01 -04:00
matt kuhlenschmidt
fcea7ab455 Stage one of editor style recolor
- Buttons, checkboxes, menus, toolbars, trees, combos, and text boxes all have consistent sizing and coloring
- Invalidated current dark theme

#pf 612d40b9423a8f00013c5b92

#ROBOMERGE-SOURCE: CL 17369605 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17369625 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-08-31 12:02:37 -04:00
matt kuhlenschmidt
995c0b6abf Moved SEditorHeaderButton out of UnrealEd and into EditorWidgets
#ROBOMERGE-SOURCE: CL 17157455 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17157466 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-08-12 15:48:02 -04:00