Commit Graph

15 Commits

Author SHA1 Message Date
sebastian nordgren
73e62b9ef3 JsonConfig shared pointers are now passed by const&.
Added tests for EditorConfig.

#review-20127432 @aditya.ravichandran, @lauren.barnes
#preflight 628764ef2c34da686ac74123
#rnx

[CL 20292425 by sebastian nordgren in ue5-main branch]
2022-05-20 06:20:33 -04:00
sebastian nordgren
8eafe4f70e Editor configs now correctly diff against the CDO when serializing.
Previously, I had assumed that FProperty::InitializeValue() would initialize a simple member (eg. a float) to the correct value, but this appears not to be the case, rather values are zero-initialized and the CDO stores the correct default values. In the case of structs, InitializeStruct() does in fact initialize correctly.

However, this means that we can't use GetMutableDefault() to get an instance of the UObject, since then we're changing what we're diffing against and serialize no values. Changed the usages of this pattern to use singletons instead.

#jira UE-141150
#review-19900014 @lauren.barnes, @aditya.ravichandran
#preflight 6267fa44a021c91a50f26a65

[CL 19919719 by sebastian nordgren in ue5-main branch]
2022-04-26 10:20:56 -04:00
jason stasik
e4651fb422 Fix non-unity error
#rb none
#preflight skip

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19798556 via CL 19798564 via CL 19798565
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19809766 by jason stasik in ue5-main branch]
2022-04-19 11:44:04 -04:00
jason stasik
a650434255 Log error when JSON deserializer fails to parse an EditorConfig file
#rb rex.hill,eric.knapik
#preflight 6259d6ca201cdc3ec501a4b3

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19794091 via CL 19798053 via CL 19798283 via CL 19798394
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19809723 by jason stasik in ue5-main branch]
2022-04-19 11:41:31 -04:00
jason stasik
57ecabf8c0 Expose AddSearchDirectory and LoadFromFile for EditorConfigs
#rb sebatian.nordgren

#ROBOMERGE-OWNER: jason.stasik
#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 18795736 via CL 18797126 via CL 18803326 via CL 18803348 via CL 18803356 via CL 18804424 via CL 18821688
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822076 by jason stasik in ue5-main branch]
2022-02-02 02:16:18 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
sebastian nordgren
bb68ab3b81 Added UClass & UStruct versions of FEditorConfigSubsystem::TryGetRoot*.
#review-16449464 @lauren.barnes
#preflight

[CL 16467398 by sebastian nordgren in ue5-main branch]
2021-05-26 08:27:40 -04:00
sebastian nordgren
5072dd8816 UEditorConfigSubsystem now has helpers to directly load into UObjects based on the EditorConfig= class metadata, as well as filtering of properties tagged with the EditorConfig property metadata.
#rb tim.smith, lauren.barnes
#jira UETOOL-3448
#preflight 60aceb521d02bb000144bc59

[CL 16447508 by sebastian nordgren in ue5-main branch]
2021-05-25 10:01:03 -04:00
sebastian nordgren
6d625d8bcb Added code for favoriting custom builders.
Also added code for favoriting groups, but this currently isn't enabled work since header widgets suffer from the same problem as custom widget rows do - their SWidget is created in place rather than through a function call, so thus cannot be duplicated. This needs some more thought, but the code for storing them is the same either way.

#jira UE-109586
#rb lauren.barnes

[CL 15802120 by sebastian nordgren in ue5-main branch]
2021-03-24 12:54:49 -04:00
sebastian nordgren
1b2a1ceacb Added some includes to fix non-unity compile issues.
#jira UE-107391
#rb trivial

#ROBOMERGE-SOURCE: CL 15311900 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15311992 by sebastian nordgren in ue5-main branch]
2021-02-04 05:47:39 -04:00
sebastian nordgren
27f0137dec Fixed non-unity build errors due to missing semicolon after IMPLEMENT_MODULE.
Removed unnecessary includes and overrides in EditorConfigModule.

#rb paul.chipchase
#jira UE-107391

[CL 15269585 by sebastian nordgren in ue5-main branch]
2021-02-01 06:01:10 -04:00
sebastian nordgren
16a291e899 Fixed CIS errors: static_assert with no message is a C++17 extension.
#rb trivial

[CL 15208687 by sebastian nordgren in ue5-main branch]
2021-01-26 12:33:13 -04:00
sebastian nordgren
1853026606 Fixed CIS errors in previous submits.
[CL 15208595 by sebastian nordgren in ue5-main branch]
2021-01-26 12:19:41 -04:00
sebastian nordgren
560ed14eb0 Added EditorMetadataOverrides subsystem and enabled its usage for details view favourites.
The Favorites category is now always visible, and displays a note about how to add properties there when empty.

#rb chris.gagnon
#jira UETOOL-2769

[CL 15208242 by sebastian nordgren in ue5-main branch]
2021-01-26 11:51:28 -04:00
sebastian nordgren
6fe795953f Initial submit of the new JSON-based editor config system. This consists of two layers - the JSON config system enables access to JSON objects through the use of JSON paths of the form $.Object.Array[3].Member. The editor config system applies this system to UObjects and UStructs.
#rb chris.gagnon
#jira UETOOL-2769

[CL 15208207 by sebastian nordgren in ue5-main branch]
2021-01-26 11:48:50 -04:00