Commit Graph

8 Commits

Author SHA1 Message Date
sebastian nordgren
73e62b9ef3 JsonConfig shared pointers are now passed by const&.
Added tests for EditorConfig.

#review-20127432 @aditya.ravichandran, @lauren.barnes
#preflight 628764ef2c34da686ac74123
#rnx

[CL 20292425 by sebastian nordgren in ue5-main branch]
2022-05-20 06:20:33 -04:00
sebastian nordgren
8eafe4f70e Editor configs now correctly diff against the CDO when serializing.
Previously, I had assumed that FProperty::InitializeValue() would initialize a simple member (eg. a float) to the correct value, but this appears not to be the case, rather values are zero-initialized and the CDO stores the correct default values. In the case of structs, InitializeStruct() does in fact initialize correctly.

However, this means that we can't use GetMutableDefault() to get an instance of the UObject, since then we're changing what we're diffing against and serialize no values. Changed the usages of this pattern to use singletons instead.

#jira UE-141150
#review-19900014 @lauren.barnes, @aditya.ravichandran
#preflight 6267fa44a021c91a50f26a65

[CL 19919719 by sebastian nordgren in ue5-main branch]
2022-04-26 10:20:56 -04:00
lauren barnes
04f2e6cd99 Adding init values to FEditorConfigTestKeyStruct and FEditorConfigTestStruct
#jira UE-110790
#rb trivial
[FYI] Sebastian.Nordgren
#pf 60622a2125b98e00011377ed

#ROBOMERGE-SOURCE: CL 15854920 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)

[CL 15857226 by lauren barnes in ue5-main branch]
2021-03-29 20:49:29 -04:00
sebastian nordgren
1b2a1ceacb Added some includes to fix non-unity compile issues.
#jira UE-107391
#rb trivial

#ROBOMERGE-SOURCE: CL 15311900 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15311992 by sebastian nordgren in ue5-main branch]
2021-02-04 05:47:39 -04:00
Zousar Shaker
3b4c8fc1c5 Automated wrapped object pointer upgrade for Engine + ShooterGame + ShooterGame referenced plugins
#rb none

[CL 15224650 by Zousar Shaker in ue5-main branch]
2021-01-27 17:40:25 -04:00
sebastian nordgren
9950d61b10 Removed a dangling PRAGMA_ENABLE_OPTIMIZATION. Added copyright notice.
#rb trivial
#jira UE-107301
#jira UE-107312

[CL 15218462 by sebastian nordgren in ue5-main branch]
2021-01-27 13:21:35 -04:00
sebastian nordgren
4d09b44a23 Fixes for CIS errors.
#rb trivial

[CL 15208897 by sebastian nordgren in ue5-main branch]
2021-01-26 12:58:58 -04:00
sebastian nordgren
6fe795953f Initial submit of the new JSON-based editor config system. This consists of two layers - the JSON config system enables access to JSON objects through the use of JSON paths of the form $.Object.Array[3].Member. The editor config system applies this system to UObjects and UStructs.
#rb chris.gagnon
#jira UETOOL-2769

[CL 15208207 by sebastian nordgren in ue5-main branch]
2021-01-26 11:48:50 -04:00