Commit Graph

199 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
jason stasik
3ce9c775a2 Allow separate permission lists for viewing and creating assets
#rb rex.hill
#preflight 62574684667d4516642224fa

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19760664 via CL 19762141 via CL 19762160 via CL 19762168
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19802156 by jason stasik in ue5-main branch]
2022-04-18 23:31:34 -04:00
Patrick Enfedaque
d31019c9e9 - FLinkerInstancingContext: Add Tag support
- Use FLinkerInstancingContext Tag to load all external actors instead of using a global map

#rb richard.malo, jeanfrancois.dube, francis.hurteau
#preflight 624aea29c51908059ae6b82f
#rnx

[CL 19607995 by Patrick Enfedaque in ue5-main branch]
2022-04-04 09:31:43 -04:00
Patrick Laflamme
4d73fc9ae4 Fixed Python file being filtered out by the Content Browser.
- The OnShouldFilterAsset is not a legacy delegate binding, but the one added when the ContentBrowser was decoupled from the AssetRegistry. So it should not be used to set bHasLegacyDelegateBindings.

#jira UE-145569 - Can't see python and execute scripts from the content browser
#rb Jamie.Dale, Scott.Nelson
#preflight 62333120fc4d442f89842a06

[CL 19419791 by Patrick Laflamme in ue5-main branch]
2022-03-17 09:11:01 -04:00
scott nelson
66d040f74f Add OnShouldFilterItem delegate to SAssetView
#preflight 621e95b3e15c51d8c5dae7e0
#rb Rex.Hill

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19211175 via CL 19214799 via CL 19216582 via CL 19216684 via CL 19216697
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19225339 by scott nelson in ue5-main branch]
2022-03-02 14:02:23 -05:00
jamie dale
bdb944808c Fixed quick jump extending the selection rather than setting it
#jira UE-139157
[FYI] zach.rammell
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 19063361 via CL 19063363 via CL 19075490 via CL 19077155 via CL 19078951
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19122686 by jamie dale in ue5-main branch]
2022-02-24 15:00:36 -05:00
zach rammell
35b8c062d5 Fix for content browser quick jump expanding selection
#jira UE-139157
#rb none
#preflight 620d519be06ffdf305e5f2d2

#ROBOMERGE-AUTHOR: zach.rammell
#ROBOMERGE-SOURCE: CL 19022819 via CL 19023039 via CL 19023259 via CL 19031937
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v917-18934589)

[CL 19032167 by zach rammell in ue5-main branch]
2022-02-17 03:42:57 -05:00
zach rammell
18ac669b42 Asset View: Quick jumping now affects navigation selection
Previously, quick jumping would not properly move the selection, making it so that navigation after jumping would ignore the jump.

#jira UE-139157
#rb Patrick.Laflamme
#preflight 6204396cbf7362cd77f98d91

#ROBOMERGE-AUTHOR: zach.rammell
#ROBOMERGE-SOURCE: CL 18929685 via CL 18929752 via CL 18929770 via CL 18930108 via CL 18930394
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18930400 by zach rammell in ue5-main branch]
2022-02-09 20:52:09 -05:00
patrick enfedaque
e53cc4aa19 ContentBrowser: Better support for Delete/Copy/Rename operations on World Partition worlds
- FScopedLoadAllExternalObjects object that can be used to force the loading of all external actors of a WP world to allow those operations to succeed. (for larger worlds commandlet should be used)
- ContentBrowser operation like: Delete, Duplicate, Rename, Move, Copy use this new scope
- World Partition worlds are no longer loaded on right-click context menu.
- Note: change was done with explicit scopes to only address specific use cases and limit the impact of this CL. It could become a default behavior in later versions.

#jira UE-140032, UE-114002

#rb richard.malo, jeanfrancois.dube, rex.hill
#preflight 61f2b479800734b52da816b4

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 18753910 in //UE5/Release-5.0/... via CL 18753926 via CL 18756993
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18757308 by patrick enfedaque in ue5-main branch]
2022-01-27 14:11:04 -05:00
jamie dale
99c15dbf3e Amortize user searching in the content browser
This avoids part of the hitch when searching the CB in large projects, as while the initial backend hitch (to show all content) remains, the frontend filtering is now amortized so the editor remains responsive as you type out your search query. The CB shows a little progress bar above the asset view while the search is running.

#jira
#rb Rex.Hill, Lauren.Barnes
#preflight 61e05ebc250b9537f77918fe

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18600367 via CL 18603781 via CL 18603885 via CL 18603962 via CL 18614021 via CL 18614086 via CL 18614115
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18614137 by jamie dale in ue5-main branch]
2022-01-13 22:33:30 -05:00
julien stjean
302f52ee97 Changed a check to a ensure to avoid crashing in a bad scenario where an asset creation would be requested while a another is active still active.
Added a line of log to help us track the potential cause of the issue.

#jira UE-104471
#preflight 61a8db639c77d610079f42ab

#ROBOMERGE-AUTHOR: julien.stjean
#ROBOMERGE-SOURCE: CL 18352172 in //UE5/Release-5.0/... via CL 18352195
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18352205 by julien stjean in ue5-release-engine-test branch]
2021-12-02 10:20:12 -05:00
aditya ravichandran
e9688809f4 Asset Picker: Fix an issue preventing some options in the Asset Picker from working when summoned from a menu
#jira UE-108063
#rb lauren.barnes
#preflight 619e6b88801b361978c8f58a

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 18285239 in //UE5/Release-5.0/... via CL 18285248
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18285253 by aditya ravichandran in ue5-release-engine-test branch]
2021-11-24 12:19:18 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
daren cheng
45625f4109 Performance improvements to widget library.
Add callback for source data generation to asset views.
Add UObject enumeration to content browser API (By Rex Hill).
Intentionally reserve thumbnail pool sizes instead of flat 1024 reservation.

#jira UE-129795
#rb Rex.Hill
#preflight 615e0c51c5e9590001f4a22a
#preflight 615e4400f13022000126efda

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 17744889 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v879-17706426)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0
#ROBOMERGE[bot1]: Main

[CL 17744914 by daren cheng in ue5-release-engine-test branch]
2021-10-06 21:35:45 -04:00
aditya ravichandran
77f084d116 Scroll Bars now highlight when hovering anywhere along the slider well
Moved Show Empty Folders to the top level in Content Browser Settings
Replaced the icon for SingleFrameAdvance in the play control toolbar buttons
#jira UETOOL-3815
#rb steven.dao
#preflight 613a53e90c19af0001c4f0ad

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 17475265 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17475269 by aditya ravichandran in ue5-release-engine-test branch]
2021-09-09 15:19:23 -04:00
matt kuhlenschmidt
5d10725c0c Fix up use cases of specifying "PrimaryButton" style directly. Replaced instances with SPrimaryButton
#pf https://horde.devtools.epicgames.com/job/612d40b9423a8f00013c5b92

#ROBOMERGE-AUTHOR: matt.kuhlenschmidt
#ROBOMERGE-SOURCE: CL 17457077 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17457092 by matt kuhlenschmidt in ue5-release-engine-test branch]
2021-09-08 08:29:49 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
daren cheng
1feccb8ad3 Enable widget library by default.
---
Add size & type display options to SAssetView constructor / interface.
Implement search & centralized list / column / size control on widget library.

#jira UE-121731
#rb Julien.StJean, Vincent.Gauthier
#preflight 611d61c88ff554000152647e

#ROBOMERGE-SOURCE: CL 17234350 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17234363 by daren cheng in ue5-release-engine-test branch]
2021-08-19 11:04:54 -04:00
aurel cordonnier
dc4bf61540 Merge from Release-Engine-Staging @ 17030559 to Release-Engine-Test
This represents UE4/Main @ 17030256 and Dev-PerfTest @ 17030553

[CL 17031509 by aurel cordonnier in ue5-release-engine-test branch]
2021-08-03 11:56:47 -04:00
steven dao
fab60388a6 Re-add adjusting Content Browser thumbnail size via ctrl+mouse scroll wheel
This previously worked in UE4, then was removed when the thumbnail size selector was changed from a continuous slider to discrete predefined options.

#jira UETOOL-3281
#rb lauren.barnes
#preflight 6101beabb4288d0001b7a6e0

#ROBOMERGE-SOURCE: CL 16988630 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)

[CL 16988669 by steven dao in ue5-release-engine-test branch]
2021-07-28 18:02:38 -04:00
Jamie Dale
3649fdd9e3 Suppress Tick from modal dialogs during rename finalization in the Content Browser
This can cause a reentrancy issue where the item currently being renamed is removed via an update while we're still processing it

#rb Francis.Hurteau

[CL 16412079 by Jamie Dale in ue5-main branch]
2021-05-20 18:56:49 -04:00
aurel cordonnier
50944fd712 Merge UE5/RES @ 16162155 to UE5/Main
This represents UE4/Main @ 16130047 and Dev-PerfTest @ 16126156

[CL 16163576 by aurel cordonnier in ue5-main branch]
2021-04-29 19:32:06 -04:00