Commit Graph

720 Commits

Author SHA1 Message Date
aditya ravichandran
29e05ea283 Fix a bug with the animation browser where sound assets would always show up.
SFilterList: Use the AddFilter() function to add extra filters to make sure the activation helper gets bound and inverse filters are handled properly.

#jira UE-154474
#preflight 6296225bfe779f23c8e3c9c7
#rb lauren.barnes

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20437413 via CL 20438847 via CL 20439153 via CL 20439227
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448728 by aditya ravichandran in ue5-main branch]
2022-06-01 03:56:36 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
paul chipchase
d47a75be71 Restore the 'virtualized data' filter that was removed in CL 20340436
#rb aditya.ravichandran
#rnx
#preflight 628e2d4beb57f851e2261683

[CL 20363963 by paul chipchase in ue5-main branch]
2022-05-25 09:59:13 -04:00
bob tellez
c24eefba8a FilterBar: Fix deprecation warnings when including AssetFilter.h
#preflight skip
#rb trivial

#ROBOMERGE-OWNER: bob.tellez
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20339304 via CL 20339470 via CL 20339741 via CL 20339759
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20341215 by bob tellez in ue5-main branch]
2022-05-23 19:09:18 -04:00
aditya ravichandran
53360c9ff0 Refactor SFilterList in the Content Browser into more globally usable Filter Widgets
SBasicFilterBar in ToolWidgets is the most generic filter bar, usable in non editor buillds as well
SAssetFilterBar in EditorWidgets is a complex filter bar with support for the built in asset filters from the content browser
SFilterBar in EditorWidgets is the most convinient filter bar to use in editor if you want asset filters and custom filters

#jira UE-151904
#rbJulien.StJean, jamie.dale
#preflight 628ba0da693c5e1de27cbc30

#ROBOMERGE-OWNER: aditya.ravichandran
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20330320 via CL 20337158 via CL 20338269 via CL 20338595
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20340436 by aditya ravichandran in ue5-main branch]
2022-05-23 18:18:06 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
scott nelson
68b08f6fbe [VK] Update UX to toggle Public/Private asset state to use radio buttons
#rb Jason.Stasik
#preflight 625f0016d412434587ffc000

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19818081 via CL 19821452 via CL 19822253 via CL 19822529
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19827855 by scott nelson in ue5-main branch]
2022-04-20 08:20:21 -04:00
zach rammell
f62da3bef9 Fix content browser doing partial deselections on syncing selection set
#jira UE-136475
#rb brooke.hubert
#preflight 625db144804460ab0fd82312

#ROBOMERGE-AUTHOR: zach.rammell
#ROBOMERGE-SOURCE: CL 19793080 via CL 19793245 via CL 19793663
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19809626 by zach rammell in ue5-main branch]
2022-04-19 11:36:18 -04:00
jason stasik
3ce9c775a2 Allow separate permission lists for viewing and creating assets
#rb rex.hill
#preflight 62574684667d4516642224fa

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 19760664 via CL 19762141 via CL 19762160 via CL 19762168
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19802156 by jason stasik in ue5-main branch]
2022-04-18 23:31:34 -04:00
aditya ravichandran
9b01ff613f SContentBrowser: Fix missing icon causing warning in Lyra
#jira UE-148280
#rb trivial
#preflight 624ee877c64cf034f4cdd6ce

[CL 19668175 by aditya ravichandran in ue5-main branch]
2022-04-07 09:51:58 -04:00
Patrick Enfedaque
d31019c9e9 - FLinkerInstancingContext: Add Tag support
- Use FLinkerInstancingContext Tag to load all external actors instead of using a global map

#rb richard.malo, jeanfrancois.dube, francis.hurteau
#preflight 624aea29c51908059ae6b82f
#rnx

[CL 19607995 by Patrick Enfedaque in ue5-main branch]
2022-04-04 09:31:43 -04:00
scott nelson
d66e31243a Setup delegate to dirty cache of Private Content Folder List when it's edited
#preflight 6243218873665f7d5e31ce98
#rb Rex.Hill

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19544776 via CL 19545477 via CL 19545511 via CL 19545538
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19547100 by scott nelson in ue5-main branch]
2022-03-29 15:08:58 -04:00
scott nelson
a35dcfe58b Dirty folder paths showing Private Content when All/ folder is hidden
[FYI] Rex.Hill
#rb Jason.Stasik
#preflight 62421f3c470aff98e94617b8

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19534459 via CL 19534474 via CL 19534482 via CL 19534492
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19535470 by scott nelson in ue5-main branch]
2022-03-28 19:37:57 -04:00
aditya ravichandran
5f6031e5a2 Content Browser: Filter checkboxes now show indeterminate state when some sub-menu items are disabled
#jira UE-146838
#rb louise.rasmussen
#preflight 623cc93c410b5c4a7526fa3e

[CL 19501710 by aditya ravichandran in ue5-main branch]
2022-03-24 15:56:28 -04:00
Patrick Laflamme
4d73fc9ae4 Fixed Python file being filtered out by the Content Browser.
- The OnShouldFilterAsset is not a legacy delegate binding, but the one added when the ContentBrowser was decoupled from the AssetRegistry. So it should not be used to set bHasLegacyDelegateBindings.

#jira UE-145569 - Can't see python and execute scripts from the content browser
#rb Jamie.Dale, Scott.Nelson
#preflight 62333120fc4d442f89842a06

[CL 19419791 by Patrick Laflamme in ue5-main branch]
2022-03-17 09:11:01 -04:00
rex hill
e9da6f48ca Content Browser: Deactivate Add and Import buttons in content browser when path selected does not support those features (virtual paths such as /All)
#preflight 6227f184695c94f981bc741a
#rb jamie.dale

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 19322495 via CL 19339234 via CL 19344449 via CL 19350377 via CL 19350529
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19351705 by rex hill in ue5-main branch]
2022-03-11 03:58:36 -05:00
rex hill
9252795bd8 ContentBrowser: Fix not being able to hide favorites
#jira UE-144894
#preflight skip

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 19275120 via CL 19278999 via CL 19294653 via CL 19297443 via CL 19297550
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19345717 by rex hill in ue5-main branch]
2022-03-10 19:54:37 -05:00
aditya ravichandran
54b09af1e6 Content Browser: Unlock a Browser on closing its tab, and add a toast for when all browsers are locked and the user tries to summon one
#jira UE-143981
#rb lauren.barnes
#preflight 622125734e07145cce56d399

[CL 19252415 by aditya ravichandran in ue5-main branch]
2022-03-03 15:44:38 -05:00
scott nelson
176e8c30df Fix issue with multi select in Content Browser when toggling Private Public state of an asset
- Added in bulk set Public set Private when more than one asset is selected in the Content Browser
- Additionally added in caching mechanism for selected file Public asset editability

#preflight 621fca28e15c51d8c50a90bf
#rb Rex.Hill

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19230234 via CL 19235956 via CL 19238861 via CL 19238938 via CL 19245822
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19247030 by scott nelson in ue5-main branch]
2022-03-03 13:14:36 -05:00
rex hill
fece0f140f Phase 2 Public Assets
- Added ability to toggle Private Content Edit mode at Folder level in Content Browser
- You cannot edit an asset's Private/Public state unless it's within a Private Content Editable folder
- Private Assets do not show up unless their within a Private Content Editable folder

#preflight 621fbc63e15c51d8c509559d
#rb Rex.Hill

#ROBOMERGE-OWNER: rex.hill
#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19226371 via CL 19235626 via CL 19238850 via CL 19238931 via CL 19245779
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19247024 by rex hill in ue5-main branch]
2022-03-03 13:14:11 -05:00
scott nelson
0b6149cf4c Updated font and padding for Public Asset tooltip UI
#preflight 621e9a413e14f0c7e5540913
#rb Rex.Hill

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19224985 via CL 19228155 via CL 19237761 via CL 19237938 via CL 19238473
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19239361 by scott nelson in ue5-main branch]
2022-03-03 01:27:18 -05:00
scott nelson
66d040f74f Add OnShouldFilterItem delegate to SAssetView
#preflight 621e95b3e15c51d8c5dae7e0
#rb Rex.Hill

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 19211175 via CL 19214799 via CL 19216582 via CL 19216684 via CL 19216697
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19225339 by scott nelson in ue5-main branch]
2022-03-02 14:02:23 -05:00
aditya ravichandran
3df03cfc05 Content Browser: Added functionality to summon other Content Browsers by right clicking on the tab
#rb lauren.barnes
#preflight 62193918783beeaf8a0d8e4b

[CL 19155132 by aditya ravichandran in ue5-main branch]
2022-02-25 15:32:07 -05:00
jamie dale
bdb944808c Fixed quick jump extending the selection rather than setting it
#jira UE-139157
[FYI] zach.rammell
#rnx

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 19063361 via CL 19063363 via CL 19075490 via CL 19077155 via CL 19078951
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19122686 by jamie dale in ue5-main branch]
2022-02-24 15:00:36 -05:00