Commit Graph

22 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
sebastian nordgren
57e39f65fa Scripted Asset Actions now work with collection parameters.
CPF_Parm was not being applied to child properties (ie. items in the array), and the IsPropertyVisible delegate wasn't checking parent properties for the flag, which was causing only the root to be visible. This is a result of a change made to the details view to run the IsPropertyVisible delegate more frequently - previously it was only run when initializing the property tree.

#jira UE-148027
#review-20008735 @jurre.debaare, @lauren.barnes
#preflight 6270dd90ae03caabf7103e9e

[CL 20023534 by sebastian nordgren in ue5-main branch]
2022-05-03 07:47:41 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
marc audy
cff01aa9fa Added support for native FProperty setters and getters.
Setters and getters are native functions called by FProperties when setting property values with *_InContainer functions.
Setters and getter function names can be manually specified with Setter = Func and Getter = Func keywords inside of UPROEPRTY macro but they will also be automatically parsed if the name is not explicitly specified if the setter or getter function name matches SetPropertyName and GetPropertyName pattern.
The latter behavior can be disabled in UHT's DefaultEngine.ini by setting AutomaticSettersAndGetters=False.
ImportText and ExportTextItem functions have been deprecated and should be replaced with *_InContainer or *_Direct variants.

#rb Steve.Robb
#preflight 6210a377a83e0bcefd03d9e1

#ROBOMERGE-OWNER: marc.audy
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 19070318 via CL 19098059 via CL 19104650 via CL 19104661 via CL 19110012
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19147839 by marc audy in ue5-main branch]
2022-02-25 10:39:39 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
jamie dale
107f7b0f0c Audited use of FDetailsViewArgs::ObjectsUseNameArea
CL# 15481362 changed the behavior of ObjectsUseNameArea so that the object name was visible, and upon auditing the current use of ObjectsUseNameArea it was found that all but a few cases likely intended to use HideNameArea instead.

Breaking: This change also renames FDetailsViewArgs::bShowActorLabel to FDetailsViewArgs::bShowObjectLabel to reflect what it actually does.

#rb Brooke.Hubert

#ROBOMERGE-SOURCE: CL 15496125 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15496134 by jamie dale in ue5-main branch]
2021-02-22 19:45:57 -04:00
Zousar Shaker
ab3554e509 Finding and addressing codepaths that check property type by explicitly checking equality with FObjectProperty::StaticClass() or FClassProperty::StaticClass(). Changing them to instead use CastField<FObjectProperty> (which will generically handle both FObjectProperty, FClassProperty, and any of their derivatives). Could be further genericized in the future to use FObjectPropertyBase, but don't want to add more risk by introducing that at this point.
Confirmed that now System.Core.Serialization.StructElementSerializer and System.Core.Serialization.StructSerializer unit tests are passing.

#rb francis.hurteau

[CL 15294198 by Zousar Shaker in ue5-main branch]
2021-02-03 12:08:22 -04:00
Jurre deBaare
dc93250453 Asset/actor action utilities improvements:
1. Added ability to define utilities natively, or in Python (UClasses are now harvested alongside blueprint assets)
2. Functions are now grouped according to their category and placed in a submenu
3. Added ability to automatically forward the object selection to the first parameter of the function. (AActor and FAssetData) Only sub-set of the selection that passes SupportedClass is forwarded.
#rb Lauren.Barnes
#jira UE-101204, UE-101203, UE-101202

[CL 14500269 by Jurre deBaare in ue5-main branch]
2020-10-15 05:35:34 -04:00
ryan durand
627baf970a Updating copyright for Engine Editor.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869241 via CL 10869527 via CL 10869904
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870586 by ryan durand in Main branch]
2019-12-26 15:33:43 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
Chris Gagnon
2e87118a18 Copying //UE4/Dev-Editor to Dev-Main (//UE4/Dev-Main) Interim 4.24.
#rb none

[CL 8614014 by Chris Gagnon in Main branch]
2019-09-10 11:35:20 -04:00
lauren ridge
0bf7f28cc7 Blutility updates to add more generic base classes and libraries for editor scripting
#rb Chris.Gagnon
#rnx


#ROBOMERGE-SOURCE: CL 5808467 via CL 5811585

[CL 5811826 by lauren ridge in Main branch]
2019-04-09 16:17:53 -04:00
Chris Gagnon
0dbe1f7fb2 Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
#rb none

[CL 4766091 by Chris Gagnon in Dev-Editor branch]
2019-01-21 17:47:02 -05:00
Marc Audy
1e8b20c2c2 (4.21.2) Prevent Blutility object from being destroyed by GC while script are executing
#jira UE-61971
#jira UE-68108
#rb Phillip.Kavan
#rnx

[CL 4692853 by Marc Audy in Dev-Framework branch]
2019-01-09 11:50:30 -05:00
Chris Gagnon
8fc25ea18e Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
#rb none

[CL 4676797 by Chris Gagnon in Dev-Editor branch]
2019-01-02 14:54:39 -05:00
Marc Audy
608734e30d Merging //UE4/Dev-Main to Dev-Framework (//UE4/Dev-Framework) @ 4664414
#rb
#rnx

[CL 4666113 by Marc Audy in Dev-Framework branch]
2018-12-17 12:24:20 -05:00
Matt Kuhlenschmidt
cde8160913 Merging //UE4/Dev-Main to Dev-Editor (//UE4/Dev-Editor)
#rb none

[CL 4572510 by Matt Kuhlenschmidt in Dev-Editor branch]
2018-11-16 11:15:08 -05:00
Ben Marsh
ea340d3fbf Copying //UE4/Fortnite-Staging to Dev-Main (//UE4/Dev-Main)
#rb none
#lockdown Nick.Penwarden

[CL 4567513 by Ben Marsh in Main branch]
2018-11-14 19:05:13 -05:00
Thomas Sarkanen
d390d676dc Fix additional params being displayed on blutility asset/actor actions dialog
#jira UE-62063 - Blutility context menu popup shows all pins inside function
#rb Jurre.deBaare

[CL 4322333 by Thomas Sarkanen in Dev-Anim branch]
2018-08-28 11:18:46 -04:00
Dan Oconnor
2c80e4ea2e Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 4006870)
#lockdown Nick.Penwarden
#rb None
#rnx

============================
  MAJOR FEATURES & CHANGES
============================

Change 3967603 by Marc.Audy

	Fix force feedback events being played on the correct controller if the OffsetPlayerGamepadIds feature is in use
	#jira UE-56077

Change 3969399 by Phillip.Kavan

	Partially fix runtime failures for converted circular dependency test actors in a nativized QAGame.

	#jira UE-56287

Change 3970181 by Phillip.Kavan

	Improved handling of circular dependencies during Blueprint nativization between converted and unconverted assets.

	Change summary:
	- Removed FGatherConvertedClassDependencies::MarkUnconvertedClassAsNecessary(); no longer in use.
	- Modified FFindAssetsToInclude::MaybeIncludeObjectAsDependency() to remove the case that was marking assets for stub class generation; no longer needed.
	- Modified FBlueprintNativeCodeGenModule::IsTargetedForReplacement() to detect, report on and handle circular references between converted and unconverted assets (ensuring that both sides are converted).

	#jira UE-56292

Change 3970185 by Phillip.Kavan

	Fix initialization of special UMG struct types in nativized Blueprint ctor code.

	Change summary:
	- Modified FBackendHelperUMG::SpecialStructureConstructorUMG() to emit the proper constructor call based on the value of the 'ForcedTime' field. Also modified to emit updated constructor code for the FMovieSceneSegment struct's 'Range' member, which is now a TRange<> type.
	- Fixed a typo in the TBaseStructure<FInt32Range> case in FEmitDefaultValueHelper::SpecialStructureConstructor().

	#jira UE-56487

Change 3971520 by mason.seay

	Adjusted widget anchor to fix screen positioning

Change 3972611 by Mieszko.Zielinski

	Fixed some of the vislogger macros using old 'Actor' rather than new 'LogOwner' parameter #UE4

	#jira UE-56978

Change 3973564 by Phillip.Kavan

	Fix missing dependency on linker response file. Prevents target being relinked when build environment changes.

	- Mirrored from //UE4/Dev-Core (3973331).

	#jira UE-56277

Change 3974308 by Phillip.Kavan

	Fix crash when choosing to delete multiple bookmarks selected in the Bookmarks tree view.

	Change summary:
	- Modified SBlueprintBookmarks::OnDeleteSelectedTreeViewItems() to make a local copy of the reference to the entry in the source array.
	- Modified FBlueprintEditor::RemoveBookmark() to save local config settings *after* modifying the persistent Bookmarks array (it was previously happening before).

	#jira UE-55598

Change 3975506 by Mason.Seay

	Code and blueprints for subobject testing

Change 3977558 by Mason.Seay

	Checking in missed header file

Change 3978137 by Ben.Zeigler

	#jira UE-57154 Fix crash where component instance data cache would duplicate external objects during the null component pre serialize

Change 3978326 by Ben.Zeigler

	#jira UE-57062 Only look for class redirects for soft object paths if the string starts with /script, some of the class redirect match strings are overly broad and were catching assets

Change 3978393 by Ben.Zeigler

	Fix FAssetData::IsUAsset comment to match what it actually does, old comment implied it was false for maps which is wrong

Change 3978837 by Marc.Audy

	Make GetAutoEmitTermParameters and IsAutoCreateRefTerm static and optimize both

Change 3978838 by Marc.Audy

	(4.19.1) PR #4480: Crash fix trying to open the console command on Windows (Contributed by bakjos)
	#jira UE-54908
	#jira UE-54215

Change 3979156 by Marc.Audy

	PR #4615: Update WindDirectionalSourceComponent.h (Contributed by c4tnt)
	#jira UE-57071

Change 3982289 by Ben.Zeigler

	Fix several issues with unloaded blueprints and the class picker/viewer
	#jira UE-53646 Reimplement CR #4369 so setting a Class blueprint variable to a blueprint class will correctly allow unloaded blueprint children to be selected in the picker
	Added FName defines to FBlueprintTags for the asset registry tags used for unloaded blueprints, and removed the ParentClassPackage tag as it was redundant with ParentClass
	Fixed it so Soft Class Reference properties can be set back to none with the picker
	Removed FUnloadedClassDragDropOp as it did not work correctly and replaced uses with FAssetDragDrop, which was already used for content browser drags
	Changed internals of class viewer to properly store and use the paths to the actual generated class

Change 3982684 by Ben.Zeigler

	Add DevelopmentAlwaysCook setting to the asset manager cook rule, this works like AlwaysCook in development and like NeverCook in production. DevelopmentCook works like Unknown in development

Change 3982762 by Mieszko.Zielinski

	PR #4614: Fix UBTTask_RotateToFaceBBEntry when trying to face a position where i. (Contributed by Goutye)

	I've improved the original PR by relaxing condition constraints, and removing some unnecessary vector normalization (since FVecotr::CosineAngle2D normalizes the input parameters anyway).


	#jira UE-57070

Change 3982866 by Marc.Audy

	Defer Destroying an Actor if it is in the process of beginning play
	#jira UE-57091

Change 3982965 by Mieszko.Zielinski

	PR #3567: add API declarations to BlueprintNodeHelpers (Contributed by kayama-shift)


Change 3987399 by Dan.Oconnor

	Remove unused ReloadObjectArc and unimplemented ArchiveReplaceArchetype

	#jira None

Change 3987956 by Mieszko.Zielinski

	Fixed inconsistincies in BT category naming in BP #UE4

	#jira UE-57262

Change 3988308 by Mieszko.Zielinski

	Fixed 'navmesh needs to be rebuild' displaying even after navigation building with navmesh auto building disabled #UE4

	#jira UE-57286

Change 3989309 by Mieszko.Zielinski

	A support AI pluggin that links the aimodules #UE4

Change 3989311 by Mieszko.Zielinski

	Moved the HTNPlanner plugin into the newly created Plugins/AI subfolder #UE4

Change 3989506 by mason.seay

	WIP Navigation Test Map

Change 3990826 by Phillip.Kavan

	Fix existing placements of nativized Blueprint actors with a nonzero (legacy) root component scene transform at the CDO level.

	This corrects a long-standing issue that was introduced back in 2947488.

	Change summary:
	- Modified AActor::PostSpawnInitialize() to zero out RelativeLocation and RelativeRotation when spawning actors with a native scene root inherited from a converted Blueprint class.
	- Modified FNonativeComponentData to remove the HandledAsSpecialProperty() override for skipping the RelativeLocation and RelativeRotation properties on root components when emitting code to initialize the CDO for a converted Actor BP with a non-native root component.

	#jira UE-50452

Change 3993174 by mason.seay

	Cleared out unnecessary BP logic

Change 3994370 by Ben.Zeigler

	Remove manual AI includes, the AI support plugin correctly pulls in those references now

Change 3995399 by Marc.Audy

	When destroying the world clear out level collections
	#jira UE-57257

Change 3995731 by Marc.Audy

	Fix UEngine::CommitMapChange issues with new streaming level state machine
	* Level needs to be added to array before determining current state
	* Should be adding, not setting streaming levels from fake world

	#jira UE-57424

Change 3996917 by Ben.Zeigler

	ObjectWriter should not reset the soft object weak pointer, it should be a const operation

Change 3996921 by Ben.Zeigler

	#jira UE-57288 Improve ensures for invalid primary asset types, it only complains if type is set and gives a better error

Change 3997164 by Dan.Oconnor

	Don't purge classes until they are recompiled and relink all child classes immediately after a blueprint generated class has changed. This allows iterative compilation logic to behave as it did before the compilation manager
	#jira UE-55667

Change 3997674 by paulo.souza

	Reverting camera setup changes from the renaming

Change 3997901 by mason.seay

	Updates to subobject test bp's

Change 3998028 by mason.seay

	Move logic to Event Graph

Change 3998051 by Mason.Seay

	Adding QAGame ClassGroup to actively tested QAGame components for organization

Change 3999438 by Dan.Oconnor

	Fix deterministic cooking issues by avoiding use of MakeUniqueObjectName when instantiating component templates
	#jira FORT-81409

Change 4000265 by Mason.Seay

	Checking in QAGame classes again to (hopefully) fix property issues

Change 4000339 by Marc.Audy

	PR #4652: AttachComponent Message Fix (Contributed by nonlin)
	#jira UE-57656

Change 4001338 by Dan.Oconnor

	Fix reinstancing bug introduced in 3591939 which could cause some reinstanced objects to have references within them replaced. If the object in question was an actor it could take ownership of components owned by another actor and destroy them, resulting in a crash when the other actor tried to use its components

	#jira UE-57335

Change 4001400 by Marc.Audy

	Per https://udn.unrealengine.com/questions/407745/childactorcomponent-and-modifications-to-component.html don't redirect or reset loaders when renaming components as part of the component instance data cache.

Change 4001530 by Marc.Audy

	Use a clean default object to calculate the empty archive size.

Change 4002791 by Marc.Audy

	Fix ensure when loading sublevel that has been redirected
	#jira UE-57516

Change 4002812 by mason.seay

	Added BP code to test Watching Sets and Maps

Change 4002947 by mason.seay

	More code for watch values testing

Change 4003059 by paulo.souza

	Fixes to volumetric lighting and sphere capture bakes

Change 4003509 by Dan.Oconnor

	Reset bIsFakingTouched and bIsGameFakingTouch when the game viewport is unregistered. This prevents the PIE session from tainting editor session behavior when UInputSettings::bUseMouseForTouch is set
	#jira UE-57724

Change 4005596 by Phillip.Kavan

	Fix random crashes when running multiple global blueprint search tabs in parallel just after editor launch.

	Change summary:
	- Refactored global FiB APIs to use thread-safe shared pointer types when referencing imaginary Blueprint data, which is a shared resource.
	- Modified FFindInBlueprintSearchManager::ContinueSearchQuery() to ensure that parsing imaginary Blueprint data only happens on a single thread.

	#jira UE-57046

Change 4005657 by Dan.Oconnor

	Don't attach OldRoot component if it's not outered to the current actor
	#jira UE-55300

Change 4005709 by Phillip.Kavan

	Ensure rather than assert on failed child promotion when destroying a non-root scene component within an Actor's scene component hierarchy.

	#jira UE-52921

Change 4005825 by paulo.souza

	New camera angle + touch rotation tests + "Action RPG" logos

Change 4006058 by Sam.Deiter

	Removing this as it is not needed.

Change 3980745 by Marc.Audy

	Apply CL# 3977198 from Dev-Core
	#author Ben.Marsh
	Remove INI file override for editor stack size on Windows. This is rarely valid since editor targets share build products with other games by deafult. Fix to add linker response file as prerequisite exposed targets overriding this as a bug.

[CL 4006923 by Dan Oconnor in Main branch]
2018-04-16 20:19:04 -04:00
Marc Audy
7a0f229e8d Copying //UE4/Fortnite-Staging to //UE4/Dev-Main (Source: //Fortnite/Main/Engine @ 3876564)
#lockdown Nick.Penwarden
#rnx
#rb none

[CL 3903710 by Marc Audy in Main branch]
2018-02-22 11:25:06 -05:00