Commit Graph

15 Commits

Author SHA1 Message Date
dave jones2
ed1b4ed6a5 UE-140327 - Remove ENABLE_BLUEPRINT_REAL_NUMBERS usage
The original ENABLE_BLUEPRINT_REAL_NUMBERS macro was strictly meant for AB testing in the Dev-LWC. Currently, disabling it won't work, and would likely lead to broken behavior. Its presence might incorrectly indicate to licensees that this is an option that can be toggled safely.

#rb marc.audy
#jira UE-140327
#preflight 61fc6449dc0b3ecbecb6f381
#lockdown julien.marchand

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18864654 in //UE5/Release-5.0/... via CL 18864683 via CL 18864993
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18865002 by dave jones2 in ue5-main branch]
2022-02-04 11:54:52 -05:00
dave jones2
c8574d3b74 Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0
Blueprint real number support.

This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures).

One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code.

The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG.

#rb marc.audy (serialization changes)
#jira UE-116484
#preflight 61f8bdd5a2514ba12ff7bdfc

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
ben hoffman
db5e4f9d36 Clean up BP type promotion unit tests to reduce code repetition
#jira none
#rb me
#rnx

[CL 15072671 by ben hoffman in ue5-main branch]
2021-01-13 17:25:57 -04:00
ben hoffman
56fbe1b810 Make the output message on the type promotion test include the pin types for better log output
#jira none
#rb me
#rnx

[CL 14880824 by ben hoffman in ue5-main branch]
2020-12-08 14:49:52 -04:00
ben hoffman
1d21405407 Add type promotion tests for having the correct tolerance pin
#jira none
#rb me
#rnx

[CL 14864616 by ben hoffman in ue5-main branch]
2020-12-05 12:03:00 -04:00
ben hoffman
33abf3b1ba Add another type promotion unit test to check that each primitive type has a correct matching function
#jira none
#rb me
#rnx

[CL 14853924 by ben hoffman in ue5-main branch]
2020-12-04 09:26:40 -04:00
ben hoffman
62fe10c425 Update type promo tests to have more AddPin interface coverage
#jira none
#rb me
#rnx

[CL 14839997 by ben hoffman in ue5-main branch]
2020-12-02 19:08:05 -04:00
ben hoffman
ecb7342a32 Blueprints: Add a type promotion unit test that will cover making connections to the node and allow us to check that things don't disconnect when they shouldn't.
#rb me
#jira none
#rnx

[CL 14829857 by ben hoffman in ue5-main branch]
2020-12-01 14:35:39 -04:00
ben hoffman
31fad7356f Clean up helper methods within the Type Promotion unit tests
#jira none
#rb trivial
#rnx

[CL 14823888 by ben hoffman in ue5-main branch]
2020-11-30 17:44:42 -04:00
ben hoffman
8e40deb646 Blueprints: Remove unused function in type promotion. We use FindBestMatchingFunc now isntead of GetOperatorFunction
#jira none
#rb me
#rnx

[CL 14755891 by ben hoffman in ue5-main branch]
2020-11-16 13:05:02 -04:00
ben hoffman
13aa56ac3c Blueprints: Change the Type Promotion test to not be a smoke test, but an engine test. Add the vector pin type to the promotion unit tests.
#jira none
#rb me
#rnx

[CL 14677117 by ben hoffman in ue5-main branch]
2020-11-06 11:31:15 -04:00
ben hoffman
2bf406fc20 Blueprints: Add more in depth unit testing for Type Promotion with struct combinations and comparison.
#jira none
#rb me
#rnx

[CL 14525154 by ben hoffman in ue5-main branch]
2020-10-20 13:36:31 -04:00
ben hoffman
33a72be4c4 Blueprints: Add unit test for "FTypePromotino::FindBestMatchingFunc"
#jira none
#rb me
#rnx

[CL 14398238 by ben hoffman in ue5-main branch]
2020-09-25 14:05:34 -04:00
ben hoffman
d757e55259 Blueprints: Type promotion operator table and comparison options. Unit tests for primitive types. Type promotion is disabled by default via the BP.TypePromo.IsEnabled config variable. This allows for two pin types to be compared and determine which is the lower type, so that we can automatically set the type to the higher one when necessary. This will specifically benefit Operators to start (addition, subtraction, greater than, etc).
#jira UE-94217
#rb
#rnx

[CL 14109082 by ben hoffman in ue5-main branch]
2020-08-13 19:05:37 -04:00