Commit Graph

120 Commits

Author SHA1 Message Date
Tim Smith
196d6c5b42 Fix improper extern declaration that caused issues with Clang but not MSVC (Clang was right IMHO)
#rb trivial
#jira UE-111492

[CL 15747765 by Tim Smith in ue5-main branch]
2021-03-19 11:36:00 -04:00
Tim Smith
a2237e050d LiveCoding Re-instancing
LIMITATIONS:

1) Re-instancing will only update UClass instance data.
2) Adding and removing properties should only be done towards the end of a class or structure and can not be followed by complex data types.
3) Adding and removing properties from a base class should not be done if a derived class contains complex data types.

KNOWN ISSUES:

1) Changes to enumerations and structures will not be reflected in existing blueprints.  However, adding new nodes to the blueprint will show the updated enumeration or structure.
2) If a class contains an enumeration or structure as a member, the class will not be re-instanced if enumeration or structure is changed.

CHANGES:

1) LiveCodingServer
1a) Modified to always execute certain static instances during load.
1b) Modified to exclude the _Statics static structures to avoid patching to old copies.

2) Added support for LiveCoding reinstancing
2a) Refactored deferred registration system for UClass, UEnum, and UScriptStruct to use a common system that works for normal game, hot reload and live coding.
2b) Type specific version check data is possible (i.e. enum doesn't have a size)
2c) Single registration static for UClass
2d) Single registration class for all types that is just a blind forward to API.
2e) Static and dynamic registrations use different API entry points to avoid having overloaded argument lists that just apply to one or the other.
2f) Shims for older API

3) New common "Reload" system to avoid using HotReload code.
3a) Support common delegates regardless of who is reloading/reinstancing.
3b) Re-instancing code moved from HotReload to Kismet2 (where the bulk of the re-instance code already existed).
3c) Modified PyWrapper to use new helper class instead of depending on HotRelaod
3d) Added WITH_RELOAD which is defined if HotReload or LiveCoding is enabled.
3e) Modifed existing code to use new #define and delegates.

Robert did the review on the changes covered by Part 2.  Remaining changes are all straightforward.

#rb robert.manuszewski
#jira UE-74493

[CL 15736777 by Tim Smith in ue5-main branch]
2021-03-18 08:13:59 -04:00
Tim Smith
bbe145fc4d Refixing a PVS warning stomped by the integration
#rb trivial
#jira none
#rnx

[CL 15136209 by Tim Smith in ue5-main branch]
2021-01-19 11:40:24 -04:00
Tim Smith
e599eed6a4 Integration of Live++ 1.6.4 (2021/18/01)
This fixes and re-enables a feature of 1.6 that didn't work in an Unreal environment.

#jira none
#rb trivial
#rnx

[CL 15131026 by Tim Smith in ue5-main branch]
2021-01-18 13:02:32 -04:00
Tim Smith
d193b70a3b Fixing PVS 7.7 Issues:
warning V781: The value of the 'XYZ' index is checked after it was used. Perhaps there is a mistake in program logic.

#rb trivial
#jira UE-91644

[CL 15066377 by Tim Smith in ue5-main branch]
2021-01-13 09:08:55 -04:00
Martin Ridgers
51437d6cf8 Fixed static analysis warning. The warning is correct; _setjmp is declared with and without the _Out_ annotation in setjmp.h and intrin.h respectively. It is however, harmless in this instance.
#rb none
#rnx

[CL 14968921 by Martin Ridgers in ue5-main branch]
2020-12-30 11:10:50 -04:00
Tim Smith
76cec15371 Fixing a PVS warning. Changing the code to avoid the + operator since PVS is having issues interpreting the code in this instance.
#rb trivial
#jira UE-104645

[CL 14946615 by Tim Smith in ue5-main branch]
2020-12-17 10:05:33 -04:00
Tim Smith
ca0e8a4101 Fixing a few PVS warning. The memcpy issue is intentional by the 3rd party library.
#rb trivial
#jira UE-104645

[CL 14940455 by Tim Smith in ue5-main branch]
2020-12-16 13:43:24 -04:00
Tim Smith
cae58c2372 Crash fix in LC_ClientStartupThread.cpp. If LPP is initialized but not started, the editor/game/cooker could crash on shutdown.
#rb trivial

[CL 14932140 by Tim Smith in ue5-main branch]
2020-12-15 12:53:25 -04:00
Tim Smith
b48b94b010 Integration of Live++ 1.6.3
#rb none
#rnx

[CL 14926202 by Tim Smith in ue5-main branch]
2020-12-15 09:27:44 -04:00
Marc Audy
ada7c144fa Merge //UE5/Release-Engine-Staging @14903491 to //UE5/Main
[CL 14906022 by Marc Audy in ue5-main branch]
2020-12-11 14:21:20 -04:00
Ben Marsh
e5c1cf2274 Fix static analysis warning.
#rb none
#rnx
#jira UE-87765

[CL 11199518 by Ben Marsh in Main branch]
2020-01-31 15:18:30 -05:00
Ben Marsh
0e6aa011b3 Copying //UE4/Dev-Build @ CL 11166028 to Dev-Main (//UE4/Dev-Main)
#rb none
#rnx

[CL 11166227 by Ben Marsh in Main branch]
2020-01-29 14:48:18 -05:00
graeme thornton
5059d3cb48 Make UAT use a config setting to decide which editor target is the default for use within automation scripts
Have UBT set the source target name as a define during compilation. For unique environments, embed that macro globally, but in shared environments just embed it into game modules.
Have the primary game module bind that define to a core delegate so engine systems can query it
Make LiveCodingModule pass the UBT target name to the UBT so that it doesn't have to guess which target to build
For agnostic executables (UE4Game, UE4Editor)  running content only projects, the delegate won't be bound, so revert back to type based recompile requests in live coding
Handle DTE string for VS2019 in the source code accessor module

#rb ben.marsh


#ROBOMERGE-SOURCE: CL 11103653 via CL 11103654 via CL 11103656
#ROBOMERGE-BOT: (v640-11091645)

[CL 11103658 by graeme thornton in Main branch]
2020-01-24 03:22:33 -05:00
ryan durand
d278f1012f Updating copyright for Engine Developer.
#rnx
#rb none

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902 via CL 10870584
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v613-10869866)

[CL 10871012 by ryan durand in Dev-Build branch]
2019-12-27 01:09:11 -05:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
robert manuszewski
7f79bbd140 Copying //UE4/Dev-Core [at] 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 10708666 in //UE4/Main/...
#ROBOMERGE-BOT: BUILD (Main -> Dev-Build) (v610-10636431)

[CL 10820551 by robert manuszewski in Dev-Build branch]
2019-12-19 14:30:47 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
Ben Marsh
403204ae43 Live Coding: Fix process group names being derived from relative paths, resulting in two workspaces using the same project sharing the same name (causing changes in one project to show up in the other's console window)
#rb none
#rnx

[CL 10608414 by Ben Marsh in Dev-Build branch]
2019-12-07 19:03:02 -05:00
steve robb
14cab21e0c Deprecating ARRAY_COUNT and changing it to UE_ARRAY_COUNT.
Replicated from CL# 7924370.

#rb none


#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 9279060 via CL 9279063
#ROBOMERGE-BOT: (v443-9013191)

[CL 9279836 by steve robb in Main branch]
2019-09-28 08:19:35 -04:00
Ben Marsh
8f8a65e814 LiveCoding: Fix deadlock when using the quick restart functionality, where a patch can be loaded before the module has been registered.
#rb none
#jira UE-79633
#rnx

[CL 8575142 by Ben Marsh in Dev-Build branch]
2019-09-09 14:18:24 -04:00
ben marsh
227ccc472b Fix compile error on Clang due to different behavior in scoping for extern'd variables.
#jira UE-79560


#ROBOMERGE-SOURCE: CL 8376935 via CL 8380487
#ROBOMERGE-BOT: (v402-8361577)

[CL 8380544 by ben marsh in Main branch]
2019-08-29 19:52:45 -04:00
ben marsh
1c50519254 LiveCoding: Add a delegate that's called when a Live Coding patch is applied.
#jira UE-79227
[FYI] Rex.Hill


#ROBOMERGE-SOURCE: CL 8362316 via CL 8362852
#ROBOMERGE-BOT: (v402-8361577)

[CL 8362915 by ben marsh in Main branch]
2019-08-28 12:34:28 -04:00
ben marsh
534d6889d8 LiveCoding: Live Coding cannot be re-enabled after being disabled from the Compile button.
#jira
#rb none
#rnx

#ROBOMERGE-SOURCE: CL 8361959 in //UE4/Release-4.23/...
#ROBOMERGE-BOT: RELEASE (Release-4.23 -> Main) (v402-8361577)

[CL 8361962 by ben marsh in Main branch]
2019-08-28 10:30:23 -04:00
Ben Marsh
f2af127fe7 Fix some compile errors running with /permissive- on Windows.
#rb none
#rnx

[CL 8211779 by Ben Marsh in Main branch]
2019-08-22 10:52:35 -04:00