Commit Graph

573 Commits

Author SHA1 Message Date
lauren barnes
3f374d3e77 Updating style files with new icon paths
#jira UE-154238
#rb trivial
#preflight 6294d02d4c7bcac173d1abf2

#ROBOMERGE-OWNER: lauren.barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20435771 via CL 20436327 via CL 20436365 via CL 20436375
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448577 by lauren barnes in ue5-main branch]
2022-06-01 03:50:29 -04:00
josh adams
46a830d6b4 - Replacing many uses of LoadGlobalIniFile and LoadExternalIniFile with FCOnfigContext
#rb matt.peters
#p4v-preflight-copy 20293528
#preflight 629665d15238916c514359ad

[CL 20441581 by josh adams in ue5-main branch]
2022-05-31 16:25:06 -04:00
ionut matasaru
abf79e101f [Insights]
- Tree Table views: Fixed missing tree items when multiple groupings are added in a generic Tree Table view (like in Memory Insights \ Allocs Table view). Groupings are now recursively applied correctly also when a grouping creates a hierarchy of nodes (not only a flat list of nodes).
  - Tree Table views: Improved performance of filtering and grouping.

#jira UE-147408
#rb Catalin.Dragoiu
#preflight 6290c85a3c05bea8bfcfa869

[CL 20392842 by ionut matasaru in ue5-main branch]
2022-05-27 10:03:51 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
Catalin Dragoiu
241fc540f9 [Insights] Resize Screenshots to a max width of 640 pixels and a max heigth of 480 when displaying them.
#rb Ionut.Matasaru
#preflight 628f3b7f80139a51815dd700

[CL 20377206 by Catalin Dragoiu in ue5-main branch]
2022-05-26 05:23:55 -04:00
ionut matasaru
44f8cb8176 [Insights] Added "Insights" mem scope in various places to capture untagged memory when Insights is running in Editor (i.e. as Animation Insights).
#jira UE-153276
#rb Catalin.Dragoiu
#preflight 628d026dc97e4beea3a506cd

[CL 20362212 by ionut matasaru in ue5-main branch]
2022-05-25 06:45:23 -04:00
Brandon Schaefer
02140e5921 Check if CookProvider is null before dereferencing
Work around for this, as likely we should be able to assume this is not null

#jira none
#rb none
#fyi Catalin.Dragoiu
#preflight none

[CL 20328373 by Brandon Schaefer in ue5-main branch]
2022-05-23 11:03:29 -04:00
Catalin Dragoiu
0b478d5694 Cooking Profiler Prototype
#rb Ionut.Matasaru  Matt Peters
#preflight 628b8690693c5e1de2773a39

[CL 20327158 by Catalin Dragoiu in ue5-main branch]
2022-05-23 10:13:54 -04:00
ionut matasaru
63fcdbc1e2 [Insights]
- Timing view: Fixed track invalidation when a track filter is changed (using "Filter Track..." from context menu). Also improved code related to filters attached to each track, avoiding unnecessary duplications.

#rb Catalin.Dragoiu
#preflight 62875a5e8828ea88c84402af

[CL 20292366 by ionut matasaru in ue5-main branch]
2022-05-20 05:56:41 -04:00
ionut matasaru
e5a08d1eb4 [Insights] Added LLM_SCOPEs to each analyzer in TraceServices and in few Insights plugins (in an effort to reduce the Untagged allocations).
#jira UE-147172
#rb Johan.Berg
#preflight 6284c4ecf239239af6738fb4

[CL 20277513 by ionut matasaru in ue5-main branch]
2022-05-19 05:03:20 -04:00
ionut matasaru
6ba99a3742 [Insights]
- Table Tree view: Added "SameValue" aggregation for the table/tree columns of CString type. Aggregated value is equal with children value if all children have exactly same value, otherwise aggregated value is empty.
  - Memory Insights: Enabled "SameValue" aggregation for the Mem Tag column of the Mem Allocs table/tree view.

#jira UE-152586
#rb Catalin.Dragoiu
#preflight 6282a1907d471e73a568ea4c

[CL 20239889 by ionut matasaru in ue5-main branch]
2022-05-17 05:41:12 -04:00
ionut matasaru
7abf3bac49 [Insights]
- Memory Insights: Added "Open Source in Visual Studio" for any callstack frame of any allocation item, in the Allocs Table/Tree view (even if the tree is not grouped by callstack).

#jira UE-152557
#rb Catalin.Dragoiu
#preflight 6282660f046b81bf93be7420

[CL 20226574 by ionut matasaru in ue5-main branch]
2022-05-16 12:40:00 -04:00
ionut matasaru
0af516c8c2 [Insights]
- Session Browser: Improved metadata update by prioritizing the newer trace sessions. Also enabled parallel update for metadata (~10x faster to update metadata for large number of traces).
  - Added a critical section for synchronizing the use of FStoreClient exposed by Insights Manager (as FStoreClient API is not thread safe).
  - Session Browser: Added F5 key shortcut to refresh the list of trace sessions (debug functionality).

#rb Johan.Berg
#preflight 627a5bce937a047d622c1a6e

[CL 20122453 by ionut matasaru in ue5-main branch]
2022-05-10 09:53:30 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
ionut matasaru
5c0c1c14b7 [Insights] Increased version to v1.01 (supports trace protocol 6).
#rb trivial
#preflight trivial

[CL 20076446 by ionut matasaru in ue5-main branch]
2022-05-06 11:17:28 -04:00
ionut matasaru
866441effc [Insights]
- Fixed UE-150996, log message after "TimingInsights.ExportThreads" execute command not counting correctly the total number of threads (ignoring the two gpu threads).
  - Fixed UE-150992, executing commands from a response file was ignoring the last command if that last line was not EOL terminated.
  - Added support to comment a command (i.e. ignore execution) in a response file by using # as the first char on a line.

#jira UE-150996
#jira UE-150992
#rb Catalin.Dragoiu
#preflight 627294cf2f6d177be3c33229

[CL 20042287 by ionut matasaru in ue5-main branch]
2022-05-04 11:17:38 -04:00
Devin Doucette
748e39e3c0 Replaced uses of _SV with TEXTVIEW
#preflight 6266da740634d0904ce6de29
#rb Steve.Robb
#rnx

[CL 19905760 by Devin Doucette in ue5-main branch]
2022-04-25 13:56:30 -04:00
Steve Robb
f4d1564ffe New BitCast<>() function which works like C++20's std::bit_cast<>().
Deprecation of FPlatformMath::IsNegative*() functions.
New FPlatformMath::IsNegativeOrNegativeZero().
Fix up of existing usage to either use < 0 or IsNegativeOrNegativeZero where appropriate.
Fixes for aliasing problems in various FMath functions, including IsNegative*().

Resubmission of CL# 19833778 with fixes for problematic Mac and Android toolchains, causing spurious errors while building PCHs.

#rb devin.doucette, charles.bloom, will.damon, chris.babcock
#jira UE-148435
#preflight 6260764d91376845adf9893f

[CL 19840896 by Steve Robb in ue5-main branch]
2022-04-20 19:05:47 -04:00
Steve Robb
5c1f45e9a8 Undo //UE5/Main/Engine/... changelist 19833778 due to Mac and Android compilation failure.
#rb none
#jira none
#preflight none
#fyi will.damon

[CL 19835840 by Steve Robb in ue5-main branch]
2022-04-20 15:09:51 -04:00
Steve Robb
a9e89c3ed6 New BitCast<>() function which works like C++20's std::bit_cast<>().
Deprecation of FPlatformMath::IsNegative*() functions.
New FPlatformMath::IsNegativeOrNegativeZero().
Fix up of existing usage to either use < 0 or IsNegativeOrNegativeZero where appropriate.
Fixes for aliasing problems in various FMath functions, including IsNegative*().

#rb devin.doucette, charles.bloom
#jira UE-148435
#preflight 625ece48f16e0d2accab15d9

[CL 19833778 by Steve Robb in ue5-main branch]
2022-04-20 13:38:10 -04:00
ionut matasaru
55c4430fc0 [Insights] Added toggle button to choose btween searching/filtering the list of trace session by Name or by Command Line. Also added highlights for searched text (also in tooltip, when searching by cmd line).
#jira UE-149686
#rb Catalin.Dragoiu
#preflight 6260066de30cb43e8cb6ed35

[CL 19829017 by ionut matasaru in ue5-main branch]
2022-04-20 09:25:11 -04:00
ionut matasaru
45a1aef30f [Insights]
- Added "Auto Open Live Trace" toggle option in the main menu. If enabled, the analysis starts automatically for each new live trace session, replacing the current analysis session.
  - Moved the two "Open Trace File" options (from the main menu) into a sub-menu. Also added folder-open icon for these actions.

#jira UE-149129
#rb Catalin.Dragoiu
#preflight 62583459c738207d0320c02a

[CL 19758255 by ionut matasaru in ue5-main branch]
2022-04-14 12:03:02 -04:00
ionut matasaru
82fa75e865 [Insights]
- Removed workaround for closing a tab.
  - Refactored S*ProfilerWindow implementations to use a base class. Moved all common code into a new SMajorTabWindow class.
  - Added extensibility to layout and main toolbar (and to the right side toolbar) for all profiler windows: Timing Insights, Asset Loading Insights, Memory Insights and Networking Insights.

#jira UE-147404, UE-147405, UE-148086
#rb Catalin.Dragoiu
#preflight 6255729c69015afc27a5e41b

[CL 19737560 by ionut matasaru in ue5-main branch]
2022-04-13 06:39:18 -04:00
Catalin Dragoiu
7b00ffd891 [Insights] Fix hang when closing during an async operation.
#rb Ionut.Matasaru
#preflight 624c555e8d1db441a90eb8a1
#jira UE-148086

[CL 19625698 by Catalin Dragoiu in ue5-main branch]
2022-04-05 11:10:59 -04:00
ionut matasaru
bcd889d733 [Insights]
- Added "Session Browser" in main menu. Opens the Unreal Insights Session Browser window.
  - Added "Open Trace File (new instance)...". Starts analysis for a specified trace file, in a separate Unreal Insights instance.
  - Added "Open Trace File (same instance)...". Starts analysis for a specified trace file, replacing the current analysis session.

#rb Catalin.Dragoiu
#preflight 624af26edf7d23dbfe359c0d

[CL 19609997 by ionut matasaru in ue5-main branch]
2022-04-04 11:43:37 -04:00