Commit Graph

44 Commits

Author SHA1 Message Date
Helge Mathee
0edf08d7f8 RigVM: Invoke Entry functionality for the model
#rb benoit.gadreau
#jira UE-153498
#preflight https://horde.devtools.epicgames.com/job/629733a2ed7762ca42de8245

[CL 20450402 by Helge Mathee in ue5-main branch]
2022-06-01 05:56:08 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Helge Mathee
d4934bf859 Control Rig: Allow change pin types on wildcard pins
#rb na
#jira na
#preflight skip

[CL 20430758 by Helge Mathee in ue5-main branch]
2022-05-30 10:01:57 -04:00
sara schvartzman
ed571628f5 Control Rig: Filtered permutations for template nodes
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62769cbe75268b4ace10dc69

[CL 20101111 by sara schvartzman in ue5-main branch]
2022-05-09 07:34:28 -04:00
Helge Mathee
0cb1b899f7 Control Rig: Fix crash during undo / redo
#rb sara.schvartzman
#jira UE-147278
#preflight https://horde.devtools.epicgames.com/job/6245e0fbf4217035fa8d02f0

[CL 19585547 by Helge Mathee in ue5-main branch]
2022-04-01 04:36:14 -04:00
sara schvartzman
4e0eb3f007 Control Rig: Do not allow functions with wildcards
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62449133c51908059aaf4652

[CL 19570679 by sara schvartzman in ue5-main branch]
2022-03-31 05:28:05 -04:00
sara schvartzman
c7b0e74c59 Controlr Rig: UI implementation of Aggregate nodes
#jira UE-146928
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62433ef7dc6183e3f5e500dc

[CL 19554694 by sara schvartzman in ue5-main branch]
2022-03-30 05:21:45 -04:00
sara schvartzman
256ad8d9ef Control Rig: Add aggregate node
#jira UE-146926
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/623b5f4ada56b5683a0b05b7

[CL 19524901 by sara schvartzman in ue5-main branch]
2022-03-28 05:56:56 -04:00
sara schvartzman
4080ae8f74 Control Rig: Deprecate URigVMGraph::GetVariableDescriptions
#jira UE-143286
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62336d5684667926da2830dc

[CL 19433944 by sara schvartzman in ue5-main branch]
2022-03-18 07:41:19 -04:00
Helge Mathee
63e119a364 Control Rig: Further template node workflows
Implemented unresolve as well as re-resolve node on already typed pins
Added UI in contextual menu to re-type pins

#rb sara.schvartzman
#jira UE-125892
#preflight https://horde.devtools.epicgames.com/job/622f488f505788e09ffffbe4

[CL 19372564 by Helge Mathee in ue5-main branch]
2022-03-14 10:19:31 -04:00
Helge Mathee
4cc75cf9a5 RigVM: Node upgrade functionality
As part of debugging the last unit test I've added functionality to support debugging of the ActionStack. The controller is now able to upgrade a node as per user interaction. next up I'll integrate this into the user interface.

#rb sara.schvartzman
#jira UE-141505
#preflight https://horde.devtools.epicgames.com/job/6226280ca71867308f24c641

[CL 19286305 by Helge Mathee in ue5-main branch]
2022-03-07 12:07:36 -05:00
sara schvartzman
d904b9cfe5 Control Rig: Remove parameters
#jira UE-143591
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6225ed1d8e6b4641d86295c4

[CL 19284981 by sara schvartzman in ue5-main branch]
2022-03-07 10:20:24 -05:00
Helge Mathee
627cb75494 Control Rig: Template Node Support.
The UE_RIGVM_ENABLE_TEMPLATE_NODES is disabled in this submit for now - which disabled the creation of template nodes as well, disabled auto-update functionality during load and spawning resolved templates nodes instead of unit nodes.

We'll enable the define in a follow up submit

#rb jack.cai
#jira na
#preflight https://horde.devtools.epicgames.com/job/621de289ca28c55634199235

[CL 19196111 by Helge Mathee in ue5-main branch]
2022-03-01 04:23:55 -05:00
Helge Mathee
80cb75fa33 Control Rig: refactor details panel to show any node, support vector, rotator and transform widgets
#rb sara.schvartzman
#jira UE-139767 UE-121980
#preflight https://horde.devtools.epicgames.com/job/620cde9301253d2e1906c4eb

[CL 19012796 by Helge Mathee in ue5-main branch]
2022-02-16 07:27:08 -05:00
helge mathee
ef04d8cfe7 RigVM: Rely on import text for undo / redo of Collapse, Expand
#rb sara.schvartzman
#jira UE-139731
#preflight https://horde.devtools.epicgames.com/job/61ea9f26445cebac10bf1f63

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18688153 in //UE5/Release-5.0/... via CL 18688156 via CL 18688161
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18688164 by helge mathee in ue5-main branch]
2022-01-21 07:17:55 -05:00
sara schvartzman
d3fad84790 Control Rig: Fix crash on copy paste nodes with variable binding
#jira UE-138888
#rb helge.mathee
#preflight 61deff35ff67b6fe7abb99fe

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18595239 in //UE5/Release-5.0/... via CL 18595240 via CL 18595248
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18596669 by sara schvartzman in ue5-main branch]
2022-01-13 10:07:57 -05:00
sara schvartzman
380253e03f Control Rig: fix eject last node
#jira UE-136077
#rb helge.mathee
#preflight 61dc43c26c000c869b446a51

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18559696 in //UE5/Release-5.0/... via CL 18559710
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18559732 by sara schvartzman in ue5-release-engine-test branch]
2022-01-10 10:15:49 -05:00
sara schvartzman
589d45bdd7 Control Rig: Fix undo change type of local variable not relinking variable nodes
#jira UE-137215
#rb halfdan.ingvarsson
#preflight 61b367e5c01c89f906e5d43e

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18438835 in //UE5/Release-5.0/... via CL 18444731
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18444867 by sara schvartzman in ue5-release-engine-test branch]
2021-12-13 13:16:13 -05:00
sara schvartzman
f0a942f45e Control Rig: Refactor variable binding
#jira na
#rb helge.mathee
#preflight 61a4c443be6d0d4512c093f6

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 18310323 in //UE5/Release-5.0/... via CL 18310628
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18310747 by sara schvartzman in ue5-release-engine-test branch]
2021-11-29 11:26:01 -05:00
helge mathee
6462b5a2b4 RigVM: Implement undo / redo for promote actions
#rb jack.cai
#jira UE-132110
#preflight https://horde.devtools.epicgames.com/job/618ccb47026d8c8fe93bd749

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18149987 in //UE5/Release-5.0/... via CL 18150366
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v889-18060218)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18150401 by helge mathee in ue5-release-engine-test branch]
2021-11-11 09:37:24 -05:00
sara schvartzman
488074a7e5 Control Rig: Fix "show bubble when zoom" change is not getting saved
#jira UE-131734
#rb helge.mathee
#preflight 6172abfceeaa6c00017ff565

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 17904076 in //UE5/Release-5.0/... via CL 17904086
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v883-17842818)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 17904089 by sara schvartzman in ue5-release-engine-test branch]
2021-10-25 04:25:30 -04:00
sara schvartzman
408eee294f Control Rig: Fix Unable to redo Forward solve nodes paste
#jira UE-117162
#rb helge.mathee
#preflight 61534846cf40300001b4cd54

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 17674697 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v875-17642767)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0

[CL 17674711 by sara schvartzman in ue5-release-engine-test branch]
2021-09-30 05:07:08 -04:00
sara schvartzman
256a836829 Control Rig: Local variable deletion in the Control Rig cannot be undone
#jira UE-120844
#rb helge.mathee
#preflight 6151ca1259c66a000108cb34

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 17631071 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v871-17566257)

[CL 17631072 by sara schvartzman in ue5-release-engine-test branch]
2021-09-27 11:30:52 -04:00
sara schvartzman
9c12db0405 Control Rig: Promote to collapse node from function without invalid local variables
#jira UE-125910
#rb helge.mathee

#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-SOURCE: CL 17481068 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17481076 by sara schvartzman in ue5-release-engine-test branch]
2021-09-10 10:04:27 -04:00
helge mathee
f4138a3a68 Control Rig: Support for unknown pins + spawning nodes with unknown pins
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/61388e8a25e540000167bbec

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 17456830 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17456834 by helge mathee in ue5-release-engine-test branch]
2021-09-08 07:57:30 -04:00