Commit Graph

423 Commits

Author SHA1 Message Date
Helge Mathee
0edf08d7f8 RigVM: Invoke Entry functionality for the model
#rb benoit.gadreau
#jira UE-153498
#preflight https://horde.devtools.epicgames.com/job/629733a2ed7762ca42de8245

[CL 20450402 by Helge Mathee in ue5-main branch]
2022-06-01 05:56:08 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Marc Audy
1b70e12969 Fix non-unity
#preflight
#rnx

[CL 20442673 by Marc Audy in ue5-main branch]
2022-05-31 17:12:58 -04:00
Helge Mathee
40dbac202b RigVM: Restructure entry invocation for nativized VMs
#rb sara.schvartzman
#jira UE-153498
#preflight https://horde.devtools.epicgames.com/job/62962b08fe779f23c8e4d093

[CL 20441428 by Helge Mathee in ue5-main branch]
2022-05-31 16:18:09 -04:00
Helge Mathee
6520c809a9 Control Rig: backend work for support for multi graph
#rb benoit.gadreau
#jira UE-153497
#preflight https://horde.devtools.epicgames.com/job/6294be4e2e34c2e487b13394

[CL 20434781 by Helge Mathee in ue5-main branch]
2022-05-31 04:27:20 -04:00
Helge Mathee
d4934bf859 Control Rig: Allow change pin types on wildcard pins
#rb na
#jira na
#preflight skip

[CL 20430758 by Helge Mathee in ue5-main branch]
2022-05-30 10:01:57 -04:00
semion piskarev
b09efbe2a6 Fix link errors caused by RigVMPythonUtils.
#rb Helge.Mathee
#preflight 628d0285710271c31823419c

#ROBOMERGE-AUTHOR: semion.piskarev
#ROBOMERGE-SOURCE: CL 20351003 via CL 20351380 via CL 20351574
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20353622 by semion piskarev in ue5-main branch]
2022-05-24 15:20:08 -04:00
sara schvartzman
0937ada054 Control Rig: Fix select nodes not supporting arrays of arrays
#jira na
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/6287aa2e5b568e5761f505cc

[CL 20294487 by sara schvartzman in ue5-main branch]
2022-05-20 11:00:38 -04:00
sara schvartzman
38c72b07e2 Control Rig: Fix load of pre-template assets
#jira UE-153247
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6287664b1e478b95c7fbc926

[CL 20293516 by sara schvartzman in ue5-main branch]
2022-05-20 09:28:06 -04:00
sara schvartzman
6a719c2fcc Control Rig: Fix crash when undo/redo upgrade nodes
#jira UE-147278
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/628524452a7df8ed9f9e1424

[CL 20277521 by sara schvartzman in ue5-main branch]
2022-05-19 05:05:24 -04:00
sara schvartzman
47d4498fd6 Control Rig: Fix loading template nodes with wildcard pins
#jira UE-152862
#rb bob.tellez
#preflight https://horde.devtools.epicgames.com/job/628577d3890768f0e93e68b4

#ROBOMERGE-OWNER: bob.tellez
#ROBOMERGE-AUTHOR: sara.schvartzman
#ROBOMERGE-COMMAND: _robomerge[bot4] UE5-MAIN
#ROBOMERGE-SOURCE: CL 20271485 via CL 20271505
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20271643 by sara schvartzman in ue5-main branch]
2022-05-18 19:49:22 -04:00
sara schvartzman
6c0d38da89 Control Rig: Performance improvements on template nodes
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6283a58a730e8423d1256bf5

[CL 20258899 by sara schvartzman in ue5-main branch]
2022-05-18 06:43:26 -04:00
sara schvartzman
642f1d141d Control Rig: Fix crash when connecting different type to template node
#jira UE-152650
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/62837e9aed2c0847b026948c

[CL 20240830 by sara schvartzman in ue5-main branch]
2022-05-17 07:43:53 -04:00
jack cai
65e04a2821 ControlRig: rigvmpythonuitl.cpp non-unity compilation issue, missing class.h header include
#jira UE-152512
#rb trivial
#preflight skip

[CL 20227668 by jack cai in ue5-main branch]
2022-05-16 13:47:05 -04:00
sara schvartzman
1bce442c08 Control Rig: Fix hanging of editor when adding/breaking links
#jira UE-151849
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627e3843830b40b66830915e

[CL 20179303 by sara schvartzman in ue5-main branch]
2022-05-13 07:10:24 -04:00
Helge Mathee
79506075b5 RigVMDeveloper: Centralize pythonize for enum values
#rb sara.schvartzman
#jira UE-151724
#preflight https://horde.devtools.epicgames.com/job/627e298434434190054ad8c8

[CL 20178877 by Helge Mathee in ue5-main branch]
2022-05-13 05:53:36 -04:00
sara schvartzman
bcc85fc71e Control Rig: Fix crash when pasting function reference node from another project
#jira UE-151748
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627e1a7bb6530f0fc715ae28

[CL 20178719 by sara schvartzman in ue5-main branch]
2022-05-13 04:59:36 -04:00
Helge Mathee
27713261f0 RigVM: Promoting CollapseNode To Function to respect execute pin direction
#rb sara.schvartzman
#jira UE-151694
#preflight https://horde.devtools.epicgames.com/job/627d07ae332e182a583320d5

[CL 20167692 by Helge Mathee in ue5-main branch]
2022-05-12 14:01:54 -04:00
sara schvartzman
9e31190bab Control Rig: Fix ensure that was breaking a unit test
#jira na
#rb trivial
#preflight https://horde.devtools.epicgames.com/job/627d19ea9f7ad2a14be51694

[CL 20164220 by sara schvartzman in ue5-main branch]
2022-05-12 10:31:30 -04:00
Helge Mathee
663eb5877e RigVM: Fix deletion of functions
Resulted from bad merge

#rb sara.schvartzman
#jira UE-151695
#preflight https://horde.devtools.epicgames.com/job/627d008dce4192efbe4c30fd

[CL 20163569 by Helge Mathee in ue5-main branch]
2022-05-12 08:56:43 -04:00
sara schvartzman
acabc382aa Control Rig: Fix adding/resolving/unresolving template nodes either not printing Python commands or printing wrong python command
#jira UE-151590
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627bcb6d2d67896030144afb

[CL 20140249 by sara schvartzman in ue5-main branch]
2022-05-11 10:53:58 -04:00
sara schvartzman
c77c447f49 Control Rig: Fix function not editable after renaming
#jira UE-151489
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627b9cca1e749933437e0031

[CL 20136303 by sara schvartzman in ue5-main branch]
2022-05-11 07:30:10 -04:00
sara schvartzman
c7e9e84575 Control Rig: Fix crash when recomputing filtered permutations and preferred types is set
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627b957b0a5817c9d93fcb34

[CL 20136135 by sara schvartzman in ue5-main branch]
2022-05-11 07:01:37 -04:00
sara schvartzman
f7578148a8 Control Rig: Test recompute all filtered permutations on templates
#jira na
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/627b8348b60dee4a43a104f9

[CL 20135765 by sara schvartzman in ue5-main branch]
2022-05-11 05:46:12 -04:00
sara schvartzman
dbf7254f5a Control Rig: Back to initializing all template filtered permutations from types
#jira UE-151518
#rb halfdan.ingvarsson
#preflight https://horde.devtools.epicgames.com/job/627a8b34d847d5f149e73145

[CL 20124326 by sara schvartzman in ue5-main branch]
2022-05-10 12:00:48 -04:00