Commit Graph

619 Commits

Author SHA1 Message Date
zousar shaker
022ac1483a Fix for Unity name collision on MakeArrayView.
#jira UE-143154
#preflight 620edc52c91bcd0017af81c5
#rb matt.peters
#lockdown mitchell.wilson


#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 19044958 via CL 19045096 via CL 19045152 via CL 19045155 via CL 19045399
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19045909 by zousar shaker in ue5-main branch]
2022-02-17 20:05:08 -05:00
danny couture
1f388a417c Fix audio crash when using -DDC-All-MissTypes on streamed audio by only returning DDC miss until a put is done.
- Infinite misses break the editor in too many ways as we often rely on the local cache to be working correctly as off-memory storage.

#rnx
#rb Devin.Doucette
#preflight 620e36ea7e2cef4bf1d255a2

[CL 19033237 by danny couture in ue5-main branch]
2022-02-17 06:59:36 -05:00
Zousar Shaker
a0c688d5fd Unshelved from pending changelist '18992789' in UE5/Release-5.0:
Change Zen to  ValueWithLegacyFallback mode now that it handles Value PUTs to Jupiter correctly.  Add Jupiter auto test that ensures a PUT via UE->Zen->UpstreamZen->Jupiter produces something that can be GET from UE<-Jupiter.  Confirmed test passes.

#rb devin.doucette
#jira UE-134381
#lockdown Aurel.Cordonnier
#preflight 620b4e22bb6a072d17cdd6dd

[CL 18998519 by Zousar Shaker in ue5-main branch]
2022-02-15 12:34:29 -05:00
devin doucette
5953a87414 DDC: Fixed an error caught by StressTestUnity
#jira none
#preflight 620af27d583261b0a67b105b
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18989454 in //UE5/Release-5.0/... via CL 18992558 via CL 18992930
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18997149 by devin doucette in ue5-main branch]
2022-02-15 11:27:30 -05:00
devin doucette
2800210897 DDC: Enabled compression of legacy cache data
- FileSystem, Http, Pak, S3 use the ValueWithLegacyFallback mode by default, which cause them to fall back to searching for uncompressed data if compressed data is not found.
- FileSystem has been fixed to store up to 1 MiB of compressed data inline with the value package rather than separately in content-addressable storage.
- Pak has been optimized to have GetChunks only load the required region of the requested value, rather than the whole value.
- Pak has been changed to stop storing data inline in the record package, since it will end up in the same file anyway when stored separately.
- Pak will upgrade the compressor and compression level when a compressed pak file is requested. Default cache compression uses Oodle Mermaid VeryFast and will upgrade to Oodle Kraken Optimal2.
- Zen does not have compression enabled by default, pending deployment of a new version that stores compressed values to Horde Storage.
- Added a missing request barrier when saving uncompressed data as compressed.

Example reduction in file system cache size when cooking for Windows:
- CitySample dropped from 66.5 GiB to 21.8 GiB.
- Lyra dropped from 2.54 GiB to 672 MiB.
- ShooterGame dropped from 1.21 GiB to 380 MiB.

Example reduction in compressed pak file cache size when cooking for Windows:
- CitySample dropped from 22.3 GiB to 18.5 GiB.
- Lyra dropped from 691 MiB to 543 MiB.
- ShooterGame dropped from 387 MiB to 313 MiB.

#jira UE-134381
#preflight 620a703f583261b0a658e043, 620a6fb2803d9066e6805310, 620a733117632e948459b6af
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18983671 in //UE5/Release-5.0/... via CL 18983890 via CL 18984096
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18984126 by devin doucette in ue5-main branch]
2022-02-14 14:43:39 -05:00
zousar shaker
f3b211baa8 Bump CacheStoreTest version as the AWS file share has had some test values put into it that are expected not to exist, meaning that the test always fails when using AWS as the shared cache.
#rb matt.peters
#jira UE-141632
#preflight 6206deaec663666c89b2df53
#lockdown aurel.cordonnier

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18963345 in //UE5/Release-5.0/... via CL 18963931 via CL 18964734
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18964750 by zousar shaker in ue5-main branch]
2022-02-11 18:17:49 -05:00
zousar shaker
c800de44ea Value API support for S3 DDC backend.
#rb devin.doucette
#jira UE-134381
#lockdown aurel.cordonnier
#preflight 62060b280d0c8cd8abb00af0

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18954097 in //UE5/Release-5.0/... via CL 18954693 via CL 18955168
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18955205 by zousar shaker in ue5-main branch]
2022-02-11 12:57:03 -05:00
devin doucette
70d0aea9a6 DDC: Added support for 64-bit sizes in the legacy cache
Includes an optimization to avoid an extra copy of data loaded from the cache.

#jira UE-103039
#preflight 6205f379b84973a2bb76d942
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18954059 in //UE5/Release-5.0/... via CL 18954686 via CL 18955089
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18955195 by devin doucette in ue5-main branch]
2022-02-11 12:56:47 -05:00
zousar shaker
82fa907ee1 Value API support for PAK DDC backend.
#rb devin.doucette
#jira UE-134381
#lockdown aurel.cordonnier
#preflight 62059568a155a4cddac9e324

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18945276 in //UE5/Release-5.0/... via CL 18946208 via CL 18946560
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18946566 by zousar shaker in ue5-main branch]
2022-02-10 18:46:59 -05:00
zousar shaker
54406ad0b8 Value API support for Memory DDC backend.
#rb devin.doucette
#jira UE-134381
#lockdown mark.lintott
#preflight 62055c084c6c33118fadaf04

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18941729 in //UE5/Release-5.0/... via CL 18941872 via CL 18942045
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18942059 by zousar shaker in ue5-main branch]
2022-02-10 15:29:38 -05:00
devin doucette
778a7d292b DDC: Added compression support to legacy cache values
The cache stores can individually control their "legacy mode" now, which offers a choice of ValueOnly, ValueWithLegacyFallback, LegacyOnly.
- Using ValueOnly will forward every legacy request through the Value API, which compresses values by default and supports values larger than 2 GiB.
- Using ValueWithLegacyFallback behaves like ValueOnly, but misses from GetValue are forwarded to GetCachedData, and stored with PutValue if found.
- Using LegacyOnly will forward every legacy request through the Legacy API.

FLegacyCacheValue uses shared state to ensure that each value is compressed or decompressed at most once.

#jira UE-134381
#preflight 62054b430c64e1822f41231b
#lockdown Mark.Lintott
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18940270 in //UE5/Release-5.0/... via CL 18941016 via CL 18941392
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941401 by devin doucette in ue5-main branch]
2022-02-10 14:57:42 -05:00
devin doucette
87fd32cbac DDC: Fixed an error in GetChunks in the pak file cache
#jira MH-5194
#preflight 620559904c6c33118fad9a05
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18940207 in //UE5/Release-5.0/... via CL 18941009 via CL 18941325
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941355 by devin doucette in ue5-main branch]
2022-02-10 14:55:00 -05:00
Matt Peters
f76045bb7e LowLevelMemTracker - add scopes for some large allocations during cooking.
#rb Devin.Doucette
#rnx
#preflight 62047a600a1c4eb68f555ba5

[CL 18930861 by Matt Peters in ue5-main branch]
2022-02-09 21:53:31 -05:00
devin doucette
c2a46c2242 DDC: Fixed a test failure for small values in the file system cache
#jira UE-141632
#preflight 6202b6c9bf28c072cbf308ce
#lockdown Mark.Lintott
#rb Matt.Peters
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18909346 in //UE5/Release-5.0/... via CL 18909604 via CL 18909733
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v915-18905420)

[CL 18909753 by devin doucette in ue5-main branch]
2022-02-08 16:07:34 -05:00
devin doucette
2ae070347f DDC: Fixed a memory leak in the cache
#jira UE-141335
#preflight 620294f5bd4f846436e5f4c6
#lockdown Mark.Lintott
#rb Matt.Peters
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18903655 in //UE5/Release-5.0/... via CL 18903892 via CL 18904098
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v912-18901109)

[CL 18904146 by devin doucette in ue5-main branch]
2022-02-08 12:17:15 -05:00
zousar shaker
df06aa0d18 Allow for region pinning when connecting to Jupiter. Fix value printing error. Increase concurrent PUT operations from 2 to 4 when batching is enabled.
#preflight 6201d9c7384d6a94e8fc20d7
#jira UE-141733
#rb devin.doucette

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18899614 in //UE5/Release-5.0/... via CL 18899644 via CL 18899680
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18899684 by zousar shaker in ue5-main branch]
2022-02-08 01:56:17 -05:00
devin doucette
c03d680063 DDC: Fixed propagation of cache values when a value policy contains SkipData
#jira UE-141576
#preflight 61fe001fdb3d0b17a933391c
#lockdown Mark.Lintott
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18896581 in //UE5/Release-5.0/... via CL 18896633 via CL 18896789
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18897023 by devin doucette in ue5-main branch]
2022-02-07 20:06:56 -05:00
danny couture
dcff1b48cb Fix infinite wait on async compilation when in pause mode by using an unpausable priority when forced compilation is required to wait
#rb Francis.Hurteau
#jira ue-141319
#preflight 62010b324346561cadf30657
#lockdown mark.lintott

#ROBOMERGE-AUTHOR: danny.couture
#ROBOMERGE-SOURCE: CL 18886756 in //UE5/Release-5.0/... via CL 18886809 via CL 18887172
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18887216 by danny couture in ue5-main branch]
2022-02-07 12:22:00 -05:00
devin doucette
0818b14470 DDC: Fixed incorrect callbacks in put batches with failures
Also adds the intended inline allocators for arrays that were missing them.

#jira UE-134381
#lockdown Mark.Lintott
#preflight 61fd998ff370b0d3111fad17
#rb Matt.Peters
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18874174 in //UE5/Release-5.0/... via CL 18874208 via CL 18874924
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18874951 by devin doucette in ue5-main branch]
2022-02-04 17:24:08 -05:00
devin doucette
e963d14d2a DDC: Fixed the Zen cache being accidentally made read-only
#jira UE-134381
#preflight 61fcb3a2b434724823d9f733
#lockdown Mark.Lintott
#rb Zousar.Shaker
#rnx

#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge UE5-Main
#ROBOMERGE-SOURCE: CL 18860637 in //UE5/Release-5.0/... via CL 18860644 via CL 18860646
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18860649 by devin doucette in ue5-main branch]
2022-02-04 00:27:54 -05:00
zousar shaker
2903c5331f Fix static analysis error in CacheStoreTest.cpp.
#rb matt.peters
#jira UE-141032
#lockdown aurel.cordonnier
#preflight 61fc4d11e058822bdaaaefcb

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18853180 in //UE5/Release-5.0/... via CL 18853206 via CL 18853946
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18853959 by zousar shaker in ue5-main branch]
2022-02-03 17:43:34 -05:00
devin doucette
c7954aebce DDC: Switched to the async cache hierarchy and fully implemented the verify wrapper
The async cache hierarchy:
- Is required to add compression to the legacy cache by forwarding LegacyPut/LegacyGet to PutValue/GetValue.
- Is always present in the graph, unlike the previous cache hierarchy, which will allow significant simplification of leaf cache stores.
- Allows for the leaf cache store nodes to operate asynchronously without blocking a worker thread like the previous cache hierarchy.
- Shifts from controlling cache behavior by speed class to controlling cache behavior by local/remote classification, which is a critical distinction for a cache like Zen that can identify as both local and remote.
- Respects the local/remote and query/store flags in the cache policy.
- Does not fully implement the partial record cache policy at this time.
- Does not propagate records or values in GetChunks, which will be added in a future release.

The verify wrapper was previously missing an implementation for the new cache interface. This version is more efficient than the previous because requests through the new cache interface can compare data without loading it from storage, and load it only when a mismatch has been detected, to dump it to disk.

#jira UE-134381
#lockdown Mark.Lintott
#preflight 61fc32ac0a50c2606f266388
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18851861 in //UE5/Release-5.0/... via CL 18851943 via CL 18852169
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18852184 by devin doucette in ue5-main branch]
2022-02-03 16:49:32 -05:00
devin doucette
07e3b20f45 DDC: Fixed a missing decrement of the async completion counter
Cancellation of requets in the async put wrapper was not decrementing the async completion counter, which causes a hang on exit if any cancellations have occurred. Any cook that builds a lot of meshes changes the timing of other operations enough that they are often canceled.

#jira UE-140939
#preflight 61fa2af34404d5fade10bd72
#lockdown Mark.Lintott
#rb Zousar.Shaker
#rnx

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18824202 in //UE5/Release-5.0/... via CL 18825870 via CL 18826297
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18826347 by devin doucette in ue5-main branch]
2022-02-02 09:54:07 -05:00
zousar shaker
b9fdfa4036 GetChunks value implementation for Jupiter.
#rb devin.doucette
#preflight 61f9db609e4d23cd93b7b28d

#ROBOMERGE-AUTHOR: zousar.shaker
#ROBOMERGE-SOURCE: CL 18819720 in //UE5/Release-5.0/... via CL 18819729 via CL 18822895
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18825048 by zousar shaker in ue5-main branch]
2022-02-02 08:18:44 -05:00
devin doucette
20ea07085b DDC: Added GetChunks support to the new cache hierarchy
Includes policy fixes for other functions.

#rb Zousar.Shaker
#rnx
#preflight 61f9b31c9e4d23cd93b1dad3

#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 18817404 in //UE5/Release-5.0/... via CL 18817411 via CL 18822862
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824693 by devin doucette in ue5-main branch]
2022-02-02 07:58:00 -05:00