Commit Graph

190 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Ben Marsh
56e16f5ca4 Fix non-deterministic initialization of FRemoteControlPresetGroup, causing warnings when running initialization tests.
#preflight 62921a7fa962938dff650b3c

[CL 20407100 by Ben Marsh in ue5-main branch]
2022-05-28 08:54:29 -04:00
Marc Audy
c77dc2604e Fix non-unity
#rnx
#preflight

[CL 20403276 by Marc Audy in ue5-main branch]
2022-05-28 01:16:10 -04:00
Alejandro Arango
7efe6eb9a7 Fix CIS
#rb
#jira UE-155051
#fyi paul.vincent
#preflight 62915131cb21fde6265409ad

[CL 20400661 by Alejandro Arango in ue5-main branch]
2022-05-27 18:46:58 -04:00
mark lintott
c812baa63e Fix for un-initialised variable CIS compiler issue
#jira none
#rb trivial
#fyi paul.vincent
#preflight 62909fdcf6668c14a3c8c009

[CL 20391387 by mark lintott in ue5-main branch]
2022-05-27 06:09:12 -04:00
Paul Vincent
6c8ca02f8f 1. Remote control preset UI revamp
#jira UE-146238
#rb Simon.Therriault Jeremie.Roy Denys.Dubinin Patrick.Gross
#preflight 19827247

2. Rework grouping UI

#jira UE-146240
#rb Simon.Therriault Jeremie.Roy Denys.Dubinin Patrick.Gross
#preflight 19827247

[CL 20390330 by Paul Vincent in ue5-main branch]
2022-05-27 00:54:18 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
Marc Audy
f9445fed38 Initialize TransactionIds
#jira UE-153291
#codreview Elliot.Colp
#rnx
#preflight

[CL 20376151 by Marc Audy in ue5-main branch]
2022-05-26 00:50:44 -04:00
Denys Dubinin
9c4cf836d5 ~~~ Remote Control Logic Core / Runtime changes ~~~
#jira UE-146247

Added new function to URCVirtualPropertyBase class:

* CopyCompleteValue - Provides support for copying the controller value onto a given FProperty. This will be used the RC Web API's GetPresetController route.
#preflight 628bd9d2183c1e134645e40a

[CL 20335117 by Denys Dubinin in ue5-main branch]
2022-05-23 15:18:42 -04:00
Elliot Colp
5dd755610e [WebRemoteControl] Move manual transaction timeout to a CVar
#jira: UE-151340
#rb: Alejandro.Arango
#preflight 6288165a7e018d20dc195123

[CL 20304652 by Elliot Colp in ue5-main branch]
2022-05-20 18:44:31 -04:00
Elliot Colp
e0a67fef06 [WebRemoteControl] Don't mix together struct fields when sending property updates
#jira: UE-151340
#rb: Alejandro.Arango, Jeremie.Roy
#preflight 6287ca731e478b95c729b852

[CL 20299104 by Elliot Colp in ue5-main branch]
2022-05-20 14:04:44 -04:00
Elliot Colp
39825987c5 [WebRemoteControl] Add WebSocket routes to control when transactions are created
#jira: UE-151340
#rb: Alejandro.Arango
#preflight 6286d359cf5ac7317c494b5a

[CL 20289121 by Elliot Colp in ue5-main branch]
2022-05-19 19:41:12 -04:00
George Rolfe
9316b050f5 RCPropertyContainer setter fix
#jira UE-151244
#rb simon.therriault
#preflight 6285b80f9016c6dd8965278e

[CL 20274951 by George Rolfe in ue5-main branch]
2022-05-18 23:44:18 -04:00
George Rolfe
f43055b426 RCPropertyUtilities cis fix
#jira none
#rb none
#preflight 6285ab427f55da1a6ed3d302

[CL 20274206 by George Rolfe in ue5-main branch]
2022-05-18 23:00:33 -04:00
George Rolfe
3eb92f797b RCP support for property setters
#jira none
#rb simon.therriault
#preflight 6285a4b5c77ffa7c35423bb9

[CL 20273706 by George Rolfe in ue5-main branch]
2022-05-18 22:20:17 -04:00
George Rolfe
724f9a7c8f LightComponent LightColor setter + RC patch
#jira UE-147609
#rb simon.therriault
#preflight 6285a4e1a474f8bb21896f08

[CL 20273701 by George Rolfe in ue5-main branch]
2022-05-18 22:17:42 -04:00
George Rolfe
2255e934f3 ProtocolBindingVM pointer cleanup
#jira UE-150808
#rb simon.therriault
#preflight 628593302b53e2be4c6e08f0

[CL 20273392 by George Rolfe in ue5-main branch]
2022-05-18 21:31:26 -04:00
Elliot Colp
9d7db4bdb1 [WebRemoteControl] Send property update messages for the same type as a single batch
Remove tracked actors when world is destroyed and ignore tracking for actors outside the current editor world
#jira: UE-151340
#rb: Alejandro.Arango, Jeremie.Roy
#preflight 62853fac882a1e5cd78f6ee3

[CL 20266375 by Elliot Colp in ue5-main branch]
2022-05-18 15:18:41 -04:00
Marc Audy
25478ced7f Fix non-unity errors
#preflight
#rnx

[CL 20255119 by Marc Audy in ue5-main branch]
2022-05-17 22:01:45 -04:00
Elliot Colp
39b71bbd0a [RemoteControl] Fix bound object pointers always returning a stale pointer after the map is reloaded
#jira: UE-151340
#rb: Alejandro.Arango, Jeremie.Roy
#preflight 627d54469f7ad2a14bf95ce1

[CL 20168405 by Elliot Colp in ue5-main branch]
2022-05-12 14:46:55 -04:00
lauren barnes
4b82e918fa Replacing legacy EditorStyle calls with AppStyle
#rb header and class name replacement

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20078276 via CL 20078825
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106316 by lauren barnes in ue5-main branch]
2022-05-09 13:51:26 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Denys Dubinin
14d9673794 Remote Control Logic.
Runtime part is ready for review
#rb simon.therriault

#jira UE-146247
#preflight 62728aa8ec1566a70616aeb1

[CL 20041750 by Denys Dubinin in ue5-main branch]
2022-05-04 10:43:42 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
George Rolfe
e0f3acf37b RC protocol mapping undo/redo crash fix
#jira UE-145254
#rb simon.therriault
#preflight 626a82e6464ae4f520efb9e3

[CL 20006171 by George Rolfe in ue5-main branch]
2022-05-01 23:49:44 -04:00