Commit Graph

54 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Geoffrey Douglas
7d3985da84 Centralize application of nodal offset to LensComponent, removing all references to nodal offset from the LiveLink camera controller
#jira UE-153107
#jira UE-146118
#rb simon.therriault
#preflight 628fe02174630984fd4eb26a

[CL 20385271 by Geoffrey Douglas in ue5-main branch]
2022-05-26 16:49:09 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Geoffrey Douglas
9f1a9bf6d5 Rename LensDistortionComponent to LensComponent and move from CameraCalibration plugin to CameraCalibrationCore plugin
Remove CameraCalibration module from CameraCalibration plugin
#rb simon.therriault
#preflight 62840673114e08fa2f3d59a8

[CL 20250823 by Geoffrey Douglas in ue5-main branch]
2022-05-17 17:04:38 -04:00
Jurre deBaare
631bec320b Moved RichCurve evaluation code from RichCurve.cpp to separate file and consolidated all instances of copy-pasta behaviour
#jira none
#rb Mike.Zyracki
#preflight 627cd946e97f57bf6cc98b8a

[CL 20162602 by Jurre deBaare in ue5-main branch]
2022-05-12 06:08:53 -04:00
geoffrey douglas
6b56d8c32f Fix camera calibration producing NANs on Vulkan
#jira UE-142731
#rb simon.therriault
#preflight 620e6a2f242ff267d4734926
#lockdown alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 19060582 in //UE5/Release-5.0/... via CL 19078444
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19121449 by geoffrey douglas in ue5-main branch]
2022-02-24 14:36:33 -05:00
geoffrey douglas
5b25666102 Properly initialize ImageDimensions script struct member
#jira UE-140884
#preflight 61faa58d1a71e1f04e92ff5e
#lockdown cristina.riveron
#rb simon.therriault

#ROBOMERGE-OWNER: geoffrey.douglas
#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18827623 in //UE5/Release-5.0/... via CL 18827793 via CL 18827887
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18827918 by geoffrey douglas in ue5-main branch]
2022-02-02 11:18:36 -05:00
andrew davidson
60a1fa84a7 Fix FVector2D variant casts - Plugins
Submitted on behalf of fred.kimberley
#rb andy.davidson
#preflight 61f86c4ca6632a34f35dfbca

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18800855 in //UE5/Release-5.0/... via CL 18802061 via CL 18802724
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18810177 by andrew davidson in ue5-main branch]
2022-02-01 12:08:54 -05:00
Marc Audy
c43360f47c Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#[fyi] Aurel.Cordonnier

#ushell-cherrypick of 18448630 by Marc.Audy
#preflight none

[CL 18483677 by Marc Audy in ue5-main branch]
2021-12-17 03:41:59 -05:00
geoffrey douglas
c9dd4b72e0 Nodal offset calibration algorithm for finding the optical axis of the lens and the entrance pupil position that lies along that axis
#preflight 61ba60dd23741afd577080f5
#rb alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475255 in //UE5/Release-5.0/... via CL 18480663 via CL 18480758
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18480888 by geoffrey douglas in ue5-main branch]
2021-12-16 18:31:30 -05:00
geoffrey douglas
65120afceb Nodal offset calibration algorithm for finding the optical axis of the lens and the entrance pupil position that lies along that axis
#preflight 61ba60dd23741afd577080f5
#rb alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475255 in //UE5/Release-5.0/... via CL 18480663
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18480758 by geoffrey douglas in ue5-release-engine-test branch]
2021-12-16 18:24:58 -05:00
chris norden
3e077f67e1 Moved more OpenCV convenience functions into OpenCVHelper
#rb geoffrey.douglas

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18460069 in //UE5/Release-5.0/... via CL 18460078 via CL 18460112
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v898-18417669)

[CL 18460143 by chris norden in ue5-main branch]
2021-12-14 16:27:58 -05:00
chris norden
d278e0906a Moved more OpenCV convenience functions into OpenCVHelper
#rb geoffrey.douglas

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18460069 in //UE5/Release-5.0/... via CL 18460078
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18460112 by chris norden in ue5-release-engine-test branch]
2021-12-14 16:27:10 -05:00
Marc Audy
f512a6d461 Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#fyi Aurel.Cordonnier

[CL 18448630 by Marc Audy in ue5-release-engine-test branch]
2021-12-13 15:59:48 -05:00
geoffrey douglas
85d1ffe95d [CameraCalibration] Add overlay rendering shader to draw crosshair at an off-center viewport position.
#jira none
#preflight 61ae664fc6650f98a96d4367
#rb simon.therriault

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18387409 in //UE5/Release-5.0/... via CL 18387425 via CL 18387443
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v896-18170469)

[CL 18387455 by geoffrey douglas in ue5-main branch]
2021-12-06 15:52:21 -05:00
geoffrey douglas
21fdc72657 [CameraCalibration] Add overlay rendering shader to draw crosshair at an off-center viewport position.
#jira none
#preflight 61ae664fc6650f98a96d4367
#rb simon.therriault

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18387409 in //UE5/Release-5.0/... via CL 18387425
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18387443 by geoffrey douglas in ue5-release-engine-test branch]
2021-12-06 15:51:30 -05:00
Marc Audy
8ba98596d9 Merge Release-Engine-Test @ 18241953
[CL 18242679 by Marc Audy in ue5-main branch]
2021-11-18 15:09:09 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
denys dubinin
1deaab7a4f Lens Calibration. Unit Test for Remove Points
#jira UETOOL-3784

#rb Simon.Therriault
#preflight 6182963a68a27b00010a6f5e

#ROBOMERGE-AUTHOR: denys.dubinin
#ROBOMERGE-SOURCE: CL 18191918 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v895-18170469)

[CL 18192010 by denys dubinin in ue5-release-engine-test branch]
2021-11-15 11:50:43 -05:00
Denys Dubinin
bc9ff75961 Lens Calibration. Unit Test for Remove Points
#jira UETOOL-3784

#rb Simon.Therriault
#preflight 6182963a68a27b00010a6f5e

[CL 18191918 by Denys Dubinin in ue5-main branch]
2021-11-15 11:47:13 -05:00
aurel cordonnier
6db40f979c Merge from Release-Engine-Test @ 18113376 to UE5/Main
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18118478 by aurel cordonnier in ue5-main branch]
2021-11-09 19:40:57 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
34f55d3a4a Merge from Release-Engine-Test @ 17946149 to UE5/Main
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17949667 by aurel cordonnier in ue5-main branch]
2021-10-27 15:14:40 -04:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
thales sabino
53e44b58a3 Add an importer for ulens files.
This makes it possible to associate a LensFile asset with a file on disk, so it can be reimported as well

#rb Simon.Therriault
#preflight 615f0c75cec44a000134ca74

#ROBOMERGE-AUTHOR: thales.sabino
#ROBOMERGE-SOURCE: CL 17905730 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v883-17842818)

[CL 17905747 by thales sabino in ue5-release-engine-test branch]
2021-10-25 09:36:52 -04:00