Commit Graph

60 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Geoffrey Douglas
7d3985da84 Centralize application of nodal offset to LensComponent, removing all references to nodal offset from the LiveLink camera controller
#jira UE-153107
#jira UE-146118
#rb simon.therriault
#preflight 628fe02174630984fd4eb26a

[CL 20385271 by Geoffrey Douglas in ue5-main branch]
2022-05-26 16:49:09 -04:00
Geoffrey Douglas
9f1a9bf6d5 Rename LensDistortionComponent to LensComponent and move from CameraCalibration plugin to CameraCalibrationCore plugin
Remove CameraCalibration module from CameraCalibration plugin
#rb simon.therriault
#preflight 62840673114e08fa2f3d59a8

[CL 20250823 by Geoffrey Douglas in ue5-main branch]
2022-05-17 17:04:38 -04:00
lauren barnes
4b82e918fa Replacing legacy EditorStyle calls with AppStyle
#rb header and class name replacement

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20078276 via CL 20078825
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106316 by lauren barnes in ue5-main branch]
2022-05-09 13:51:26 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
Geoffrey Douglas
5ee338d11b [CameraCalibration] Fix NonUnity compile error in CameraLensDistortionAlgoCheckerboard.cpp
#jira UE-146550
#preflight 623a0bb9ca34ffd7bf6de294
#rb simon.therriault

[CL 19470858 by Geoffrey Douglas in ue5-main branch]
2022-03-22 15:41:26 -04:00
Dominik Peacock
d017c2c53a Move SCustomDialog from UnrealEd to ToolWidgets
Unshelved from pending changelist '19221005':

#jira none
#rb Sebastian.Nordgren
#preflight 622105f6a00412627d0743ed

[CL 19311394 by Dominik Peacock in ue5-main branch]
2022-03-08 16:29:24 -05:00
Geoffrey Douglas
1853c78760 Fix PVS static analysis warnings
#jira UE-144643
#preflight 62278a4f695c94f981a96abb?step=29eb
#rb simon.therriault

[CL 19309303 by Geoffrey Douglas in ue5-main branch]
2022-03-08 15:13:02 -05:00
yali he
59f59aef87 Fix some remaining loc duplicate keys
#JIRA UE-143620
#rb Mitchell.Wilson
#preflight

#ROBOMERGE-AUTHOR: yali.he
#ROBOMERGE-SOURCE: CL 19148868 in //UE5/Release-5.0/... via CL 19149121
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19160953 by yali he in ue5-main branch]
2022-02-25 19:29:53 -05:00
geoffrey douglas
b1cb54a5f3 Fixed duplicate localization keys in VP-IO plugins
#jira UE-141508
#preflight 61fd8a50b5226316389684b7
#rb alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18892450 in //UE5/Release-5.0/... via CL 18892959 via CL 18893403
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18893418 by geoffrey douglas in ue5-main branch]
2022-02-07 16:29:26 -05:00
robert manuszewski
97b5e82c0b Deprecating EInternalObjectFlags::PendingKill. Making sure iterators use the appropriate flags based on the current state of PendingKill being enabled or not.
#preflight 61f8f33d537702981c352c7a
#rb Steve.Robb

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 18806353 in //UE5/Release-5.0/... via CL 18808526 via CL 18821789
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822151 by robert manuszewski in ue5-main branch]
2022-02-02 02:21:12 -05:00
andrew davidson
60a1fa84a7 Fix FVector2D variant casts - Plugins
Submitted on behalf of fred.kimberley
#rb andy.davidson
#preflight 61f86c4ca6632a34f35dfbca

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18800855 in //UE5/Release-5.0/... via CL 18802061 via CL 18802724
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18810177 by andrew davidson in ue5-main branch]
2022-02-01 12:08:54 -05:00
geoffrey douglas
16a387f24e [CameraCalibration] Distortion calibration algo based on an arbitrary set of 2D-3D point correspondences
#jira UE-138743
#rb alejandro.arango, simon.therriault
#preflight 61eacb72460e5880b40fccd4

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18689722 in //UE5/Release-5.0/... via CL 18689742 via CL 18689754
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18689877 by geoffrey douglas in ue5-main branch]
2022-01-21 10:52:40 -05:00
geoffrey douglas
16261748f7 Add scroll boxes to the camera calibration right and bottom panels to avoid widgets getting squished.
#jira UE-139853
#rb jeremie.roy
#preflight 61e9d6c6ab6e1cc028bb3ff7

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18682150 in //UE5/Release-5.0/... via CL 18682174 via CL 18682201
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18682222 by geoffrey douglas in ue5-main branch]
2022-01-20 16:57:43 -05:00
simon therriault
0ea46cf1e2 - Updating opencv to 4.5 version
- still Windows platform only

#jira UETOOL-4742
#rb geoffrey.douglas, alejandro.arango, chris.norden
#preflight 61e817fd614a721b0c41c7d0

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18657870 in //UE5/Release-5.0/... via CL 18657890 via CL 18657913
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18657937 by simon therriault in ue5-main branch]
2022-01-19 09:46:08 -05:00
Marc Audy
c43360f47c Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#[fyi] Aurel.Cordonnier

#ushell-cherrypick of 18448630 by Marc.Audy
#preflight none

[CL 18483677 by Marc Audy in ue5-main branch]
2021-12-17 03:41:59 -05:00
geoffrey douglas
cce4808a15 [CameraCalibration] Fix LensInfo step to be Transactional to properly support undo
#rb trivial
#preflight 61bb4e86f56c20cf093fed68

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475562 in //UE5/Release-5.0/... via CL 18481191 via CL 18481222
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18481266 by geoffrey douglas in ue5-main branch]
2021-12-16 19:12:20 -05:00
geoffrey douglas
39721ddb0c [CameraCalibration] Fix LensInfo step to be Transactional to properly support undo
#rb trivial
#preflight 61bb4e86f56c20cf093fed68

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475562 in //UE5/Release-5.0/... via CL 18481191
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18481222 by geoffrey douglas in ue5-release-engine-test branch]
2021-12-16 19:10:06 -05:00
geoffrey douglas
5b59229346 Remove "Save Lens Information" button from LensInfo step in LensFile editor. Changes made to the LensInfo in the details panel are now applied directly to the LensFile.
#rb alejandro.arango
#preflight 61bb45423961edbe76e1b25b

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475311 in //UE5/Release-5.0/... via CL 18481093 via CL 18481097
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18481099 by geoffrey douglas in ue5-main branch]
2021-12-16 18:59:32 -05:00
geoffrey douglas
d991a0ef44 Remove "Save Lens Information" button from LensInfo step in LensFile editor. Changes made to the LensInfo in the details panel are now applied directly to the LensFile.
#rb alejandro.arango
#preflight 61bb45423961edbe76e1b25b

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475311 in //UE5/Release-5.0/... via CL 18481093
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18481097 by geoffrey douglas in ue5-release-engine-test branch]
2021-12-16 18:58:54 -05:00
geoffrey douglas
c9dd4b72e0 Nodal offset calibration algorithm for finding the optical axis of the lens and the entrance pupil position that lies along that axis
#preflight 61ba60dd23741afd577080f5
#rb alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475255 in //UE5/Release-5.0/... via CL 18480663 via CL 18480758
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18480888 by geoffrey douglas in ue5-main branch]
2021-12-16 18:31:30 -05:00
geoffrey douglas
65120afceb Nodal offset calibration algorithm for finding the optical axis of the lens and the entrance pupil position that lies along that axis
#preflight 61ba60dd23741afd577080f5
#rb alejandro.arango

#ROBOMERGE-AUTHOR: geoffrey.douglas
#ROBOMERGE-SOURCE: CL 18475255 in //UE5/Release-5.0/... via CL 18480663
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18480758 by geoffrey douglas in ue5-release-engine-test branch]
2021-12-16 18:24:58 -05:00
chris norden
3e077f67e1 Moved more OpenCV convenience functions into OpenCVHelper
#rb geoffrey.douglas

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18460069 in //UE5/Release-5.0/... via CL 18460078 via CL 18460112
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v898-18417669)

[CL 18460143 by chris norden in ue5-main branch]
2021-12-14 16:27:58 -05:00
chris norden
d278e0906a Moved more OpenCV convenience functions into OpenCVHelper
#rb geoffrey.douglas

#ROBOMERGE-AUTHOR: chris.norden
#ROBOMERGE-SOURCE: CL 18460069 in //UE5/Release-5.0/... via CL 18460078
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18460112 by chris norden in ue5-release-engine-test branch]
2021-12-14 16:27:10 -05:00