- fixed crash (lookup out of date) in flee fallback behavior
- fixe left overd issues from an older review 19243357
#jira UE-148343
#review
#preflight 6262502b4c7bb31da22101b4
[CL 19861852 by mikko mononen in ue5-main branch]
#jira UE-144360
#rb yoan.stamant mieszko.zielinski
#preflight 622129a9bf662715a8cb85f2
#lockdown julien.marchand
- Made AMassSpawner visible in non-shipping/testing so that component debug draw works
- Fixed crash in UZoneGraphAnnotationComponent::OnUnregister() when component is edited BP editor
- Added debug draw culling to ZoneGraph Disturbance annotations and ZoneGraph Crowd Lane annotations
- Fixed flee lane tags on CitySample (flee would try to use sidewalks, which causes problems)
- Added fallback for flee calculation when there are no exists
- Added helper functions to UZoneGraphAnnotationComponent to add distance culling for debug draws
#ROBOMERGE-AUTHOR: mikko.mononen
#ROBOMERGE-SOURCE: CL 19253567 in //UE5/Release-5.0/... via CL 19257906
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)
[CL 19263528 by mikko mononen in ue5-main branch]
- Removed ununed processors and fragments
- Separated ZoneGraph specific things from common movement and navigation fragments and processors
- First attempt at cleaner separation between Mass Movement and Mass Navigation
- Moved configs and hard coded values to shared fragments
- Simplified and clarified parameters
#jira none
#rb Aris.Theophanidis
#preflight 61f283b61e5d78c383072b4a
#ROBOMERGE-AUTHOR: mikko.mononen
#ROBOMERGE-SOURCE: CL 18752305 in //UE5/Release-5.0/... via CL 18752314 via CL 18752372
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)
[CL 18752384 by mikko mononen in ue5-main branch]
In some code paths for loaded actors the call order might be different since primitive registration gets deferred (i.e. FRegisterComponentContext != nullptr).
Case 1 (normal flow): FRegisterComponentContext == nullptr
> UPrimitiveComponent::CreateRenderState_Concurrent : calls CreateSceneProxy
> RegisterDebugDrawDelegate
> UnregisterDebugDrawDelegate ==> works fine
Case 2 (deferred AddPrimitive): FRegisterComponentContext != nullptr
> UPrimitiveComponent::CreateRenderState_Concurrent : defers CreateSceneProxy
> RegisterDebugDrawDelegate (skip register since not init)
> CreateSceneProxy
> UnregisterDebugDrawDelegate ==> ensures in UnregisterDebugDrawDelegate
With this new version `CreateRenderState_Concurrent` calls `RequestRegisterDebugDrawDelegate` that will take care of registering the delegate immediately or mark it for deferred execution. An explicit call to `ProcessDeferredRegister` is then required from `CreateSceneProxy` to implement proper flow:
Case 2 (fixed) (deferred AddPrimitive + deferred Register): FRegisterComponentContext != nullptr
> UPrimitiveComponent::CreateRenderState_Concurrent: defers CreateSceneProxy
> RequestRegisterDebugDrawDelegate: defers RegisterDebugDrawDelegate
> CreateSceneProxy: calls ProcessDeferredRegister & RegisterDebugDrawDelegate
> UnregisterDebugDrawDelegate ==> works fine
Bonus:
- New DebugDrawComponent abstract class that is now used to share common functionalities between existing debug related components. Takes care of DelegateHelper registration flow to render text on screen from different sources.
- FDebugDrawDelegateHelper::InitDelegateHelper is no longer virtual and derived classes requiring extra data from their associated scene proxy should set it up from their overriden CreateSceneProxy
- FDebugDrawDelegateHelper derived classes should not override RegisterDebugDrawDelegate/UnregisterDebugDrawDelegate to use their `DrawDebugLabels` method since this is already a virtual method that would get called from the base class.
- Fixed a few ViewFlag members in the SceneProxy so the DelegateHelper base class can behave as expected
#jira FORT-419154
#rb mieszko.zielinski
#robomerge FnMain
#preflight 61703f8766ed7f0001c0faf1
[CL 17875336 by Yoan StAmant in ue5-main branch]
Moved SmartObjects out of restricted folder
Moved StateTree out of restricted folder
Moved ZoneGraph out of restricted folder
Moved ZoneGraphAnnotations out of restricted folder
#jira UE-115297
#ROBOMERGE-OWNER: mieszko.zielinski
#ROBOMERGE-AUTHOR: mieszko.zielinski
#ROBOMERGE-SOURCE: CL 17648223 via CL 17648246 via CL 17648261 via CL 17648385 via CL 17648390 via CL 17648742
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v875-17642767)
[CL 17648750 by mieszko zielinski in ue5-main branch]