Commit Graph

170 Commits

Author SHA1 Message Date
rob gay
f4d6d39ff5 Fix for Undoing/Redoing change to a MetaSound not propagating to other referencing MetaSounds.
#rb phil.popp
#rnx
#jira UE-137481
#preflight 6205f4cc69224cb0d8912fd7

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18983245 in //UE5/Release-5.0/... via CL 18983457 via CL 18983733
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18983749 by rob gay in ue5-main branch]
2022-02-14 14:25:01 -05:00
helen yang
bb284960b2 Compile out FText from MetaSound Nodes in non editor builds
#rb rob.gay
#preflight 62057365a155a4cddac5bf1d
#jira UE-142194

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18945030 in //UE5/Release-5.0/... via CL 18945230 via CL 18946167
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18946312 by helen yang in ue5-main branch]
2022-02-10 18:36:47 -05:00
rob gay
45e4645008 Compile out editor-only data from MetaSoundFrontend
- Move Author field to FString to avoid generated text collisions (Authors should always be culture invariant anyway) & add option to override default in MetaSound user settings
#rb helen.yang
#jira UE-142159
#preflight 62055c89057375a802938669

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18941073 in //UE5/Release-5.0/... via CL 18941268 via CL 18941634
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941665 by rob gay in ue5-main branch]
2022-02-10 15:07:39 -05:00
phil popp
e11afa41f0 Fix for metasound waveplayer pop on PCM audio
#jira UE-141570
#rb helen.yang
#preflight 62044d022f56bd0ebfa2184c

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18928111 in //UE5/Release-5.0/... via CL 18931097 via CL 18931389
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18932016 by phil popp in ue5-main branch]
2022-02-10 00:30:57 -05:00
rob gay
6d4096c2af - Reduce MetaSounds loaded on Editor startup by moving additional MetaSound loads/registration to occur when MetaSoundEditor is loaded
- Add UX to communicate on first asset editor load that MetaSounds are still loading and class picker results may be incomplete
#rb phil.popp
#jira UE-134364
#rnx
#preflight 6202b588bf28c072cbf2faeb

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18911432 in //UE5/Release-5.0/... via CL 18919339 via CL 18920527
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18920775 by rob gay in ue5-main branch]
2022-02-09 12:52:44 -05:00
phil popp
d7bcb9e7a4 Fix for altered volume when using a mono wave file in a metasound wave player node.
#jira UE-141262
#rb Max.Hayes
#preflight 6201c188e85c7a08bbcbefa5

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18906409 in //UE5/Release-5.0/... via CL 18906649 via CL 18907001
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v915-18905420)

[CL 18907023 by phil popp in ue5-main branch]
2022-02-08 14:13:09 -05:00
phil popp
7742829e5d Fix AudioModulations Metasound Node audio device in PIE
#jira UE-138516
#preflight 61fdbae4cc13ffbd10f6bbe5
#lockdown nick.whiting
#rb rob.gay

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18894988 in //UE5/Release-5.0/... via CL 18895269 via CL 18895513
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18895534 by phil popp in ue5-main branch]
2022-02-07 18:00:45 -05:00
aaron mcleran
8db0b74958 Cleaning up codec definitions on soundwaves.
- Adding new enumeration to select PCM, ADPCM, Bink, and "platform specific"
- Updated platform codecs and various APIs to select correctly which codec to use
- Changed "is seekable streaming" semantics to "Is Seekable" since that is more correct in a post-stream-caching world
- Tried to clean up platform backends. Unable to move Bink decoder to multiplatform code because of module dependencies, will require a future refactor of our decoder module setup.

#rb Phil.Popp, Jimmy.Smith
#jira UE-140860
#preflight 61f97ad7f02e20f45add6d45

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18813332 in //UE5/Release-5.0/... via CL 18813341 via CL 18822758
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824290 by aaron mcleran in ue5-main branch]
2022-02-02 07:35:13 -05:00
rob gay
6887608d07 - Version MetaSound asset graph name FText being generated from file name & copied to MetaSound asset.
- Add missing user-defined fields to MetaSound graph options (ex. IsDeprecated, Keywords, etc.) and force update on transient style changeID (TODO: Probably would make more sense for Metadata FText to live on style struct and share that transient ChangeID, so that non-runtime changes to FText metadata wouldn't bump the change ID)
[CODEREVIEW] helen.yang
#jira UE-137696
#rnx
#preflight 61f870c0a6632a34f35e5e3c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18805501 in //UE5/Release-5.0/... via CL 18807964 via CL 18821755
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822116 by rob gay in ue5-main branch]
2022-02-02 02:19:16 -05:00
rob gay
90a3fc277e Move asset loading logs to verbose to avoid spamming editor on load
#rb trivial
#jira none
#rnx
[FYI] sondra.moyls
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18793996 in //UE5/Release-5.0/... via CL 18794666 via CL 18795168
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18795943 by rob gay in ue5-main branch]
2022-01-31 15:27:41 -05:00
phil popp
662b778281 Fix for metasound wave player node using incorrect OnNearlyDone trigger index
#rnx
#rb trivial
#jira none
#preflight skip

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18775135 in //UE5/Release-5.0/... via CL 18775407 via CL 18775692
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18775727 by phil popp in ue5-main branch]
2022-01-28 14:02:03 -05:00
phil popp
ce4d6652d0 Fix CIS linker issue
#okforgithbu public
#rnx
#rb none
#jira none
#preflight skip

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18748569 in //UE5/Release-5.0/... via CL 18748578 via CL 18748643
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18748662 by phil popp in ue5-main branch]
2022-01-26 20:26:26 -05:00
phil popp
44fc0c38c2 Rework Metasound Wave Player
#jira UE-134456
#rb Aaron.McLeran
#preflight 61f1e6c2f8088a3d299c5b9a

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18748267 in //UE5/Release-5.0/... via CL 18748279 via CL 18748380
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18748393 by phil popp in ue5-main branch]
2022-01-26 19:58:08 -05:00
rob gay
e00c7856fa Move any places where FText is copied to a MetaSound document to transient UProperties that are populated by external registries (i.e. the interface registry & the class registry)
#rb phil.popp
#rnx
#jira none
#preflight 61f1cc37c0033b39f89ee39c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18746974 in //UE5/Release-5.0/... via CL 18746984 via CL 18747190
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18747199 by rob gay in ue5-main branch]
2022-01-26 18:11:52 -05:00
maxwell hayes
b5d37cfbb1 Fix for crash when metasound wave player uses ForceInline-ed audio on some platforms (increased decode size).
#rb Aaron.McLeran
#jira UE-137715
#preflight 61ef42b6ca3de856bce22a7d

#ROBOMERGE-AUTHOR: maxwell.hayes
#ROBOMERGE-SOURCE: CL 18717853 in //UE5/Release-5.0/... via CL 18717885 via CL 18718013
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18718038 by maxwell hayes in ue5-main branch]
2022-01-24 19:42:07 -05:00
aaron mcleran
48af5ea956 Fixing up warnings about one-shots with MetaSounds
- changing GetDuration(), IsLooping(), and IsOneShot() to be const for better consistency on API (const-cast the one case that is not const for caching data)
- Renaming SoundCue param in GameplayCueNotify for sounds to Sound since it's not a SoundCue.

#rb Rob.Gay, Maxwell.Hayes
#jira UE-138532
#preflight https://horde.devtools.epicgames.com/job/61e73d73b56c33b8ecfadb1a
#p4v-preflight-copy 18647645

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18650552 in //UE5/Release-5.0/... via CL 18650576 via CL 18650607
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18650642 by aaron mcleran in ue5-main branch]
2022-01-18 18:05:56 -05:00
aaron mcleran
cafeb6e075 Backward compat for IsLooping() to fix some issues.
#jira UE-137171
#rb Dan.Reynolds
#preflight none

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18607155 in //UE5/Release-5.0/... via CL 18607179 via CL 18607198
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18607224 by aaron mcleran in ue5-main branch]
2022-01-13 17:34:30 -05:00
rob gay
522b5ad474 Split Modulation Registration into actual registration/Modulation proxy generation vs Settings construction to support AudioDevice-less DATAProxy generation
- Made modulator settings objects stateless & removed AudioDevice dependency in mod settings constructors.
- Required moving ModulationParameters to thread-safe registered singleton registry in AudioExtensions and out of plugin
- Rename IAudioModulation/FAudioModulation to IAudioModulationManager/FAudioModulationManager for clarity
#rb phil.popp
#jira UE-138516
#rnx
#preflight 61ddc6b9f33c075417271dc2

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18574824 in //UE5/Release-5.0/... via CL 18574848
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18574874 by rob gay in ue5-release-engine-test branch]
2022-01-11 13:52:09 -05:00
aaron mcleran
7fe9a945c8 Fixing versioning with metasounds
#jira UE-137762
#rb Rob.Gay
#preflight trivial

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18481426 in //UE5/Release-5.0/... via CL 18481578
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18481840 by aaron mcleran in ue5-release-engine-test branch]
2021-12-16 19:59:03 -05:00
aaron mcleran
0ffa11ba73 Adding new interface for one-shots, upgrading old metasounds to use new interface if they hooked up the on-finished trigger.
Great test-case for interfaces and our upgrade code paths.

#rb Rob.Gay
#jira UE-137708
#preflight 61ba7d64753a9d8c87c2a038

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18472322 in //UE5/Release-5.0/... via CL 18473370
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18473402 by aaron mcleran in ue5-release-engine-test branch]
2021-12-15 23:11:10 -05:00
rob gay
753d3eb20a Ensure registration of engine-level parameter interfaces by MetaSoundEngine Module and split out from loading default settings call in AudioSettings (can happen on app load if cooking and AudioDeviceManager isn't loaded).
#rb aaron.mcleran
#jira UE-137597
#rnx
[FYI] sondra.moyls
#preflight 61ba4f9823741afd576c1e0f

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18470944 in //UE5/Release-5.0/... via CL 18470970
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18470975 by rob gay in ue5-release-engine-test branch]
2021-12-15 16:05:33 -05:00
anna lantz
dcb0dc50ad Removing blacklist terminology from MetaSound settings
#jira UE-136369
#rb trivial
#preflight 61b418e66f369ba19f3af5e4

#ROBOMERGE-AUTHOR: anna.lantz
#ROBOMERGE-SOURCE: CL 18438192 in //UE5/Release-5.0/... via CL 18444715
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18444844 by anna lantz in ue5-release-engine-test branch]
2021-12-13 13:15:05 -05:00
rob gay
3bdc09e2a5 Backout out backed out changelist 18369256 (includes AudioComponent redirect fix)
-----------------------------------------------------------------
MetaSounds Interfaces Checkpoint 2:
- Version up source archetypes to become two interfaces: channel interfaces (mono/stereo) & base source namespace
- Clean-up Interface panel to support namespacing better
- Fix bugs with assuming interfaces are always and the only base namespace members
- Allow namespacing for any arbitrary interface member
- Add lock icon to clarify what interface members cannot be modified individually (i.e. cannot add, remove, or rename them as they are interface members)
- Organize members alphabetically
#jira UE-135000
#rnx
#rb phil.popp
#preflight 61a7d1079c77d610079303ec
#p4v-cherrypick 18344347

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18413245 via CL 18413381 via CL 18413401 via CL 18434953 via CL 18437303
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18437360 by rob gay in ue5-release-engine-test branch]
2021-12-10 20:37:31 -05:00
aurel cordonnier
3e68a3edef [Backout] - CL18345215
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
MetaSounds Interfaces Checkpoint 2:
- Version up source archetypes to become two interfaces: channel interfaces (mono/stereo) & base source namespace
- Clean-up Interface panel to support namespacing better
- Fix bugs with assuming interfaces are always and the only base namespace members
- Allow namespacing for any arbitrary interface member
- Add lock icon to clarify what interface members cannot be modified individually (i.e. cannot add, remove, or rename them as they are interface members)
- Organize members alphabetically
#jira UE-135000
#rnx
#rb phil.popp
#preflight 61a7d1079c77d610079303ec
#p4v-cherrypick 18344347

#ROBOMERGE-AUTHOR: aurel.cordonnier
#ROBOMERGE-SOURCE: CL 18369256 via CL 18369273 via CL 18369290 via CL 18434224 via CL 18435611
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18436532 by aurel cordonnier in ue5-release-engine-test branch]
2021-12-10 19:13:22 -05:00
aaron mcleran
704575bff1 Fixing waveplayer tooltip
#jira UE-116875
#rb trivial

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18426948 in //UE5/Release-5.0/... via CL 18427098
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18427130 by aaron mcleran in ue5-release-engine-test branch]
2021-12-09 18:59:08 -05:00