Commit Graph

696 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Rob Gay
7ecfe9175e Fix for missing enum ensure through second missed ctor
#rnx
#jira UE-147220
#rb trivial
#preflight 629681bb5238916c514b3b97

[CL 20444298 by Rob Gay in ue5-main branch]
2022-05-31 19:10:07 -04:00
Rob Gay
b3b1847b7f MetaSound animated connection optimizations/minor improvements
- Don't copy point array, just add wrapped accessor for simple FloatWindow
- Move to drawing lines instead of a bunch of bubble images
- Add max number of draw segments
- Add cvars for tweaking
- Split out numeric & envelope thickness options
#rb helen.yang
#jira UE-153987
#rnx
#preflight 62967f0a9d75300f41bdb820

[CL 20444237 by Rob Gay in ue5-main branch]
2022-05-31 19:05:10 -04:00
Aaron McLeran
75d30b02e5 Fixing tooltip loctext namespace
#rb none
#jira none
#preflight none

[CL 20444203 by Aaron McLeran in ue5-main branch]
2022-05-31 19:00:48 -04:00
Aaron McLeran
0c4b32c059 Changing display name of PitchShift node to "delay pitch shift"
#rb none
#jira none
#preflight none

[CL 20443100 by Aaron McLeran in ue5-main branch]
2022-05-31 17:50:00 -04:00
Aaron McLeran
ae9ca7c01f Grain Delay Node
- Fix for compressor for limiter case (removed unncessarily clamp on detector output)

#jira UE-150598
#rb Dan.Reynolds, Maxwell.Hayes, Jimmy.Smith
#preflight 6291227bbc1213abd7dc43bd

[CL 20442694 by Aaron McLeran in ue5-main branch]
2022-05-31 17:14:23 -04:00
anna lantz
f01df4a3ab Fix for generator nodes behaving incorrectly when given negative frequencies
#jira UE-152354
#rb phil.popp
#preflight 62853718614041edb79f8bb0
#p4v-cherrypick 20265411
#preflight 628eceb7a3384b0a96b92c64

#ROBOMERGE-AUTHOR: anna.lantz
#ROBOMERGE-SOURCE: CL 20404406 in //UE5/Release-5.0/... via CL 20406514
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20406985 by anna lantz in ue5-main branch]
2022-05-28 07:36:47 -04:00
aaron mcleran
9f6bbe1698 Trigger route fix
#jira UE-146466, UE-153239
#rb Maxwell.Hayes
#preflight 6290f6166c4b4192f2a1bb9e

#ROBOMERGE-OWNER: aaron.mcleran
#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 20395550 in //UE5/Release-5.0/... via CL 20398380
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20401217 by aaron mcleran in ue5-main branch]
2022-05-27 19:30:23 -04:00
Aaron McLeran
d2bc4d3555 Trigger route fix part 2
- Better fix, CL 20297675 introduced

#jira UE-146466, UE-153239
#rb Maxwell.Hayes
#preflight 6290f6166c4b4192f2a1bb9e

[CL 20395031 by Aaron McLeran in ue5-main branch]
2022-05-27 12:53:21 -04:00
phil popp
8efec09fb3 MetaSound: Add vertex access type to frontend document in order to support constructor pins.
#jira UE-151659
#preflight 628ff53e8c077c0d6628377b

[CL 20386454 by phil popp in ue5-main branch]
2022-05-26 17:59:27 -04:00
jimmy smith
b987fbbe0e Fix for Cook warning/content validation
#preflight none

[CL 20384864 by jimmy smith in ue5-main branch]
2022-05-26 16:32:38 -04:00
Leon Huang
19877e39c5 Fix for duplicate localization key warnings and missing localization defines/undefines in various files.
#rnx
#rb: Vincent.Gauthier
#jira: UE-151614
#preflight: 628fc4a98c23e52ef0fdfa7d

[CL 20384450 by Leon Huang in ue5-main branch]
2022-05-26 16:11:10 -04:00
jimmy smith
2093834e8d Fixed up TObjectPtr for Metasounds as I had warnings as errors on
#rb rob.gay
#jira none
#preflight 628fc3ff74630984fd46f137

[CL 20383257 by jimmy smith in ue5-main branch]
2022-05-26 15:06:53 -04:00
Aaron McLeran
28e9de2061 Doppler Pitch Shift Node
#rb Maxwell.Hayes
#jira UE-151343
#preflight 6288121f9b098f85416f3ed2

[CL 20373739 by Aaron McLeran in ue5-main branch]
2022-05-25 19:53:29 -04:00
anna lantz
7cd176edc4 Fix for frequency modulation going above Nyquist
#jira UE-153370
#rb phil.popp
#preflight 628eb3019a2b52f7c7fb961d

[CL 20373141 by anna lantz in ue5-main branch]
2022-05-25 19:07:19 -04:00
phil popp
22d9cb3137 Metasound: Add constuctor vertex info to data type registration.
#jira UE-151659
#preflight 628e3a7ceb57f851e227976b

[CL 20364388 by phil popp in ue5-main branch]
2022-05-25 10:29:35 -04:00
helen yang
bfeda1bb29 Fix MetaSound editor meter channel count being incorrect resulting in incorrect meter values for mono sources
#jira UE-153872
#rb rob.gay
#preflight 628d0a79710271c31824286e

[CL 20356800 by helen yang in ue5-main branch]
2022-05-24 17:55:21 -04:00
alfaroh corneyiii
b17e186979 "Using Native Audio" Telemetry
#jira UE-151075
#rb rob.gay helen.yang
#preflight 628c08e4183c1e1346577d5a

[CL 20341003 by alfaroh corneyiii in ue5-main branch]
2022-05-23 18:58:53 -04:00
helen yang
1a31dac048 Properly update MetaSound node positions when nodes are moved with comment nodes or by alignment actions
#jira UE-147971
#rb rob.gay
#preflight 6287e90a7e018d20dc0de915

[CL 20334468 by helen yang in ue5-main branch]
2022-05-23 14:56:04 -04:00
robert manuszewski
be1c20b7ff Reverting accidentally submitted files
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20315042 via CL 20315044 via CL 20315048 via CL 20315049
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315217 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:23 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Rob Gay
3ab1010fde Fix for implicit bool cast with MetaSound boolean connection animation throwing build warnings
#rb trivial
#jira UE-153318
#rnx
#preflight 6287efa88828ea88c87d1448

[CL 20302347 by Rob Gay in ue5-main branch]
2022-05-20 16:29:01 -04:00
phil popp
c75259278f CIS fix for audio low level test failure.
#jira UE-153192
#rb trivial
#rnx
#preflight 62879fdc9b764703c301909c

[CL 20293932 by phil popp in ue5-main branch]
2022-05-20 10:11:42 -04:00
phil popp
a07731a335 CIS build fix for MetasoundVertexData
#rnx
#jira none
#rb trivial
#preflight 6286ba42045aba2279782ab4

[CL 20288249 by phil popp in ue5-main branch]
2022-05-19 17:52:23 -04:00
Rob Gay
ca643f250e MetaSound Editor Analyzer Checkpoint
#rb helen.yang
#jira UE-147027
#rnx
#preflight 62855a90614041edb7a54d23

[CL 20285298 by Rob Gay in ue5-main branch]
2022-05-19 15:24:49 -04:00