Commit Graph

126 Commits

Author SHA1 Message Date
simon orr
6c4e29aa7a Fix to null dereference when calculating memory stats.
#rb Evgenii.Babinets

#ROBOMERGE-AUTHOR: simon.orr
#ROBOMERGE-SOURCE: CL 20431038 via CL 20433869 via CL 20435498 via CL 20435573
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448503 by simon orr in ue5-main branch]
2022-06-01 03:47:15 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Mieszko Zielinski
874965ac1a Mass: Added more visually informative flat processing graph logging, essentially describing processors' runtime dependencies.
#preflight 62963748e62c873b96cca4df

[CL 20438151 by Mieszko Zielinski in ue5-main branch]
2022-05-31 12:05:37 -04:00
Mieszko Zielinski
a11057ff5e Fixes to mass dependency solving required by failing unit tests.
* readded previously removed duplicates handling
* improved one of the dependency tests and improved the solving algorithm to handle "execute before group"-kind of dependencies.

#review-20364357
#preflight 628e3f1a9f6fbd94adf5bbb4

[CL 20367147 by Mieszko Zielinski in ue5-main branch]
2022-05-25 12:54:17 -04:00
Mieszko Zielinski
513eabbb45 Improved resource-base dependencies.
The main change is that if a processor P in group A depends on a processor R in group B we no longer infer group A depending on group B (which was the case previously). In fact, groups are no longer represented outside of dependency solving step - once dependencies are solved we end up with a list of processors ordered in a way respecting both declared "execute after" and "execute before" dependencies but also dependencies resulting from requirements declared by Processors' queries (the latter part has practical meaning in single-threaded mode).
As part of this CL remnants of old approaches have been cut, along with the PARALLELIZED_TRAFFIC_HACK (which is not compatible with the how phase-composite-processor stored its child processors, i.e. in a flat list).

#review-20329323
#preflight 628bcc6f693c5e1de28c8f1a
#preflight 628cc759f057b981ca578f4e

[CL 20346695 by Mieszko Zielinski in ue5-main branch]
2022-05-24 08:23:12 -04:00
Mieszko Zielinski
cf1347fca6 Fixed one execution path of MassEntityQuery::ForEachEntityChunk not releasing aquired resource access detectors
#rb trivial
#preflight skip

[CL 20332679 by Mieszko Zielinski in ue5-main branch]
2022-05-23 13:49:39 -04:00
Mieszko Zielinski
4a77314ec8 Fixed Mass's test-time processors failing ensure in FMassEntityQuery::ForEachEntityChunk due to not having registered their entity queries
#rb trivial
#preflight skip

[CL 20332229 by Mieszko Zielinski in ue5-main branch]
2022-05-23 13:29:59 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Mieszko Zielinski
1b0e1ef841 Replaced FMassTweakables with UE::Mass::Tweakables in MassProcessingPhase.cpp
#rb trivial
#preflight skip

[CL 20292461 by Mieszko Zielinski in ue5-main branch]
2022-05-20 06:25:48 -04:00
Mieszko Zielinski
55c7bd5a8a Renamed UE::MassEntity namespace to UE::Mass
#rb Mikko.Mononen
#preflight skip

[CL 20277986 by Mieszko Zielinski in ue5-main branch]
2022-05-19 06:35:38 -04:00
Mieszko Zielinski
b89eb0fac0 Revived MASS_DO_PARALLEL implementation. Disabled by default.
#review-20258306
#preflight 6284ad80614041edb75c401e
#preflight 6284b597ba3597a030e3e4ef

[CL 20258528 by Mieszko Zielinski in ue5-main branch]
2022-05-18 05:20:23 -04:00
Mieszko Zielinski
90c9694fe4 Made MassEntityQuery.ForEachEntityChunk's path for entity collection utilize stored requirements mapping if given archetype is "known" by the query (i.e. its one of the cached archetypes). This is the most common case and reusing mapping save nontrivial of work.
#review-20258099
#preflight 62849aeb486700b561d02bd8

[CL 20258157 by Mieszko Zielinski in ue5-main branch]
2022-05-18 03:39:25 -04:00
Mieszko Zielinski
76236ec52d Marked a number of Mass or Mass-used systems as save to be accessed off-game-thread.
Also added a dedicated traits template for shared fragments.

As part of implementation added a dedicated MassGameplay module for storing TMassExternalSubsystemTraits declared for subsystems external to Mass code that the MassGameplay plugin's modules are using.

#jira UE-152550
#review-20242604
#preflight 6283c6ed18591b86df9346e0
#preflight 6283f43f0a585259b1ac8e04

[CL 20249633 by Mieszko Zielinski in ue5-main branch]
2022-05-17 15:40:34 -04:00
Mieszko Zielinski
9be0cf2bda Requirement-based processor dependencies.
This version only expands on current declaration-based dependencies. More iterations to come.

#review-20239911
#preview 62836e380039ea57a5342daf
#preflight 6283b1944316db80d18e7bd3

[CL 20243066 by Mieszko Zielinski in ue5-main branch]
2022-05-17 10:53:38 -04:00
Mieszko Zielinski
60318d6a24 Exporting mass processor requirements
#review-20221126
#preflight 628212a5db627d25bd5dc3b9

[CL 20221445 by Mieszko Zielinski in ue5-main branch]
2022-05-16 05:26:24 -04:00
Mieszko Zielinski
ce38e79d53 Fixed missing header in MassRequirementAccessDetector.cpp
#jira UE-151892
#rb trivial
#preflight skip

[CL 20180935 by Mieszko Zielinski in ue5-main branch]
2022-05-13 10:19:32 -04:00
Mieszko Zielinski
606165b6d5 Added a way to mark up MassEntityQueries as owned by a processor and auto-registering such queries. Also added some verication code that ensures all queries run as part of processors are properly marked up as such.
This is a prerequisite step to support fetching processors' requirements.

Updated all the queries owned by processors at this moment.

#review-20178362
#preflight 627e2b2d9650a277336b85e1
#preflight 627e37860d2d1f6ed8be0d95

[CL 20179262 by Mieszko Zielinski in ue5-main branch]
2022-05-13 07:07:16 -04:00
Mieszko Zielinski
9fb49db23d Implemented a helper, debug-time tool for detecting MT access to requirements declared by MassEntityQueries
#review
#preflight 627b9a449f7ad2a14b4995ac
#preflight 627ce1a180307e522bcbcfa0

[CL 20162912 by Mieszko Zielinski in ue5-main branch]
2022-05-12 06:53:18 -04:00
Mieszko Zielinski
ba65be6fe2 Massaging existing Mass parallelization code in preparation for its revival as benchmarking baseline.
#rb none
#preflight 627a528c10766ef8c1ebbc18

[CL 20121558 by Mieszko Zielinski in ue5-main branch]
2022-05-10 08:30:57 -04:00
Mieszko Zielinski
18dbc443e7 Renamed FMassExecutionContext::GetSystemInternal to FMassExecutionContext::GetSubsystemInternal and updated FMassExecutionContext::bFlushDeferredCommands's oudated comment
#rb trivial
#preflight 627a500210766ef8c1e82bec

[CL 20121529 by Mieszko Zielinski in ue5-main branch]
2022-05-10 08:27:09 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Mieszko Zielinski
a3f5127690 Added a couple of missing stats to Mass code
#review-20102520
#preflight skip

[CL 20103008 by Mieszko Zielinski in ue5-main branch]
2022-05-09 10:59:56 -04:00
Mieszko Zielinski
af039bb853 Setting default value of MassEntitySubsystem's atomic counters
#preflight 6279209c066ebb49109dd59b
#rb trivial

[CL 20102508 by Mieszko Zielinski in ue5-main branch]
2022-05-09 10:23:43 -04:00
Mieszko Zielinski
bad1d8f4fa Exposed parts of MassEntityTestSuite for reuse in other test-focused plugins
#preflight 627920d64561731dbeeff2cd

[CL 20102478 by Mieszko Zielinski in ue5-main branch]
2022-05-09 10:23:04 -04:00
Mieszko Zielinski
3654d50fb0 Renamed missed "system" occurences in the "subsystem requirements" code
#rb trivial
#preflight 626bf7d72660750c3ffd66ed

[CL 19979452 by Mieszko Zielinski in ue5-main branch]
2022-04-29 11:01:35 -04:00