Commit Graph

77 Commits

Author SHA1 Message Date
Mieszko Zielinski
8f15f52956 Added Num to StructTypeBitSet along with one debug-time funciton fetching the name of value given by index
#review-20450239
#preflight skip

[CL 20450358 by Mieszko Zielinski in ue5-main branch]
2022-06-01 05:46:26 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
Mieszko Zielinski
7d374ab022 Added a function to TStructTypeBitSet to fill an instance with amount of false or true values coresponding to the number of known types tracked by a given bitset specialization.
#review-20429871
#preflight 6294abd5380652524ec2d8ae

[CL 20430496 by Mieszko Zielinski in ue5-main branch]
2022-05-30 09:20:06 -04:00
mikko mononen
cd37fde862 PropertyBag static analysis fix
#jira UE-153549
#preflight 628e1ab29f6fbd94adee08ae

[CL 20362842 by mikko mononen in ue5-main branch]
2022-05-25 08:23:55 -04:00
mikko mononen
37de7a0cf2 InstancedSructArray: Fix for nonunity compile
#rb trivial
#preflight 628dd992277bee3c6a4c3784

[CL 20361131 by mikko mononen in ue5-main branch]
2022-05-25 03:37:08 -04:00
mikko mononen
f47169e845 FInstancedStructArray, heterogenous array of structs
#jira UE-153269
#preflight 628c8f276f6741ae3155dc08

[CL 20345176 by mikko mononen in ue5-main branch]
2022-05-24 04:02:53 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
mikko mononen
6111ab76c4 PropertyBag: allow to load bags with missing types.
- Allow to load property bags with missing struct, enum, and object types
- Mark missing types with specific types so that we can report error in the UI
- Report missing types in the UI

#jira none
#preflight 6285f4abbf7dfd7f057d3bcd

[CL 20277109 by mikko mononen in ue5-main branch]
2022-05-19 03:48:22 -04:00
Mieszko Zielinski
92986342bf Added an "index iterator" to StructTypeBitSet allowing retrieval of iterrative retrieval of indices representing a given value.
Also, added some unit tests for it.

#review-20138757
#preflight 627ce7d09f7ad2a14bc6aff8
#preflight 627cf037ce4192efbe3778e9

[CL 20163173 by Mieszko Zielinski in ue5-main branch]
2022-05-12 07:51:07 -04:00
Mieszko Zielinski
9fb49db23d Implemented a helper, debug-time tool for detecting MT access to requirements declared by MassEntityQueries
#review
#preflight 627b9a449f7ad2a14b4995ac
#preflight 627ce1a180307e522bcbcfa0

[CL 20162912 by Mieszko Zielinski in ue5-main branch]
2022-05-12 06:53:18 -04:00
lauren barnes
5055406ba5 Fixing EditorStyle->AppStyle merge errors
#rb trivial

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20073158 via CL 20073163
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20105762 by lauren barnes in ue5-main branch]
2022-05-09 13:32:48 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
mikko mononen
c5a2705367 PropertyBag: Fix potential null ptr access
- fixed nullptr access reported by static analysis
- improved error handling in case of missing struct/class/enum type

#jira
UE-150958
#preflight 6273bc86e95a8b960e451bb7

[CL 20056351 by mikko mononen in ue5-main branch]
2022-05-05 08:19:14 -04:00
Denys Dubinin
459f5892c0 Property Bag changes for Remote Control Logic Plugin.
Adding functionality for creating a Property from source FProperty
Adding functionality for copy property value from source FProperty ContainerPtr

#rb mikko.mononen
#rb Simon.Therriault

#jira UE-146247
#preflight 62725edde56311b5d87a7f0f

[CL 20039807 by Denys Dubinin in ue5-main branch]
2022-05-04 07:18:52 -04:00
mikko mononen
739a976ab0 PropertyBag: Moved internal methods into lambdas to avoid exposing types in header
#jira UE-150401
#rb Mieszko.Zielinski
#preflight 626a45ed0464895bc5f91a0e

[CL 19954490 by mikko mononen in ue5-main branch]
2022-04-28 03:48:27 -04:00
christopher waters
c848b53f89 Fixing various NonUnity compile errors.
#jira none
#rb none
#preflight 626990c02735a2c0ea8cc96b

[CL 19946125 by christopher waters in ue5-main branch]
2022-04-27 16:20:41 -04:00
Mieszko Zielinski
0e02b2019f Removed remnants of STRUCTUTILS_STRICT_CONFORMANCE StructTypeBitSet fix.
#rb trivial
#preflight skip

[CL 19937564 by Mieszko Zielinski in ue5-main branch]
2022-04-27 07:57:38 -04:00
Mieszko Zielinski
d071efca6c Enriched MassEntityQuery with capability to declare USubsystem requirements, that then can be fetched from the MassExecutionContext.
MassEntityQuery requirements are declared just like other requirements with a dedicated AddSystemRequirement call.
MassExecutionContext supplies functions for fetching subsystem instances checking if active query declared them as dependency in a given mode (ReadOnly or ReadWrite).
Temporarily added a way to fetch a subsystem outside of a query, then all restrictions are lifted. This will be replaced in further work on multithreading mass work.

#review-19769060
#preflight 6268f560853fdb6fdd09db41
#preflight 626906054c09420241febb79

[CL 19936428 by Mieszko Zielinski in ue5-main branch]
2022-04-27 05:21:28 -04:00
jamie dale
6071834747 Fixed FInstancedStruct edits not propagating to instances when editing a CDO
Only the ImportText flow of changing a property actually calls PropagatePropertyChange, so we need to use SetPerObjectValues (which calls ImportText internally) rather than directly copy the struct state.

#jira
#rb Rex.Hill, Mikko.Mononen

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 19918614 via CL 19920983 via CL 19921157
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 19923192 by jamie dale in ue5-main branch]
2022-04-26 12:54:29 -04:00
mikko mononen
8824b8d398 Property Bag: Fixed layout and other improvements
- Changed GetOrCreateFromDescs() to always ensure on errors
- Added method to migrate to another property bag instance
- Added metatag "FixedLayout" which allows to only edit values, not layout
- Changed the details customization to be allowed to embed in other customizations

#jira UE-147507
#review
#preflight 6267da5a272f4a558dbcedf6

[CL 19918231 by mikko mononen in ue5-main branch]
2022-04-26 07:56:14 -04:00
Mieszko Zielinski
8476f0f6ae Proper solution to static StructTracker compilation/linking issue
#review-19902964
#preflight 6266e3c80634d0904ce82afc
#jira UE-150071
#preflight 6267c1bb820fbeb9a4f77f4a

[CL 19917319 by Mieszko Zielinski in ue5-main branch]
2022-04-26 06:11:41 -04:00
Mieszko Zielinski
7adb101dcd StructTypeBitSet compilation fix for strict conformance mode
#jira UE-149818
#review-19865642
#preflight 6262c729e87284a93cd20056

[CL 19866012 by Mieszko Zielinski in ue5-main branch]
2022-04-22 11:43:24 -04:00
mikko mononen
d2adb2cc5b PropertyBag: fix for NoPCH compilation of the tests
#jira UE-149696
#preflight 62624fdca2579b4c773905b3

[CL 19861884 by mikko mononen in ue5-main branch]
2022-04-22 03:04:47 -04:00
marc audy
006002155d Fix non-unity no-pch issues
#preflight 626180076119a1a496ab2bdf
#rnx

[CL 19852196 by marc audy in ue5-main branch]
2022-04-21 13:34:58 -04:00
Mieszko Zielinski
a9f90cacf2 Fix to StructTypeBitSet.StructTracker being instanced per module.
#review-19827285
#preflight 625fe08edd47b4ad2166d510
#jira UE-149046

[CL 19829083 by Mieszko Zielinski in ue5-main branch]
2022-04-20 09:30:32 -04:00