Commit Graph

122 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
joseph strubhart
db7c796ffe Adds BP callable setter for bHideInputAction on CommonButtonBase.
#ROBOMERGE-AUTHOR: joseph.strubhart
#ROBOMERGE-SOURCE: CL 20346239 via CL 20346469 via CL 20346481 via CL 20346487
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20347313 by joseph strubhart in ue5-main branch]
2022-05-24 09:25:11 -04:00
marshall beachy
106bedb7f3 Fixing a bug with UCommonTextBlock::SynchronizeProperties. We were previously running the bAutoCollapseWithEmptyText logic before calling Super. If this textfield had SetText called on it before the internal Slate object existed, the GetText call here will return an empty string because it's not set until the Super call runs.
#rb [at]daren.cheng

#ROBOMERGE-AUTHOR: marshall.beachy
#ROBOMERGE-SOURCE: CL 20331688 via CL 20331711 via CL 20331724 via CL 20331731
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20334075 by marshall beachy in ue5-main branch]
2022-05-23 14:42:48 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
daren cheng
c5fb55c802 Speculative Fix ensure CommonUI postload
#jira UE-153367
#rb Patrick.Boutot
#preflight 62841ae0185a31bd39edc2e1

[CL 20302071 by daren cheng in ue5-main branch]
2022-05-20 16:18:32 -04:00
patrick boutot
e7fc3f9e55 UMG: Update UWidget::Visibility initialization from SetVisibility to SetVisibilityInternal.
[FYI] vincent.gauthier

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20142060 via CL 20143142 via CL 20143633
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20148091 by patrick boutot in ue5-main branch]
2022-05-11 15:55:37 -04:00
patrick boutot
0f21de1fa2 Quick fix to prevent recursive call in CommonButton.
#rb none
#preflgiht none

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20127799 via CL 20127904 via CL 20127984
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20130790 by patrick boutot in ue5-main branch]
2022-05-10 18:03:15 -04:00
patrick boutot
4f178c7f0c UMG: Update the Widget with accessors.
#rb vincent.gauthier
#preflight 627a4e42705bfaf9ae31ee20

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20123512 via CL 20123528 via CL 20123564
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20125750 by patrick boutot in ue5-main branch]
2022-05-10 13:53:03 -04:00
patrick boutot
8b5e983a4b UMG: Update the Border widget with accessors.
#preflight 62792bf6822bdc69f0101954

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 20104249 via CL 20104272 via CL 20104285
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20109749 by patrick boutot in ue5-main branch]
2022-05-09 15:48:48 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
daren cheng
feb4ec1b25 Remove option to disable action domains from CommonUI
#preflight 626ca6459b5919403acdaf26
#rb Patrick.Boutot

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 20015087 via CL 20015127 via CL 20015163
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20017242 by daren cheng in ue5-main branch]
2022-05-02 18:27:19 -04:00
Cody Albert
1433595e79 Checking validity of RootButton in UCommonButtonBase::RefreshDimensions to avoid crashes when the preview widget is rebuilt
See UDN: https://epicgames.lightning.force.com/lightning/r/Case/5004z00001dHIK7AAO/view

#review-19765011 @Daren.Cheng
#preflight 62701d7d645c64f3a24fbc40

[CL 20012356 by Cody Albert in ue5-main branch]
2022-05-02 14:09:39 -04:00
graham lewis
42462fd8f7 UCommonActivatableWidgetSwitcher:
- If the switcher has an owning activatable widget, only activate switcher child if the owning widget is active.
- Removed unnecessary includes.

#jira
#rb geoffrey.wong, saad.nader, vincent.gauthier

#ROBOMERGE-AUTHOR: graham.lewis
#ROBOMERGE-SOURCE: CL 19866540 via CL 19869150 via CL 19869845
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19874264 by graham lewis in ue5-main branch]
2022-04-22 17:41:33 -04:00
patrick boutot
aab0524385 UMG: Update the Slider widget with accessors.
#preflight 62582e2d946114248db734d5

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 19759850 via CL 19760019 via CL 19760159
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19802099 by patrick boutot in ue5-main branch]
2022-04-18 23:30:29 -04:00
patrick boutot
00509a3076 UMG: Update the TextBlock widget with accessors.
#rb daren.cheng, sebastien.nordgren
#preflight 6256b877c869cc25414cda6d

#ROBOMERGE-AUTHOR: patrick.boutot
#ROBOMERGE-SOURCE: CL 19738533 via CL 19738538 via CL 19738551
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19740125 by patrick boutot in ue5-main branch]
2022-04-13 10:57:51 -04:00
enrique conty
e130b1b731 Allow CommonAnimatedSwitcher to report transitioning animation status.
#OKFORGITHUB PUBLIC
[REVIEW] [at]Dan.Kaufman [at]Beth.Towns [at]Christopher.Daniel [at]Anthony.Glueck [at]Altair.Lane

#ROBOMERGE-AUTHOR: enrique.conty
#ROBOMERGE-SOURCE: CL 19738279 via CL 19738282 via CL 19738284 via CL 19738290 via CL 19738298
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19739374 by enrique conty in ue5-main branch]
2022-04-13 10:06:29 -04:00
erin wasik
85bc5b22f2 CommonTileView: move SCommonTileView to a header so we can inherit from it properly
- minor cleanup: removed override that was just calling parent, add parent call for OnFocusLost

[REVIEW] [at]editor-ui-systems

#ROBOMERGE-AUTHOR: erin.wasik
#ROBOMERGE-SOURCE: CL 19674022 via CL 19675620 via CL 19675679 via CL 19676022
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19677745 by erin wasik in ue5-main branch]
2022-04-07 16:37:41 -04:00
saad nader
7e680c8a13 Added ability to check if input is allowed.
[REVIEW] [at]daren.cheng, [at]vincent.gauthier

#ROBOMERGE-AUTHOR: saad.nader
#ROBOMERGE-SOURCE: CL 19673608 via CL 19674174 via CL 19674269
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v938-19570697)

[CL 19676109 by saad nader in ue5-main branch]
2022-04-07 15:45:02 -04:00
jc authier
8908dff9f5 Common Input:
- Enable action domain system by default

[REVIEW] [at]forest.sharp, [at]philip.buuck, [at]prajwal.manjunath

#ROBOMERGE-AUTHOR: jc.authier
#ROBOMERGE-SOURCE: CL 19450892 via CL 19452240 via CL 19453836 via CL 19453998
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v933-19451510)

[CL 19455857 by jc authier in ue5-main branch]
2022-03-21 14:49:00 -04:00
prajwal manjunath
0a04311c67 Crash fix - In ActionRouterBase Tick function, the call to ActionDomain input processor was not guarded by a check to see if ActionDomainRouting is enabled. Also add sanity checks in the ProcessInput functions so it's not a fatal crash if it happens again.
#jira UE-146330
#preflight 19423400
#rb jc.authier, vincent.gauthier

#ROBOMERGE-AUTHOR: prajwal.manjunath
#ROBOMERGE-SOURCE: CL 19424044 via CL 19430550 via CL 19435026 via CL 19435288
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v930-19419903)

[CL 19436855 by prajwal manjunath in ue5-main branch]
2022-03-18 12:16:43 -04:00
jc authier
afc2c47e30 CIS Fix
#ROBOMERGE-AUTHOR: jc.authier
#ROBOMERGE-SOURCE: CL 19384424 via CL 19386071 via CL 19397896 via CL 19397991
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19403156 by jc authier in ue5-main branch]
2022-03-16 03:28:58 -04:00
jc authier
a3a921be4b Common Input:
- Separate the widgets in the action domain system from the old input system
- Input will pass through the active root node (old system) and if not handled, will pass to the action domain system (new system)

[REVIEW] [at]prajwal.manjunath, [at]daren.cheng, [at]forest.sharp, [at]philip.buuck

#ROBOMERGE-AUTHOR: jc.authier
#ROBOMERGE-SOURCE: CL 19384223 via CL 19385706 via CL 19397294 via CL 19397344
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19403009 by jc authier in ue5-main branch]
2022-03-16 03:26:03 -04:00
erin wasik
43b46e512f Common TextBlocks: add options for enabling/disabling scroll style for marqueeing text
- handles ellipsis when scrolling. it should be off and when no longer scrolling it should revert to its desired setting

[REVIEW] [at]editor-ui-systems
#rb [at]vincent.gauthier
[FYI] [at]jesse.raymond, [at]michail.michail

#ROBOMERGE-AUTHOR: erin.wasik
#ROBOMERGE-SOURCE: CL 19354851 via CL 19354907 via CL 19355910 via CL 19357541 via CL 19357717
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19359151 by erin wasik in ue5-main branch]
2022-03-11 14:31:02 -05:00
graham lewis
ae4dad0fb2 Allow tabs to be inserted to tab list.
UCommonTabListWidgetBase:
- Added TabIndex parameter to RegisterTab (default value -1 which means tab will be added to end).
- If new tab is being inserted before end of list, rebuild tab list with tabs in correct order.
- Added option to defer rebuilding till next tick (so we only rebuild once if multiple tabs are inserted).

[REVIEW] [at]daren.cheng, [at]forest.sharp, [at]jc.authier, [at]joseph.strubhart, [at]philip.buuck

#ROBOMERGE-AUTHOR: graham.lewis
#ROBOMERGE-SOURCE: CL 19336653 via CL 19342719 via CL 19349676 via CL 19349766
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19350597 by graham lewis in ue5-main branch]
2022-03-11 01:30:59 -05:00
daren cheng
dd57a0079c Fix Ensure quitting PIE session in Lyra using Quit Game.
#jira UE-144626
#rb patrick.boutot
#preflight 62225e4fef188a763d69dc4d
#lockdown simon.tourangeau

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 19271608 in //UE5/Release-5.0/... via CL 19271788
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19273914 by daren cheng in ue5-main branch]
2022-03-04 15:28:39 -05:00