Commit Graph

48 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
fernando coello
f8a1685dcf Contextual Anim (WIP): Added support for multiple sections and renamed Variants to AnimSet and AlignmentSection to AnimSetPivotDefinition
#review-20315406 @jose.villarroel
#fyi @aaron.cox
#jira none
#preflight 628e758f82597362d1077aa2

[CL 20369561 by fernando coello in ue5-main branch]
2022-05-25 14:59:07 -04:00
fernando coello
0420123905 Contextual Anim Editor (WIP): Updated new variant popup to use AnimSequenceBase instead of Montage.
#review-20170217 trivial
#preflight none
#fyi @aaron.cox

[CL 20170214 by fernando coello in ue5-main branch]
2022-05-12 16:19:32 -04:00
fernando coello
9c3ca15166 Contextual Anim Editor (WIP): Refactored binding mechanism to support external data and extended blueprint interface
#review-20063449 @jose.villarroel @aaron.cox
#jira none
#preflight 627d62b314419e106f782594

[CL 20170094 by fernando coello in ue5-main branch]
2022-05-12 16:14:08 -04:00
lauren barnes
ae96704e9c Removing EditorStyleSet.h includes
#rb trivial

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20080050 via CL 20080336
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106472 by lauren barnes in ue5-main branch]
2022-05-09 13:56:34 -04:00
lauren barnes
4b82e918fa Replacing legacy EditorStyle calls with AppStyle
#rb header and class name replacement

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20078276 via CL 20078825
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106316 by lauren barnes in ue5-main branch]
2022-05-09 13:51:26 -04:00
fernando coello
1d2e3df00c Contextual Anim (WIP): Refactored SceneAsset to work with AnimSequenceBase instead of only Montages (Montage still supported)
#review-20047143 @jose.villarroel @aaron.cox
#jira none
#preflight 6272da3d606d0d83893d60dc

[CL 20059797 by fernando coello in ue5-main branch]
2022-05-05 12:53:46 -04:00
fernando coello
b5d09beac3 ContextualAnim bug fixes (regressions): Fixed bug causing missing ik targets. Fixed bug causing crash when generating alignment tracks. Minor change: Removed const param from query function.
#review-19708828 trivial
#preflight none

[CL 19708826 by fernando coello in ue5-main branch]
2022-04-11 13:39:01 -04:00
fernando coello
b65b0a3dbf Contextual Anim: Re-added old query function (for backward compatibility) and removed check when populating preview scene if preview actor class is not valid.
#review-19259892 trivial
#jira none
#preflight 62216e04a00412627d20873f
#fyi @aaron.cox

[CL 19260355 by fernando coello in ue5-main branch]
2022-03-03 20:54:06 -05:00
fernando coello
122c83f28e Contextual Anim Editor (WIP): Fixed crash when removing a selection criterion while hitproxy is selected and removed inactive asset browser tab
#review-19225123 trivial
#preflight none
#fyi @aaron.cox @jose.villarroel

[CL 19225118 by fernando coello in ue5-main branch]
2022-03-02 13:53:22 -05:00
fernando coello
b2a3cdaffa Contextual Anim Editor (WIP):
- Refactored ActorSceneComp to provide Ik Goals to Ik Rig via IIKGoalCreatorInterface
 - Added option to create and switch between variants
 - Refactored selection logic and added option in the editor to edit the trigger area in context
 - Added option to toggle draw debug of ik targets in the editor
 - Simplified alignment logic
 - Added option to simulate the interaction in the editor
#review-19159922 @jose.villarroel @aaron.cox
#preflight 621ec9e9ca28c55634440b9c

[CL 19222215 by fernando coello in ue5-main branch]
2022-03-02 11:03:43 -05:00
jurre debaare
b8c3f5335c Montage segment changes:
- Deprecated public access to AnimReference
    * Used for new behaviour that keeps track of PlayLength from referenced asset
    * In case the cached PlayLength does not match the current _and_ the cache playlength == than the segment length it can be deemed out-of-date due to a reimport
    * Out-of-date segments show in the OrangeAccent on the timeline rather than GreenAccent
    * Out-of-date segments will introduce log warnings on-load
- Patched up all paths using AnimReference (get/set)
- Modernized parts of EditorAnim* files
- Face-lifted details customization for AnimSegment
    * Scrollboxes now have (dynamic) UI/Clamp according to the context
    * Added behaviour for interactive operation when dragging the timeline (dragable) bars
- Implemented FAnimModel_AnimMontage::OnDataModelChanged to handle curve changes only - as play length etc is handled by montage editor itself

#rb Thomas.Sarkanen
#preflight 620fb4c9be45100d32bcc000

#ROBOMERGE-OWNER: jurre.debaare
#ROBOMERGE-AUTHOR: jurre.debaare
#ROBOMERGE-SOURCE: CL 19051190 via CL 19051207 via CL 19051231 via CL 19051241 via CL 19058489
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19066040 by jurre debaare in ue5-main branch]
2022-02-21 01:10:52 -05:00
fred kimberley
7fbfaf57c8 Require explicit constructors/casts when converting between FVector, FVector3d, and FVector3f.
#jira UE-122078
#rb Andrew.Davidson, Colin.McGinley
#preflight standard build

#ROBOMERGE-AUTHOR: fred.kimberley
#ROBOMERGE-SOURCE: CL 18817999 in //UE5/Release-5.0/... via CL 18818012 via CL 18822871
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824721 by fred kimberley in ue5-main branch]
2022-02-02 07:59:31 -05:00
fernando coello
fde8bc1ed2 Fixed Unknown Cook Failure error in QAGame due to uninitialized properties
#jira UE-132781
#fyi @aaron.cox

[CL 17944354 by fernando coello in ue5-main branch]
2021-10-27 10:55:18 -04:00
fernando coello
dab3a7acea Fix for static analysis warnings
#jira UE-132591
#fyi @aaron.cox

[CL 17925103 by fernando coello in ue5-main branch]
2021-10-26 11:10:57 -04:00
fernando coello
6702b2204e Contextual Anim Scene Asset Editor: Fix crash when adding a section to a newly created notify track
#review-17908369 trivial
#fyi @aaron.cox

[CL 17908367 by fernando coello in ue5-main branch]
2021-10-25 13:07:54 -04:00
fernando coello
32bcf14df3 Contextual Anim Scene Asset Editor (WIP)
#review-17853060 @thomas.sarkanen, @jurre.debaare
#fyi @aaron.cox
#preflight 617308ecbe0cfd00012a75c5

[CL 17898057 by fernando coello in ue5-main branch]
2021-10-22 15:48:55 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
jimmy andrews
580e488045 fix default-enabled ed modes showing up in random order
#rb ryan.schmidt
#rb matt.kuhlenschmidt
#preflight 61535b2d260f7d0001c9cc81

#ushell-cherrypick of 17650582 by Jimmy.Andrews
#preflight 615e2ba87e9a010001258498

#ROBOMERGE-AUTHOR: jimmy.andrews
#ROBOMERGE-SOURCE: CL 17746676 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v879-17706426)

[CL 17746682 by jimmy andrews in ue5-release-engine-test branch]
2021-10-07 03:22:05 -04:00
aurel cordonnier
69fe095547 Merge from Release-Engine-Staging @ 17636544 to Release-Engine-Test
This represents UE4/Main @17638339 and Dev-PerfTest @17636504

[CL 17638842 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-27 19:54:25 -04:00
fernando coello
09b3dfa636 Motion Warping API clean up (deprecated simple warp and replaced SyncPoint with WarpTarget with an extra option to create warp targets from a scene comp, an optional bone, and an option to automatically follow that target)
[at]jose.villarroel, [at]aaron.cox #fyi [at]jaren.peterson
#preflight 6126744dec829600019118c8

#ROBOMERGE-SOURCE: CL 17307480 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v861-17282326)

[CL 17307489 by fernando coello in ue5-release-engine-test branch]
2021-08-25 15:05:29 -04:00
yoan stamant
af2ec418f6 Fixed multiple uninitialized script struct members found while cooking
#rb aris.theophanidis
#preflight 611adf7f76f1fd0001f05104

#ROBOMERGE-SOURCE: CL 17188358 via CL 17188373
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17188381 by yoan stamant in ue5-release-engine-test branch]
2021-08-17 06:38:04 -04:00
fernando coello
56c3185f1f Motion Warping: Exposed RootMotionModifier's properties to blueprint and exposed debug console variables
Contextual Anim: Separated BoneName from IKGoalName in IKTargetDefinition so we can have more than one curve for the same bone + Added a few blueprint callable functions to query data from the SceneAsset

#ROBOMERGE-SOURCE: CL 16838836 via CL 16840167
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16840262 by fernando coello in ue5-release-engine-test branch]
2021-07-13 14:26:43 -04:00
fernando coello
4a623d1716 Contextual Anim
- Added console variable to toggle draw debug and to override alpha value for IK Targets
- Added blueprint function to get IKTarget by goal name
- SceneActorComps are now sorted before attempt to start an interaction in the Preview EdMode
#jira none #rb @jose.villarroel #fyi @aaron.cox
#preflight 608b29bdd4026b0001cd5517

[CL 16163176 by fernando coello in ue5-main branch]
2021-04-29 18:38:34 -04:00
Marc Audy
3cfedaade8 Fix PVS warning V502 when comparing against NAME_None in a trinary
[CL 16137741 by Marc Audy in ue5-main branch]
2021-04-28 01:58:36 -04:00