Commit Graph

1266 Commits

Author SHA1 Message Date
michal cieciura
15194f6cb3 Fixed crash when streaming nodes
#jira UE-152529
#rb jeanluc.corenthin
#preflight 62927ee5fd2c7f2aa7922e83
#lockdown jeanmichel.dignard

#ROBOMERGE-AUTHOR: michal.cieciura
#ROBOMERGE-SOURCE: CL 20436910 in //UE5/Release-5.0/... via CL 20437701
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448622 by michal cieciura in ue5-main branch]
2022-06-01 03:52:56 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
David Lesage
76ef0ee3d9 #Jira UE-155108 Add output in the log about the used tessellator (Rhino, Alias)
#rb none
#preflight 62968dde88749bbb83ab4fa8

[CL 20444391 by David Lesage in ue5-main branch]
2022-05-31 19:20:46 -04:00
Marc Audy
0fc8b6a522 Fix spelling error
#rnx
#preflight
#fyi JeanLuc.Corenthin

[CL 20444233 by Marc Audy in ue5-main branch]
2022-05-31 19:04:54 -04:00
emil kirichev
c8164bed52 VariantManager: Align UI with new UE5 template
#jira UETOOL-4739
#preflight 62947c42380652524eb23d8f
#rb JeanLuc.Corenthin

[CL 20429399 by emil kirichev in ue5-main branch]
2022-05-30 05:32:58 -04:00
michal cieciura
892dbb5aa9 Fixed crash when building collision
#jira UE-151315
#rb JeanLuc.Corenthin
#preflight 62927ed19058ddbed4f0716f

[CL 20414985 by michal cieciura in ue5-main branch]
2022-05-28 16:08:29 -04:00
michal cieciura
566a04920d Added DataWithClassificationAlpha color source
#jira none
#rb JeanLuc.Corenthin
#fyi anousack.kitisa
#preflight 62927d22a962938dff7d9377

[CL 20414864 by michal cieciura in ue5-main branch]
2022-05-28 16:05:29 -04:00
Jon Nabozny
127848635c Fix cases of engine classes not returning normalized INI paths.
#JIRA None
#review-20392531 @Ben.Marsh @Josh.Adams
#preflight None
#rb Trivial

[CL 20394955 by Jon Nabozny in ue5-main branch]
2022-05-27 12:44:56 -04:00
David Lesage
25e4bb3c8d #jira UE-144087: Switch IFC import from custom code to TechSoft
A CVar (ds.IFC.EnableNativeTranslator) allows to enable UE native IFC translator.
#rb jeanluc.corenthin
#preflight 6290e9e7183e241099c84df6

[CL 20394468 by David Lesage in ue5-main branch]
2022-05-27 12:08:59 -04:00
David Lesage
07e4246c1f #jira UE-149250 Alias CVar registration is moved in CADOption to avoid multiple registration (due to multiple Alias translator DLL)
Enable CADkernel
#jira UE-150925 Add Alias 2023.0 SDK
#rb jeanluc.corenthin
#preflight 6290ea47fe5e30102ab06e2b

[CL 20394287 by David Lesage in ue5-main branch]
2022-05-27 12:01:32 -04:00
emil kirichev
268a03d085 Dataprep: Cannot commit dataprep with a rect light in the scene
#jira UE-148590
#preflight 6290cb821f0041249bed9249
#rb JeanLuc.Corenthin

[CL 20393420 by emil kirichev in ue5-main branch]
2022-05-27 10:47:33 -04:00
David Harvey
b5840fed7f removing several PLATFORM_HOLOLENS references, mostly around WindowsHWrapper etc.
#jira UE-149794
#rnx
#preflight 628f7a4df622d972b5db8318
#rb pending

[CL 20391626 by David Harvey in ue5-main branch]
2022-05-27 07:04:22 -04:00
Per Larsson
c30e677d1b Merge BulkData 1&2
#rb Paul.Chipchase, PJ.Kack, CarlMagnus.Nordin
#jira none
#preflight 629085d14f63120d8e170977

###
This change attempts to merge the editor and the runtime version of bulk data, i.e. bulk data one and two.
The major difference between the two is the fact that the editor version supported element vice
serialization via inheritance. This has been complelety removed in the runtime version. In order
to mitigate this divergance a non-virtual base class has been extracted that forms the base
for the untyped and typed versions of bulk data.
The untyped version is only used in editor and will be deprecated. However this is a breaking change,
previously it was possible to inherit from FByteBulkData in editor builds.
Other differences between the two includes:
* IsBulkDataLoaded - returns true for bulk data 1 if an allocation has been made even if the size is zero
* StartStreaming - was removed in bulk data 2 and has been removed
* FlushAsyncLoading - bulk data 2 was busy waiting, now an event is used

All I/O related functionality has been extracted into BulkDataStreaming.cpp and is using
a  FBulkDataChunkId that is either a package path or a package ID.This could potentially
be extended to contain a cache key in development builds to support loading from DDC, i.e derived
data references.

[CL 20391050 by Per Larsson in ue5-main branch]
2022-05-27 04:31:58 -04:00
David Lesage
da7a0897f5 Add Alias 2023 Sdk
#rb none
#preflight 628f7ddbe17a02240dcf1331

[CL 20378672 by David Lesage in ue5-main branch]
2022-05-26 09:42:25 -04:00
Johan Duparc
2715f2aa58 Datasmith: Cloth support prototype
#jira UETOOL-4936
#rb JeanLuc.Corenthin
#preflight 628ba117693c5e1de27cbe06

[CL 20328481 by Johan Duparc in ue5-main branch]
2022-05-23 11:06:36 -04:00
Johan Duparc
fed4755571 Datasmith: Mesh serialization cleanup
#rb JeanLuc.Corenthin
#preflight 6287ca238828ea88c8677f23

[CL 20324914 by Johan Duparc in ue5-main branch]
2022-05-23 08:40:15 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
Johan Duparc
504dacddd3 Datasmith: minor cleanup
#rb none
#preflight none

[CL 20297940 by Johan Duparc in ue5-main branch]
2022-05-20 13:21:20 -04:00
David Lesage
70ad2fba6d Remove debug compilation definitions
#rb none
#preflight 62866c3f2c1bb3e25a4ac17d

[CL 20283463 by David Lesage in ue5-main branch]
2022-05-19 13:36:52 -04:00
David Lesage
510b02356c CAD import fixes (manual merge from 5.0.3):
#jira UE-150398 / UE-144502: CAD - not all expected materials are created upon importing assemblies
FTechSoftFileParser::TraverseBRepModel: Default material was not applied from parent

#jira UE-150565: Cad - imported static mesh names are too generic to be used in a dataprep context

#jira UE-148504: Alias wire import mesh names are inconsistent with original file

#jira UE-139703: Inventor actors imported into UE via Datasmith have incorrect names

#jira UE-149540: Datasmith does not assign Rhino imported materials on corresponding meshes
Static mesh from Rhino has its unique material at slot 0 while other CAD import (from techsoft or Alias) static mesh can have many material and the slot of the material is defined by the material/color components.
To respect the mecanisme of other CAD import, BRep from Rhino is added of a color that has a slotId = 0. This color is (0, 0, 0, 0)
The Rhino import will be improve like Alias import to allow static mesh with multiple of materials (jira UETOOL-5196)

#jira UE-143899: UE.EditorAutomation(RunTest=Editor) Win64 - Editor.Python.EngineTest.Pipeline.Datasmith
Revert to revision 2 + adapt value to TechSoft tessellation and TechSoft material

#jira UE-152505: In the particular case of CATProduct referencing CGR, the external file is defined as a externalData vs an "empty" Occurence in the other case

#jira UE-131465: In the case of a body that generate an Empty mesh, a break point is triggered. The ensureMsg is replace by a message in the log.

 #jira UE-133180: the error logged has been fixed by preventing the creation of empty StaticMesh (ps. the cannot be done with Alias and Rhino)

#preflight 62854966614041edb7a05036
#rb jeanluc.corenthin

[CL 20267096 by David Lesage in ue5-main branch]
2022-05-18 15:57:31 -04:00
emil kirichev
bc535cd460 glTF import of unlit material generates a default lit material
#jira UETOOL-5193
#rb JeanLuc.Corenthin
#preflight none

[CL 20240424 by emil kirichev in ue5-main branch]
2022-05-17 06:39:59 -04:00
benoit deschenes
915788312b DatasmithImporter - Fix crash caused by threadsafety issue when logging errors.
When importing a scene using a lot of unsupported texture formats, the asynchronous logging of those errors would make the editor crash.
#preflight 627e92016423fc4fa7ecfde6

[CL 20183737 by benoit deschenes in ue5-main branch]
2022-05-13 13:26:52 -04:00
Jurre deBaare
631bec320b Moved RichCurve evaluation code from RichCurve.cpp to separate file and consolidated all instances of copy-pasta behaviour
#jira none
#rb Mike.Zyracki
#preflight 627cd946e97f57bf6cc98b8a

[CL 20162602 by Jurre deBaare in ue5-main branch]
2022-05-12 06:08:53 -04:00
Johan Duparc
a6c4af0f04 Datasmith cleanup:
- update AssetRegistryModule.h include path
- fix malformed visual assist todo tags
- removed unactioned wip tags
#rb none
#preflight 627bc67a9f7ad2a14b6a4209

[CL 20139955 by Johan Duparc in ue5-main branch]
2022-05-11 10:41:40 -04:00
lauren barnes
4b82e918fa Replacing legacy EditorStyle calls with AppStyle
#rb header and class name replacement

#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20078276 via CL 20078825
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20106316 by lauren barnes in ue5-main branch]
2022-05-09 13:51:26 -04:00