Commit Graph

61 Commits

Author SHA1 Message Date
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
stanley hayes
43ee646399 #JIRA: FORT-477503
Script cannot be added to a project

There was an issue converting from a relative path to a full path if the directories were named similarly, the fix for this caused the later part of the directory to get missed

#rb YiLiang.Siew, Rex.Hill
#Preflight 628c1452576542980819f08b
#rnx

#ROBOMERGE-AUTHOR: stanley.hayes
#ROBOMERGE-SOURCE: CL 20343002 via CL 20343047 via CL 20343097 via CL 20343129
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20343711 by stanley hayes in ue5-main branch]
2022-05-23 22:55:58 -04:00
stanley hayes
e4969abf08 #JIRA: FORT-477503
#rb rex.hill,yiliang.siew

There was an issue converting from a relative path to a full path if the directories were named similarly

#ROBOMERGE-AUTHOR: stanley.hayes
#ROBOMERGE-SOURCE: CL 20250150 via CL 20250321 via CL 20250806 via CL 20250872 via CL 20250905
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20252549 by stanley hayes in ue5-main branch]
2022-05-17 18:16:52 -04:00
kiaran ritchie
088adbe916 Fixing Content Browser not showing asterisk when asset dirtied after reload.
#rb jamie.dale
#JIRA https://jira.it.epicgames.com/browse/UE-146540
#preflight https://horde.devtools.epicgames.com/job/627be559a85e625d6f6d856b
#fyi halfdan.ingvarsson
#preflight 627bf9192d678960301b5c45

[CL 20145264 by kiaran ritchie in ue5-main branch]
2022-05-11 14:09:20 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
d64cf41728 AssetRegistry includes (Engine Plugins): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270563191629533ec2b6f6e

[CL 20017756 by Matt Peters in ue5-main branch]
2022-05-02 18:59:38 -04:00
wouter burgers
d3b5f4f753 SourceControl: Only show a failure to check-in popup if the operation actually failed (it could have been cancelled).
#jira none
#review-19720682
#preflight 6255d4d669015afc27bcf2b0

[CL 19752146 by wouter burgers in ue5-main branch]
2022-04-14 03:15:26 -04:00
Patrick Enfedaque
d31019c9e9 - FLinkerInstancingContext: Add Tag support
- Use FLinkerInstancingContext Tag to load all external actors instead of using a global map

#rb richard.malo, jeanfrancois.dube, francis.hurteau
#preflight 624aea29c51908059ae6b82f
#rnx

[CL 19607995 by Patrick Enfedaque in ue5-main branch]
2022-04-04 09:31:43 -04:00
rex hill
e9da6f48ca Content Browser: Deactivate Add and Import buttons in content browser when path selected does not support those features (virtual paths such as /All)
#preflight 6227f184695c94f981bc741a
#rb jamie.dale

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 19322495 via CL 19339234 via CL 19344449 via CL 19350377 via CL 19350529
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v926-19321884)

[CL 19351705 by rex hill in ue5-main branch]
2022-03-11 03:58:36 -05:00
paul chipchase
c7cad5cf29 Improve user visibility for packages with virtualized data by adding "Has Virtualized Data" to the tool tip in the content browser as well as adding an asset filter to hide all packages without virtualized data.
#rb Johan.Torp, Lauren.Barnes
#jira UE-135423
#rnx
#preflight 620374f674604bc6b1a62882

- The filter can be found in Filter->Other Filters -> Virtualized Data
- Since we only want to store if a package has virtualized data or not we can just use a bit in FAssetPackageData::Flags

[CL 18951020 by paul chipchase in ue5-main branch]
2022-02-11 08:04:32 -05:00
dave belanger
f49a9666a2 Hide some more C++ creation/editing menus when !GUnrealEd->GetUnrealEdOptions()->IsCPPAllowed() (follow up on 18815523)
#rb Rex.Hill
#preflight 61fbfcdee058822bda9ab04b

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 18863343 via CL 18863389 via CL 18863403 via CL 18863429 via CL 18863995 via CL 18864392
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18864406 by dave belanger in ue5-main branch]
2022-02-04 11:19:37 -05:00
patrick enfedaque
e53cc4aa19 ContentBrowser: Better support for Delete/Copy/Rename operations on World Partition worlds
- FScopedLoadAllExternalObjects object that can be used to force the loading of all external actors of a WP world to allow those operations to succeed. (for larger worlds commandlet should be used)
- ContentBrowser operation like: Delete, Duplicate, Rename, Move, Copy use this new scope
- World Partition worlds are no longer loaded on right-click context menu.
- Note: change was done with explicit scopes to only address specific use cases and limit the impact of this CL. It could become a default behavior in later versions.

#jira UE-140032, UE-114002

#rb richard.malo, jeanfrancois.dube, rex.hill
#preflight 61f2b479800734b52da816b4

#ROBOMERGE-AUTHOR: patrick.enfedaque
#ROBOMERGE-SOURCE: CL 18753910 in //UE5/Release-5.0/... via CL 18753926 via CL 18756993
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18757308 by patrick enfedaque in ue5-main branch]
2022-01-27 14:11:04 -05:00
jason stasik
f534144875 Remove ensure from missing alias data, added comment to explain why this may legitimately happen.
#rb none

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 18730629 via CL 18730647 via CL 18730654 via CL 18730658 via CL 18730790 via CL 18730845
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18730924 by jason stasik in ue5-main branch]
2022-01-25 20:03:57 -05:00
jason stasik
229e00c6d2 Add null check in alias data source
#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 18726734 via CL 18726764 via CL 18726793 via CL 18726816 via CL 18727562 via CL 18727975
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18728014 by jason stasik in ue5-main branch]
2022-01-25 16:09:24 -05:00
rex hill
36ca9082eb Allow blocking rename and duplicate UI per asset
#rb patrick.enfedaque
#preflight 61eae71cea0da8133dcf24d4

#ROBOMERGE-AUTHOR: rex.hill
#ROBOMERGE-SOURCE: CL 18691368 in //UE5/Release-5.0/... via CL 18691395 via CL 18691432
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18691442 by rex hill in ue5-main branch]
2022-01-21 12:33:34 -05:00
ben hoffman
1fec7c3dbd Add a notification when assets can't be opened pointing the user to the detailed output log.
#jira UE-129865
#rb rex.hill
#rnx
#preflight 61dcbfa0917ab97716a3e6f3

#ROBOMERGE-AUTHOR: ben.hoffman
#ROBOMERGE-SOURCE: CL 18573958 in //UE5/Release-5.0/... via CL 18574021
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18574079 by ben hoffman in ue5-release-engine-test branch]
2022-01-11 12:47:51 -05:00
jason stasik
d88184c691 Always remove aliases when an asset is removed
#rb jamie.dale
#preflight 61d5d569411c1403a3ccd327

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 18521955 via CL 18524355 via CL 18524394 via CL 18524422 via CL 18524975 via CL 18524990
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18525023 by jason stasik in ue5-release-engine-test branch]
2022-01-05 16:56:26 -05:00
julien stjean
c9ff073b14 Added a function ImportAssetsWithDialogAsync to the AssetTools.
Changed two import calls in the editor where interchange wasn't used. ImportAssetsWithDialog doesn't support async import to avoid breaking existing automation scripts or code.

#jira UE-136698
#rb Alexis.Matte
#preflight 61d340472e0e436c7257dbe4

#ROBOMERGE-AUTHOR: julien.stjean
#ROBOMERGE-SOURCE: CL 18503230 in //UE5/Release-5.0/... via CL 18503245
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18503259 by julien stjean in ue5-release-engine-test branch]
2022-01-03 15:53:45 -05:00
Marc Audy
f512a6d461 Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#fyi Aurel.Cordonnier

[CL 18448630 by Marc Audy in ue5-release-engine-test branch]
2021-12-13 15:59:48 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
daren cheng
45625f4109 Performance improvements to widget library.
Add callback for source data generation to asset views.
Add UObject enumeration to content browser API (By Rex Hill).
Intentionally reserve thumbnail pool sizes instead of flat 1024 reservation.

#jira UE-129795
#rb Rex.Hill
#preflight 615e0c51c5e9590001f4a22a
#preflight 615e4400f13022000126efda

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 17744889 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v879-17706426)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0
#ROBOMERGE[bot1]: Main

[CL 17744914 by daren cheng in ue5-release-engine-test branch]
2021-10-06 21:35:45 -04:00
aurel cordonnier
69fe095547 Merge from Release-Engine-Staging @ 17636544 to Release-Engine-Test
This represents UE4/Main @17638339 and Dev-PerfTest @17636504

[CL 17638842 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-27 19:54:25 -04:00
aditya ravichandran
9c09a76984 Reskin the Level Editor Main Toolbar,
Move Editor Modes to a Combo Button,
Combine Content and Create into one dropdown,
Reorder items in the Content Browser add and context menu to be more meaningful
#jira UETOOL-3814
#preflight 61434322599fd8000190b8bf
#rb Louise.Rasmussen, brooke.hubert

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 17538574 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17538604 by aditya ravichandran in ue5-release-engine-test branch]
2021-09-16 10:15:01 -04:00